Re: [edk2] [PATCH 4/6] ArmVirtPkg: use small code model for all UEFI_APPLICATION modules

On 4 January 2016 at 19:27, Laszlo Ersek wrote: > On 12/24/15 14:03, Ard Biesheuvel wrote: >> Unfortunately, compiling the DEBUG shell using the small code model is >> not sufficient in all cases to get a successful build when the toolchain >> defaults to the tiny code model.

Re: [edk2] undefined Reference to 'strtof'

which tests are you using? a quick grep on the edk2 tree shows me that strtof isn't really used. On Sun, Jan 3, 2016 at 11:59 PM, Daryl McDaniel wrote: > Michael, > > How would one reproduce the problem you are seeing? > I don't see any problems when building or

[edk2] [PATCH 2/2] BaseTools AARCH64: build XIP modules with strict alignment

GCC for AARCH64 recognizes byte swapping load and store sequences and may replace them with wider loads or stores combined with rev instructions. In some cases (i.e., with GCC version 5 and later) this may result in unaligned accesses, which are not allowed before we turn the MMU on. So build any

[edk2] [PATCH 0/2] BaseTools AARCH64: build XIP modules with strict alignment

On AARCH64, before we turn on the MMU, unaligned accesses are not allowed. Since the idiom recognition employed by GCC may turn allowable sequences into sequences that result in such unaligned accesses (i.e., a sequence of byte wide loads in reverse order may be turned into a wider load and a rev

Re: [edk2] [PATCH v2 0/5] AARCH64 code model and toolchain updates

On 31 December 2015 at 13:57, Ard Biesheuvel wrote: > This is a followup to the patch 'BaseTools AARCH64: add -mstrict-align to > all AARCH64 GCC flavors' that I sent out on the 23rd. As it turns out, using > strict alignment results in a code size increase which breaks

[edk2] [PATCH] BaseTools: Fix 'caculate' typos

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenBootSector/GenBootSector.c | 2 +- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2] [PATCH v2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

This patch updates the MNP driver to recycle TX buffer asynchronously, instead of using a while loop wait after each transmit command. This patch also fixes a bug in SNP.GetStatus() interface to support the MNP update. The UNDI driver may return multiple transmitted buffers in a single GetStatus

[edk2] [PATCH] ShellPkg: Fix Shell assert when mv a file to a NULL target.

When run command 'mv file ' the Shell assert. The patch refined the length of the buffer to fix this bug. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin ---

[edk2] [Patch] NetworkPkg: Removing or adding some ASSERT statement

Refine the code by removing or adding some ASSERT statement to make the code more readable. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/DnsDxe/DnsImpl.c

Re: [edk2] [PATCH] BaseTools: Fix 'caculate' typos

Reviewed-by: Liming Gao -Original Message- From: Wu, Hao A Sent: Tuesday, January 05, 2016 9:24 AM To: edk2-devel@lists.01.org; Zhu, Yonghong; Gao, Liming Cc: Wu, Hao A Subject: [PATCH] BaseTools: Fix 'caculate' typos Contributed-under: TianoCore Contribution

Re: [edk2] [Patch] NetworkPkg: Removing or adding some ASSERT statement

Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Tuesday, January 5, 2016 9:47 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan Subject: [Patch] NetworkPkg: Removing or adding some ASSERT statement

[edk2] [patch] MdeModulePkg:Avoid ASSERT in HiiConfigRoutingRouteConfig

Add error handling code to enhance the code,the driver may not install the ConfigAccess protocol,so should not just ASSERT here. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch] MdeModulePkg:Fix the potential memory leak issue in Display Engine

The MenuOption insert to gMenuOption allocate memory everytime,but not free. Now add the code to free it. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi ---

[edk2] [PATCH] MdeModulePkg: Fix 'accroding' typos in MdeModulePkg.dec/.uni

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/MdeModulePkg.dec | 8 MdeModulePkg/MdeModulePkg.uni | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec

Re: [edk2] [PATCH] MdeModulePkg: Fix 'accroding' typos in MdeModulePkg.dec/.uni

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Tuesday, January 05, 2016 09:21 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH] MdeModulePkg: Fix 'accroding'

Re: [edk2] [Patch] NetworkPkg: Removing or adding some ASSERT statement

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Tuesday, January 05, 2016 9:47 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan Subject: [Patch] NetworkPkg: Removing or adding some ASSERT statement Refine the code by removing or adding some

Re: [edk2] [PATCH v2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

Siyuan, Some small comments: 1. Please update MnpBuildTxPacket() function's description. 2. Since Mnp Sent the packet asynchronously, MnpSyncSendPacket() function's name is improper, the corresponding description also should be updated. Other parts good to me. Reviewed-by: Jiaxin Wu

Re: [edk2] [Patch] NetworkPkg: Fix suspicious dereference of pointer before NULL check

Hi Leif, I think you are raising a general question "can we trust the consumed API already return defined value", not specific to this patch. I don't have an answer to this. And I also would like to hear more opinions. For this patch: I would accept the change made to core services such as

Re: [edk2] [patch] MdeModulePkg:Fix the potential memory leak issue in Display Engine

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, January 05, 2016 9:59 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch] MdeModulePkg:Fix the

Re: [edk2] [patch] MdeModulePkg:Change the type of BootNext

Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Tuesday, January 05, 2016 8:34 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Change the type of BootNext Currently the invalid boot next set to the number

Re: [edk2] [PATCH v2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

Thank Jiaxin, I will update the content when commit the patch. Siyuan -Original Message- From: Wu, Jiaxin Sent: Tuesday, January 5, 2016 3:34 PM To: Fu, Siyuan ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [edk2] [PATCH v2] MdeModulePkg:

Re: [edk2] [PATCH] StdLib: Implement da_ConFlush() and flush I/O buffers when closing a console device.

Reviewed-by: Erik Bjorge > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Sunday, January 3, 2016 2:45 PM > To: edk2-devel@lists.01.org; Carsey, Jaben ; Bjorge, > Erik C > >

Re: [edk2] [PATCH] StdLib: Temporarily restrict compiler warnings so that sockets can be built using VS2015.

Daryl, What are the plans for fixing the socket code to pass with VS2015? I just want to know how long this temporary patch will be around. Thanks, -Erik From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] Sent: Sunday, January 3, 2016 2:21 PM To: edk2-devel@lists.01.org; Carsey, Jaben

Re: [edk2] [PATCH] StdLib: Fix IIO_Write() to return the number of bytes consumed, not characters output.

I am not sure I like how the W_INSTRUMENT and R_INSTRUMENT look in the code but I also do not have a good alternate suggestion. It just looked odd when I was reading the patch. Reviewed-by: Erik Bjorge > -Original Message- > From: Daryl McDaniel

Re: [edk2] [PATCH] Python: Clean up and document how to escape the -# option.

Reviewed-by: Erik Bjorge > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Sunday, January 3, 2016 4:07 PM > To: edk2-devel@lists.01.org; Carsey, Jaben ; Bjorge, > Erik C > >

Re: [edk2] [PATCH] StdLib: Clarify and improve comments.

Please also note in the comments for the commits where you fixed indentation issues. Reviewed-by: Erik Bjorge > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Sunday, January 3, 2016 2:51 PM > To: edk2-devel@lists.01.org;

Re: [edk2] [PATCH 4/6] ArmVirtPkg: use small code model for all UEFI_APPLICATION modules

On 12/24/15 14:03, Ard Biesheuvel wrote: > Unfortunately, compiling the DEBUG shell using the small code model is > not sufficient in all cases to get a successful build when the toolchain > defaults to the tiny code model. The reason is that not only the Shell binary > itself should be built