Re: [edk2] Dxe Core support for EFI_SECTION_PEI_DEPEX section.

2016-02-02 Thread Kinney, Michael D
Liming, The PI Specifications only defines the use of SMM_DEPEX for SMM drivers. Not for FV images. If an FV image has an SMM_DEPEX, then I think this section should be ignored. We could add an ASSERT() to the DXE Core if an SMM_DEPEX is present, so an invalid FV can be fixed during

Re: [edk2] [PATCH 1/4] ArmPlatformPkg: Rectify file modes

2016-02-02 Thread Jordan Justen
In the future, can you send your patchsets threaded together. If you run git send-email *.patch, it should automatically set the In-Reply-To email header for the second and subsequent emails. Thanks, -Jordan On 2016-02-02 06:28:49, wrote: > From: Evan Lloyd > > Problems

Re: [edk2] How to I get access to the "Project Tracker"?

2016-02-02 Thread Jordan Justen
On 2016-02-02 15:33:00, Andrew Fish wrote: > It looks like Laszlo is doing maintenance on bugs, but I can't seem > to find the location of the database? > https://github.com/tianocore/edk2/issues > All I could find was this very in-depth explanation of the concept > of bug tracking that is

[edk2] Transition to GitHub is complete

2016-02-02 Thread Jordan Justen
On 2016-02-02 09:47:23, Jordan Justen wrote: > As mentioned previously, we will attempt to transition to GitHub > starting this morning (around 10AM PST, UTC-8). One of the first steps > will be to disable SourceForge SVN write access. > > You can follow the progress here: > >

Re: [edk2] How to I get access to the "Project Tracker"?

2016-02-02 Thread Laszlo Ersek
On 02/03/16 00:33, Andrew Fish wrote: > It looks like Laszlo is doing maintenance on bugs, but I can't seem to find > the location of the database? Ooops, been caught red-handed! :) The issue tracker summary page is: https://github.com/tianocore/edk2/issues/ The result list can be filtered in

[edk2] How to I get access to the "Project Tracker"?

2016-02-02 Thread Andrew Fish
It looks like Laszlo is doing maintenance on bugs, but I can't seem to find the location of the database? All I could find was this very in-depth explanation of the concept of bug tracking that is really hard to follow since I can't figure out how to look at a bug? Why does the Community

Re: [edk2] How to I get access to the "Project Tracker"?

2016-02-02 Thread Andrew Fish
> On Feb 2, 2016, at 3:41 PM, Laszlo Ersek wrote: > > On 02/03/16 00:33, Andrew Fish wrote: >> It looks like Laszlo is doing maintenance on bugs, but I can't seem to find >> the location of the database? > > Ooops, been caught red-handed! :) > > The issue tracker summary

Re: [edk2] Dxe Core support for EFI_SECTION_PEI_DEPEX section.

2016-02-02 Thread Gao, Liming
Mike: Thanks for your clarification. I will work out the patch for this issue. Thanks Liming -Original Message- From: Kinney, Michael D Sent: Wednesday, February 3, 2016 3:57 AM To: Gao, Liming; Andrew Fish; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [edk2] Dxe Core

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Ryan Harkin
Hi Dandan, Saying as I've asked you to update your patch, please can you also update the commit message with the minor changes below? On 2 February 2016 at 02:17, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but Space after comma

[edk2] [PATCH v3 5/6] SecurityPkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Dandan Bi
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: Chao Zhang Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v3 1/6] ArmPlatformPkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Dandan Bi
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear. Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: Leif Lindholm

[edk2] [PATCH v3 6/6] SecurityPkg: Use FileExplorerLib in SecureBootConfigDxe

2016-02-02 Thread Dandan Bi
Using existing library FileExplorerLib to replace the same logic in SecureBootConfigDxe to make the code clear. After using FileExplorerLib, the UI behavior for enroll PK will change, previously when select one PK file, commit/discard changes will return to Device Manager,press ESC will return to

[edk2] [PATCH v3 3/6] OvmfPkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Dandan Bi
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear. Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: Jordan Justen

[edk2] [PATCH v3 4/6] Vlv2TbltDevicePkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Dandan Bi
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear. Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: David Wei

Re: [edk2] [Patch] MdeModulePkg/UsbAbsPointer:Fix GetState() to return absolute value

2016-02-02 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Tuesday, February 02, 2016 16:04 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/UsbAbsPointer:Fix GetState() to return absolute value Fix

[edk2] [PATCH v3 2/6] ArmVirPkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Dandan Bi
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear. Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build. Cc: Laszlo Ersek

[edk2] [PATCH v3 0/6] Use FileExplorerLib in SecureBootConfigDxe

2016-02-02 Thread Dandan Bi
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE in ArmPlatformPkg, ArmVirPkg, OvmfPkg, Vlv2TbltDevicePkg. Please ignore previous version! Thanks! Using existing library FileExplorerLib to replace the same logic in SecureBootConfigDxe. And add FileExplorerLib to dsc files of related

Re: [edk2] [PATCH v4] NetworkPkg:Add a new error status code EFI_HTTP_ERROR

2016-02-02 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Tuesday, February 02, 2016 2:52 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [PATCH v4] NetworkPkg:Add a new error status code EFI_HTTP_ERROR v4: * Update macro

[edk2] [Patch] MdeModulePkg/UsbAbsPointer:Fix GetState() to return absolute value

2016-02-02 Thread Ruiyu Ni
Fix UsbMouseAbsolutePointer driver GetState() interface to return absolute value instead of relative value. The driver is ported from UsbMouse driver. The GetState of SimplePointer protocol returns relative value but the GetState of AbsolutePointer protocol should return absolute value.

Re: [edk2] UEFI Shell: Backspace doesn't work

2016-02-02 Thread Ard Biesheuvel
On 2 February 2016 at 09:05, Bhupesh Sharma wrote: > Hi, > > I think some of the edk2 shell users might have already noticed this, that the > Backspace input doesn't work on the UEFI shell (I am using the latest > edk2/master branch). > > On Qemu-AARCH64 2.5 build, I can

Re: [edk2] [patch 6/6] SecurityPkg:Use FileExplorerLib in SecureBootConfigDxe

2016-02-02 Thread Laszlo Ersek
On 02/02/16 07:26, Dandan Bi wrote: > Sorry for giving the wrong [patch 6/6] in patches serial, > this is the correct one. > > Using existing library FileExplorerLib to replace the same > logic in SecureBootConfigDxe to make the code clear.After using > FileExplorerLib,the UI behavior for enroll

Re: [edk2] [patch 2/6] ArmVirPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Laszlo Ersek
CC'ing Ard On 02/02/16 03:17, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but > FileExplorerLib is not in the dsc file of the package > which use SecureBootConfigDxe.Now add it to pass build. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [PATCH v4] NetworkPkg:Add a new error status code EFI_HTTP_ERROR

2016-02-02 Thread Wu, Jiaxin
Looks good! Reviewed-by: Jiaxin Wu -Original Message- From: Zhang, Lubo Sent: Tuesday, February 2, 2016 2:52 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin Subject: [PATCH v4] NetworkPkg:Add a new error status code EFI_HTTP_ERROR v4: * Update

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Laszlo Ersek
Hello Siyuan, On 02/02/16 02:03, Fu, Siyuan wrote: > Hi, Laszlo > > Yes it's to make it same as the MAX_XMIT_BUFFERS in PxeGetStatus(), > and I agree that the MNP and SNP driver are independent with each > other. I make this change just because some people in edk2 community > have concern about

Re: [edk2] [patch 3/6] OvmfPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Laszlo Ersek
CC'ing Jordan On 02/02/16 03:18, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but > FileExplorerLib is not in the dsc file of the package > which use SecureBootConfigDxe.Now add it to pass build. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Fu, Siyuan
Hi, Laszlo Thanks for your detailed analysis, I will update the commit log for the patch 2/3, and let's wait Sriram to see if he has any concern about 1/3. Best Regards Siyuan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, February 2, 2016 4:12 PM To:

Re: [edk2] [patch 0/6] Use FileExplorerLib in SecureBootConfigDxe

2016-02-02 Thread Laszlo Ersek
On 02/02/16 03:17, Dandan Bi wrote: > Using existing library FileExplorerLib to replace the same > logic in SecureBootConfigDxe.And add FileExplorerLib to > dsc files of related packages which use SecureBootConfigDxe. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

[edk2] UEFI Shell: Backspace doesn't work

2016-02-02 Thread Bhupesh Sharma
Hi, I think some of the edk2 shell users might have already noticed this, that the Backspace input doesn't work on the UEFI shell (I am using the latest edk2/master branch). On Qemu-AARCH64 2.5 build, I can get 'Ctrl + H' to work as the Backspace key on the shell, but on my AARCH64 platform

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Laszlo Ersek
Ard, Leif, can you please review this? Thanks Laszlo On 02/02/16 03:17, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but > FileExplorerLib is not in the dsc file of the package > which use SecureBootConfigDxe.Now add it to pass build. > > Contributed-under: TianoCore

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Ard Biesheuvel
On 2 February 2016 at 09:20, Laszlo Ersek wrote: > Ard, Leif, can you please review this? > > Thanks > Laszlo > > On 02/02/16 03:17, Dandan Bi wrote: >> Because SecureBootConfigDxe use FileExplorerLib now,but >> FileExplorerLib is not in the dsc file of the package >> which use

Re: [edk2] UEFI Shell: Backspace doesn't work

2016-02-02 Thread Bhupesh Sharma
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, February 02, 2016 1:44 PM > On 2 February 2016 at 09:05, Bhupesh Sharma > wrote: > > Hi, > > > > I think some of the edk2 shell users might have already noticed this, > > that the Backspace input

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Subramanian, Sriram (EG Servers Platform SW)
Hi Laszlo, Thanks for your feedback. With [Patch 3/3], that fixes an issue where we could return EFI_DEVICE_ERROR (on UNDI returning PXE_STATCODE_BUFFER_FULL), [Patch 1/3] is no longer a pressing need. Otherwise, with the bug described in [Patch 3/3], even if the UNDI returned

Re: [edk2] UEFI Shell: Backspace doesn't work

2016-02-02 Thread Laszlo Ersek
On 02/02/16 10:09, Bhupesh Sharma wrote: >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Tuesday, February 02, 2016 1:44 PM > >> On 2 February 2016 at 09:05, Bhupesh Sharma >> wrote: >>> Hi, >>> >>> I think some of the edk2 shell users might have

[edk2] [PATCH v2 5/6] SecurityPkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Dandan Bi
Because SecureBootConfigDxe use FileExplorerLib now,but FileExplorerLib is not in the dsc file of the package which use SecureBootConfigDxe.Now add it to pass build. V2:Add the FileExplorerLib in [LibraryClasses.common.DXE_DRIVER] section instead of [LibraryClasses] in V1. Cc: Chao Zhang

[edk2] [PATCH] Maintainers.txt: Update source repository urls

2016-02-02 Thread Jordan Justen
Add 'backup' to backup git repositories, and mark svn as 'deprecated'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- Note: This should be the first patch that we push to git first, rather than svn. Maintainers.txt | 6

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Ryan Harkin
On 2 February 2016 at 15:06, Laszlo Ersek wrote: > On 02/02/16 15:54, Ryan Harkin wrote: >> On 2 February 2016 at 08:33, Ard Biesheuvel >> wrote: >>> On 2 February 2016 at 09:20, Laszlo Ersek wrote: Ard, Leif, can you please

Re: [edk2] [PATCH v2 3/6] OvmfPkg: Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Laszlo Ersek
On 02/02/16 14:33, Dandan Bi wrote: > Because SecureBootConfigDxe use FileExplorerLib now,but > FileExplorerLib is not in the dsc file of the package > which use SecureBootConfigDxe.Now add it to pass build. > > V2:Add the FileExplorerLib in [LibraryClasses.common.DXE_DRIVER] section > instead of

Re: [edk2] UEFI Shell: Backspace doesn't work

2016-02-02 Thread Ryan Harkin
On 2 February 2016 at 11:59, Laszlo Ersek wrote: > On 02/02/16 12:53, Bhupesh Sharma wrote: >>> From: Ryan Harkin [mailto:ryan.har...@linaro.org] >>> Sent: Tuesday, February 02, 2016 4:57 PM >>> >>> On 2 February 2016 at 10:18, Laszlo Ersek wrote: On

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-02-02 Thread Laszlo Ersek
On 02/01/16 16:07, Marcel Apfelbaum wrote: > On 01/26/2016 07:17 AM, Ni, Ruiyu wrote: >> Laszlo, >> I now understand your problem. >> Can you tell me why OVMF needs multiple root bridges support? >> My understanding to OVMF is it's a firmware which can be used in a >> guest VM >> environment to

Re: [edk2] UEFI Shell: Backspace doesn't work

2016-02-02 Thread Ryan Harkin
On 2 February 2016 at 10:18, Laszlo Ersek wrote: > On 02/02/16 10:09, Bhupesh Sharma wrote: >>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>> Sent: Tuesday, February 02, 2016 1:44 PM >> >>> On 2 February 2016 at 09:05, Bhupesh Sharma >>>

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

2016-02-02 Thread Carsey, Jaben
Looks like good info. Should we clarify that SVN is read only also? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Tuesday, February 02, 2016 9:03 AM > To:

Re: [edk2] [patch 1/6] ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file

2016-02-02 Thread Laszlo Ersek
On 02/02/16 16:38, Ryan Harkin wrote: > On 2 February 2016 at 15:06, Laszlo Ersek wrote: >> On 02/02/16 15:54, Ryan Harkin wrote: >>> On 2 February 2016 at 08:33, Ard Biesheuvel >>> wrote: On 2 February 2016 at 09:20, Laszlo Ersek

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

2016-02-02 Thread Jordan Justen
On 2016-02-02 09:07:24, Carsey, Jaben wrote: > Looks like good info. Should we clarify that SVN is read only also? > Good point. Also, maybe 'mirror' would be better than 'backup'? T: git (mirror) - https://bitbucket.org/tianocore/edk2.git T: git (mirror) -

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

2016-02-02 Thread Carsey, Jaben
I like that a lot. Reviewed-by: Jaben Carsey > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, February 02, 2016 9:35 AM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE:

[edk2] Notice: SourceForge SVN to become read-only - Re: Transition to GitHub Dates

2016-02-02 Thread Jordan Justen
As mentioned previously, we will attempt to transition to GitHub starting this morning (around 10AM PST, UTC-8). One of the first steps will be to disable SourceForge SVN write access. You can follow the progress here: https://github.com/tianocore/tianocore.github.io/wiki/Transition-to-GitHub

[edk2] [Patch] MdeModulePkg/PcRtc: Still create timezone variable when Daylight != 0

2016-02-02 Thread Ruiyu Ni
The patch fixes a regression bug caused by last check-in which causes Daylight setting cannot be set when timezone is unspecified. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian ---

[edk2] [Patch v2 3/3] MdeModulePkg: Correct one return status code in SNP Transmit function.

2016-02-02 Thread Fu Siyuan
According to UEFI spec, a BUFFER_FULL return status in UNDI Transmit command indicates UNDI "Transmit buffer is full. Call Get Status command toempty buffer." So this patch updates the SNP Transmit to return EFI_NOT_READY for BUFFER_FULL to let the call know the buffer full status.

[edk2] [Patch v2 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Fu Siyuan
The MNP and SNP are independent drivers so the MNP_TX_BUFFER_INCREASEMENT could choose any value as needed. While this patch update the default value of this macro to 32, to be same as the maximum recycled buffer numbers in one UNDI GetStatus command. It is a workaround for some incorrect UNDI

[edk2] [Patch v2 0/3] Fix several issues related to TX buffer recycle

2016-02-02 Thread Fu Siyuan
1. MdeModulePkg-Update-the-default-size-of-MNP-TX-buffer. 2. Update DBsize in SNP GetStatus command 3. Correct one return status code in SNP Transmit function. Fu Siyuan (3): MdeModulePkg: Update the default size of MNP TX buffer pool. MdeModulePkg: Update DBsize in SNP GetStatus command.

[edk2] [Patch v2 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command.

2016-02-02 Thread Fu Siyuan
Update the DBsize in GetStatus command to let UNDI return an array of recycled buffers. This is to make the loop at the end of PxeGetStatus() useful and to prevent buffer overflow with some non-conformant UNDI drivers which not check the value of the input DBsize in UNDI GetStatus command.

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Fu, Siyuan
Hi, Laszlo and Sriram I have sent out the v2 patch, only the commit message is updated, please help to review. Thanks Siyuan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, February 2, 2016 7:36 PM To: Subramanian, Sriram (EG Servers Platform SW)

Re: [edk2] [Patch v2 0/3] Fix several issues related to TX buffer recycle

2016-02-02 Thread Subramanian, Sriram (EG Servers Platform SW)
Series Reviewed-by: Sriram Subramanian -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, February 03, 2016 9:17 AM To: edk2-de...@ml01.01.org Cc: ting...@intel.com; jiaxin...@intel.com; ler...@redhat.com; Subramanian, Sriram (EG Servers

Re: [edk2] [Patch v2 2/3] MdeModulePkg: Update DBsize in SNP GetStatus command.

2016-02-02 Thread Subramanian, Sriram (EG Servers Platform SW)
Hi Siyuan, Looks good, just one feedback to remove the below comments (not applicable now since the size is no longer for one buffer): // // size DB for return of one buffer // Reviewed-by: Sriram Subramanian Thanks, Sriram. -Original Message- From: Fu

Re: [edk2] [Patch 1/3] MdeModulePkg: Update the default size of MNP TX buffer pool.

2016-02-02 Thread Subramanian, Sriram (EG Servers Platform SW)
Thanks Siyuan, I reviewed the series, looks good. Sriram. -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, February 03, 2016 9:19 AM To: Laszlo Ersek; Subramanian, Sriram (EG Servers Platform SW) Cc: edk2-de...@ml01.01.org; Ye, Ting; Wu, Jiaxin;