[edk2] [PATCH] SecurityPkg : Tpm12DeviceLibDTpm: Fix TPM12 wrong Response Tag check

2016-06-06 Thread Zhang, Chao B
TcgDxePassThroughToTpm should be able to handle all TPM12 Command & Response correctly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Tis.c | 6 -- 1 file changed, 4 insertions(+), 2

[edk2] [PATCH V2 0/4] Add DESTRUCTOR for SmmLockBoxSmmLib and PiDxeS3BootScriptLib

2016-06-06 Thread Star Zeng
V2: 1. Fix typo in SmmLockBoxSmmConstructuor and SmmLockBoxSmmDestructuor. 2. Add comment for S3BootScriptLibDeinitialize to explain that the desturctor doesn't support unloading as a separate action, and it only supports unloading if the containing driver's entry point function fails. 3. Revert

[edk2] [PATCH V2 2/4] MdeModulePkg SmmLockBoxSmmLib: Add DESTRUCTOR SmmLockBoxSmmDestructor

2016-06-06 Thread Star Zeng
SmmLockBoxSmmLib is linked to SMM modules. If the module entry-point function returns error, the module will be unloaded and the global variables will point to undefined memory. This patch is to add DESTRUCTOR SmmLockBoxSmmDestructor to uninstall SmmLockBoxCommunication configuration table if it

[edk2] [PATCH V2 3/4] MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR S3BootScriptLibDeinitialize

2016-06-06 Thread Star Zeng
PiDxeS3BootScriptLib has a constructor S3BootScriptLibInitialize() that registers ready-to-lock callback S3BootScriptSmmEventCallBack() and several more. The library is linked to SMM modules. If the module entry-point function returns error (because of lack of resources, unsupported, whatever),

[edk2] [PATCH V2 4/4] MdeModulePkg DxeS3BootScriptLib: Revert git commit 058196bbb345

2016-06-06 Thread Star Zeng
With a destructor implemented, the shortcut from 058196bbb345 should be unnecessary. Cc: Jiewen Yao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Suggested-by: Laszlo Ersek

[edk2] [PATCH V2 1/4] MdeModulePkg SmmLockBoxSmmLib: Fix typo in SmmLockBoxSmmConstructuor

2016-06-06 Thread Star Zeng
SmmLockBoxSmmConstructuor should be SmmLockBoxSmmConstructor. Cc: Jiewen Yao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng ---

Re: [edk2] [PATCH 0/2] UefiCpuPkg, OvmfPkg: prevent (unchecked) SMM stack overflow

2016-06-06 Thread Fan, Jeff
Laszlo, I agree. Please go ahead to check-in this serial of patches. We may revisit it if we receive other concern in the future. Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, June 02, 2016 6:13 PM To: Fan, Jeff; edk2-devel-01 Cc: Yao,

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add Memory Type selection support in Ramdisk HII

2016-06-06 Thread Wu, Hao A
Hi Tapan, I think you are right that there will be issues for not saving the changed 'Size' numeric and 'MemoryType' oneof back to the varstore. My expecting behavior for these two HII elements during raw RAM disk creation is that after a user created (or canceled the creation) a RAM disk, their

Re: [edk2] [Patch v2] UefiCpuPkg/MtrrLib: Fixed bug if length is less than Fixed-MTRR range

2016-06-06 Thread Dong, Eric
Reviewed_by: Eric Dong > -Original Message- > From: Fan, Jeff > Sent: Monday, June 06, 2016 2:00 PM > To: edk2-de...@ml01.01.org > Cc: Dong, Eric; Tian, Feng; Kinney, Michael D > Subject: [Patch v2] UefiCpuPkg/MtrrLib: Fixed bug if length is less than > Fixed-MTRR

Re: [edk2] [patch][edk2-platforms/branch]: Add new platform branch pentium-celeron-n-udk2015

2016-06-06 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Guo, Mang > Sent: Friday, June 03, 2016 3:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Wei, David ; > Guo, Mang ; Wu, Mike

Re: [edk2] [Patch] NetworkPkg: Remove TokenEntry from Token list before freed

2016-06-06 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo -Original Message- From: Wu, Jiaxin Sent: Thursday, June 02, 2016 4:26 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Zhang, Lubo Subject: [Patch] NetworkPkg: Remove TokenEntry from Token list before

Re: [edk2] [Patch] NetworkPkg: Fix DNS GeneralLookUp failure in some case

2016-06-06 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo -Original Message- From: Wu, Jiaxin Sent: Monday, June 06, 2016 1:33 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Zhang, Lubo Subject: [Patch] NetworkPkg: Fix DNS GeneralLookUp failure in some case

[edk2] [PATCH v2 1/2] MdeModulePkg RamDiskDxe: Do not save 'Size' numeric value by varstore

2016-06-06 Thread Hao Wu
The 'Size' numeric value used when creating a raw RAM disk does not require a varstore to save its previous value in the create raw RAM disk HII page. The expecting behavior is that after a user created a raw RAM disk, the next time when the create raw RAM disk page is entered, the 'Size' numeric

[edk2] [PATCH v2 2/2] MdeModulePkg/RamDiskDxe: Add Memory Type selection support in Ramdisk HII

2016-06-06 Thread Hao Wu
From: Tapan Shah Adding an option in HII menu so user can choose memory type to use when creating a RAM Disk in system. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tapan Shah --- .../Universal/Disk/RamDiskDxe/RamDiskHii.vfr

[edk2] [PATCH v2 0/2] Add Memory Type selection support in Ramdisk HII

2016-06-06 Thread Hao Wu
Changes made comparing to v1: Stop using varstore to track the values of 'Size' numeric and 'MemoryType' oneof in HII. The reason for this change is that the expecting behavior for these two HII elements during raw RAM disk creation is that after a user created (or canceled the creation) a RAM

Re: [edk2] [PATCH v2 0/2] ArmVirtPkg: introduce the progress bar

2016-06-06 Thread Laszlo Ersek
On 06/06/16 11:50, Ard Biesheuvel wrote: > On 27 May 2016 at 12:42, Laszlo Ersek wrote: >> Version 2 of . >> The Nt32Pkg, MdeModulePkg, and OvmfPkg patches have been committed; so >> this series only carries the

Re: [edk2] [PATCH 2/2] MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR S3BootScriptLibDeinitialize

2016-06-06 Thread Laszlo Ersek
On 06/04/16 01:26, Yao, Jiewen wrote: > HI Laszlo/Star > > That is a good catch that this patch does not consider DriverX load, > DriverY load, then DriverX unload. > > > > Technically, it is possible for a UEFI driver according UEFI spec, by > using *EFI_BOOT_SERVICES.Exit()*to terminates a

Re: [edk2] [Patch] NetworkPkg: Fix DNS GeneralLookUp failure in some case

2016-06-06 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Monday, June 06, 2016 1:33 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Zhang, Lubo Subject:

Re: [edk2] [PATCH V2 1/4] MdeModulePkg SmmLockBoxSmmLib: Fix typo in SmmLockBoxSmmConstructuor

2016-06-06 Thread Laszlo Ersek
On 06/06/16 12:38, Star Zeng wrote: > SmmLockBoxSmmConstructuor should be SmmLockBoxSmmConstructor. > > Cc: Jiewen Yao > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng > --- >

Re: [edk2] [PATCH V2 4/4] MdeModulePkg DxeS3BootScriptLib: Revert git commit 058196bbb345

2016-06-06 Thread Laszlo Ersek
On 06/06/16 12:38, Star Zeng wrote: > With a destructor implemented, the shortcut from 058196bbb345 > should be unnecessary. > > Cc: Jiewen Yao > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng

Re: [edk2] [PATCH V2 2/4] MdeModulePkg SmmLockBoxSmmLib: Add DESTRUCTOR SmmLockBoxSmmDestructor

2016-06-06 Thread Laszlo Ersek
On 06/06/16 12:38, Star Zeng wrote: > SmmLockBoxSmmLib is linked to SMM modules. If the module entry-point > function returns error, the module will be unloaded and the global > variables will point to undefined memory. > > This patch is to add DESTRUCTOR SmmLockBoxSmmDestructor to uninstall >

Re: [edk2] [PATCH V2 3/4] MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR S3BootScriptLibDeinitialize

2016-06-06 Thread Laszlo Ersek
Two cosmetic comments: On 06/06/16 12:38, Star Zeng wrote: > PiDxeS3BootScriptLib has a constructor S3BootScriptLibInitialize() that > registers ready-to-lock callback S3BootScriptSmmEventCallBack() and several > more. The library is linked to SMM modules. If the module entry-point > function

Re: [edk2] [PATCH V2 0/4] Add DESTRUCTOR for SmmLockBoxSmmLib and PiDxeS3BootScriptLib

2016-06-06 Thread Laszlo Ersek
On 06/06/16 12:38, Star Zeng wrote: > V2: > 1. Fix typo in SmmLockBoxSmmConstructuor and SmmLockBoxSmmDestructuor. > 2. Add comment for S3BootScriptLibDeinitialize to explain that the desturctor > doesn't > support unloading as a separate action, and it only supports unloading if the > containing

[edk2] [PATCH 1/2] ArmPlatformPkg/ArmJunoDxe: Configure Marvell Yukon MAC address on Juno

2016-06-06 Thread Daniil Egranov
The patch is using device configuration protocol to push new MAC address to the Marvell Yukon NIC. A MAC address has been read from FPGA registers and pushed to the NIC before its driver started by BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov

[edk2] [PATCH 2/2] EmbeddedPkg: Added device configuration protocol

2016-06-06 Thread Daniil Egranov
The device configuration protocol definition. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- EmbeddedPkg/EmbeddedPkg.dec| 1 + .../Include/Protocol/EmbeddedDeviceConfig.h| 127

Re: [edk2] [PATCH] MdeModulePkg/AtaBusDxe: Fix some ATA hard drives cannot be discovered

2016-06-06 Thread Tian, Feng
I think you are right Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cinnamon Shia Sent: Monday, June 6, 2016 12:08 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; el...@hpe.com;

Re: [edk2] [PATCH] MdeModulePkg/AtaBusDxe: Fix some ATA hard drives cannot be discovered

2016-06-06 Thread Wu, Hao A
The patch is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, June 06, 2016 12:08 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A;

Re: [edk2] [PATCH] MdeModulePkg/AtaBusDxe: Fix some ATA hard drives cannot be discovered

2016-06-06 Thread Wu, Hao A
Pushed at 2d273c8db95430b680e542e38cf07b97f9b57d11. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, June 06, 2016 12:08 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; el...@hpe.com; Tian, Feng; Zeng, Star >

[edk2] [PATCH 0/2] Marvell Yukon MAC address configuration on Juno platform

2016-06-06 Thread Daniil Egranov
The patches add a new device configuration protocol and use it to configure a Marvell Yukon controller on the Juno platform with a valid MAC address. The device configuration protocol will enable a driver to reconfigure device specific settings before driver is started. As an example, the Juno