Re: [edk2] [Patch 3/3 V2] BaseTools/PatchCheck.py: Update to report error for EFI_D_*

On 2016-10-18 21:40:16, Zhu, Yonghong wrote: > Hi Jordan, > > If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_*''', it cannot > work because we would use mo.group(1) which report IndexError. > If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_ ([A-Z_]+)''' , > it cannot detect the

[edk2] [PATCH] edksetup.bat: Support --nt32 X64

Support --nt32 X64 for building 64-bit NT32. For setting up Windows environment variables requited by NT32, follow the same approach as Edk2Setup.bat by using the get_vsvars.bat and SetVisualStudio.bat. Sync the help text of NT32 with Edk2Setup.bat. Contributed-under: TianoCore Contribution

[edk2] [PATCH] Edk2Setup.bat: Support building platforms with Python source

Following the same approach as toolsetup.bat: If build.exe, TargetTool.exe, Trim.exe or GenFds.exe is missing, run its Python source instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- Edk2Setup.bat | 33

Re: [edk2] [Patch 3/3 V2] BaseTools/PatchCheck.py: Update to report error for EFI_D_*

Hi Jordan, If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_*''', it cannot work because we would use mo.group(1) which report IndexError. If we change regex to r'''DEBUG \s* \( \s* \(\s*. EFI_D_ ([A-Z_]+)''' , it cannot detect the case "DEBUG ((DEBUG_ERROR | EFI_D_INFO, "xxx",

Re: [edk2] [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit

Hello Ard, On Tue, Oct 18, 2016 at 09:40:42AM +0100, Ard Biesheuvel wrote: > On 18 October 2016 at 03:50, Dennis Chen wrote: > > Hello Ard, > > > > On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote: > >> On 17 October 2016 at 09:54, Dennis Chen

[edk2] [PATCH v2 1/8] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

The more proper place for macro SHELL_FREE_NON_NULL is ShellLib.h instead of ShellBase.h. Modify Compress.c to resolve build failure due to this change. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Jaben Carsey

[edk2] [Patch 3/3 V2] BaseTools/PatchCheck.py: Update to report error for EFI_D_*

In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new code, they should use DEBUG_* macro. Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143 Cc: Liming Gao Cc: Jordan Justen Contributed-under: TianoCore Contribution

[edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

The destination GUID comes first; from "MdePkg/Include/Library/BaseMemoryLib.h": > GUID * > EFIAPI > CopyGuid ( > OUT GUID *DestinationGuid, > IN CONST GUID *SourceGuid > ); Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and "Guid" is where

Re: [edk2] [PATCH v2 8/8] ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition

On 18 October 2016 at 09:46, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Ard Biesheuvel

[edk2] [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions

ACPI Low Power Idle Table (LPIT) Revision 001, dated July 2014 http://www.uefi.org/sites/default/files/resources/ACPI_Low_Power_Idle_Table.pdf Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore

Re: [edk2] [PATCH] IntelSiliconPkg: Fixed bug in IgdOpregion spec

Reviewed-by: jiewen@intel.com > -Original Message- > From: Mudusuru, Giri P > Sent: Tuesday, October 18, 2016 11:23 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] IntelSiliconPkg: Fixed bug in IgdOpregion spec > > Spec documents

[edk2] [PATCH v2 2/8] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

Move Shell/ShellDynamicCommand/ShellParameters definitions from ShellPkg to MdePkg. The following patches will rename the header file name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey Cc: Jiewen

[edk2] [PATCH v2 3/8] ShellPkg: Update header files to reference MdePkg protocol definition

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Include/Protocol/EfiShell.h | 21 + ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 21

[edk2] [PATCH v2 7/8] ShellPkg: Update sources to include MdePkg protocol definitions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Application/Shell/Shell.h| 5 ++--- ShellPkg/Include/Library/ShellCommandLib.h| 5

[edk2] [PATCH v2 6/8] EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 ++-- 1 file changed, 2 insertions(+),

[edk2] [PATCH v2 5/8] ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Leif Lindholm Cc: Ard Biesheuvel --- ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2] [PATCH v2 4/8] MdePkg: Merge ShellBase.h and remove Efi prefix from header files

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao --- MdePkg/Include/Protocol/{EfiShell.h => Shell.h}| 138 ++- ...ShellDynamicCommand.h => ShellDynamicCommand.h} | 11 +-

[edk2] [PATCH v2 8/8] ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Leif Lindholm Cc: Ard Biesheuvel --- ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h | 6 ++ 1 file changed, 2

Re: [edk2] [EDK2][USB IF]Mismatch between EDK2 and a USB vendor

Hello Feng, We haven't get any feedback from USB.org yet but could you provide us with the patch? We found a new issue probably caused by this mismatch in our current products and I want to check if the patch could fix the issue or not at least. Thank you for all your support! Kind regards,

[edk2] FW: [shell] Problems in EfiShellGetGuidFromName

Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the EDK2 implementation? Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Thursday, October 13, 2016 11:16 AM To: edk2-devel-01

Re: [edk2] OvmfPkg: hang in SetInterruptState with git 245cda6641ade1f1013c2d5c9c838f2706636828

On 10/18/16 02:06, Bruce Cran wrote: > I've just built both OVMF _and_ Qemu from the latest git sources, so I > don't know which is at fault - but I'm seeing a hang in: > > #0 0x7f9dc030 in SetInterruptState (InterruptState=104 'h') > at

Re: [edk2] [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit

On 18 October 2016 at 03:50, Dennis Chen wrote: > Hello Ard, > > On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote: >> On 17 October 2016 at 09:54, Dennis Chen wrote: >> > Since ACPI spec defines the GIC base addresses (CPU interface, >> >

Re: [edk2] [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions

HI I recommend we just use #include . Acpi.h includes all ACPI version. There is no need to include Acpi61.h. With this change, reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Giri P Mudusuru > Sent:

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

Reviewed-by: Tim Lewis -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 18, 2016 4:07 AM To: edk2-devel-01 Cc: Jaben Carsey ; Ruiyu Ni ; Tim Lewis

Re: [edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

Thanks Jordan, I sent a V2. I update a little on the re.compile to cover the case that EFI_D_* in the middle of the DEBUG string, and may have multiple space between DEBUG and ( character. Best Regards, Zhu Yonghong -Original Message- From: Justen, Jordan L Sent: Tuesday, October 18,

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

Reviewed-by: Jaben Carsey > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Tuesday, October 18, 2016 5:44 AM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org> > Cc: Carsey, Jaben ; Ni,

Re: [edk2] [PATCH v2 0/8] Move Shell protocols definition to MdePkg

I am good with this. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, October 18, 2016 1:46 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/8] Move

Re: [edk2] [PATCH 2/5] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

Yes, git automatically detects copying and moving files, as long as both halves of the action (remove + add) are in the same commit. There's a nice explanation here: https://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository#_git_mv Brian On 10/18/2016 12:59 AM, Kinney,

Re: [edk2] How to get BBS_BBS_DEVICE_PATH from BOOTXXXX variable

> On Oct 18, 2016, at 10:40 AM, Laszlo Ersek wrote: > > On 10/18/16 19:18, Saqib Khan wrote: >> Hi, >> I can not find structure of BOOT variable, Can any one help how to >> extract device path from BOOT variable. > > In UEFI-related questions, the UEFI specification

Re: [edk2] [PATCH] GPT Shell Application/Library

Thank you all for comments, So to summarize the discussion: 1. I will create a Shell library which would perform all GPT operations. Part of PartitionDxe will also be in that library so PartitionDxe will be using it. The gpt Shell tool will also be using it. 2. Refactor the parameters

Re: [edk2] [PATCH] GPT Shell Application/Library

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: October-18-16 10:24 AM > To: Vladimir Olovyannikov; Shah, Tapan; Carsey, Jaben; Michael Zimmermann > Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] GPT Shell Application/Library

Re: [edk2] [PATCH] GPT Shell Application/Library

1. Create this new shared library in MdeModulePkg. 2. For parameters: Other than standard parameters defined in Shell specification I would suggest to follow single character flag where it makes sense (example: -d to delete, -l to list, -c to create etc.) and if more than one operation can be

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

On 10/18/16 16:54, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > >> -Original Message- >> From: Tim Lewis [mailto:tim.le...@insyde.com] >> Sent: Tuesday, October 18, 2016 5:44 AM >> To: Laszlo Ersek ; edk2-devel-01 > de...@ml01.01.org> >>

Re: [edk2] [PATCH] GPT Shell Application/Library

For the standards, I would try to use the UEFI Shell Spec for some parameters. For Example: -v for verbose -h for help -sfo for standard format output > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Vladimir Olovyannikov > Sent: Tuesday,

Re: [edk2] [PATCH] GPT Shell Application/Library

On 10/18/16 18:58, Vladimir Olovyannikov wrote: > Thank you all for comments, > > So to summarize the discussion: > > 1. I will create a Shell library which would perform all GPT operations. > Part of PartitionDxe will also be in that library so PartitionDxe will > be using it. > The

Re: [edk2] [PATCH] GPT Shell Application/Library

On 10/18/16 20:03, Vladimir Olovyannikov wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: October-18-16 10:24 AM >> To: Vladimir Olovyannikov; Shah, Tapan; Carsey, Jaben; Michael Zimmermann >> Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org >>

Re: [edk2] [Patch 3/3 V2] BaseTools/PatchCheck.py: Update to report error for EFI_D_*

On 2016-10-18 03:16:53, Yonghong Zhu wrote: > In EDK2, DEBUG_* is recommended to be used instead of EFI_D_*. For new > code, they should use DEBUG_* macro. > > Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=143 > Cc: Liming Gao > Cc: Jordan Justen

Re: [edk2] [PATCH 2/5] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

Use 'git mv' command. Mike > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, October 18, 2016 1:57 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > > Subject: RE:

Re: [edk2] [PATCH] GPT Shell Application/Library

OK, Thank you for advice. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shah, Tapan > Sent: October-18-16 11:04 AM > To: Carsey, Jaben; Vladimir Olovyannikov; Michael Zimmermann > Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org;

Re: [edk2] [patch] MdeModulePkg/Ufs: ensure the DBC field of UTP PRDT is dword-aligned

The patch is good to me. Please update the copyright info before checkin. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Tuesday, October 18, 2016 1:19 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.org > Subject: [patch]

Re: [edk2] [Patch 3/3] BaseTools: Update PatchCheck to report error for EFI_D_*

On 2016-10-17 19:02:57, Zhu, Yonghong wrote: > Hi Jordan, > > We request to report error since the DEBUG_* is our recommend coding > style and EFI_D_ is obsolete. Looking for DEBUG and EFI_D_ since > only look for EFI_D_ may cause some False error be reported. And I > agree that user might put

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

Hello Fu Siyuan, Thanks for the update. I had reported a bug in the Bugzilla site. Please use the link https://bugzilla.tianocore.org/show_bug.cgi?id=155 to view the details. Please let me know if any other details are needed. Thank you, Naveen From: Fu, Siyuan

Re: [edk2] [Patch] BaseTools: Enhance tool to generate EFI_HII_IIBT_DUPLICATE image block

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Monday, October 17, 2016 5:46 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Enhance tool to generate > EFI_HII_IIBT_DUPLICATE image

[edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

Dear experts, Could anyone help to explain why USB_BOOT_IO_BLOCKS in MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h is set to 128? We found on some platforms this value may cause USB boot failure and *64* blocks will make them work. Though we have not got the final root cause, it will

Re: [edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the codes logic

Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Monday, October 17, 2016 5:08 PM > To: Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Dong, Eric; Gao, Liming > Subject: RE: [edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the > codes

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

It's just an experience value and has been here about 10 years... Which usb brand/model name do you have problem on? Thanks Feng -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Wednesday, October 19, 2016 9:57 AM To: edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [Patch] BaseTools: support PCD value to use expression in the DEC file

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, October 13, 2016 5:30 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: support PCD value to use expression in the DEC > file >