Re: [edk2] [PATCH] ArmPkg/UncachedMemoryAllocationLib: set XP bit via CPU arch protocol

On 15 March 2017 at 09:59, Ryan Harkin wrote: > Hi Ard, > > Thanks for the quick turnaround as always. > > On 14 March 2017 at 20:20, Leif Lindholm wrote: >> On Tue, Mar 14, 2017 at 07:58:15PM +, Ard Biesheuvel wrote: >>> Commit e7b24ec9785d

[edk2] [PATCH] IntelFsp2Pkg: Raise exception for invalid BSF option

Raise exception for invalid BSF option in GenCfgOpt.py Cc: Maurice Ma Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Richard Thomaiyar --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 6

Re: [edk2] [PATCH] ArmPkg/UncachedMemoryAllocationLib: set XP bit via CPU arch protocol

Hi Ard, Thanks for the quick turnaround as always. On 14 March 2017 at 20:20, Leif Lindholm wrote: > On Tue, Mar 14, 2017 at 07:58:15PM +, Ard Biesheuvel wrote: >> Commit e7b24ec9785d ("ArmPkg/UncachedMemoryAllocationLib: map uncached >> allocations

[edk2] how to load drivers from additional FV's?

I'm trying to add another FV section FVMAIN_COMPACT so I can keep Platform specific drivers in a separate, included fdf. I did this: FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE { SECTION FV_IMAGE

Re: [edk2] [PATCH] BaseTools/tools_def: Use armv7-a for CLANG35 ARM compilations.

Ard, Please help to review. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Sunday, March 05, 2017 9:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong

Re: [edk2] [PATCH] BaseTools/tools_def: Use armv7-a for CLANG35 ARM compilations.

On 15 March 2017 at 09:16, Zhu, Yonghong wrote: > Ard, > > Please help to review. Thanks. > > Best Regards, > Zhu Yonghong > > > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: Sunday, March 05, 2017 9:59 AM > To:

Re: [edk2] [PATCH 2/3] ShellPkg UefiDpLib: Handle "/" separator in debug path for GCC build

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Wednesday, March 15, 2017 1:51 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Ni, Ruiyu ; Carsey,

Re: [edk2] [PATCH 3/3] MdeModulePkg BmPerf: Handle "/" separator in debug path for GCC build

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Tian, Feng > Sent: Wednesday, March 15, 2017 1:52 PM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ruiyu ; > Tian, Feng

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Add Ip/Netmask pair check for Ip4Config2

Reviewed-by: Hegde, Nagaraj P -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Thursday, March 16, 2017 7:11 AM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P ; Subramanian, Sriram ; Ye Ting

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Add Ip/Netmask pair check for Ip4Config2

We need to handle the case of DHCP server serving with a subnet of 0.0.0.0. When we set the Policy to Dhcp, we enter into Ip4Config2OnPolicyChanged, which calls Ip4StartAutoConfig. Here we configure DHCP and we queue up Ip4Config2OnDhcp4Complete to be called once DHCP is complete. In

Re: [edk2] [patch] OvmfPkg/QemuFwCfgS3Lib: Fix VS tool chain build failure

Reviewed-by: Jordan Justen Pushed as 08bed3fbac. Thanks! On 2017-03-15 18:25:52, Dandan Bi wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan

Re: [edk2] [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4 dxe.

Hi Lubo, Please update the comment for IP4_STATE_DESTROY in Ip4Impl.h and other possible places, since the patch removed the value. Also update CopyRight year in SockImpl.h before check-in. Others are good to me. Reviewed-by: Ye Ting Best Regards, Ting -Original

[edk2] [PATCH] Nt32Pkg: Use Shell source code directly

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- Nt32Pkg/Nt32Pkg.dsc | 20 +++- Nt32Pkg/Nt32Pkg.fdf | 2 +- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH] MdeModulePkg/ConPlatform: Support GOP created as PCI's grandson

The original logic assumes GOP hande is son of PCI handle but it is not always true. Below wordings are from UEFI Spec: If a graphics device supports multiple frame buffers, then handles for the frame buffers must be created first, and then the handles for the video output devices can be created

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Add Ip/Netmask pair check for Ip4Config2

Nagaraj, You are right, but I'd like to update the patch to check it in Ip4Config2SetDefaultIf instead of Ip4SetAddress to avoid the previous interface free operation. After that, the check in Ip4SetAddress is needless. Thanks, Jiaxin > -Original Message- > From: Hegde, Nagaraj P

Re: [edk2] [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4 dxe.

Go it, thanks for your comments Best Regards Lubo -Original Message- From: Ye, Ting Sent: Thursday, March 16, 2017 1:31 PM To: Zhang, Lubo ; edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Fu, Siyuan Subject: RE: [PATCH V2]

Re: [edk2] [PATCH V2] NetworkPkg: Fix service binding issue in TCP dxe.

Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Wednesday, March 15, 2017 10:28 AM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan Subject: [PATCH V2] NetworkPkg: Fix

Re: [edk2] [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

I will do that. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Thursday, March 16, 2017 6:28 AM > To: Jeff Westfahl > Cc: edk2-devel@lists.01.org; Ni, Ruiyu ; Carsey, Jaben > > Subject: RE: [PATCH v2]

Re: [edk2] FDF dependency?

Matthew: One solution is to configure those PCDs as PatchablePcd and generate the binary image. Then, consume the binary image AsBuild INF file in the different FDF file. AsBuild INF can be found in the source build output directory. Thanks Liming > -Original Message- > From:

Re: [edk2] [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4 dxe.

Looks good to me. Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Lubo Sent: 2017年3月15日 10:28 To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan Subject: [PATCH V2] MdeModulePkg:

Re: [edk2] [PATCH V2] NetworkPkg: Fix service binding issue in TCP dxe.

Looks good to me. Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Lubo Sent: 2017年3月15日 10:28 To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan Subject: [PATCH V2] NetworkPkg:

Re: [edk2] [PATCH V2] NetworkPkg: Fix service binding issue in TCP dxe.

Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, March 15, 2017 10:28 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan >

Re: [edk2] [PATCH V2] MdeModulePkg: Fix service binding issue in TCP4 and Ip4 dxe.

For this patch, my comments as below: 1. The commit log should better cover the changes of Ip4Dxe but currently it's not. 2. Intel Copyright in SockImpl.h should be 2017, not 2007. Other looks to me. Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message-

[edk2] [PATCH v2] MdeModulePkg/Ip4Dxe: Add Ip/Netmask pair check for Ip4Config2

v2: * Add the check in Ip4Config2SetDefaultIf to avoid the DHCP configuration case. Ip4config2 doesn't check the validity of Ip/Netmask pair, which leads to the invalid combination of Ip and Netmask setting. This patch is to resolve the issue. Cc: Hegde Nagaraj P Cc:

Re: [edk2] how to load drivers from additional FV's?

> On Mar 15, 2017, at 8:38 AM, Laszlo Ersek wrote: > > On 03/15/17 16:13, Andrew Fish wrote: >> >>> On Mar 15, 2017, at 8:07 AM, Laszlo Ersek wrote: >>> >>> On 03/15/17 13:23, Michael Zimmermann wrote: I'm trying to add another FV section

[edk2] Testing NVMe async commands

We have developed an application to test the async flow in NvmExpressDxe. We have allocated a buffer of size 8 MB and in that buffer we are reading 128k chunks, which results in 64 commands as the async submission queue depth is 64, after calling passthru with the Event we increment a counter and

Re: [edk2] how to load drivers from additional FV's?

On 03/15/17 16:13, Andrew Fish wrote: > >> On Mar 15, 2017, at 8:07 AM, Laszlo Ersek wrote: >> >> On 03/15/17 13:23, Michael Zimmermann wrote: >>> I'm trying to add another FV section FVMAIN_COMPACT so I can keep >>> Platform specific drivers in a separate, included fdf. >>>

Re: [edk2] how to load drivers from additional FV's?

> On Mar 15, 2017, at 5:23 AM, Michael Zimmermann > wrote: > > I'm trying to add another FV section FVMAIN_COMPACT so I can keep > Platform specific drivers in a separate, included fdf. > > I did this: > FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { >

Re: [edk2] how to load drivers from additional FV's?

On 03/15/17 13:23, Michael Zimmermann wrote: > I'm trying to add another FV section FVMAIN_COMPACT so I can keep > Platform specific drivers in a separate, included fdf. > > I did this: > FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { > SECTION GUIDED

Re: [edk2] how to load drivers from additional FV's?

> On Mar 15, 2017, at 8:07 AM, Laszlo Ersek wrote: > > On 03/15/17 13:23, Michael Zimmermann wrote: >> I'm trying to add another FV section FVMAIN_COMPACT so I can keep >> Platform specific drivers in a separate, included fdf. >> >> I did this: >> FILE FV_IMAGE =

Re: [edk2] how to load drivers from additional FV's?

> On Mar 15, 2017, at 8:28 AM, Michael Zimmermann > wrote: > > Laszlo: As Andrew said, the problem is nesting FV's. I've also tried > different ways and depths of nesting FV's in the main FV, but none of > them worked. Also, I'm using PrePi, > > Andrew: Yea that

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Remove MSR_IA32_MISC_ENABLE check

On Wed, Mar 15, 2017 at 09:54:30AM +0800, Jeff Fan wrote: > The architectural MSR MSR_IA32_MISC_ENABLE is not supported by AMD processors. > Because reading CPUID.8001H:EDK[20] is enough to check if XD feature is > supported or not, we just remove checking MSR_IA32_MISC_ENABLE(0x1A0). > > Cc:

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Add Ip/Netmask pair check for Ip4Config2

Ip4config2 manual address setting doesn't check the validity of Ip/Netmask pair, which leads to the invalid combination of Ip and Netmask setting. This patch is to resolve this issue. Cc: Hegde Nagaraj P Cc: Subramanian Sriram Cc: Ye Ting

[edk2] [patch] OvmfPkg/QemuFwCfgS3Lib: Fix VS tool chain build failure

Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- OvmfPkg/Include/Library/QemuFwCfgS3Lib.h| 10 +-

Re: [edk2] how to load drivers from additional FV's?

Michael: I agree this is an issue in PeiCore and DxeCore, because PI spec has no limitation to nest FV number. Could you help submit one tracker in bugzillar? We will fix it. Thanks Liming > -Original Message- > From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] > Sent:

Re: [edk2] how to load drivers from additional FV's?

> On Mar 15, 2017, at 7:29 PM, Gao, Liming wrote: > > Michael: > I agree this is an issue in PeiCore and DxeCore, because PI spec has no > limitation to nest FV number. Could you help submit one tracker in bugzillar? > We will fix it. > Liming, Thanks for double

Re: [edk2] [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

I was unsure if printing the hex address of the load options was useful (useful enough?). I know for some images it was nice to get the load options printed as a string since they are command line parameters. I guess that might be more focused on learning about the shell itself and how it was

Re: [edk2] Testing NVMe async commands

Hi, Sharma As far as I know, we have UEFI SCT test suite to cover NVME_PASS_THRU async test. But it's not complex as your case. As you have sent 210720 cmds, it's more like memory leak issue. Could you please only send 1 cmds and compare the memory map change before and after? If there is

Re: [edk2] how to load drivers from additional FV's?

Andrew, using a fallback with 1 as the fourth argument didn't seem to work. > So one workaround would be to add a 2nd FV_IMAGE file that contains the 2nd > FV in the 1st FV_IMAGE Section. I've actually tried that before and it didn't seem to work. BUt after what you've said I tried using a

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

On 03/15/17 02:22, Zeng, Star wrote: > On 2017/3/14 21:13, Laszlo Ersek wrote: >> On 03/14/17 09:33, Zeng, Star wrote: >>> In original code for < 4G table, >>> Dsdt and XDsdt will be both assigned if FADT is installed before >>> DSDT, but >>> Dsdt and XDsdt will have mutual exclusion if FADT is

Re: [edk2] how to load drivers from additional FV's?

Laszlo: As Andrew said, the problem is nesting FV's. I've also tried different ways and depths of nesting FV's in the main FV, but none of them worked. Also, I'm using PrePi, Andrew: Yea that seems to be the problem, but how would I access other sections? ReadSection doesn't seem to take any

[edk2] FDF dependency?

Is there a compile time dependency on values provided in the FDF file? I am facing a situation where I am using pre-built binaries for some modules when building. We had a need to create another FDF file to create a separate flash image with different values, but finding that some of the

Re: [edk2] [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

Does the print call need to be updated to print this out properly? -Jaben > -Original Message- > From: Jeff Westfahl [mailto:jeff.westf...@ni.com] > Sent: Tuesday, March 14, 2017 2:02 PM > To: edk2-devel@lists.01.org > Cc: Jeff Westfahl ; Ni, Ruiyu

Re: [edk2] [PATCH] ArmPkg/UncachedMemoryAllocationLib: set XP bit via CPU arch protocol

On 15 March 2017 at 10:12, Ard Biesheuvel wrote: > On 15 March 2017 at 09:59, Ryan Harkin wrote: >> Hi Ard, >> >> Thanks for the quick turnaround as always. >> >> On 14 March 2017 at 20:20, Leif Lindholm wrote: >>> On

Re: [edk2] [PATCH v2] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

Jaben, I think the output looks good with the udpated format. All of the output values are aligned, and it prints the hex address of the load options, just like it prints the hex address of the image address right below. Regards, Jeff On Wed, 15 Mar 2017, Carsey, Jaben wrote: Does the

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Fix runtime issue

Reviewed-by : Chao Zhang -Original Message- From: Yao, Jiewen Sent: Wednesday, March 15, 2017 2:04 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [PATCH] MdeModulePkg/CapsuleLib: Fix runtime issue The previous patch has

Re: [edk2] [Patch] MdePkg/UefiDevicePathLib: Fix the wrong MAC address length

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Friday, March 10, 2017 2:47 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Ye, Ting ; Fu, Siyuan

Re: [edk2] [PATCH 0/3] DP: Handle "/" separator in debug path for GCC

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Wednesday, March 15, 2017 1:50 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [edk2] [PATCH

Re: [edk2] [Patch] MdePkg/UefiDevicePathLib: Fix the wrong MAC address length

Reviewed-by: Fu Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: 2017年3月10日 14:47 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Ye, Ting ; Fu, Siyuan

[edk2] [PATCH] MdeModulePkg/CapsuleLib: Fix runtime issue

The previous patch has problem on handling capsule request at runtime. This patch fixed the issue. Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao ---

[edk2] [Patch][edk2-platforms] Vlv2TbltDevicePkg: Disable LPC Serial IRQ.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2TbltDevicePkg/PlatformDxe/IchPlatformPolicy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Vlv2TbltDevicePkg/PlatformDxe/IchPlatformPolicy.c

Re: [edk2] [PATCH] MdeModulePkg PiSmmCore: Remove unreferenced symbol for SMRAM profile

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 14, 2017 5:12 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Tian, > Feng > Subject: [PATCH] MdeModulePkg

Re: [edk2] [PATCH] MdeModulePkg DxeCore: Remove unreferenced symbol for memory profile

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 14, 2017 5:11 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Tian, > Feng > Subject: [PATCH] MdeModulePkg