Re: [edk2] [PATCH edk2-platforms 17/41] Silicon/NXP : Add NOR driver.

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:31PM +0530, Meenakshi Aggarwal wrote: > Add NOR DXE phase driver, it installs BlockIO and Fvp > protocol. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc|

Re: [edk2] [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds

2018-12-19 Thread Ard Biesheuvel
On Wed, 19 Dec 2018 at 20:11, Leif Lindholm wrote: > > On Wed, Dec 19, 2018 at 06:39:07PM +0100, Ard Biesheuvel wrote: > > Ensure that we prevent the CPU from proceeding after having taken an > > unhandled exception on a RELEASE build, which does not contain the > > ASSERT() which ensures this on

Re: [edk2] [PATCH edk2-platforms 16/41] Silicon/NXP : Add support of NorFlashLib

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:30PM +0530, Meenakshi Aggarwal wrote: > NorFlashLib interacts with the underlying IFC NOR controller. Expand IFC in commit message. > This will be used by NOR driver for any information > exchange with NOR controller. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms 18/41] LS1043 : Enable NOR driver for LS1043aRDB package.

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:32PM +0530, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal I think I actually gave a Reviewed-by: Leif Lindholm for this one last round. > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc

Re: [edk2] [PATCH edk2-platforms 19/41] Silicon/NXP:Add LS1046ARDB SoCLib Support

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:33PM +0530, Meenakshi Aggarwal wrote: > Provide Functions to initialize peripherals, > print board and soc information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH edk2-platforms 00/27] Import Hummingboard Edge platform for Windows IoT Core

2018-12-19 Thread Chris Co via edk2-devel
Hi Leif, No problem - it's been a crazy year all around so I fully understand. Thank you for making time to review and provide feedback on this patch set. I am already out of office for the rest of the year so I will make the changes recommended by you and Ard when I get back. And I also have

Re: [edk2] [PATCH edk2-platforms 20/41] Silicon/NXP:Add support for PCF2129 Real Time Clock Library

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:34PM +0530, Meenakshi Aggarwal wrote: > From: Vabhav > > Library to provide functions for NXP pcf2129 real time clock library > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and above Support.

2018-12-19 Thread Ashish Singhal
No problem. Please let me know when you have reviewed it and I will send the final patch with your name as reviewer. Thanks Ashish From: Wu, Hao A Sent: Tuesday, December 18, 2018 6:46:57 PM To: Ashish Singhal; edk2-devel@lists.01.org Subject: RE: [edk2]

Re: [edk2] [PATCH edk2-platforms 23/41] Platform/NXP: Add Platform driver for LS1046 RDB board

2018-12-19 Thread Leif Lindholm
Add a commit message please. Like - what is going on with the handling of multiple I2c masters? On Wed, Nov 28, 2018 at 08:31:37PM +0530, Meenakshi Aggarwal wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

[edk2] [edk2-platforms] [PATCH v7 2/2] Platform/ARM: Add Readme.md

2018-12-19 Thread Nariman Poushin
This covers the bulk of the information originally present in https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64 regarding building and running the Foundation/Base FVP Platforms. The sections on fetching source have been delegated to the root Readme.md

Re: [edk2] [PATCH edk2-platforms 21/41] Platform/NXP: LS1046A RDB Board Library

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:35PM +0530, Meenakshi Aggarwal wrote: > Library to provide board specific timings for LS1046ARDB > board with interfacing to IFC controller for accessing > FPGA and NAND. Expand IFC in commit message, please. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH edk2-platforms 22/41] Platform/NXP: Add ArmPlatformLib for LS1046A

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:36PM +0530, Meenakshi Aggarwal wrote: > From: Vabhav > > Adding support of ArmPlatformLib for NXP LS1046ARDB board > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > Reviewed-by: Leif Lindholm > --- >

Re: [edk2] [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 06:39:07PM +0100, Ard Biesheuvel wrote: > Ensure that we prevent the CPU from proceeding after having taken an > unhandled exception on a RELEASE build, which does not contain the > ASSERT() which ensures this on DEBUG and NOOPT builds. > > Retain the code following the

[edk2] [PATCH v2 1/6] MdePkg/Base: introduce MAX_ALLOC_ADDRESS

2018-12-19 Thread Ard Biesheuvel
On some architectures, the maximum representable address deviates from the virtual address range that is accessible by the firmware at boot time. For instance, on AArch64, UEFI mandates a 4 KB page size, which limits the address space to 48 bits, while more than that may be populated on a

[edk2] [PATCH v2 0/6] introduce MAX_ALLOC_ADDRESS to limit boot time allocations

2018-12-19 Thread Ard Biesheuvel
Since modifying MAX_ADDRESS to limit the memory used at boot time has turned out to be intractible, this series proposes another approach to do the same, by introducing MAX_ALLOC_ADDRESS for firmware internal use. I tested these patches with ArmVirtQemu in the following way: - limit

[edk2] [PATCH v2 3/6] MdeModulePkg/Dxe/Page: take MAX_ALLOC_ADDRESS into account

2018-12-19 Thread Ard Biesheuvel
Take MAX_ALLOC_ADDRESS into account in the implementation of the page allocation routines, so that they will only return memory that is addressable by the CPU at boot time, even if more memory is available in the GCD memory map. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2 4/6] ArmPkg/ArmMmuLib: take MAX_ALLOC_ADDRESS into account

2018-12-19 Thread Ard Biesheuvel
When creating the page tables for the 1:1 mapping, ensure that we don't attempt to map more than what is architecturally permitted when running with 4 KB pages, which is 48 bits of VA. This will be reflected in the value of MAX_ALLOC_ADDRESS once we override it for AArch64, so use that macro

[edk2] [PATCH v2 6/6] ArmVirtPkg/MemoryInitPeiLib: split memory HOB based on MAX_ALLOC_ADDRESS

2018-12-19 Thread Ard Biesheuvel
The current ArmVirtMemoryInitPeiLib code splits the memory region passed via PcdSystemMemoryBase/PcdSystemMemorySize in two if the region extends beyond the MAX_ADDRESS limit. This was introduced for 32-bit ARM, which may support more than 4 GB of physical address space, but cannot address all of

[edk2] [PATCH v2 5/6] ArmPlatformPkg/MemoryInitPeim: take MAX_ALLOC_ADDRESS into account

2018-12-19 Thread Ard Biesheuvel
Limit the PEI memory region so it will not extend beyond what we can address architecturally when running with 4 KB pages. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c | 6 +++--- 1 file changed, 3

[edk2] [PATCH v2 2/6] MdeModulePkg/Dxe/Gcd: disregard memory above MAX_ALLOC_ADDRESS

2018-12-19 Thread Ard Biesheuvel
Update the GCD memory map initialization code so it disregards memory that is not addressable by the CPU at boot time. This only affects the first memory descriptor that is added, other memory descriptors are permitted that describe memory ranges that may be accessible to the CPU itself only when

Re: [edk2] [PATCH v2 4/6] ArmPkg/ArmMmuLib: take MAX_ALLOC_ADDRESS into account

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 09:56:38PM +0100, Ard Biesheuvel wrote: > When creating the page tables for the 1:1 mapping, ensure that we don't > attempt to map more than what is architecturally permitted when running > with 4 KB pages, which is 48 bits of VA. This will be reflected in the > value of

Re: [edk2] [PATCH v2 5/6] ArmPlatformPkg/MemoryInitPeim: take MAX_ALLOC_ADDRESS into account

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 09:56:39PM +0100, Ard Biesheuvel wrote: > Limit the PEI memory region so it will not extend beyond what we can > address architecturally when running with 4 KB pages. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by:

Re: [edk2] [PATCH] BaseTools/tools_def ARM: emit PIC veneers

2018-12-19 Thread Ard Biesheuvel
On Wed, 12 Dec 2018 at 13:36, Leif Lindholm wrote: > > On Wed, Dec 12, 2018 at 01:19:31PM +0100, Ard Biesheuvel wrote: > > The ARM linker may emit veneers, i.e., trampolines, when ordinary > > direct relative branches cannot be used, e.g., for Thumb interworking > > or branch targets that are out

[edk2] [PATCH v2 3/4] ArmPkg/GenericWatchdogDxe: clean up the code

2018-12-19 Thread Ard Biesheuvel
Clean up the code, by adding missing STATIC modifiers, drop redundant casts, and get rid of the 'success handling' anti pattern in the entry point code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm ---

[edk2] [PATCH v2 1/4] ArmPlatformPkg/SP805WatchdogDxe: cosmetic cleanup

2018-12-19 Thread Ard Biesheuvel
Before fixing the SP805 driver, let's clean it up a bit. No functional changes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf | 11 +--

[edk2] [PATCH v2 2/4] ArmPlatformPkg/SP805WatchdogDxe: switch to interrupt mode

2018-12-19 Thread Ard Biesheuvel
The SP805 watchdog driver doesn't implement the PI watchdog protocol fully, but always simply resets the system if the watchdog time runs out. However, the hardware does support the intended usage model, as long as the SP805 is wired up correctly. So let's implement interrupt based mode involving

[edk2] [PATCH v2 0/4] ArmPkg, ArmPlatformPkg: watchdog driver cleanup

2018-12-19 Thread Ard Biesheuvel
This series cleans up the code of the two watchdog drivers we have for ARM systems, and brings them in compliance with the PI spec, which specifies that the default action of the watchdog can be overridden by registering a handler. Note that the TC2 code in edk2-platforms will have to be brought

[edk2] [PATCH v2 4/4] ArmPkg/GenericWatchdogDxe: implement RegisterHandler() method

2018-12-19 Thread Ard Biesheuvel
Even though UEFI does not appear to use it, let's implement the complete PI watchdog protocol, including handler registration, which will be invoked instead of the ResetSystem() runtime service when the watchdog timer expires. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 11:08:32AM +0100, Ard Biesheuvel wrote: > On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > > > ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still > > referenced in StyxDtbLoaderLib.inf, but not actually used anywhere - > > so drop them. > > > >

Re: [edk2] [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 11:08:48AM +0100, Ard Biesheuvel wrote: > On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > > > The following Pcds > > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable > > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset > > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset > > -

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib

2018-12-19 Thread Ard Biesheuvel
On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still > referenced in StyxDtbLoaderLib.inf, but not actually used anywhere - > so drop them. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif

Re: [edk2] [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec

2018-12-19 Thread Ard Biesheuvel
On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > The following Pcds > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment > remained defined, without actual

[edk2] [PATCH v3 2/3] MdePkg/BaseLib: Remove InternalCharToUpper and InternalBaseLibAsciiToUpper

2018-12-19 Thread Shenglei Zhang
InternalCharToUpper and InternalBaseLibAsciiToUpper are internal functions and now we will introduce public functions that have the same effects. So I remove their definition in BaseLibInternals.h. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Leif Lindholm Cc: Laszlo Ersek Cc:

[edk2] [PATCH v3 1/3] MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly

2018-12-19 Thread Shenglei Zhang
Introduce two public functions CharToUpper and AsciiToUpper. They have the same functions as InternalCharToUpper and InternalBaseLibAsciiToUpper.Considering the internal functions will be removed,so directly I change their function names to the public ones'.

[edk2] [PATCH v3 0/3] Introduce two public functions and remove internal ones

2018-12-19 Thread Shenglei Zhang
Introduce public functions CharToUpper and AsciiToUpper. Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper. v2: Update the title and commit message of 1/3. v3: 1.Add a patch to remove AsciiToUpper in EdbSupportString.c. 2.Revert the changes in Basetools. Cc:

[edk2] [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper

2018-12-19 Thread Shenglei Zhang
AsciiToUpper in EdbSupportString.c is an internal function. And we will introduce a public function which has the same name and effect. So we remove its implement. Code in EdbSupportString.c now consumes the public one. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Jian J Wang Cc: Hao

Re: [edk2] [PATCH 2/4] ArmPlatformPkg/SP805WatchdogDxe: switch to interrupt mode

2018-12-19 Thread Thomas Abraham
Hi Ard, On Tue, Dec 18, 2018 at 9:59 PM Ard Biesheuvel wrote: > > On Tue, 18 Dec 2018 at 14:39, Leif Lindholm wrote: > > > > On Tue, Dec 18, 2018 at 02:10:12PM +0100, Ard Biesheuvel wrote: > > > The SP805 watchdog driver doesn't implement the PI watchdog protocol > > > fully, but always simply

[edk2] [PATCH v2 0/3] Fix an incorrectly spelled Marco

2018-12-19 Thread Shenglei Zhang
EFI_RETURNING_FROM_EFI_APPLICATOIN is not spelled correctly and change it to EFI_RETURNING_FROM_EFI_APPLICATION. v2 In v1 EFI_RETURNING_FROM_EFI_APPLICATOIN is changed into EFI_RETURNING_FROM_EFI_APPLICATION directly in one patch, which may lead to unbisectability. To solve this problem, the

[edk2] [PATCH v2 2/3] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c

2018-12-19 Thread Shenglei Zhang
Change EFI_RETURNING_FROM_EFI_APPLICATOIN to EFI_RETURNING_FROM_EFI_APPLICATION. https://bugzilla.tianocore.org/show_bug.cgi?id=1368 Cc: Chao Zhang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4

[edk2] [PATCH v2 3/3] MdePkg/IndustryStandard: Remove an incorrectly spelled Marco

2018-12-19 Thread Shenglei Zhang
EFI_RETURNING_FROM_EFI_APPLICATOIN is not correctly spelled, so now remove it. https://bugzilla.tianocore.org/show_bug.cgi?id=1368 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH v2 1/3] MdePkg/IndustryStandard: Introduce a correctly spelled Marco

2018-12-19 Thread Shenglei Zhang
EFI_RETURNING_FROM_EFI_APPLICATOIN is incorrect. Before removing it, introduce the correctly spelled one, EFI_RETURNING_FROM_EFI_APPLICATION. https://bugzilla.tianocore.org/show_bug.cgi?id=1368 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH edk2-platforms 13/41] Silicon/NXP : Add support of IfcLib

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:27PM +0530, Meenakshi Aggarwal wrote: > Add support of IfcLib, it will be used to perform > any operation on IFC controller. Expand acronym. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE

2018-12-19 Thread Ard Biesheuvel
On Tue, 18 Dec 2018 at 14:05, Ard Biesheuvel wrote: > > On Tue, 18 Dec 2018 at 14:04, Sumit Garg wrote: > > > > On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel > > wrote: > > > > > > On Tue, 18 Dec 2018 at 13:58, Sumit Garg wrote: > > > > > > > > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel > >

Re: [edk2] [PATCH v3 3/3] MdeModulePkg/EbcDebugger: Remove an internal function AsciiToUpper

2018-12-19 Thread Wu, Hao A
Hi, I think the patch will bring issue with regard to bisecting. One way to resolve this is to introduce a patch to rename the 'AsciiToUpper' within file EdbSupportString.c to something like 'InternalAsciiToUpper'. And make the new patch as the 1st one of the series. Then goes the remaining 3

[edk2] [PATCH] BaseTools/tools_def ARM: use softfloat target for CLANG3x

2018-12-19 Thread Ard Biesheuvel
The target triplet we use for CLANG35 and CLANG38 specifies a hardfloat target, and so the binaries that are emitted are annotated as using VFP registers for passing floating point arguments, even though no VFP is used anywhere in the code. This works fine as long as we don't try to link against

Re: [edk2] [PATCH] EmbeddedPkg: remove GdbDebugAgent library

2018-12-19 Thread Leif Lindholm
On Wed, Dec 12, 2018 at 03:17:29PM +, Leif Lindholm wrote: > > Considering the commit log from its introduction > > > > """ > > commit 969eba7b0df70c9aa261eaf005085568b88de87c > > Author: andrewfish > > Date: Sat Apr 3 00:41:42 2010 + > > > > Add the beginning of a GDB based Debug

Re: [edk2] [PATCH] EmbeddedPkg: remove GdbDebugAgent library

2018-12-19 Thread Ard Biesheuvel
On Wed, 19 Dec 2018 at 16:30, Ard Biesheuvel wrote: > > On Wed, 19 Dec 2018 at 16:20, Leif Lindholm wrote: > > > > On Wed, Dec 12, 2018 at 03:17:29PM +, Leif Lindholm wrote: > > > > Considering the commit log from its introduction > > > > > > > > """ > > > > commit

[edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: build capsule unconditionally

2018-12-19 Thread Ard Biesheuvel
Remove the DO_CAPSULE conditionals so that the capsules are always built. This fixes a build issue that exists currently, since the IPv6 enabled version of IScsiDxe that we now include depends on a library class that can only be resolved if building with DO_CAPSULE=TRUE. Contributed-under:

Re: [edk2] [PATCH] Platform/FVP-AArch64: switch to the SBSA watchdog

2018-12-19 Thread Leif Lindholm
On Tue, Dec 18, 2018 at 05:46:21PM +0100, Ard Biesheuvel wrote: > On the FVP Foundation model, the SP805 watchdog appears to be 'wired' > incorrectly, resulting in a watchdog counter that decrements at the > APB clock rate of 24 MHz instead of the usual 32 kHz. Since the > timer start value is

Re: [edk2] [PATCH v2 edk2-platforms 0/8] Platform/ARM/Sgi: Add support for virtio network device

2018-12-19 Thread Vijayenthiran Subramaniam
On Wed, Dec 19, 2018 at 4:08 PM Ard Biesheuvel wrote: > > On Fri, 14 Dec 2018 at 17:59, Vijayenthiran Subramaniam > wrote: > > > > Changes since v1: > > - Rebased the series against latest edk2-platforms > > > > This patch series adds support for virtio network controller found in ARM > > SGI >

Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: build capsule unconditionally

2018-12-19 Thread Ard Biesheuvel
On Wed, 19 Dec 2018 at 18:26, Leif Lindholm wrote: > > On Wed, Dec 19, 2018 at 06:06:14PM +0100, Ard Biesheuvel wrote: > > Remove the DO_CAPSULE conditionals so that the capsules are > > always built. This fixes a build issue that exists currently, > > since the IPv6 enabled version of IScsiDxe

[edk2] [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds

2018-12-19 Thread Ard Biesheuvel
Ensure that we prevent the CPU from proceeding after having taken an unhandled exception on a RELEASE build, which does not contain the ASSERT() which ensures this on DEBUG and NOOPT builds. Retain the code following the deadloop so that we can keep going when running in a debugger.

Re: [edk2] [PATCH v2 edk2-platforms 0/8] Platform/ARM/Sgi: Add support for virtio network device

2018-12-19 Thread Ard Biesheuvel
On Fri, 14 Dec 2018 at 17:59, Vijayenthiran Subramaniam wrote: > > Changes since v1: > - Rebased the series against latest edk2-platforms > > This patch series adds support for virtio network controller found in ARM SGI > plaform's fast models. The first patch in this series restructure the >

Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: build capsule unconditionally

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 06:06:14PM +0100, Ard Biesheuvel wrote: > Remove the DO_CAPSULE conditionals so that the capsules are > always built. This fixes a build issue that exists currently, > since the IPv6 enabled version of IScsiDxe that we now include > depends on a library class that can only

Re: [edk2] [PATCH 0/2] Delete TCP, PXE, iSCSI driver in MdeModulePkg

2018-12-19 Thread Leif Lindholm
On Wed, Dec 19, 2018 at 01:42:03PM +0800, Fu Siyuan wrote: > This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe > drivers in MdeModulePkg. These drivers will not be maintained and can't > co-work with the dual-stack drivers in NetworkPkg. > > In future, people should use below

Re: [edk2] [PATCH edk2-platforms 14/41] Silicon/NXP : Add support for FpgaLib.

2018-12-19 Thread Leif Lindholm
On Wed, Nov 28, 2018 at 08:31:28PM +0530, Meenakshi Aggarwal wrote: > FpgaLib export FPGA_READ and FPGA_WRITE function and > provide a function to print Board personality. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Dong, Eric
Agreed, Maybe it's time to add a new API like AcquireSpinLockWithoutTimeOut? Thanks, Eric > -Original Message- > From: Yao, Jiewen > Sent: Thursday, December 20, 2018 9:19 AM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject: RE: [edk2] [Patch 1/3]

[edk2] [PATCH v2 4/6] NetworkPkg: Remove some clarification from IScsiDxe.inf

2018-12-19 Thread Siyuan Fu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1278 This patch is to remove the clarification about usage/difference between those drivers in MdeModulePkg and NetworkPkg, since the MdeModulePkg one have been deleted. Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2 0/6] Delete TCP, PXE, iSCSI driver in MdeModulePkg

2018-12-19 Thread Siyuan Fu
Delete TCP, PXE, iSCSI driver in MdeModulePkg This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe drivers in MdeModulePkg. These drivers will not be maintained and can't co-work with the dual-stack drivers in NetworkPkg. In future, people should use below NetworkPkg drivers

[edk2] [PATCH v2 2/6] NetworkPkg: Remove some clarification from TcpDxe.inf

2018-12-19 Thread Siyuan Fu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1278 This patch is to remove the clarification about usage/difference between those drivers in MdeModulePkg and NetworkPkg, since the MdeModulePkg one have been deleted. Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2 6/6] NetworkPkg: Remove some clarification from UefiPxeBcDxe.inf

2018-12-19 Thread Siyuan Fu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1278 This patch is to remove the clarification about usage/difference between those drivers in MdeModulePkg and NetworkPkg, since the MdeModulePkg one have been deleted. Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless function.

2018-12-19 Thread Ni, Ruiyu
Nice cleanup. Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, December 20, 2018 9:16 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject: [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless > function. > >

Re: [edk2] [PATCH v2 3/6] MdeModulePkg/Dxe/Page: take MAX_ALLOC_ADDRESS into account

2018-12-19 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 20, 2018 4:57 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Gao, Liming ; Wang, > Jian J ; Wu, Hao A ; Leif > Lindholm ;

[edk2] [Patch 3/3] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless function.

2018-12-19 Thread Eric Dong
Directly call the API instead of create function for it. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1411 Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- .../PeiRegisterCpuFeaturesLib.c| 35

[edk2] [Patch 0/3] Avoid AP calls PeiService

2018-12-19 Thread Eric Dong
AP should not use PeiServices. This patches fixed two issues which both caused by AP try to call PeiServices. Eric Dong (3): UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService. UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService. UefiCpuPkg/RegisterCpuFeaturesLib: Remove

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Ni, Ruiyu
Can you just change the AcquireSpinLock() behavior to remove the Timeout PCD consumption? I haven't seen a real case that the timed acquisition of spin lock is needed. Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Thursday, December 20, 2018 9:23 AM > To: Yao, Jiewen ;

Re: [edk2] [PATCH 1/1] UefiCpuPkg/CpuExceptionHandlerLib: Fix spelling issue

2018-12-19 Thread Dong, Eric
Hi Mike, I searched the code base, found you missed one in PeiCpuException.c file. Can you change it also and send the new patch again? Thanks, Eric > -Original Message- > From: Mike Maslenkin [mailto:mike.maslen...@gmail.com] > Sent: Wednesday, December 19, 2018 7:55 AM > To:

[edk2] [Patch 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Eric Dong
GetProcessorIndex function calls GetMpPpi to get the MP Ppi. Ap will calls GetProcessorIndex function which final let AP calls PeiService. This patch avoid GetProcessorIndex call PeiService. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1411 Cc: Ruiyu Ni Cc: Laszlo Ersek

[edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Eric Dong
In AcquireSpinLock function, it calls GetPerformanceCounter which final calls PeiService service. This patch avoid to call AcquireSpinLock function. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1411 Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Yao, Jiewen
Hi If we think below code is generic, can we have an API for that? + // + // Wait for the AP to release the MSR spin lock. + // + while (!AcquireSpinLockOrFail (>ConsoleLogLock)) { +CpuPause (); + } > -Original Message- > From: edk2-devel

[edk2] [PATCH v2 0/6] Delete TCP, PXE, iSCSI driver in MdeModulePkg

2018-12-19 Thread Siyuan Fu
Delete TCP, PXE, iSCSI driver in MdeModulePkg This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe drivers in MdeModulePkg. These drivers will not be maintained and can't co-work with the dual-stack drivers in NetworkPkg. In future, people should use below NetworkPkg drivers

Re: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.

2018-12-19 Thread Yao, Jiewen
Yes, I agree, if we don't have any real case. > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, December 20, 2018 10:07 AM > To: Dong, Eric ; Yao, Jiewen > ; edk2-devel@lists.01.org > Cc: Laszlo Ersek > Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid > AP

Re: [edk2] [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE

2018-12-19 Thread Sumit Garg
On Wed, 19 Dec 2018 at 20:37, Ard Biesheuvel wrote: > > On Tue, 18 Dec 2018 at 14:05, Ard Biesheuvel > wrote: > > > > On Tue, 18 Dec 2018 at 14:04, Sumit Garg wrote: > > > > > > On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel > > > wrote: > > > > > > > > On Tue, 18 Dec 2018 at 13:58, Sumit Garg

Re: [edk2] Drop CSM support in OvmfPkg?

2018-12-19 Thread Gerd Hoffmann
On Mon, Dec 17, 2018 at 10:54:25AM +0100, Laszlo Ersek wrote: > (Adding Kevin, Gerd, David) > > On 12/17/18 03:23, Ni, Ruiyu wrote: > > Hi OvmfPkg maintainers and reviewers, > > I am working on removing IntelFrameworkModulePkg and IntelFrameworkPkg. The > > biggest dependency now I see is the

Re: [edk2] [PATCH v2 1/6] MdePkg/Base: introduce MAX_ALLOC_ADDRESS

2018-12-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Thursday, December 20, 2018 4:57 AM >To: edk2-devel@lists.01.org >Cc: Andrew Jones ; Wu, Hao A ; >Gao, Liming ; Kinney, Michael D >; Laszlo Ersek

Re: [edk2] [PATCH] BaseTools/tools_def ARM: use softfloat target for CLANG3x

2018-12-19 Thread Gao, Liming
Ard: So, this change requires ARM users to install the additional tool chain? If yes, could you list the detail impact to user? Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Wednesday, December 19, 2018

[edk2] [PATCH edk2-platforms v2 0/3] Platform/ARM/SgiPkg: Enable StandaloneMm on Sgi platforms

2018-12-19 Thread Sughosh Ganu
Changes since v1: Rebased on top of latest edk2-platforms master The following patches enable building of StandaloneMm image on Sgi platforms. The first patch adds build infra for StandaloneMm image. The second patch of the series adds memory buffer required for communication between the

[edk2] [PATCH edk2-platforms v2 1/3] Platform/ARM/SgiPkg: Build infrastructure for StandaloneMm image

2018-12-19 Thread Sughosh Ganu
Add the build infrastructure for compilation of StandaloneMm image files and FD file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 130 +++

[edk2] [PATCH edk2-platforms v2 2/3] Platform/ARM/SgiPkg: Setup memory buffers for MmCommunicate

2018-12-19 Thread Sughosh Ganu
Add memory regions for MmCommuncate buffers into the virtual memory table. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 4 Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 8

[edk2] [PATCH edk2-platforms v2 3/3] Platform/ARM/SgiPkg: Enable MmCommunication module on the platform

2018-12-19 Thread Sughosh Ganu
The ArmMmCommunication module is used for communication between non-secure and secure world using Arm's Management Mode Specification. Enable this module on Sgi platforms. This would be used subsequently by the RAS and SecureBoot features, support for which is to be added on the platform.