Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-20 Thread Jordan Justen
On 2015-07-17 04:11:46, Laszlo Ersek wrote: > On 07/17/15 12:42, Ard Biesheuvel wrote: > > On 17 July 2015 at 12:10, Laszlo Ersek wrote: > >> On 07/17/15 08:45, Ard Biesheuvel wrote: > > [...] > >>> > >>> There is a distinction, though. The reason we could not rely on the > >>> HOB for the XenHype

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-20 Thread Jordan Justen
On 2015-07-17 03:42:21, Ard Biesheuvel wrote: > On 17 July 2015 at 12:10, Laszlo Ersek wrote: > > On 07/17/15 08:45, Ard Biesheuvel wrote: > [...] > >> > >> There is a distinction, though. The reason we could not rely on the > >> HOB for the XenHypercall code on the ARM side was that those > >> hy

Re: [edk2] [patch] MdeModulePkg:Correct the parameter order in match2 sample opcode

2015-07-20 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Monday, July 20, 2015 5:13 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Correct the parameter order in match2 sample opcode The first parameter of match2 opcode should be the patt

Re: [edk2] [patch] MdeModulePkg:Check the case caused by mismatch

2015-07-20 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Tuesday, July 21, 2015 10:37 AM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Check the case caused by mismatch When mismatch happens,there exists one case that exit current form and d

[edk2] [patch] MdeModulePkg:Check the case caused by mismatch

2015-07-20 Thread Dandan Bi
When mismatch happens,there exists one case that exit current form and display last form.Assert code don't cover this case. Now add check to handle this situation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/FormDis

Re: [edk2] [Patch] ShellPkg: Fix bad TimeZone (TZ) conversion.

2015-07-20 Thread Carsey, Jaben
Andrew, What do you think about adding this to ShellCommandLib? I think that we would want to consider refactoring Time and TimeZone to use this new code in the future also. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Andrew F

[edk2] AMD's UEFI strategy?

2015-07-20 Thread Blibbet
Hi, Is anyone from AMD on this list? If you know the right person, could you please forward? Can anyone explain AMD's strategy w/r/t UEFI and BIOS, UEFI and coreboot? For x64/EMT64 systems: What models use UEFI, what models use BIOS, what models use coreboot? I'm unclear if they're still using

Re: [edk2] [Patch] ShellPkg: Fix bad TimeZone (TZ) conversion.

2015-07-20 Thread Andrew Fish
> On Jul 20, 2015, at 10:35 AM, Carsey, Jaben wrote: > > I cannot commit anything at this point due to the sourceforge issue. > > The other routine that you mention could help. Yes please contribute that > when you have time. > Do you have an opinion on the form? In the ls code, new library

Re: [edk2] [Patch] ShellPkg: Fix bad TimeZone (TZ) conversion.

2015-07-20 Thread Carsey, Jaben
I cannot commit anything at this point due to the sourceforge issue. The other routine that you mention could help. Yes please contribute that when you have time. -Jaben From: Andrew Fish [mailto:af...@apple.com] Sent: Friday, July 17, 2015 11:32 AM To: edk2-devel@lists.01.org Cc: Carsey, Jabe

Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64

2015-07-20 Thread Ard Biesheuvel
On 20 July 2015 at 10:42, Ard Biesheuvel wrote: > On 17 July 2015 at 21:07, Cohen, Eugene wrote: >> Ard, >> >>> The bottom line is that we are still losing around 40 KB on padding in >>> total, >> >> If I understand correctly you're saying because of limitations in the >> AArch64 LLVM/clang too

Re: [edk2] [PATCH 0/6] ArmVirtPkg/ArmVirtQemu: support SMBIOS

2015-07-20 Thread Laszlo Ersek
On 07/16/15 00:41, Laszlo Ersek wrote: > Laszlo Ersek (6): > OvmfPkg: SmbiosPlatformDxe: move IsEntryPointStructureValid() to Xen.c #1 reviewed by Wei Liu, acked by Gabriel > OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64 #2 acked-by Stefano, not optimal according to Jord

Re: [edk2] Question regarding the PixelFormat in GOP

2015-07-20 Thread Ni, Ruiyu
GetPixelElementSize() in the spec returns the bit size not byte size which I think it's a bug of spec. Based on that, I cannot trust that code:) > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, July 20, 2015 5:59 PM > To: Ni, Ruiyu; edk2-devel@lists.01.

Re: [edk2] Question regarding the PixelFormat in GOP

2015-07-20 Thread Laszlo Ersek
On 07/20/15 09:08, Ni, Ruiyu wrote: > Video experts, > UEFI spec defines a pixel format (PixelBitMask) in the Graphics Output > Protocol chapter. In this pixel format, below structure is used to get the > bits information for each color. > typedef struct { > UINT32 RedMask; > UINT32 GreenMask; >

[edk2] [patch] MdeModulePkg:Correct the parameter order in match2 sample opcode

2015-07-20 Thread Dandan Bi
The first parameter of match2 opcode should be the pattern and the second one should be the string. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [edk2] [Patch] NetworkPkg: Add old IPv4_DEVICE_PATH and IPv6_DEVICE_PATH support

2015-07-20 Thread Ye, Ting
It looks IPv4_NODE_LEN_OLD_VERSIONS useless and your patch uses wrong macro for IPv6 device path node. Please update your patch. Best Regards, Ting -Original Message- From: Wang, Fan Sent: Monday, July 20, 2015 4:38 PM To: Ye, Ting; Fu, Siyuan; Wu, Jiaxin; edk2-devel@lists.01.org Cc: Ti

Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64

2015-07-20 Thread Ard Biesheuvel
On 17 July 2015 at 21:07, Cohen, Eugene wrote: > Ard, > >> The bottom line is that we are still losing around 40 KB on padding in total, > > If I understand correctly you're saying because of limitations in the AArch64 > LLVM/clang toolchain we must suffer some sort of code size increase (of whic

Re: [edk2] Filesystem support

2015-07-20 Thread Ni, Ruiyu
Meenakshi, I guess Partition driver wasn't able to start so your fix embedding partition related code to Fat driver resolves your bug. Please check whether Partition driver is started. Thanks, Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

[edk2] Question regarding the PixelFormat in GOP

2015-07-20 Thread Ni, Ruiyu
Video experts, UEFI spec defines a pixel format (PixelBitMask) in the Graphics Output Protocol chapter. In this pixel format, below structure is used to get the bits information for each color. typedef struct { UINT32 RedMask; UINT32 GreenMask; UINT32 BlueMask; UINT32 ReservedMask; } EFI_PIXEL_BI