Re: [edk2] [PATCH v1] MdeModulePkg: Remove event from protocol database only if registered

2015-09-17 Thread Tian, Feng
Great improvement:-) I am ok with your fix. Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Subramanian, Sriram (System FW, HP Servers) Sent: Thursday, September 17, 2015 16:30 To: Tian, Feng; edk2-devel@lists.01.org Su

Re: [edk2] Some question for MTFTP4 protocol

2015-09-17 Thread Ye, Ting
Correct a typo below. MTFTP4 server -> MTFTP4 driver. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting Sent: Friday, September 18, 2015 11:13 AM To: Mang Chia Ho; edk2-devel@lists.01.org Subject: Re: [edk2] Some question for MTFTP4 protocol

Re: [edk2] Some question for MTFTP4 protocol

2015-09-17 Thread Ye, Ting
Hi, For GetInfo(), the MTFTP4 server provides a callback function named "Mtftp4GetInfoCheckPacket" for CheckPacket(). Even though the UEFI spec does not define the GetInfo() should use EFI_MTFTP4_TOKEN, the MTFTP4 driver implements GetInfo() based on Readfile() thus it need supply callback func

[edk2] [PATCH] MdeModulePkg : Add a new DxeServicesLib GetFileDevicePathFromAnyFv () function

2015-09-17 Thread Wang, Nickle (HPS SW)
Dear MdeModulePkg maintainers, Please see attached patch. I follow the suggestions from previous email thread and update the patch. MdeModulePkg : Add a new DxeServicesLib GetFileDevicePathFromAnyFv () function Contributed-under: TianoCore Contribution Agreement 1.0 From: Shia Cinnamon Signed-

[edk2] [Patch] Update some smbios string and macro name for MinnowBoard Turbot board.

2015-09-17 Thread Tim He
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tim He --- Vlv2TbltDevicePkg/Include/Guid/PlatformInfo.h| 4 ++-- .../Library/MultiPlatformLib/BoardClkGens/BoardClkGens.c | 2 +- .../Library/MultiPlatformLib/BoardGpios/BoardGpios.c | 6 +++--- .../Library

Re: [edk2] [Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board

2015-09-17 Thread Wei, David
This patch looks good. Thanks, David | SSG BIOS From: He, Tim Sent: Thursday, September 17, 2015 5:38 PM To: 'edk2-devel@lists.01.org' Cc: Wei, David; Lu, ShifeiX A Subject: RE: [edk2][Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board Adding patch file, which is

Re: [edk2] [PATCH] ArmVirtPkg: PlatformIntelBdsLib: signal ReadyToBoot on direct kernel boot

2015-09-17 Thread Ard Biesheuvel
On 17 September 2015 at 17:07, Laszlo Ersek wrote: > According to the UEFI spec, EFI_EVENT_GROUP_READY_TO_BOOT "is notified by > the system when the Boot Manager is about to load and execute a boot > option". ArmVirtPkg doesn't do this currently when launching a kernel from > the QEMU command line

Re: [edk2] [PATCH v3] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
On 17 September 2015 at 16:57, Qiu Shumin wrote: > Difference with the 1st version: > It's not correct to casts away constness to allow TrimSpaces() to modify > 'commandline'. > This version make a copy of 'commandLine' and work with that in the remainder > of the function. > > Difference with t

[edk2] [PATCH] ArmVirtPkg: PlatformIntelBdsLib: signal ReadyToBoot on direct kernel boot

2015-09-17 Thread Laszlo Ersek
According to the UEFI spec, EFI_EVENT_GROUP_READY_TO_BOOT "is notified by the system when the Boot Manager is about to load and execute a boot option". ArmVirtPkg doesn't do this currently when launching a kernel from the QEMU command line. OvmfPkg does (see git commit 28a34033ee). At least two ed

[edk2] [PATCH v3] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Qiu Shumin
Difference with the 1st version: It's not correct to casts away constness to allow TrimSpaces() to modify 'commandline'. This version make a copy of 'commandLine' and work with that in the remainder of the function. Difference with the 2nd version Remove the redundant code. Cc: Jaben Carsey Cc

Re: [edk2] [PATCH v2] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
On 17 September 2015 at 14:27, Qiu Shumin wrote: > Difference with previous version: > It's not correct to casts away constness to allow TrimSpaces() to modify > 'commandline'. > This version make a copy of 'commandLine' and work with that in the remainder > of the function. > OK, much better.

[edk2] Some question for MTFTP4 protocol

2015-09-17 Thread Mang Chia Ho
Hi all, I have some question about the mtftp4 protocol. When i use the "EFI_MTFTP4_PROTOCOL.GetInfo()" function to get the file size of server's file. And server will send a OACK packet to client for file info. And client should use "EFI_MTFTP4_PROTOCOL.ParseOptions()" to parsing the OACK packet.

[edk2] [PATCH v2] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Qiu Shumin
Difference with previous version: It's not correct to casts away constness to allow TrimSpaces() to modify 'commandline'. This version make a copy of 'commandLine' and work with that in the remainder of the function. Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Yang Jadis Cc: Ard Biesheuvel Contributed

Re: [edk2] [PATCH] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Qiu, Shumin
Thanks for your comments I'll update the patch. -Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Thursday, September 17, 2015 4:56 PM To: Qiu, Shumin Cc: Carsey, Jaben; Ni, Ruiyu; edk2-devel@lists.01.org; Yang, Jadis Su

Re: [edk2] [Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board

2015-09-17 Thread He, Tim
Adding patch file, which is to update some Smbios string and macro name for MinnowBoard Turbot board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tim He mailto:tim...@intel.com>> Best Regards, Tim From: He, Tim Sent: Thursday, September 17, 2015 4:34 PM To: 'edk2-deve

Re: [edk2] [PATCH] ShellPkg: Fix GCC build fail.

2015-09-17 Thread Ard Biesheuvel
On 17 September 2015 at 05:04, Qiu Shumin wrote: > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Yang Jadis > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin > --- > ShellPkg/Application/Shell/ShellParametersProtocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

[edk2] [Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board

2015-09-17 Thread He, Tim
Update some smbios string and macro name for MinnowBoard Turbot board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tim He mailto:tim...@intel.com>> Best Regards, Tim ___ edk2-devel mailing list edk2-devel@lists.01.org https:

Re: [edk2] [PATCH v1] MdeModulePkg: Remove event from protocol database only if registered

2015-09-17 Thread Subramanian, Sriram (System FW, HP Servers)
Hi Feng, It was a while since we tested (the data is from June). With this change alone, we saw about 35% improvement in network download performance when HTTP/FTP like application running over TcpDxe and downloading files > 200MB in size. Also, in addition to the numbers, we didn't see a point

Re: [edk2] [PATCH] ShellPkg: Fix Shell fail when execute command in ShellProtocol.Execute().

2015-09-17 Thread Ard Biesheuvel
On 16 September 2015 at 07:51, Qiu Shumin wrote: > When execute a command with tailing blank spaces in ShellProtocol.Execute() > Shell will fail. This patch move the TrimSpaces operation into > ParseCommandLineToArgs function to fix the problem. > > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contribute

Re: [edk2] [PATCH V2] MdeModulePkg DxeCore: Take the range in resource HOB for PHIT as higher priority

2015-09-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Thursday, September 17, 2015 4:09 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Gao, Liming Subject: [PATCH V2] MdeModulePkg DxeCore: Take the range in resource HOB for PHIT as higher priority Take the range in the res

[edk2] [PATCH V2] MdeModulePkg DxeCore: Take the range in resource HOB for PHIT as higher priority

2015-09-17 Thread Star Zeng
Take the range in the resource descriptor HOB for the memory region described by the PHIT as higher priority if it is big enough. It can make the memory bin allocated to be at the same memory region with PHIT that has more better compatibility to avoid memory fragmentation for some code practices

Re: [edk2] [PATCH v1] MdeModulePkg: Remove event from protocol database only if registered

2015-09-17 Thread Tian, Feng
Hi, Sriram Do you have any performance data about this change for Network IO case? Thanks Feng -Original Message- From: Subramanian, Sriram (System FW, HP Servers) [mailto:srira...@hpe.com] Sent: Thursday, September 17, 2015 14:07 To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer; T

Re: [edk2] [PATCH 1/1] MdeModulePkg: Add SMBIOS 3.0 support in NetLibGetSystemGuid

2015-09-17 Thread Fu, Siyuan
Hi, Samer Should below if condition + if (!(EFI_ERROR (Status) || Smbios30Table == NULL)) { to be if (!(EFI_ERROR (Status) && Smbios30Table != NULL)) Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Se