Re: [edk2] [Patch 1/5] MdeModulePkg: Move OEMBadging protocol from IntelFrameworkModulePkg

2015-09-28 Thread Ni, Ruiyu
Jordan, I see lots of comments raised from you. Can you list all of your concerns which may result changing the patch? Because I do not have any idea what your intention is for the following words. " Those existing drivers also have the IntelFrameworkModulePkg.dec listed, so they can easily

Re: [edk2] [Patch 2/5] MdeModulePkg: Add ImageDecoderLib to provide image decoding service.

2015-09-28 Thread Jordan Justen
On 2015-09-28 19:35:07, Ni, Ruiyu wrote: > Jordan, > The NULL class library which provides real image decoding capability > should be able to detect the image format and decide to decode it or > not. I don't know that every format we'll ever want to support can be autodetected. Why not add a

Re: [edk2] [Patch 1/5] MdeModulePkg: Move OEMBadging protocol from IntelFrameworkModulePkg

2015-09-28 Thread Jordan Justen
On 2015-09-28 19:32:25, Ni, Ruiyu wrote: > Jordan, > I forgot to include the OEMBadging.h in the patch. But yes the file > will be moved to MdeModulePkg/Include/Protocol/OEMBadging.h. I think the patch should be resubmitted to correct this. > I didn't change the name in order to maintain the

Re: [edk2] PCI code is finding only Bus 0. I need Bus 1

2015-09-28 Thread Laszlo Ersek
On 09/26/15 02:49, Shubha Ramani wrote: > Thank you again for your detailed email Lazslo. The fun never stops; last time you wrote "Lazlo" and I mentioned that my first name was L-A-S-Z-L-O. I also recommended that you try copy & paste. I can see the attempt here (you added an "S" indeed), but

Re: [edk2] BUG: UEFI won't recognize PCI busses which don't sit under a bridge

2015-09-28 Thread Laszlo Ersek
On 09/27/15 21:46, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Shubha Ramani had to > walk into mine at 15:45:52 on Saturday 26 September 2015 and say: > >> Yes it's a bug but... >> OK I'm a dumb-ass. What I'm asking for with 0xCF8/0xCFC doesn't make sense. >> I

Re: [edk2] BUG: UEFI won't recognize PCI busses which don't sit under a bridge

2015-09-28 Thread Shubha Ramani
Laszlo and Bill, I appreciate where you're coming from. But I can't say anymore than I already have.It's OK. The "bug" where-ever it is probably won't get fixed as quickly as I need it. To get my job done I'm going the PciCf8Lib.h route. It will work fine I think. Thanks for all of your help. 

Re: [edk2] TFTP issue, Ping 1st packet reply missing

2015-09-28 Thread Paolo Bonzini
On 28/09/2015 12:24, Leekha Shaveta wrote: > Hi Laszlo, > > Please find the detailed "tcpdump" on my setup: You still aren't following Laszlo's instructions: "your dump is missing the DHCP packets that should be captured while the ifconfig program (launched from the UEFI shell) brings up the

Re: [edk2] TFTP issue, Ping 1st packet reply missing

2015-09-28 Thread Leekha Shaveta
Hi, I am not using DHCP I am setting IP statically using command: Shell> ifconfig -s eth0 static 192.168.3.154 255.255.252.0 192.168.3.1 InstallProtocolInterface: F4B427BB-BA21-4F16-BC4E-43E416AB619C DF5118B0 Shell> ping 192.168.3.221 InstallProtocolInterface:

Re: [edk2] TFTP issue, Ping 1st packet reply missing

2015-09-28 Thread Laszlo Ersek
On 09/28/15 12:24, Leekha Shaveta wrote: > Hi Laszlo, > > Please find the detailed "tcpdump" on my setup: > > test@boardfram-OptiPlex-790:/tftpboot$ sudo tcpdump -v -v -n -l -X -e -i eth0 > tcpdump: listening on eth0, link-type EN10MB (Ethernet), capture size 65535 > bytes > 21:39:42.028524

Re: [edk2] BUG: UEFI won't recognize PCI busses which don't sit under a bridge

2015-09-28 Thread Ni, Ruiyu
Shubha, PciBus only scan in a depth-first-search algorithm from the bus reported by PciHostBridgeResourceAllocation->StartBusEnumeration (RootBridgeHandle). Normally the bus reported out is 0, so all devices behind the bridges in BUS 0 are found and reported, so we can get the PciIo instances