[edk2] [PATCH] MdeModulePkg: PiSmmCore: Remove confusing CopyMem() of SMM_ENTRY_CONTEXT

2015-10-30 Thread Michael Kinney
A subset of fields in the EFI_SMM_SYSTEM_TABLE2 structure are identical to the fields in the SMM_ENTRY_CONTEXT structure. CopyMem() is used to transfer the contents of the SMM_ENTRY_CONTEXT structure into the EFI_SMM_SYSTEM_TABLE2. This is confusing because SMM_ENTRY_CONTEXT is not used in the de

[edk2] [PATCH] MdeModulePkg: PiSmmCore: Remove confusing CopyMem() of SMM_ENTRY_CONTEXT

2015-10-30 Thread Michael Kinney
A subset of fields in the EFI_SMM_SYSTEM_TABLE2 structure are identical to the fields in the SMM_ENTRY_CONTEXT structure. CopyMem() is used to transfer the contents of the SMM_ENTRY_CONTEXT structure into the EFI_SMM_SYSTEM_TABLE2. This is confusing because SMM_ENTRY_CONTEXT is not used in the de

[edk2] [PATCH v2] MdeModulePkg: Add DEBUG statement when reaching max perf log entries

2015-10-30 Thread Samer El-Haj-Mahmoud
Add a DEBUG statement when the number of PEI perf log entries exceeds PcdMaxPeiPerformanceLogEntries Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [edk2] [PATCH v2] MdeModulePkg: Add some common HTTP definitions

2015-10-30 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, October 30, 2015 4:08 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Samer El-Haj-Mahmoud mahm...@hp.com> > Subject: [edk2]

[edk2] [PATCH v2] MdeModulePkg: Add some common HTTP definitions

2015-10-30 Thread Samer El-Haj-Mahmoud
Add common HTTP definitions for use in HTTP clients/applications. List includes: HTTP methods, request/response headers, and encodings. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Include/Library/HttpLib.h | 43

[edk2] [PATCH] MdeModulePkg: Add DEBUG statement on reaching PEI perf log max entries

2015-10-30 Thread Samer El-Haj-Mahmoud
Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c index 0b5a717..fdc0ae0

Re: [edk2] [PATCH] Add common HTTP definitions for use in HTTP clients/applications. List includes: HTTP methods, request/response headers, and encodings.

2015-10-30 Thread Carsey, Jaben
Samer, The change looks good, but you need to add the "contributed" line and brief description for the patch. The commit tool is picky. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, October 30, 2015

Re: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues

2015-10-30 Thread Ni, Ruiyu
Sunny, You could move the two FreePool (FullInstance) to one place which is under the LocateDevicePath() call to make the change smaller a bit. What do you think? Thanks, Ray -Original Message- From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com] Sent: Friday, October 30, 2015 6:21 PM T

[edk2] [PATCH] Add common HTTP definitions for use in HTTP clients/applications. List includes: HTTP methods, request/response headers, and encodings.

2015-10-30 Thread Samer El-Haj-Mahmoud
Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Include/Library/HttpLib.h | 43 ++ 1 file changed, 43 insertions(+) diff --git a/MdeModulePkg/Include/Library/HttpLib.h b/MdeModulePkg/Include/Library/HttpLib.h index ce5a839..8d5412e 100644 --- a/MdeModulePkg/

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

2015-10-30 Thread Ni, Ruiyu
Sunny, I don't like to add a library interface as a short term fix. I will provide a patch next week to enable platform recovery (We are still working on OS recovery) so that you don't need PlatformBootManagerDefaultBootFail() interface. Thanks, Ray -Original Message- From: edk2-devel [

[edk2] [PATCH] UefiCpuPkg: PiSmmCpuDxeSmm: Remove Framework compatibility

2015-10-30 Thread Michael Kinney
The PiSmmCpuDxeSmm module is using PcdFrameworkCompatibilitySupport to provide compatibility with the SMM support in the IntelFrameworkPkg. This change removes the Framework compatibility and requires all SMM modules that provide SMI handlers to follow the PI Specification. Contributed-under: Tian

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

2015-10-30 Thread Leif Lindholm
Hi Ray, Many thanks for this. On Fri, Oct 30, 2015 at 04:53:54AM +, Ni, Ruiyu wrote: > Ok I will revert the two patches I committed (big patch + small > patch). But I want to clarify one thing that not every big patch can > be easily understood by just splitting to small patches. Certainly,

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-30 Thread Kinney, Michael D
Jiewen, Yes. That is a longer term goal for the PiSmmCpuDxeSmm. Making the GDTs consistent helps debug and is a fix that works until we can add logic to PiSmmCpuiDxeSmm to inherit current GDT information and use it throughout this module. Thanks, Mike >-Original Message- >From: Yao

Re: [edk2] [PATCH 1/2] MdeModulePkg/RegularExpressionDxe: Correct copyright

2015-10-30 Thread El-Haj-Mahmoud, Samer
Thanks for fixing this Cinnamon Series Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Shia, Cinnamon Sent: Thursday, October 29, 2015 11:39 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Shia, Cinnamon Subject: [PATCH 1/2] MdeModulePkg/RegularExpressionDxe: Co

Re: [edk2] about the SMM_S3_RESUME_SMM_64 branch in S3Resume2Pei

2015-10-30 Thread Yao, Jiewen
Yes, first, thanks the great analysis from Laszlo. Is that possible to eliminate the assumption by parsing current GDT entry? Instead of hardcode 0x38 or 0x28, if PiSmmCpu inherits GDT from other module, should it parse GDT to get correct long mode segment? I do not object the idea to change Dx

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-10-30 Thread Laszlo Ersek
On 10/30/15 14:04, Janusz Mocek wrote: > W dniu 30.10.2015 o 13:26, Laszlo Ersek pisze: >> CC'ing Xiao and Alex again. >> >> On 10/29/15 19:39, Jordan Justen wrote: >>> On 2015-10-29 04:45:37, Laszlo Ersek wrote: On 10/29/15 02:32, Jordan Justen wrote: > +ASSERT (MaxProcessors > 0); >>

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-10-30 Thread Janusz Mocek
W dniu 30.10.2015 o 13:26, Laszlo Ersek pisze: > CC'ing Xiao and Alex again. > > On 10/29/15 19:39, Jordan Justen wrote: >> On 2015-10-29 04:45:37, Laszlo Ersek wrote: >>> On 10/29/15 02:32, Jordan Justen wrote: +ASSERT (MaxProcessors > 0); +PcdSet32 (PcdCpuMaxLogicalProcessorNumb

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-10-30 Thread Laszlo Ersek
On 10/30/15 13:26, Laszlo Ersek wrote: >> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c >> index 3f56faa..e7f5b41 100644 >> --- a/UefiCpuPkg/CpuDxe/CpuMp.c >> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c >> @@ -1451,6 +1451,8 @@ ApEntryPointInC ( >>VOID* TopOfApStack; >>U

Re: [edk2] [PATCH 6/6] OvmfPkg/PlatformPei: Set PcdCpuMaxLogicalProcessorNumber using QEMU fw_cfg

2015-10-30 Thread Laszlo Ersek
CC'ing Xiao and Alex again. On 10/29/15 19:39, Jordan Justen wrote: > On 2015-10-29 04:45:37, Laszlo Ersek wrote: >> On 10/29/15 02:32, Jordan Justen wrote: >>> +ASSERT (MaxProcessors > 0); >>> +PcdSet32 (PcdCpuMaxLogicalProcessorNumber, MaxProcessors); >> >> I think that when this branch

[edk2] SecurityPkg: PeiRsa2048Sha256GuidedSectionExtractLib error handling

2015-10-30 Thread Cohen, Eugene
Dear SecurityPkg maintainer, I'm trying to track down the best way for platform policy to handle an authentication failure in the PEI Rsa2048Sha256 guided section extraction library and ran across this curious state near the end of Rsa2048Sha256GuidedSectionHandler. // // Temp solution unt

Re: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues

2015-10-30 Thread Wang, Sunny (HPS SW)
Hi Ray, Are you the owner of this module (UefiBootManagerLib)? If so, could you help to review and commit it? If not, could you tell me who is the owner? In addition, the attached patch would also need your help to get committed. Thanks! Regards, Sunny Wang -Original Messa

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

2015-10-30 Thread Wang, Sunny (HPS SW)
Hi Ray, Yes, I think OS/Platform recovery feature can meet our requirement. However, OS/Platform recovery feature has not yet been completely implemented, so we would like to have a short-term solution for this. Just like Samer said, if you are OK with introducing a new StatusCode in either BootA