Re: [edk2] [PATCH v2] ShellPkg: Add argument to set block size for tftp command.

Reviewed-by: Qiu Shumin -Original Message- From: Fu, Siyuan Sent: Friday, May 06, 2016 1:16 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben; Qiu, Shumin Subject: [PATCH v2] ShellPkg: Add argument to set block size for tftp command. V2 update: Define macros for

[edk2] [PATCH v2] ShellPkg: Add argument to set block size for tftp command.

V2 update: Define macros for the max and min block size value. TFTP block size has a big impact on the transmit performance, this patch is to add new argument [-s ] for shell "tftp" command to configure the block size for file download. Cc: Jaben Carsey Cc: Shumin Qiu

Re: [edk2] [Patch 0/2] 0001-NetworkPkg-Ignore-BootFileName-if-it-is-overloaded

Looks good to me. Series reviewed-by: Ye Ting Thanks, Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Tuesday, May 03, 2016 1:36 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2]

Re: [edk2] [Patch] NetworkPkg: Fix a memory leak in HTTP boot driver.

Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Thursday, May 05, 2016 10:16 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: [Patch] NetworkPkg: Fix a memory leak in HTTP boot driver. We

Re: [edk2] BaseTools question about FDF FILE syntax

> On May 5, 2016, at 7:24 PM, Gao, Liming wrote: > > Andrew: > NAME GUID is module INF file GUID. It is used in Rule section in FDF file > like below. This is your usage case? > > [Rule.Common.DXE_CORE] > FILE DXE_CORE = $(NAMED_GUID) { >COMPRESS PI_STD { >

Re: [edk2] BaseTools question about FDF FILE syntax

Andrew: NAME GUID is module INF file GUID. It is used in Rule section in FDF file like below. This is your usage case? [Rule.Common.DXE_CORE] FILE DXE_CORE = $(NAMED_GUID) { COMPRESS PI_STD { PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi UI STRING="$(MODULE_NAME)"

[edk2] [Patch] ShellPkg: Add argument to set block size for tftp command.

TFTP block size has a big impact on the transmit performance, this patch is to add new argument [-s ] for shell "tftp" command to configure the block size for file download. Cc: Jaben Carsey Cc: Shumin Qiu Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Tim, I agree multiple repos in a WORKSPACE can potentially be confusing. Especially if the same package dir exists in more than of the repos. To alleviate this issue, a repo can be pruned and the .gitignore feature can be used for git to ignore the packages that have been pruned. The

Re: [edk2] [Patch] NetworkPkg: Fix a memory leak in HTTP boot driver.

Looks good to me. Thanks for addressing my comemnt. (Sorry for late to review this. I was not aware of that you send the other review for my comment) Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu

[edk2] BaseTools question about FDF FILE syntax

I was trying to use a GUID CNAME with the FILE command and I got a failure. Looking at the specification it defines the GUID as the well known macro $(NAMED_GUID) . I'm not sure what the definition of $(NAMED_GUID) is when there is no INF file involved? The spec defines the FILE, and SECTION

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Mike -- At this time, no. Our internal tools do not recognize it, and would fail during tree analysis. Likewise, our policy does not allow it because we find our customers are confused by multiple roots. It makes it hard for the engineers looking at a downstream file to predict where the

Re: [edk2] [review]Please review changes to UNI file format document

Reviewed-by: Qiu Shumin From: Carsey, Jaben Sent: Saturday, April 30, 2016 1:53 AM To: edk2-devel@lists.01.org; Bjorge, Erik C; Qiu, Shumin Cc: Carsey, Jaben Subject: [review]Please review changes to UNI file format document Updated UNI spec to remove info specific to some

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Hi Tim, I wanted to follow up on the general concern on the use of the PACKAGES_PATH feature. The EDK II BaseTools still use a single WORKSPACE and can use PACKAGES_PATH for additional search paths for packages. PACKAGES_PATH can point to directories Below WORKSPACE or outside WORKSPACE, so it

Re: [edk2] [Patch] NetworkPkg: Fix a memory leak in HTTP boot driver.

The patch is good to me. Reviewed-By: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Thursday, May 5, 2016 10:16 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [Patch] NetworkPkg: Fix a

[edk2] [PATCH v2 0/3] Marvell Yukon driver

The UEFI driver for Marvell Yukon chipset On the Juno platform, this driver requires another platform-specific patch initializing the Marvell network adapter with correct MAC address. Without the patch, the PcdYukonMacAddressvariable has to be set. Changes since v1: Added declaration of

[edk2] [PATCH v2 1/3] OpenPlatformPkg/MarvellYukonDxe : Marvell Yukon driver 1/3

The UEFI driver for Marvell Yukon chipset, part 1 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- Platforms/ARM/Juno/ArmJuno.dsc | 4 Platforms/ARM/Juno/ArmJuno.fdf | 1 + 2 files changed, 5 insertions(+) diff --git

[edk2] [PATCH 12/13] ArmVirtPkg/ArmVirtQemu: use MdeModulePkg/BDS

Based on OvmfPkg commit 79c098b6d25d. Unlike in OVMF, no USE_OLD_BDS fallback is introduced; I think that ArmVirtPkg is less widely used by non-developers than OvmfPkg. ArmVirtXen is not modified, as it uses PlatformIntelBdsLib from ArmPlatformPkg. About this patch: - DxeServicesLib and

[edk2] [PATCH 11/13] ArmVirtPkg/PlatformBootManagerLib: add EnableQuietBoot & DisableQuietBoot

UefiBootManagerLib does not provide these functions, we have to implement them. (EnableQuietBoot() puts up the nice TianoCore logo.) OvmfPkg commits 817fb3ac2a78 and 8e8fd3037788 have extracted these functions already, - from "IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c" - to

[edk2] [PATCH 13/13] ArmVirtPkg: retire PlatformIntelBdsLib

This library instance is no longer referenced. Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 10/13] ArmVirtPkg/PlatformBootManagerLib: rebase boot order manipulation

QemuBootOrderLib can only filter out and reorder boot options; it cannot create boot options. It relies on Platform BDS to auto-generate all possible boot options first (for example, for new virtual devices that have been configured since the last run of the virtual machine). Then it will decide,

[edk2] [PATCH 09/13] ArmVirtPkg/PlatformBootManagerLib: use UefiBootManagerLib ConnectAll() API

This patch parallels OvmfPkg commit fed691a6f913. Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c |

[edk2] [PATCH 04/13] ArmVirtPkg/PlatformBootManagerLib: link against UefiBootManagerLib

The general BDS helper functions are now provided by MdeModulePkg's UefiBootManagerLib, and no longer by IntelFrameworkModulePkg's GenericBdsLib. This patch parallels OvmfPkg commit 2b23b8d45b62. Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under:

[edk2] [PATCH 06/13] ArmVirtPkg/PlatformBootManagerLib: don't launch the Boot Manager Menu

MdeModulePkg/BDS doesn't launch the UI (Boot Manager Menu) from the platform side. The platform is expected to store the boot timeout only, in PcdPlatformBootTimeOut. This is usually done in PlatformBootManagerBeforeConsole(). (ArmVirtXen is not modified, as it uses PlatformIntelBdsLib from

[edk2] [PATCH 01/13] ArmVirtPkg: duplicate PlatformIntelBdsLib to PlatformBootManagerLib

Create a copy of PlatformIntelBdsLib under the name PlatformBootManagerLib, with the following initial changes: - replace PlatformBdsLib references with PlatformBootManagerLib in comments, - replace "IntelBdsPlatform" with "PlatformBm" in file names and their references, - generate a new

[edk2] [PATCH 03/13] ArmVirtPkg/PlatformBootManagerLib: use EfiBootManagerUpdateConsoleVariable

In this rather mechanical patch, we replace the calls to GenericBdsLib's BdsLibUpdateConsoleVariable() with calls to UefiBootManagerLib's EfiBootManagerUpdateConsoleVariable(), which has the same purpose. The latter uses CONSOLE_TYPE enum constants from

[edk2] [PATCH 02/13] ArmVirtPkg/PlatformBootManagerLib: follow PlatformBootManagerLib interfaces

"IntelFrameworkModulePkg/Include/Library/PlatformBdsLib.h" declares the following interfaces: - PlatformBdsInit - PlatformBdsPolicyBehavior - PlatformBdsBootFail - PlatformBdsBootSuccess - PlatformBdsLockNonUpdatableFlash - LockKeyboards >From these, we've been using PlatformBdsInit() and

[edk2] [PATCH 00/13] ArmVirtPkg: move to MdeModulePkg BDS

Based on Ray's recent patches for OvmfPkg, and what I learned from them. Fixes: . Public branch: . I'm CC'ing Ray on the entire series -- I'm not asking for a in-depth code validation

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

That works well, thank you Tim Sent from my Windows 10 phone From: Mudusuru, Giri P Sent: Thursday, May 5, 2016 12:07 PM To: Tim Lewis; Yao, Jiewen;

Re: [edk2] [PATCH] ShellPkg: Remove debug message in release binaries.

Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Wednesday, May 04, 2016 11:05 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > > Subject: [PATCH] ShellPkg: Remove debug

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

On Thu, May 05, 2016 at 08:03:05AM +, Ni, Ruiyu wrote: > Gary, > Can you kindly teach me how to run OVMF under Xen? > > I worked out a draft fix and need to verify whether > everything is fine. > Hi Ray, 1. Install the Xen host. I use openSUSE Leap 42.1 as the host system and it's

Re: [edk2] [Patch 0/2] Do not use hard coded TTL/ToS in PXE driver.

Looks good to me. Series reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Tuesday, May 03, 2016 10:26 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2] Do not use hard coded TTL/ToS

Re: [edk2] [PATCH v2] MdeModulePkg: Refine SNP driver's media status check logic.

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Wednesday, May 04, 2016 4:48 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject:

Re: [edk2] [PATCH] NetworkPkg: Discard TCP segment when no TCB found

On Thu, May 05, 2016 at 07:42:33AM +, Fu, Siyuan wrote: > Hi, Michael > > So you want to have 2 network stack above the MNP protocol, the grub2 native > stack and the edk2 stack, right? Yes, that's the idea basically. > Then do you need the 2 network stack work simultaneously? Not really

Re: [edk2] [PATCH v2] MdeModulePkg: Refine SNP driver's media status check logic.

Reviewed-By: Wu Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, May 4, 2016 4:48 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [PATCH v2] MdeModulePkg: Refine SNP driver's media

Re: [edk2] [patch 0/2] MdeModulePkg/SetupBrowser: Fix two issues in submit form/formset

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 27, 2016 9:25 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch 0/2] MdeModulePkg/SetupBrowser: Fix

Re: [edk2] [patch] MdeModulePkg/FileExplore: Make LibraryClass & Depex module type consistent

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, May 05, 2016 11:04 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch] MdeModulePkg/FileExplore: Make

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

On 05/05/16 10:08, Laszlo Ersek wrote: > On 05/05/16 07:08, Ni, Ruiyu wrote: >>> -Original Message- >>> From: Daniil Egranov [mailto:daniil.egra...@arm.com] >>> Sent: Thursday, May 5, 2016 7:57 AM >>> To: Ni, Ruiyu ; edk2-devel@lists.01.org >>> Cc: Fan, Jeff

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

On 05/05/16 07:08, Ni, Ruiyu wrote: > > > Regards, > Ray > >> -Original Message- >> From: Daniil Egranov [mailto:daniil.egra...@arm.com] >> Sent: Thursday, May 5, 2016 7:57 AM >> To: Ni, Ruiyu ; edk2-devel@lists.01.org >> Cc: Fan, Jeff >>

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

Gary, Can you kindly teach me how to run OVMF under Xen? I worked out a draft fix and need to verify whether everything is fine. Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, April 28, 2016 6:36 PM >To: Ni, Ruiyu ;

Re: [edk2] [PATCH] NetworkPkg: Discard TCP segment when no TCB found

Hi, Michael So you want to have 2 network stack above the MNP protocol, the grub2 native stack and the edk2 stack, right? Then do you need the 2 network stack work simultaneously? If your requirement is the two network stack above MNP need to work at same time, for example one stack is

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

On 05/05/16 09:07, Tian, Feng wrote: > Laszlo, > > Thanks for your details. It looks make sense. > > Reviewed-by: Feng Tian Many thanks! Commit ce1647fc608e. Cheers! Laszlo > > Thanks > Feng > > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

Laszlo, Thanks for your details. It looks make sense. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, May 5, 2016 12:47 AM To: Tian, Feng

Re: [edk2] [PATCH v1 1/1] NetworkPkg:HttpDxe: Code changes to support HTTP PUT/POST operations

Hi, Nagaraj For below code change +if (!NetMapIsEmpty (>TxTokens)) { + NetMapRemoveHead (>TxTokens, (VOID**) ); + if (ValueInItem == NULL) { +goto Error; + } The original code treat an empty HttpInstance->TxTokens net map as an error, because there should be always a

[edk2] [PATCH v2 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

v2: More input validation based on Request and HeaderCount. HttpGenRequestMessage assumes that HTTP message would always contain a request-line, headers and an optional message body. However, subsequent to a HTTP PUT/POST request, HTTP requests would contain just the message body. This patch

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

If you only need to support SATA/IDE Hard Drive, then you don't need ScsiBus/ScsiDisk. If you want to support SATA/IDE CDROM, you need add them in. If a HDD has been managed by EDKII ATA stack, a device path to it would be created. So one way to check is to see if such device path has existed.

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

Nagaraj, The check is correct but incomplete, the Request and HeaderCount should both zero or both not zero. Best Regards, Siyuan From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, Nagaraj P Sent: Thursday, May 5, 2016 2:13 PM To: Fu, Siyuan ;

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

As Jiaxin pointed out in his reply, if ((Message->Data.Request != NULL && Url == NULL) || (Message->Data.Request != NULL && Message->HeaderCount == 0)) { return EFI_INVALID_PARAMETER; } looks to be a meaningful check to be in place. I will send a v2 patch. Regards, Nagaraj. From: Fu,

[edk2] [PATCH] ShellPkg: Remove debug message in release binaries.

Use BaseDebugLibNull instance instead of UefiDebugLibConOut to remove the debug message in release Shell binaries. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/ShellPkg.dsc | 4

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

Thanks for the response! So to access a SATA HDD, to send any command to SATA HDD or to probe SATA devices, we need this complete stack in place? And is there any existing command (any shell command that scans/discover SATA devices) in EDK2 to check whether HDD is scanned in the system?