[edk2] [PATCH 0/3] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

The patch series will add two APIs in BaseMemoryLib: 1. IsZeroBuffer() The API is used to check if the contents of a buffer are all zeros. 2. IsZeroGuid() The API is used to check if the given GUID is a zero GUID. In order to resolve build issues in SecurityPkg, the series will also remove the

[edk2] [PATCH 2/3] MdePkg BaseMemoryLib: Add implementation of API IsZeroBuffer()

Cc: Michael D Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Include/Library/BaseMemoryLib.h | 23

[edk2] [PATCH 3/3] SecurityPkg Tcg2: Remove internal implementation of IsZeroBuffer()

This commit removes the internal implementation of the function IsZeroBuffer(). Instead, it will use the one from BaseMemoryLib. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH 1/3] MdePkg BaseMemoryLib: Add implementation of API IsZeroGuid()

Cc: Michael D Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Include/Library/BaseMemoryLib.h | 20

Re: [edk2] [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code

Ard, Pls go ahead to add R_X86_64_PLT32 firstly. Below is my original path. And for the GOTPCREL type ones, I could finish enhance them after I back from vacation next week. Thanks. https://github.com/shijunjing/edk2/commit/dd8b1c4625cbffc7e149571266e0ae0581bd207d Steven Shi

[edk2] [PATCH] PcdBdsLinuxSupport default value

The built-in Linux Loader is obsolete and not included in most builds. The patch sets the PcdBdsLinuxSupport default value to FALSE and prevents ArmBds from looking for built-in Linux Loader by default and ASSERTing when it cannot be found. Platforms which still using built-in loader have to set

Re: [edk2] [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code

On 08/03/2016 01:47 PM, Ard Biesheuvel wrote: > >> On 3 aug. 2016, at 22:13, Jordan Justen wrote: >> >> Where does this patch stand? I think Ard was asking for it to be >> split, but also wondering if it was really required... >> >> Some devs are still reporting

Re: [edk2] [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code

> On 3 aug. 2016, at 22:53, Jordan Justen wrote: > >> On 2016-08-03 13:47:09, Ard Biesheuvel wrote: >> >>> On 3 aug. 2016, at 22:13, Jordan Justen wrote: >>> >>> Where does this patch stand? I think Ard was asking for it to be >>> split,

Re: [edk2] [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code

On 2016-08-03 13:47:09, Ard Biesheuvel wrote: > > > On 3 aug. 2016, at 22:13, Jordan Justen wrote: > > > > Where does this patch stand? I think Ard was asking for it to be > > split, but also wondering if it was really required... > > > > Some devs are still

Re: [edk2] [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code

> On 3 aug. 2016, at 22:13, Jordan Justen wrote: > > Where does this patch stand? I think Ard was asking for it to be > split, but also wondering if it was really required... > > Some devs are still reporting unsupported relocation errors during the > build.

Re: [edk2] [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code

Where does this patch stand? I think Ard was asking for it to be split, but also wondering if it was really required... Some devs are still reporting unsupported relocation errors during the build. (mischief on irc, for example.) -Jordan On 2016-08-02 05:00:43, Ard Biesheuvel wrote: > On 2

Re: [edk2] Shell Path Issues with "../.."

Thanks - I searched for the subject on my edk2-devel archive and didn't see anything. I now see the patch sent 6/21, so yeah about 3 months later. :) Next time I ask that the maintainer respond to the original email please (granted I screwed up because I forgot to include them specifically on

Re: [edk2] Shell Path Issues with "../.."

Hi Eugene, I think it has been fixed on master already. See the commit below: commit 85df61243cb56c3d9c52a5005e65c4ea8bf60e52 Author: Qiu Shumin Date: Tue Jun 21 16:18:56 2016 +0800 MdePkg: Fix 'cd ..\..' go up only 1 level. When we try to cd up two levels

Re: [edk2] Shell Path Issues with "../.."

Reminder (a few months later) > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > Of Cohen, Eugene > Sent: Wednesday, March 30, 2016 4:51 PM > To: edk2-devel@lists.01.org > Cc: Thompson, Mark L. (Boise IPG) > Subject:

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

On 3 August 2016 at 15:20, Gao, Liming wrote: > Ard: > > Thanks for your detail explain. I understand it. I add my rb for this > patch set. > > > > Reviewed-by: Liming Gao > Pushed as 108c5b601860 BaseTools GCC: move -c compiler flag to build rules

Re: [edk2] [PATCH 0/2] ArmVirtPkg EmbeddedPkg: fix build for CLANG35/ARM

On 3 August 2016 at 10:21, Ard Biesheuvel wrote: > Currently, the ArmVirtQemuKernel and ArmVirtXen platforms will not build > for ARM when using CLANG35, due to the fact that the compiler emits > MOVT/MOVW pairs into objects that are used by the relocatable PrePi, and >

Re: [edk2] [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

On Wed, Aug 03, 2016 at 02:50:59PM +0200, Ard Biesheuvel wrote: > On 3 August 2016 at 13:21, Laszlo Ersek wrote: > > On 08/03/16 12:00, Ard Biesheuvel wrote: > >> On 3 August 2016 at 11:56, Laszlo Ersek wrote: > >>> On 08/03/16 10:21, Ard Biesheuvel wrote: >

Re: [edk2] [PATCH 2/2] ArmVirtPkg ARM: make relocatable PrePi users build with CLANG35

On 3 August 2016 at 13:19, Laszlo Ersek wrote: > On 08/03/16 12:02, Ard Biesheuvel wrote: >> On 3 August 2016 at 12:00, Laszlo Ersek wrote: >>> On 08/03/16 10:21, Ard Biesheuvel wrote: The clang developers have made a backward incompatible change to the

Re: [edk2] [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

On 3 August 2016 at 13:21, Laszlo Ersek wrote: > On 08/03/16 12:00, Ard Biesheuvel wrote: >> On 3 August 2016 at 11:56, Laszlo Ersek wrote: >>> On 08/03/16 10:21, Ard Biesheuvel wrote: This library is only used by the various PrePi implementations, all

Re: [edk2] [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

On 08/03/16 12:00, Ard Biesheuvel wrote: > On 3 August 2016 at 11:56, Laszlo Ersek wrote: >> On 08/03/16 10:21, Ard Biesheuvel wrote: >>> This library is only used by the various PrePi implementations, all of >>> which are of type SEC. >> >> You can actually enforce that client

Re: [edk2] [PATCH 2/2] ArmVirtPkg ARM: make relocatable PrePi users build with CLANG35

On 08/03/16 12:02, Ard Biesheuvel wrote: > On 3 August 2016 at 12:00, Laszlo Ersek wrote: >> On 08/03/16 10:21, Ard Biesheuvel wrote: >>> The clang developers have made a backward incompatible change to the >>> command line arguments, and have replaced '-mllvm -arm-use-movt=0'

Re: [edk2] [PATCH 2/2] ArmVirtPkg ARM: make relocatable PrePi users build with CLANG35

On 3 August 2016 at 12:00, Laszlo Ersek wrote: > On 08/03/16 10:21, Ard Biesheuvel wrote: >> The clang developers have made a backward incompatible change to the >> command line arguments, and have replaced '-mllvm -arm-use-movt=0' >> with '-mno-movt'. This does not matter for

Re: [edk2] [PATCH 2/2] ArmVirtPkg ARM: make relocatable PrePi users build with CLANG35

On 08/03/16 10:21, Ard Biesheuvel wrote: > The clang developers have made a backward incompatible change to the > command line arguments, and have replaced '-mllvm -arm-use-movt=0' > with '-mno-movt'. This does not matter for most ARM platforms, and > therefore it has been removed from the default

Re: [edk2] [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

On 3 August 2016 at 11:56, Laszlo Ersek wrote: > On 08/03/16 10:21, Ard Biesheuvel wrote: >> This library is only used by the various PrePi implementations, all of >> which are of type SEC. > > You can actually enforce that client module type restriction, by setting > >

Re: [edk2] [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

On 08/03/16 10:21, Ard Biesheuvel wrote: > This library is only used by the various PrePi implementations, all of > which are of type SEC. You can actually enforce that client module type restriction, by setting LIBRARY_CLASS = MemoryAllocationLib|SEC Can you try that, in

[edk2] [Patch] BaseTools: Fix the bug when use FILE_GUID override the module in DSC

In last commit 2502b73, it doesn't cover the case that in the DSC file use FILE_GUID to override the module. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] [PATCH v5 1/4] BaseTools-Conf:Remove short dash in ar flag for LLVM

Both binutils ar and LLVM ar support "cr", but LLVM ar doens't support add "-" in the flags, and llvm-ar cannot accept "-cr". So remove the short dash "-" to make llvm archives work. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Steven Shi

[edk2] [PATCH v5 4/4] ShellPkg-UefiShellCommandLib: Add EFIAPI in VA_List library function

Add EFIAPI in CatPrint library function. Every function which uses variable list need explicit use EFIAPI to force use MS ABI. This change is needed to pass CLANG38 build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Steven Shi ---

[edk2] [PATCH v5 0/4] Introduce CLANG38 toolchain in edk2

Please review my new commits in public branch: https://github.com/shijunjing/edk2/commits/llvm_v5 The difference from V4(https://github.com/shijunjing/edk2/commits/llvm_v4): 1. Remove the GCC5 path prefix for binutils objcopy, because a clang user may not set GCC5_BIN. 2. Follow GCC5 to disable

[edk2] [PATCH v5 2/4] BaseTools-Conf:Introduce CLANG38 new toolchain for x86

This adds support for LLVM 3.8.x in LTO mode for IA32 and X64. CLANG38 enable LLVM Link Time Optimization (LTO) and code size optimization flag (-Oz) by default for aggressive code size improvement. CLANG38 X64 code is small code model + PIE. CLANG LTO needs PIE in link flags to generate PIE code

[edk2] [PATCH v5 3/4] ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin

Use explicit CopyMem to replace compiler builtin to do the structure values assignment. This change is needed to pass CLANG38 build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Steven Shi Reviewed-by: Jaben Carsey ---

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

On 3 August 2016 at 10:58, Gao, Liming wrote: > Ard: > I see Steven says it doesn't work, yet. So, I am curious what real issue is > resolved by this patch? > For example, when building ArmVirtQemu for ARM, you may get warnings (or errors when -Werror is enabled) like

Re: [edk2] [PATCH 0/3] BaseTools GCC: pass CC flags to linker

On 2 August 2016 at 16:51, Ard Biesheuvel wrote: > On 2 August 2016 at 16:50, Gao, Liming wrote: >> Ard: >> Without this change, GCC5 LTO can pass build. With it, what difference >> will be in the generated image? Original way may generate the

Re: [edk2] [PATCH 2/4] BaseTools-Conf:Introduce CLANG38 new toolchain for x86

Hello Ard, > > Hello Steven, > > On 3 August 2016 at 08:48, Shi, Steven wrote: > > This adds support for LLVM 3.8.x in LTO mode for IA32 and X64. > > CLANG38 enable LLVM Link Time Optimization (LTO) and code size > > optimization flag (-Oz) by default for aggressive code

[edk2] [PATCH 2/2] ArmVirtPkg ARM: make relocatable PrePi users build with CLANG35

The clang developers have made a backward incompatible change to the command line arguments, and have replaced '-mllvm -arm-use-movt=0' with '-mno-movt'. This does not matter for most ARM platforms, and therefore it has been removed from the default CLANG35/ARM CC flags in patch 1c63516075b3

[edk2] [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library

This library is only used by the various PrePi implementations, all of which are of type SEC. So make this library SEC as well. This may affect the build options used by the platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 0/2] ArmVirtPkg EmbeddedPkg: fix build for CLANG35/ARM

Currently, the ArmVirtQemuKernel and ArmVirtXen platforms will not build for ARM when using CLANG35, due to the fact that the compiler emits MOVT/MOVW pairs into objects that are used by the relocatable PrePi, and such instruction pairs are not runtime relocatable in ELF (i.e., there are no

[edk2] [edk2-platforms/branch]: pentium-celeron-n-udk2015

Restructured BraswellPlatformPkg on pentium-celeron-n-udk2015 branch of edk2-platforms to follow Cover Creek requirement. URL fork of edk2-platforms with the restructured code for review: https://github.com/mangguo321/edk2-platforms/tree/Braswell

[edk2] [Patch][Vlv2TbltDevicePkg] Enable Spread Spectrum of on-chip devices

>From bf33c2b16e718f9b241889d2f3e863719731f340 Mon Sep 17 00:00:00 2001 From: david wei Date: Wed, 3 Aug 2016 16:02:34 +0800 Subject: [PATCH] Enable Spread Spectrum of on-chip devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei

Re: [edk2] [PATCH 2/4] BaseTools-Conf:Introduce CLANG38 new toolchain for x86

Hello Steven, On 3 August 2016 at 08:48, Shi, Steven wrote: > This adds support for LLVM 3.8.x in LTO mode for IA32 and X64. > CLANG38 enable LLVM Link Time Optimization (LTO) and code size > optimization flag (-Oz) by default for aggressive code size > improvement. CLANG38

Re: [edk2] [PATCH 1/4] BaseTools-Conf:Remove short dash in ar flag for LLVM

On 3 August 2016 at 08:48, Shi, Steven wrote: > Both binutils ar and LLVM ar support "cr", but LLVM ar doens't > support add "-" in the flags, and llvm-ar cannot accept "-cr". > So remove the short dash "-" to make llvm archives work. > > Contributed-under: TianoCore

[edk2] [PATCH 2/4] BaseTools-Conf:Introduce CLANG38 new toolchain for x86

This adds support for LLVM 3.8.x in LTO mode for IA32 and X64. CLANG38 enable LLVM Link Time Optimization (LTO) and code size optimization flag (-Oz) by default for aggressive code size improvement. CLANG38 X64 code is small code model + PIE. CLANG LTO needs PIE in link flags to generate PIE code

[edk2] [PATCH 0/4] Introduce CLANG38 toolchain in edk2

Please review my new commits in public branch: https://github.com/shijunjing/edk2/commits/llvm_v4 The difference from last V2(https://github.com/shijunjing/edk2/commits/llvm_v2): 1. Seperate the CLANG38 from the other two toolchains (GCC5, CLANGSCAN38), and only focus on CLANG38 in this serial.

[edk2] [PATCH 1/4] BaseTools-Conf:Remove short dash in ar flag for LLVM

Both binutils ar and LLVM ar support "cr", but LLVM ar doens't support add "-" in the flags, and llvm-ar cannot accept "-cr". So remove the short dash "-" to make llvm archives work. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Steven Shi ---

[edk2] [PATCH 4/4] ShellPkg-UefiShellCommandLib: Add EFIAPI in VA_List library function

Add EFIAPI in CatPrint library function. Every function which uses variable list need explicit use EFIAPI to force use MS ABI. This change is needed to pass CLANG38 build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Steven Shi ---

[edk2] [PATCH 3/4] ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin

Use explicit CopyMem to replace compiler builtin to do the structure values assignment. This change is needed to pass CLANG38 build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Steven Shi Reviewed-by: Jaben Carsey ---