[edk2] [Patch V3] BaseTools: support the NOOPT target with the GCC tool chains

Update the tools_def.template to add NOOPT support with GCC tool chains. Also disable -flto and -Os in NOOPT target for GCC5. Cc: Liming Gao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [patch] OptionRomPkg: Fix GCC build failure

Reviewed-by: Ruiyu Ni Pushed as ea79dc2b77d8438f840e85b44a43760337637a6a. > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 22, 2016 10:51 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [patch] OptionRomPkg: Fix GCC

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Add the missing EFIAPI for the function

The function with the variable parameters should have EFIAPI. Cc: Feng Tian Cc: Cinnamon Shia Cc: Cecil Sheng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

Re: [edk2] [PATCH V2 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD.

All serials Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Yao, Jiewen > Sent: Sunday, October 9, 2016 9:28 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star ; > Gao, Liming ;

Re: [edk2] RFC: ProtocolLib for cross DXE and SMM Protocol and Handle Services

Eugene: Could this library cover PEI PPI? LocatePpi and LocateProtocol both return VOID**. And, I think this library class will include Install, Notify and Locate APIs. Right? typedef EFI_STATUS (EFIAPI *EFI_PEI_LOCATE_PPI)( IN CONST EFI_PEI_SERVICES**PeiServices, IN CONST

Re: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD.

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Sunday, October 9, 2016 9:28 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD.

[edk2] [PATCH V2 2/3] MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD.

This PCD is used to indicated the recovery file name. The previous name - FvMain.Fv is hardcoded in CdExpressPei. It does not make sense to force the name. Now a platform may use any recovery file name. Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao

[edk2] [PATCH V2 3/3] FatPkg/FatPei: Use PcdRecoveryFileName PCD.

This PCD is used to indicated the recovery file name. The previous name - FvMain.Fv is hardcoded in FatPei. It does not make sense to force the name. Now a platform may use any recovery file name. Cc: Ruiyu Ni Cc: Feng Tian Cc: Star Zeng

[edk2] [PATCH V2 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD.

This PCD is used to indicated the recovery file name. The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei. It does not make sense to force the name. Now a platform may use any recovery file name. Cc: Feng Tian Cc: Star Zeng Cc: Liming

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Follow the suggestion, the V3 patch has been just sent out, please help review that. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Sunday, October 9, 2016 3:49 AM To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D

[edk2] [PATCH V3] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

From: "Zeng, Star" Clear bits [31:24] after reading ACPI timer count by IoRead32(), and also add comments "Note: The implementation uses the lower 24-bits of the ACPI timer and is compatible with both 24-bit and 32-bit ACPI timers." in INF. Cc: Michael Kinney

Re: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD.

Yes, I agree. Thanks to catch that. Thank you Yao Jiewen From: Kinney, Michael D Sent: Sunday, October 9, 2016 8:54 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Ni, Ruiyu ; Tian, Feng

Re: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD.

Jiewen, This new PCD is restricted to only support PatchableInMoule. I think it should be moved to support all types and be in section: [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] Thanks, Mike > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Star, Minor change: "Note: The implementation uses the lower 24-bits of the ACPI timer and is compatible with both 24-bit and 32-bit ACPI timers." Mike > -Original Message- > From: Zeng, Star > Sent: Friday, October 7, 2016 11:40 PM > To: Kinney, Michael D

Re: [edk2] TE relocations

If TE is loaded such that TE header is placed in memory at THE SAME ImageBase address as the original PE would have been, its mapped original PE ImageBase will be adjusted to the begin of the TE image + sizeof (EFI_TE_IMAGE_HEADER) - StrippedSize. Then, its mapped PE image will be relocated

Re: [edk2] [Patch V2] BaseTools: support the NOOPT target with the GCC tool chains

I agree to disable LTO and Os in NOOPT target. ARM tool chain setting has disabled them in GCC5. We can refer to ARM setting, then update GCC5 IA32 and X86 arch. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel

Re: [edk2] [PATCH V2] PcAtChipsetPkg AcpiTimerLib: Clear bits [31:24] after reading by IoRead32()

Mike, Just get your point, that means the [31:24] will be always ignored regardless of the ACPI timer is 24Bits or 32Bits. How about updating the comments like below? "Note: The implementation only uses the lower 24-bits of the ACPI timer and can be compatible with both 24-bits and 32-bits