Re: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Wednesday, December 7, 2016 11:41 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Zhang, Lubo ; Fu,

Re: [edk2] [patch] MdeModulePkg: Fix assert in iSCSI.

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, December 1, 2016 2:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu,

Re: [edk2] [Patch] Vlv2TbltDevicePkg/PlatformInitPei: Better SMRAM size alignment

Reviewed-by: jiewen@intel.com > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, December 6, 2016 1:46 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Wei, David ; > Guo, Mang > Subject: [Patch]

Re: [edk2] [patch] MdeModulePkg: Fix assert in iSCSI.

Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, December 1, 2016 2:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu,

[edk2] Is the current TPL ASSERT in the LoadImage() correct?

Does anyone know why CoreLoadImageCommon() will ASSERT on TPL < TPL_NOTIFY, when the UEFI Spec calls out < TPL_CALLBACK? https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Image/Image.c#L1066

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: MemoryAttributeTable need keep non-PE record.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Thursday, December 01, 2016 4:23 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Kinney, Michael D; Laszlo Ersek Subject: [PATCH] MdeModulePkg/PiSmmCore: MemoryAttributeTable need keep non-PE record.

[edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus

Since the type of ShellStatus is SHELL_STATUS, we should use SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin Cc: Zhang Lubo Cc: Ye Ting Cc: Fu

Re: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus

Reviewed-by: Zhang Lubo -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, December 07, 2016 11:41 AM To: edk2-devel@lists.01.org Cc: Zhang, Lubo ; Ye, Ting ; Fu, Siyuan ; Wu,

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: use EfiPagesToSize to prevent build error.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Thursday, December 01, 2016 4:23 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Kinney, Michael D; Laszlo Ersek Subject: [PATCH] MdeModulePkg/PiSmmCore: use EfiPagesToSize to prevent build error.

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore; Use DEBUG_WARN for non 4k aligned image.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Thursday, December 01, 2016 4:23 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Kinney, Michael D; Laszlo Ersek Subject: [PATCH] MdeModulePkg/PiSmmCore; Use DEBUG_WARN for non 4k aligned image. Cc:

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType.

/** + Convert a UEFI memory type to SMM pool type. + + @param[in] PoolType Type of pool to allocate. [Jeff] Typo. *PoolType* should be *MemoryType*. Reviewed-by: Jeff Fan with this typo fix. -Original Message- From: Yao, Jiewen Sent: Thursday,

Re: [edk2] [PATCH V2] UefiCpuPkg/PiSmmCpu: Fixed #double fault on #page fault.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Thursday, December 01, 2016 8:04 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek; Fan, Jeff; Kinney, Michael D Subject: [PATCH V2] UefiCpuPkg/PiSmmCpu: Fixed #double fault on #page fault. This patch

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Initialize gConnectConInEvent earlier

Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ruiyu > Sent: Monday, December 05, 2016 9:57 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zhang, Chao B > Subject: [PATCH] MdeModulePkg/BdsDxe: Initialize gConnectConInEvent earlier > >

Re: [edk2] [PATCH v2 0/2] Fix runtime issue in XenBusDxe when compiled with GCC 6.2

On 12/06/16 13:03, Anthony PERARD wrote: > > > Anthony PERARD (2): > OvmfPkg/XenHypercallLib: Add EFIAPI > OvmfPkg/build.sh: Use GCC49 toolchains with GCC 6.[0-2] > > OvmfPkg/Include/Library/XenHypercallLib.h | 3 +++ > OvmfPkg/Library/XenHypercallLib/XenHypercall.c | 3 +++ >

[edk2] [PATCH v2 2/2] OvmfPkg/build.sh: Use GCC49 toolchains with GCC 6.[0-2]

The goal of the patch is to avoid using -flto with GCC 6.0 to 6.2. This is to workaround a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70955 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/build.sh | 2 +- 1

[edk2] [PATCH v2 1/2] OvmfPkg/XenHypercallLib: Add EFIAPI

Because EFIAPI is necessary for functions declared in library class header files. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/Include/Library/XenHypercallLib.h | 3 +++

[edk2] [PATCH v2 0/2] Fix runtime issue in XenBusDxe when compiled with GCC 6.2

Anthony PERARD (2): OvmfPkg/XenHypercallLib: Add EFIAPI OvmfPkg/build.sh: Use GCC49 toolchains with GCC 6.[0-2] OvmfPkg/Include/Library/XenHypercallLib.h | 3 +++ OvmfPkg/Library/XenHypercallLib/XenHypercall.c | 3 +++ OvmfPkg/build.sh | 2 +- 3 files

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Initialize gConnectConInEvent earlier

Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, December 05, 2016 9:57 AM To: edk2-devel@lists.01.org Cc: Eric Dong ; Chao B Zhang

Re: [edk2] [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs

Many thanks. Pushed as 46d4b18. Regards, Leif On Tue, Dec 06, 2016 at 06:28:48AM +, Wei, David wrote: > It looks good. > > Reviewed-by: David Wei > > Thanks, > David Wei > > -Original Message- > From: Leif Lindholm