Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Wednesday, December 14, 2016 3:34 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin ; Ni, Ruiyu ; Ye, Ting
> ; Fu, Siyuan
Thanks Jiewen, I'm fine with the flag rename:).
Best Regards!
Jiaxin
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, December 14, 2016 3:45 PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Ye, Ting ;
Hi Jiaxin
Thanks to contribute this.
I found below update is NOT related to HTTPS.
Can we use a better name, such as TLS_ENABLE ?
+!if $(HTTPS_BOOT_ENABLE) == TRUE
+ NetworkPkg/TlsDxe/TlsDxe.inf
+ NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
+!endif
Thank you
Yao Jiewen
> -Original
This patch is used to remove the 'SECURE_BOOT_ENABLE' flag for OpensslLib
and BaseCryptLib modules.
Cc: Long Qin
Cc: Ni Ruiyu
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Cc: Thomas Palmer
This path is used to enable HTTPS boot feature for Nt32 platform.
Cc: Long Qin
Cc: Ni Ruiyu
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Cc: Thomas Palmer
This patch is the implementation of EFI TLS Service Binding
Protocol, EFI TLS Protocol and EFI TLS Configuration Protocol
Interfaces.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Cc: Long Qin
Cc: Thomas Palmer
This patch is used to enable HTTPS feature. HttpDxe driver
will consume TlsDxe driver. It can both support http and https
feature, that’s depended on the information of URL, the HTTP
instance can be able to determine whether to use http or https.
Cc: Ye Ting
Cc: Fu Siyuan
This patch is used to enable ssl build in OpensslLib module
directly.
Cc: Wu Jiaxin
Cc: Ye Ting
Cc: Long Qin
Cc: Fu Siyuan
Cc: Zhang Lubo
Cc: Thomas Palmer
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Cc: Long Qin
Cc: Thomas Palmer
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin
---
This patch is used to add new TlsLib library, which is wrapped
over OpenSSL. The implementation provides TLS library functions
for EFI TLS protocol and EFI TLS Configuration Protocol.
Cc: Ye Ting
Cc: Long Qin
Cc: Fu Siyuan
Cc: Zhang
This path is used to standardize TLS definitions from related
RFCs. Including TLS Cipher Suites, TLS Version, TLS Content Type
and TLS Record Header, etc.
Cc: Long Qin
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
The series patches are used to sync the edk2-staging/HTTPS-TLS
feature into edk2 master. Detailed feature description can be
found @ https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS,
including feature timeline, support scope and verifications.
Cc: Long Qin
Cc: Ye
This patch provides the UI to support TLS auth configuration.
* EFI_SIGNATURE_LIST format is used for 'TlsCaCertificate'
variable. So, TLS supports multiple certificate configuration.
* The variable attribute is BS with NV, which only target at
preventing runtime phase attack.
Cc: Ye Ting
This patch is used to add Tls.h and TlsConfig.h header
files to define EFI TLS Configuration Protocol,
EFI TLS Service Binding Protocol and
EFI TLS Configuration Protocol.
Cc: Long Qin
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Peter:
Thanks for your report this issue. Could you report it in bugzilla
(bugzilla.tianocore.org)? We will follow up.
Thanks
Liming
> -Original Message-
> From: peter.kirme...@ts.fujitsu.com [mailto:peter.kirme...@ts.fujitsu.com]
> Sent: Wednesday, December 14, 2016 3:03 PM
> To:
Hi Andrew,
in the meantime I will work around this issue by using a script file as AWK
input, so the command is not part of build_rules.txt.
Thanks for your help.
Dear Yonghong, Liming,
first I thought that my issue came by myself (not knowing how to escape the
dollar sign at
Daniil:
Could you update the script to print line number in source file instead of
diff file? Sometimes, the developer uses this script with revision. The print
line in the diff file is not obvious. And, I also find the report line number
is difference for the same patch with the two ways:
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, December 14, 2016 1:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
>
> Change structure value
Change structure value assignment with CopyMem() API.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c | 7 +--
1 file changed, 5
Please also update the function comment to "Send BlockSid request through TPM
physical presence module."
With this change, the patch is good.
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To:
Fixed several style issues.
The patch set has been squashed in to the single patch after the
code review.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daniil Egranov
---
Changelog:
v4
Fixed driver crash during the logical interface shutdown. The
Rviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, December 14, 2016 11:31 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [PATCH v2 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
>
> 1. Change
1. Change _SECTION_ITEM to _INI_SECTION_ITEM
2. Change _COMMENT_LINE to _INI_COMMENT_LINE
Because _SECTION_ITEM and _COMMENT_LINE are duplicated with
the one defined in IntelFrameworkModulePkg\Universal\
FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
Cc: Jiewen Yao
Hi
Can we add below sentence to PcdRsa2048Sha256PublicKeyBuffer as well?
"WARNING: The default value is treated as test key. Please do not use default
value in the production."
With that, reviewed-by: jiewen@intel.com
Thank you
Yao Jiewen
>
> -Original Message-
> From: edk2-devel
Reviewed-by: jiewen@intel.com
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Fan, Jeff
Reviewed-by: jiewen@intel.com
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [edk2] [patch 17/18]
I checked code again.
May we can we use a better name, such as INI_COMMENT_LINE or INI_SECTION_ITEM?
Thank you
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
Jiewen
Sent: Tuesday, December 13, 2016 4:50 PM
To: Bi, Dandan ;
Changed code structure per Leif Lindholm's request
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daniil Egranov
---
Changelog:
v2
Corrected style issues and code structure.
v1
The patch reads a valid MAC address form the Juno IOFPGA registers
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Fu, Siyuan
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Fu, Siyuan
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: [edk2]
On Tue, Dec 13, 2016 at 03:32:49PM +, Daniil Egranov wrote:
> I understood your comments but I do not see a good reason to split a
> pretty small function on even smaller functions which will not be
> used by any other code.
How do we find such reusability unless we start looking for it?
For
Hi Leif,
I understood your comments but I do not see a good reason to split a pretty
small function on even smaller functions which will not be used by any other
code. The code has comments or function calls explain themselves in the name so
it should not be a problem to understand the code.
Corrected code checking for multi-line and commented lines. Both
multi-line and open comment flags will be reset when leaving
diff "+" area of the patch.
Changed version of the tool to 0.2.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daniil Egranov
On Tue, Dec 13, 2016 at 01:24:24AM -0600, Daniil Egranov wrote:
> Corrected style issues and code structure.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Daniil Egranov
> ---
> Changelog:
>
> v1
> The patch reads a valid MAC address form
Hi Vincent,
Many thanks for your confirmation.
Regards,
Heyi
在 11/29/2016 9:08 PM, Zimmer, Vincent 写道:
Yes. For IPV4 TFTP-based PXE the wire protocol adheres to the PXE 2.1 specification with
some errata that supercedes that frozen document found under section "E.4.20 PXE 2.1
Thanks both.
I think Andrew's idea is what I'm really looking for. But in the
meantime, adding "-s" as Michael suggested is working quite well.
On 12 December 2016 at 18:58, Michael Zimmermann
wrote:
> these build command options are probably what you want:
>
> -s,
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zhang, Chao B
>
> Subject: [patch 06/18]
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zhang, Chao B
>
This seems odd.
This is a C file. No one should include 2 files at same time.
I suggest we keep it as is.
Thank you
Yao Jiewen
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
>
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding
> style
> issues in INF
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source
> file to INF file
>
>
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: Add source
> file to INF file
>
>
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Fan, Jeff
> Subject: [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Fan, Jeff
>
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [patch 16/18] MdeModulePkg: Make the comments align with the
> function
>
> Cc: Jiewen
Cc: Jiewen Yao
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
UefiCpuPkg/UefiCpuPkg.uni | 8
1 file changed, 8 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.uni
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/Application/CapsuleApp/AppSupport.c | 10 +-
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 6 +++---
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 28 +++---
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git
1. Add MicrocodeUpdate.h to the [Sources] section.
2. Fix the incorrect Guid/Protocol format issues.
Cc: Jiewen Yao
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
Some Pcds are added to the dec file, but miss to add the
prompt& info to the uni file, now add them.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/MdeModulePkg.dec | 1 +
Cc: Jiewen Yao
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc | 1 +
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
UefiCpuPkg/CpuDxe/CpuMp.c | 2 +-
UefiCpuPkg/Include/Library/MpInitLib.h | 4 ++--
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 4 ++--
1. Change _SECTION_ITEM to _SECTION_ITEMS
2. Change _COMMENT_LINE to _COMMENT_LINES
Because _SECTION_ITEM and _COMMENT_LINE are duplicated with
the one defined in IntelFrameworkModulePkg\Universal\
FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
Cc: Jiewen Yao
Add SystemFirmwareDxe.h to [Sources] section of INF file.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf | 1 +
Add RecoveryModuleLoadPei.h to [Sources] section of INF file.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf| 1 +
1 file
Cc: Eric Dong
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Cc: Jiewen Yao
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../FmpAuthenticationLibRsa2048Sha256.inf | 6 +++---
1 file changed, 3 insertions(+),
Cc: Jiewen Yao
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf | 2 +-
1 file changed, 1 insertion(+),
Cc: Jiewen Yao
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
SecurityPkg/SecurityPkg.uni | 5 +
1 file changed, 5 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.uni
Cc: Fu Siyuan
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf | 2 +-
1 file changed, 1 insertion(+), 1
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Cc: Fu Siyuan
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
.../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf | 2 +-
1 file changed, 1 insertion(+), 1
These patch series make the coding style follow EDKII coding rules.
Dandan Bi (18):
ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues
ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format
ShellPkg/UefiShellNetwork2CommandsLib: Fix incorrect Protocol format
64 matches
Mail list logo