[edk2] [Patch] NetworkPkg/HttpBootDxe: Update to check specified media type

2017-02-14 Thread Jiaxin Wu
IANA has approved below new media type for EFI http(s) boot usage: application/vnd.efi.img application/vnd.efi.iso HTTP boot driver should be updated to check the above media type from Content-Type header field. Cc: Ye Ting Cc: Fu Siyuan

[edk2] [Patch] BaseTools: Fix bug for GUIDED tool path override by DSC [BuildOptions]

2017-02-14 Thread Yonghong Zhu
Current the GUIDED tool path can't be override to the different path in the [BuildOptions] of DSC file. This patch fix the bug. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=283 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH] Make [-D Macros] as optional argument for GenCfgOpt

2017-02-14 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > rthomaiy > Sent: Monday, February 13, 2017 18:53 > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] Make [-D

Re: [edk2] [PATCH] MdePkg/BaseLib: Refine logic for (Ascii)StrnLenS to handle MaxSize = 0

2017-02-14 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Monday, February 13, 2017 6:43 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Gao, Liming ; Kinney, Michael D >

Re: [edk2] [Patch] NetworkPkg/HttpBootDxe: Request HTTP token notify as a DPC at TPL_CALLBACK

2017-02-14 Thread Hegde, Nagaraj P
Reviewed-by: Hegde Nagaraj P -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Tuesday, February 14, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P ; Ye Ting ; Fu Siyuan

Re: [edk2] [Patch] NetworkPkg/HttpBootDxe: Request HTTP token notify as a DPC at TPL_CALLBACK

2017-02-14 Thread Subramanian, Sriram
Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Tuesday, February 14, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ; Wu

Re: [edk2] [Patch] NetworkPkg/HttpBootDxe: Request HTTP token notify as a DPC at TPL_CALLBACK

2017-02-14 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: 2017年2月14日 16:42 To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread David A. Van Arnem
On 02/14/2017 04:46 PM, Nikolay Bodunov wrote: > Hi > > I red this topic before asking the question in the maillist. Unfortunately, > it's not for DXE phase. > I even tried to use it and recieved expected compiler error: > > error 1001: Module type [PEIM] is not supported by library instance >

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread Nikolay Bodunov
Hi I red this topic before asking the question in the maillist. Unfortunately, it's not for DXE phase. I even tried to use it and recieved expected compiler error: error 1001: Module type [PEIM] is not supported by library instance [/home/nick/src/edk2/MdePkg/Library/UefiDebugLibConOut/

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread David A. Van Arnem
On 02/14/2017 03:36 PM, Nikolay Bodunov wrote: > Hi > > I wrote "As a base". It's not my current code. > I called "DEBUG() directly, without any conditions. Of course, code on > given link won't call DEBUG() if no errors happen. > I understand that UEFI Appliction should work fine with usual

Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

2017-02-14 Thread Jim.Dailey
Please disregard the earlier "Confidential" text. The stupid plug-in that adds this does not show the text in the mail when it is composed in text mode, so I often forget to turn this "feature" off when posting. Sorry. -Original Message- From: edk2-devel

Re: [edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

2017-02-14 Thread Jim.Dailey
Dell - Internal Use - Confidential Jeff, Perhaps a better approach is to print *all* the LoadOptions data as hex bytes? In addition, one might first analyze the LoadOptions data, and, when apropos, print obvious strings as strings? Regards, Jim -Original Message- From: edk2-devel

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread Nikolay Bodunov
Hi I wrote "As a base". It's not my current code. I called "DEBUG() directly, without any conditions. Of course, code on given link won't call DEBUG() if no errors happen. I understand that UEFI Appliction should work fine with usual print functions, but now I want to know how to print debug

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread David A. Van Arnem
Hi, From a quick look at your code, I'm not sure you want to make a DXE_DRIVER. The code looks more like a UEFI_APPLICATION. CrScreenshotDxe.c should normally manage a device, for UEFI_DRIVERS it will implement the Driver Binding Protocol functions Supported(), Start(), and Stop(). Likely, the

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread Nikolay Bodunov
Thank you for the suggestions. I tried to use them: > (1) Please always terminate the debug message with a newline ("\n") Done. No changes. Of course, I usually do it, but in that case all I needed was to have any string on output. Sorry for bad programming style. > (2) Please use DEBUG_ERROR

[edk2] [PATCH] ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage

2017-02-14 Thread Jeff Westfahl
The format specifier for the LoadOptions field of the LoadedImage protocol is "%s". However, the data in LoadOptions is often generic binary data. A format specifier of "%x" is more appropriate for this field. Using "dh -v" with format specifier "%s" on BIOS images based on EDK II source before

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread Kinney, Michael D
If you prefer debug messages on a serial port, you can add -D DEBUG_ON_SERIAL_PORT Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, February 14, 2017 10:17 AM > To: Nikolay Bodunov

Re: [edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread Laszlo Ersek
Hi Nikolay, On 02/14/17 18:55, Nikolay Bodunov wrote: > Hello > > > I compiled DXE Driver, in DEBUG_GCC49 mode, but I can’t print any debug > message. > DEBUG((-1, “Print test”)) does nothing. Exactly as > DebugPrint(EFI_D_ERROR, “Print Test); (1) Please always terminate the debug message

[edk2] DEBUG() macros in DXE driver: can’t make it work in QEMU

2017-02-14 Thread Nikolay Bodunov
Hello I compiled DXE Driver, in DEBUG_GCC49 mode, but I can’t print any debug message. DEBUG((-1, “Print test”)) does nothing. Exactly as DebugPrint(EFI_D_ERROR, “Print Test); However, I see “Print Test” string in my *.efi binary. I use QEMU + OMVF (OVMF was also recompliled in DEBUG_GCC49

[edk2] [Patch] NetworkPkg/HttpBootDxe: Request HTTP token notify as a DPC at TPL_CALLBACK

2017-02-14 Thread Jiaxin Wu
This patch is to update the HTTP token notify as a DPC at TPL_CALLBACK to align with UEFI Spec. Cc: Hegde Nagaraj P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin