Re: [edk2] [Patch 0/2] BaseTools: Fix XCODE5 build breaks for varargs

2017-05-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Kinney, Michael D >Sent: Friday, May 19, 2017 2:52 PM >To: edk2-devel@lists.01.org >Cc: Andrew Fish ; Gao, Liming ; >Kinney, Michael D >Subject:

Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Friday, May 19, 2017 6:48 PM >To: edk2-devel@lists.01.org >Cc: leif.lindh...@linaro.org; Zhu, Yonghong ; Gao, >Liming

Re: [edk2] [Patch] edk2: Add .DS_Store to .gitignore for macOS

2017-05-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Kinney, Michael D >Sent: Friday, May 19, 2017 2:23 PM >To: edk2-devel@lists.01.org >Cc: Andrew Fish ; Gao, Liming ; >Kinney, Michael D >Subject:

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] BroxtonPlatformPkg: Fix secure boot not work issue

2017-05-21 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Guo, Mang Sent: Monday, May 22, 2017 11:01 AM To: edk2-devel@lists.01.org Cc: Wei, David Subject:

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-05-21 Thread Fan, Jeff
Mike, This piece of code will be shared for CPU PEI/DXE MP driver. If PEI is 64bit, this piece of code maybe located on FLASH. We cannot change the value in InitialzeFloatingPointUnitsAddress if the code located on FALSH in AsmGetAddressMap(). We need to update the

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change BIOS version

2017-05-21 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/BiosId.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env b/Platform/BroxtonPlatformPkg/BiosId.env

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] BroxtonPlatformPkg: Fix secure boot not work issue

2017-05-21 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- .../BroxtonPlatformPkg/PlatformDsc/PcdsDynamicDefault.Default.dsc | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [edk2] [PATCH] MdeModulePkg/DxeHttpLib: Fix potential memory leaks

2017-05-21 Thread Wu, Jiaxin
Hello Paulo, Thanks your contribution. Only one small comments: We'd better use "ON_EXIT" instead of "Error" in HttpUrlGetPort() since the PortString should always be freed. Others is good to me. Reviewed-by: Wu Jiaxin > -Original Message- > From: edk2-devel

Re: [edk2] [Patch V2] MdeModulePkg/LogoDxe: Return error if HII Package not present

2017-05-21 Thread Zeng, Star
There is a typo "messahe" in the commit log. With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Saturday, May 20, 2017 12:27 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric

[edk2] [Patch] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-05-21 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=565 Fix NASM compatibility issues with XCODE5 tool chain. The XCODE5 tool chain for X64 builds using PIE (Position Independent Executable). For most assembly sources using PIE mode does not cause any issues. However, if assembly code is copied to a

[edk2] [PATCH] MdeModulePkg/DxeHttpLib: Fix potential memory leaks

2017-05-21 Thread Paulo Alcantara
Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-)