Re: [edk2] how to create environmental variable for Shell

Delay for the shell to start "Startup.nsh" can also be done with the option "-delay :n" where n is the number of seconds of delay, default is 5. thanks, Laurie   laurie.jarlst...@intel.com Intel SSG/STO/EBP (503) 712-9395 -Original Message- From: edk2-devel

Re: [edk2] how to create environmental variable for Shell

Hi, Are you trying to set the Timeout variable (delay to allow user to press a key to go into setup) or the delay for the shell before executing startup.nsh? The Timeout variable is a PCD and can be set with: TmpVal = 2; PcdStatus = PcdSet16(PcdPlatformBootTimeOut, (UINT16)TmpVal);

Re: [edk2] UEFI Image Attribute

Hi, Do you mean the one in EFI_FIRMWARE_IMAGE_DESCRIPTOR? My guess is it means “UEFI firmware image”, i.e. a set of firmware volumes ready for flashing (an .fd file in some contexts), as opposed to a non-UEFI firmware such as EC, BMC or some other variation. -- WBR, Igor.

[edk2] [platforms: PATCH v2 2/6] Marvell/Drivers: MvSpiFlash: Enable dynamic SPI Flash detection

Hitherto mechanism of fixing SPI flash model in the PCDs, occured to be very inefficient and problematic. Enable dynamic detection by reworking MvSpiFlashReadId() command, which now uses newly added NorFlashInfoLib, that helps to obtain description of the JEDEC compliant devices. This patch

[edk2] [platforms: PATCH v2 6/6] Marvell/Drivers: MvSpiDxe: Keep data in SPI_DEVICE structure

In the MvSpiDxe driver obtaining host register base address, controller clock and device maximum frequency directly from PCDs was done all over the code. This patch cleans up the parameters' handling and enables accessing them from SPI_DEVICE structure fields. Contributed-under: TianoCore

[edk2] [platforms: PATCH v2 5/6] Marvell/Drivers: MvSpiFlash: Fix bank selection for Spansion

Spansion SPI flash devices use different command for bank selection. Update it, basing on the first byte of flash ID. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 5 +

[edk2] [platforms: PATCH v2 3/6] Marvell/Drivers: MvSpiFlash: Remove duplicated macros

Flash commands macros are already defined in MvSpiFlash.h, so remove them from the protocol header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Include/Protocol/SpiFlash.h | 11 --- 1 file changed, 11

[edk2] [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2.

Hi, I submit corrected version of the Armada SPI improvements after the first round of review. There were no significant changes comparing to v1, please check the changelog below for the details. Patches are available in the github:

[edk2] [platforms: PATCH v2 1/6] Marvell/Drivers: MvSpiFlash: Improve ReadId

Fix the ReadId routine by using master's ReadWrite callback instead of the raw Transfer - no longer swapping and byte shifting is needed. Simplify code by using local array instead of dynamic allocation. Moreover store the FlashId in an UINT8 array PCD instead of the concatenated UINT32 format -

[edk2] [PATCH v3 1/1] EmbeddedPkg: Implement NorFlashInfoLib

The SPI NOR flash drivers which base on ArmPlatformPkg's NorFlashDxe usually make use of static declarations of the flash instances with their type and parameters. As a result it implies hardcoding the exact way of flash handling, not to mention the code does not look very nice. Much better

[edk2] UEFI Image Attribute

What does the IMAGE_ATTRIBUTE_UEFI_IMAGE attribute mean? The spec says that "image is an EFI compatible image", but what that mean exactly? Thanks ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ShellPkg/HexEdit: Fix EBC build failure

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Friday, November 03, 2017 1:59 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/HexEdit: Fix EBC build failure > Importance: High > >

Re: [edk2] how to create environmental variable for Shell

Please excuse the stupid email plug-in I have to use that puts the "Internal Use" line in my text emails. The plug-in does not allow me to see that text, so I have to remember to remove it every time even though I never see it. Sadly, I sometimes forget. -Original Message- From:

Re: [edk2] how to create environmental variable for Shell

Dell - Internal Use - Confidential You need to use the shell's GUID, gShellVariableGuid, if you want to create a shell variable. Regards, Jim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tiger Liu Sent: Friday, November 3, 2017 12:01 AM To:

Re: [edk2] [PATCH 2/3] ShellPkg: Fix misuses of AllocateCopyPool

Isn't ReallocatePool is the correct function to use in these cases? For example: NewCommandLine1 = ReallocatePool(NewSize, StrSize(OriginalCommandLine), OriginalCommandLine; Regards, Jim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,

[edk2] [PATCH v2] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

DEBUG builds of PEI code will print a diagnostic message regarding the utilization of temporary RAM before switching to permanent RAM. For example, Total temporary memory:16352 bytes. temporary memory stack ever used: 4820 bytes. temporary memory heap used for HobList: 4720

[edk2] [RFC PATCH edk2-platforms 3/3] Platform/DeveloperBox: wire up RTC support

Add the drivers, library resolutions and PCD settings to enable RTC support on DeveloperBox. Also, update PlatformDxe to register the non-discoverable device handles for both I2C controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [RFC PATCH edk2-platforms 1/3] Silicon/NXP: add RTC support library for PCF8563 I2C IP

Add a RealTimeClockLib implementation for the NXP PCF8563 as used on the Socionext Developer Box board. Note that the standard I2C protocol stack does not support runtime use, so this driver invokes the I2C master protocol directly. This requires support from the platform side as well, and so this

[edk2] [RFC PATCH edk2-platforms 2/3] Silicon/Socionext: implement I2C master protocol for SynQuacer I2C

Add a driver that produces the I2C master protocol on top of the I2C controllers that are implemented in the SynQuacer Socionext SoC. Note that this supports two modes simultaneously: I2C controllers that are only usable at boot time, and usable via the I2C protocol stack, and I2C controllers that

[edk2] [RFC PATCH edk2-platforms 0/3] add I2C RTC support to DeveloperBox

This implements RTC support over I2C for the Socionext DeveloperBox platform. Note that using the I2C protocol at runtime is not supported by the ordinary I2C protocol stack, so we have to take special precautions to allow the RTC driver to invoke the I2C master protocol directly. The same driver

Re: [edk2] [PATCH] ShellPkg/hexeditor: Use CpuIo for memory access

On 1 November 2017 at 18:15, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > >> -Original Message- >> From: Ni, Ruiyu >> Sent: Wednesday, November 01, 2017 3:13 AM >> To: edk2-devel@lists.01.org >> Cc: Carsey, Jaben

[edk2] [PATCH] ShellPkg/HexEdit: Fix EBC build failure

EfiCpuIoWidthUint8 should be used in HMemImageRead and HMemImageSave. Because CpuIo protocol is now used for memory access. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey ---

[edk2] [PATCH] ShellPkg/HexEdit: Fix EBC build failure

EfiCpuIoWidthUint8 should be used in HMemImageRead and HMemImageSave. Because CpuIo protocol is now used for memory access. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben car...@intel.com> ---

[edk2] [PATCH] Tftp assert fix for openfile failure case

Issue: when file open is failed, assert was seen due to freeing 0 size page Reason: DataSize is remain zero if error is reported in ShellOpenFileByName Fix: Update DataSize as soon as FileSize is available Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Udit Kumar

[edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

The original code enables some BITs in PCI attributes in Start(), but wrongly to disable these BITs in Stop(). The correct behavior is to save the original PCI attributes before enables some BITs in Start(), and restore to original value in Stop(). Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 2/3] ShellPkg: Fix misuses of AllocateCopyPool

2 comments below. -Original Message- From: Wang, Jian J Sent: Friday, November 3, 2017 12:58 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu ; Bi, Dandan Subject: [PATCH 2/3] ShellPkg: Fix misuses of

[edk2] 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Jian, Could you use some global variables in https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c to avoid adding new API? Jeff 发件人: Yao, Jiewen 发送时间: 2017年11月3日 9:24 收件人: Kinney, Michael

Re: [edk2] [Patch 1/3] MdeModulePkg: Add new PCD PcdInitValueInTempStack

With that added, Reviewed-by: Star Zeng to this patch series. Thanks, Star -Original Message- From: Gao, Liming Sent: Friday, November 3, 2017 3:24 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch 1/3] MdeModulePkg: Add

Re: [edk2] [Patch 1/3] MdeModulePkg: Add new PCD PcdInitValueInTempStack

Yes. Thanks for your reminder. I will add it into MdeModulePkg.uni. >-Original Message- >From: Zeng, Star >Sent: Friday, November 03, 2017 9:15 AM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: RE: [edk2] [Patch 1/3]

Re: [edk2] [patch] MdeModulePkg/VarCheckHii: Enhance VarCheckHiiLib to support bit check

Hi Star, Thanks for your comments. Yes, you are right. I will update the patch based on your comments. Regards, Dandan -Original Message- From: Zeng, Star Sent: Friday, November 3, 2017 2:04 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Dong, Eric

Re: [edk2] Official port of Python on EDK2

> FYI, this library adds thread support to UEFI: > > https://github.com/Openwide-Ingenierie/GreenThreads-UEFI IMO this library has some crucial problems like changing the TPL during context switching. For my project "EFIDroid" I've invested many months analyzing, testing and implementing my own

Re: [edk2] [patch] MdeModulePkg/VarCheckHii: Enhance VarCheckHiiLib to support bit check

Hi Dandan, 1. Could we reuse VarOffset/StorageWidth to store bit level info when BitFieldStore = TRUE? Then we can avoid adding VarOffsetBitLevel/StorageWidthBitLevel to reduce the final VarCheckBinSize, and it can be also aligned with HiiDatabase that is using VarOffset to store bit level

Re: [edk2] [PATCH] IntelSiliconPkg IntelVTdDxe: Use ACPI table event to get DMAR table

Looks good to remove the dependency. Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, November 3, 2017 1:40 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH]