[edk2] [platforms PATCH 1/1] Marvell/Drivers: MvFvbDxe: Fix uninstallation of protocol

Recently added installation of gEdkiiNvVarStoreFormattedGuid introduced bug in the error path. gBS->UninstallProtocolInterface takes an actual handle as an argument (not the pointer). Fix this and on the occasion fix indentation of multiline call. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] MdeModulePkg/Terminal: Check status of OpenProtocol in BindingStart

Indeed UEFI Spec requires that Supported() should be called before Start(). But Steven's test cases directly call Start() which exposes this "issue". I don't want to argue the call doesn't follow UEFI Spec. Fixing it doesn't harm:). > -Original Message- > From: Zeng, Star > Sent: Friday,

Re: [edk2] [RFC v2 4/4] FmpDevicePkg: Add DSC file to build all package components

Signed-off-by: Sean Brogan -Original Message- From: Kinney, Michael D Sent: Tuesday, April 17, 2018 2:05 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Jiewen Yao ; Michael D

Re: [edk2] [RFC v2 2/4] FmpDevicePkg: Add library instances

Signed-off-by: Sean Brogan -Original Message- From: Kinney, Michael D Sent: Tuesday, April 17, 2018 2:05 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Jiewen Yao ; Michael D

Re: [edk2] [RFC v2 1/4] FmpDevicePkg: Add package, library classes, and PCDs

Signed-off-by: Sean Brogan -Original Message- From: Kinney, Michael D Sent: Tuesday, April 17, 2018 2:05 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Jiewen Yao ; Michael D

Re: [edk2] [RFC v2 3/4] FmpDevicePkg: Add FmpDxe module

Signed-off-by: Sean Brogan -Original Message- From: Kinney, Michael D Sent: Tuesday, April 17, 2018 2:05 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Jiewen Yao ; Michael D

[edk2] [RFC v2 3/4] FmpDevicePkg: Add FmpDxe module

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg The FmpDxe directory contains 2 INF files. FmpDxe.inf is a DXE driver that is used in a platform to add a Firmware

[edk2] [RFC v2 2/4] FmpDevicePkg: Add library instances

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib, and FmpPayloadHeaderLib. Library Classes

[edk2] [RFC v2 0/4] Add FmpDevicePkg

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Changes in V2 = * FmpDevicePkg DEC file + Change PcdFmpDeviceSystemResetRequired from FeatureFlag to FixedAtBuild + Add PcdFmpDeviceTestKeySha256Digest for test key detection. Set to {0} to disable test key detection. *

[edk2] [RFC v2 4/4] FmpDevicePkg: Add DSC file to build all package components

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Adds a DSC file that is used to verify that all of the FmpDevicePkg libraries and modules build without error. Cc:

[edk2] [RFC v2 1/4] FmpDevicePkg: Add package, library classes, and PCDs

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Create FmpDevicePkg with library classes and PCDs used to customize the behavior of a Firmware Management Protocol

Re: [edk2] [PATCH edk2-platforms 00/39] NXP: Add support of LS1043, LS1046 and LS2088 SoCs

Could you please integrate the below changes in whichever commits they belong individually? - Clarifications (via file name changes) of which .dsc files are meant as include files rather than standalone platform descriptions. - Getting rid of relative paths to locate said include files. (No, I

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

On Fri, Feb 16, 2018 at 02:20:01PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > I2C driver produces gEfiI2cMasterProtocolGuid which can be > used by other modules. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi

Re: [edk2] [PATCH edk2-platforms 16/39] Silicon/NXP : Add NOR driver.

(Responding somewhat out of sequence, as I'm going through to build this port and encountering issues.) This patch will require something similar to edk2-platforms 79c9dd55a32752b7ae11d5f1a50fa3ae27d6d126 in order to work with recent upstream edk2. (gVariableRuntimeDxeFileGuid has gone away with

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

Leif, Yes. I think the single swap lib is sufficient for the specific use case. We can wait until there is a request to add support for a BE CPU to look at a more complete solution to reusing the same module sources for all combinations of CPU and I/O endianness. Thanks, Mike >

[edk2] [PATCH v2 2/2] BaseTools: replace 'UINT8', 'UINT16', 'UINT32', 'UINT64', 'VOID*' with shared constants.

From: Jaben v2 fixes yonghongs comment. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v3 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

From: Jaben sometimes just delete it. sometimes the loop needed .values() instead v2 was my error v3 fix error per Yonghong's review. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

From: Jaben sometimes just delete it. sometimes the loop needed .values() instead v2 - revert one change yer Yonghong's review. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] (spawning off more style discussion)

On Mon, Apr 16, 2018 at 09:32:44PM +0200, Laszlo Ersek wrote: > (4) Please consider adopting > > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-10 > >

Re: [edk2] [PATCH v1 2/4] BaseTools: replace 'UINT8', 'UINT16', 'UINT32', 'UINT64', 'VOID*' with shared constants.

Hi Jaben, In GenFdsGlobalVariable.py file, it should use DataType.TAB_VOID because current the import statement in this file is " import Common.DataType as DataType". Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 12, 2018 7:08 AM To:

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

On Mon, Apr 16, 2018 at 10:42:26PM +0200, Laszlo Ersek wrote: > On 04/16/18 16:34, Michael Brown wrote: > > On 16/04/18 15:10, Kinney, Michael D wrote: > >> I agree that the opposite use case is a BE CPU > >> needing a LE operation. > >> > >> I think we only need a single lib class and lib > >>

Re: [edk2] [PATCH v1 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

Hi Jaben, In the misc.py file, it can't do below change. Otherwise it would cause build failure for: GlobalData.gSkuids = (self.SkuIdSet) GlobalData.gSkuids.remove('COMMON') AttributeError: 'OrderedDict' object has no attribute 'remove' -self.SkuIdSet = SkuIds.keys() +

Re: [edk2] [PATCH v1 1/2] BaseTools: fix None comparisons

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 13, 2018 8:02 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/2]

Re: [edk2] [PATCH v1 0/9] BaseTools: refactoring

Reviewed this series patch. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Saturday, April 14, 2018 4:51 AM To: edk2-devel@lists.01.org Subject:

Re: [edk2] [PATCH v1] BaseTools: remove an unused file

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, April 14, 2018 1:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1]

Re: [edk2] [PATCH v1] BaseTools: delete an unused file

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, April 14, 2018 12:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1]

Re: [edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 11, 2018 7:17 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/5]

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

Hi Laszlo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 17, 2018 3:12 PM > To: Udit Kumar ; Leif Lindholm > > Cc: Kinney, Michael D ; edk2-devel@lists.01.org; > Gao,

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

On 04/17/18 11:30, Laszlo Ersek wrote: > MdeModulePkg/Include/Library/UefiBootManagerLib.h | 26 > +++--- > .../Library/UefiBootManagerLib/BmLoadOption.c | 12 ++ > 2 files changed, 26 insertions(+), 12 deletions(-) Sorry about the truncated diffstat, I forgot to

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

On 04/17/18 10:24, Michael Brown wrote: > On 17/04/18 09:01, Laszlo Ersek wrote: >> The thing is, the BeIoLib and LeIoLib classes are already good for this >> -- they can be implemented as you suggest. So no need to call the >> function SwapIfNeededForBigEndianDeviceMmioRead16(), just call it >>

Re: [edk2] [PATCH v2 1/1] ArmPkg/PlatformBootManagerLib: load boot options from platform

On 04/17/18 11:02, Laszlo Ersek wrote: > Whereas, if the option is *not* found in the original array, then you > add it -- and then EfiBootManagerAddLoadOptionVariable() *modifies* > "NewOption.OptionNumber", from "LoadOptionNumberUnassigned" to the > actual assigned. This may not have been

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

On 04/17/18 10:15, Udit Kumar wrote: > Hi Laszlo, > > Considering all possible option is best to have in code  > But IMO, We are running UEFI on LE CPU only, Not sure someone is running on > BE. AFAIK even specs says LE. > >> (c) assuming we introduce a CPU with BE byte order, the same

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

Clean up the leading comment and the prototype of EfiBootManagerAddLoadOptionVariable(): - the function may modify Option on output, annotate the parameter with OUT and update the documentation; - "@retval EFI_STATUS" and "@retval Others" are not idiomatic documentation, use @return instead;

Re: [edk2] [edk2-platforms PATCH v2 1/1] Platform/HiKey960: register predefined boot options

On 04/17/18 07:14, Haojian Zhuang wrote: > Create 4 boot options on HiKey960 platform. They're "Boot from SD", > "Grub", "Android Boot" and "Android Fastboot". > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm > Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2 1/1] ArmPkg/PlatformBootManagerLib: load boot options from platform

On 04/17/18 07:11, Haojian Zhuang wrote: > Platform drivers sets up the array of predefined boot options. > ArmPkg/PlatformBootManager converts the array to boot options. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > ---

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

On 17/04/18 09:01, Laszlo Ersek wrote: The thing is, the BeIoLib and LeIoLib classes are already good for this -- they can be implemented as you suggest. So no need to call the function SwapIfNeededForBigEndianDeviceMmioRead16(), just call it BeMmioRead16(). I know. I thought that suggesting

Re: [edk2] [patch 2/2] BaseTool/VfrCompile: make delete[] match with new[]

Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Tuesday, April 10, 2018 3:55 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming Subject: [patch 2/2] BaseTool/VfrCompile: make delete[] match with

Re: [edk2] [patch 1/2] BaseTools/VfrCompile:Fix memory leak issues

Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Tuesday, April 10, 2018 3:55 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming Subject: [patch 1/2] BaseTools/VfrCompile:Fix memory leak issues

[edk2] [Patch] IntelFrameworkModulePkg IsaSerialDxe: Update algorithm to calculate Divisor

To align the way in MdeModulePkg SerialPortLib and PciSioSerialDxe driver, Divisor is added by one when the reminder is more than half (16 * BaudRate). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni ---

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

Hi Laszlo, Considering all possible option is best to have in code  But IMO, We are running UEFI on LE CPU only, Not sure someone is running on BE. AFAIK even specs says LE. > (c) assuming we introduce a CPU with BE byte order, the same driver > source will work (for both LE and BE

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

On 04/17/18 00:14, Michael Brown wrote: > On 16/04/18 21:42, Laszlo Ersek wrote: >> On 04/16/18 16:34, Michael Brown wrote: >>> On 16/04/18 15:10, Kinney, Michael D wrote: I think we only need a single lib class and lib Instance that does the byte swap and we should not use Le or Be

Re: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

On 04/17/18 07:15, Marcin Wojtas wrote: > 2018-04-16 21:41 GMT+02:00 Laszlo Ersek : >> There's also a bit of whitespace mangling here that's not compatible >> with either multiline function call style that we like in edk2, but >> perhaps edk2-platforms treats that more laxly.

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

Hi Mike, Do we want to support BE CPUs, ? If yes then Last discussion of Lazlo is valid, where driver don't need to take care of CPU endianness. Regards Udit > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Kinney, Michael D > Sent:

Re: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

Hi Ard, 2018-04-17 7:32 GMT+02:00 Ard Biesheuvel : > On 17 April 2018 at 07:15, Marcin Wojtas wrote: >> Hi Laszlo, >> >> 2018-04-16 21:41 GMT+02:00 Laszlo Ersek : >>> On 04/16/18 07:40, Ard Biesheuvel wrote: (+ Laszlo)

Re: [edk2] [platforms PATCH 1/2] Marvell/Drivers: MvFvbDxe: Adjust to new dependencies

On 17 April 2018 at 08:04, Marcin Wojtas wrote: > Hi Ard, > > 2018-04-17 7:32 GMT+02:00 Ard Biesheuvel : >> On 17 April 2018 at 07:15, Marcin Wojtas wrote: >>> Hi Laszlo, >>> >>> 2018-04-16 21:41 GMT+02:00 Laszlo Ersek

[edk2] [PATCH v2] ArmPkg/TimerDxe: remove workaround for KVM timer handling

When we first ported EDK2 to KVM/arm, we implemented a workaround for the quirky timer handling on the KVM side. This has been fixed in Linux commit f120cd6533d2 ("KVM: arm/arm64: timer: Allow the timer to control the active state") dated 23 June 2014, which was incorporated into Linux release