Re: [edk2] [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, April 18, 2018 11:45 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi

Re: [edk2] Source code debugging of OVMF

On 04/16/18 12:25, Rebecca Cran wrote: > On 04/16/18 10:13, Laszlo Ersek wrote: > >> Here's another thread that you might find useful: >> >> http://edk2-devel.narkive.com/6BRVus92/qestion-about-how-to-debug-ovmf-on-qemu > > I should get my Phabricator wiki running again, which has a >

[edk2] [PATCH v1 1/1] BaseTools: remove EdkIIWorkspace as its not used.

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/EdkIIWorkspace.py | 317 1 file changed, 317

Re: [edk2] [PATCH v1 12/18] StandaloneMmPkg/CpuMm: Add CPU driver suitable for ARM Platforms.

Hi Supreeth, I am not sure how much it enforced in edk2 but in most of the cases, the driver's name matches its directory name. Thanks, Daniil On 04/06/2018 09:42 AM, Supreeth Venkatesh wrote: This patch adds a simple CPU driver that exports the EFI_MM_CONFIGURATION_PROTOCOL to allow

[edk2] [PATCH v1 1/1] BaseTools: remove PlatformClass as it's not used

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/CommonDataClass/PlatformClass.py | 456 1 file changed,

[edk2] [PATCH 8/8] SecurityPkg/UserProfileManagerDxe: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 7/8] SecurityPkg/UserIdentifyManagerDxe: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 5/8] SecurityPkg/Tcg2Config: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 6/8] SecurityPkg/PwdCredentialProviderDxe: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 4/8] MdeModulePkg/DriverHealthManagerDxe: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 2/8] MdeModulePkg/UiApp: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 3/8] MdeModulePkg/RamDiskDxe: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

[edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function

According to UEFI spec, the RouteConfig protocol function should populate the Progress pointer with an address inside Configuration. This patch ensures that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas

Re: [edk2] [PATCH v1 14/18] StandaloneMmPkg: Describe the declaration, definition and fdf files.

Hi Supreeth, Having .inc with the common configuration and data can be useful for including it to platform specific configurations. It will help to avoid patching platform specific builds in case of any changes in StandaloneMM structure or configuration. Thanks, Daniil On 04/06/2018 09:42

Re: [edk2] [PATCH edk2-platforms 15/39] Silicon/NXP : Add support of NorFlashLib

On Fri, Feb 16, 2018 at 02:20:11PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > NorFlashLib interacts with the underlying IFC NOR controller. > This will be used by NOR driver for any information > exchange with NOR controller. Some of this looks generic

Re: [edk2] [PATCH edk2-platforms 14/39] LS1043 : Enable support of FpgaLib.

On Fri, Feb 16, 2018 at 02:20:10PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm >

Re: [edk2] [PATCH edk2-platforms 13/39] LS1043/FpgaLib : Add support for FpgaLib.

On Fri, Feb 16, 2018 at 02:20:09PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > FpgaLib export FPGA_READ and FPGA_WRITE function and > provide a function to print Board personality. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH edk2-platforms 12/39] Silicon/NXP : Add support of IfcLib

On Fri, Feb 16, 2018 at 02:20:08PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Add support of IfcLib, it will be used to perform > any operation on IFC controller. Again, please describe what an IFC is. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms 11/39] LS1043/BoardLib : Add support for LS1043 BoardLib.

On Fri, Feb 16, 2018 at 02:20:07PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > BoardLib will contain functions specific for LS1043aRdb board. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal

Re: [edk2] [PATCH edk2-platforms 10/39] IFC : Add Header file for IFC controller

On Fri, Feb 16, 2018 at 02:20:06PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > This header file contain IFC controller timing structure, > chip select enum and other IFC macros. Could you just add a comment as to what an IFC is? (I'm guessing it's some

Re: [edk2] [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals

On Wed, Apr 18, 2018 at 04:38:22PM +, Meenakshi Aggarwal wrote: > > > + > > > +/* > > > + * Returns the bit mask for a bit index from 0 to 31 > > > + */ > > > +#define BIT(_BitIndex) (0x1u << (_BitIndex)) > > > > I don't see these being used for anything other than setting up BIT1 > >

Re: [edk2] [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals

Hi Leif, Thanks for review, responses inlined. > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, April 18, 2018 8:42 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Udit Kumar

Re: [edk2] [PATCH edk2-platforms 08/39] Compilation : Add the fdf, dsc and dec files.

On Fri, Feb 16, 2018 at 02:20:04PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > The firmware device, description and declaration files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal

Re: [edk2] [PATCH edk2-platforms 07/39] Platform/NXP: Add support for ArmPlatformLib

On Fri, Feb 16, 2018 at 02:20:03PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm >

Re: [edk2] [PATCH edk2-platforms 06/39] Silicon/Maxim : Add support for DS1307 RTC library

On Fri, Feb 16, 2018 at 02:20:02PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Real time clock Apis on top of I2C Apis > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- >

Re: [edk2] [PATCH edk2-platforms 04/39] Silicon/NXP : Add support for DUART library

On Fri, Feb 16, 2018 at 02:20:00PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm >

Re: [edk2] [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals

On Fri, Feb 16, 2018 at 02:19:59PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Add SocInit function that initializes peripherals > and print board and soc information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi

Re: [edk2] [PATCH v2 1/3] BaseTools: refactor and remove more keys() usage

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, April 18, 2018 10:22 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v2

Re: [edk2] [PATCH v1 1/1] BaseTools: Eot - Remove FvImage file

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 17, 2018 1:48 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1]

[edk2] [PATCH v2 1/3] BaseTools: refactor and remove more keys() usage

this is no longer required to make dictionary objects iterable. v2 - add back a missing "C" PcdName -> PcdCName Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

On 04/18/18 11:33, Laszlo Ersek wrote: > On 04/14/18 19:26, Kinney, Michael D wrote: >> Welcome Laszlo! > > Thanks! It's an honor and I'll do my best to measure up to the role! > >> Reviewed-by: Michael D Kinney > > I've been waiting / hoping that Andrew would ACK

Re: [edk2] [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure

On Wed, Mar 07, 2018 at 11:03:52AM +0800, Heyi Guo wrote: > We need to set PcdShellLibAutoInitialize to FALSE for > TftpDynamicCommand, or else we will get initialization failure when > loading TftpDynamicCommand module, for EFI Shell has not been started > at this moment. > > Contributed-under:

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

On 04/14/18 19:26, Kinney, Michael D wrote: > Welcome Laszlo! Thanks! It's an honor and I'll do my best to measure up to the role! > Reviewed-by: Michael D Kinney I've been waiting / hoping that Andrew would ACK as well (I understand that's left as a formality at

[edk2] [PATCH] BaseTools: Parse DSC component !include file report error issue

From: Yunhua Feng DSC format: [Components] !include TestPkg/Test.dsc if the Test.dsc have a INF, and the INF not exist, current the error message is not clearly. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under:

[edk2] [PATCH] BaseTools: Support DSC component !include PCD items

From: Yunhua Feng DSC format: [Components] TestPkg/TestDriver.inf { !include TestPkg/Test.txt } Test.txt content: PcdToken.PcdCName | 0x123 Per spec we should support this usage. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] (spawning off more style discussion)

On 04/17/18 15:55, Leif Lindholm wrote: > On Mon, Apr 16, 2018 at 09:32:44PM +0200, Laszlo Ersek wrote: >> (4) Please consider adopting >> >> >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-10 >> >>

Re: [edk2] [PATCH v1 1/3] BaseTools: refactor and remove more keys() usage

Hi Jaben, One bug on this patch. Original code it use PcdCName, now it change to use PcdName , it will cause PcdObject incorrect. -PcdsKeys = PcdValueDict.keys() -for PcdCName, TokenSpaceGuid in PcdsKeys: - -PcdSetting = PcdValueDict[PcdCName, TokenSpaceGuid] +

Re: [edk2] [PATCH v3 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 17, 2018 10:40 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v3

Re: [edk2] [PATCH v2 2/3] BaseTools: use predefined constants instead of local strings

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Monday, April 16, 2018 9:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [edk2] [PATCH v2

[edk2] [PATCH edk2-platforms [Changes Suggested by Leif]] Silicon/NXP : Add support for Watchdog driver

Installs watchdog timer arch protocol Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/Drivers/WatchDog/WatchDog.c | 422 +++ Silicon/NXP/Drivers/WatchDog/WatchDog.h | 46 +++

[edk2] [PATCH edk2-platforms [Changes Suggested by Leif]] Watchdog Driver Patch

Replace Mmio R/W functions with function pointer as these can be little or big endian for Watchdog device. Meenakshi Aggarwal (1): Silicon/NXP : Add support for Watchdog driver Silicon/NXP/Drivers/WatchDog/WatchDog.c | 422 +++

Re: [edk2] [PATCH v1 1/4] BaseTools: remove duplicate function name

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 12, 2018 7:08 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1

Re: [edk2] [PATCH v1 3/4] BaseTools: Remove un-needed list comprehension

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 12, 2018 7:08 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1