[edk2] [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue

2018-09-14 Thread Ming Huang
When some type raid cards is not healthy, such as Broadcom 3108/3508 raid card, board will enter endless loop in BmRepairAllControllers() and can't show configuration formset which need to repair raid card. DriverHealthManagerDxe is added to platform dsc/fdf, driver health manager menu can show dr

[edk2] [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue

2018-09-14 Thread Ming Huang
When some type raid cards is not healthy, such as Broadcom 3108/3508 raid card, board will enter endless loop in BmRepairAllControllers() and can't show configuration formset which need to repair raid card. Ming Huang (1): MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue .../Ue

[edk2] [RFC MdeModulePkg/UefiBootManagerLib v1 0/1] Fix raid card repair fail issue

2018-09-14 Thread Ming Huang
When some type raid cards is not healthy, such as Broadcom 3108/3508 raid card, board will enter endless loop in BmRepairAllControllers() and can't show configuration formset which need to repair raid card. Ming Huang (1): MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue .../Ue

[edk2] [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue

2018-09-14 Thread Ming Huang
When some type raid cards is not healthy, such as Broadcom 3108/3508 raid card, board will enter endless loop in BmRepairAllControllers() and can't show configuration formset which need to repair raid card. DriverHealthManagerDxe is added to platform dsc/fdf, driver health manager menu can show dr

Re: [edk2] Missing ‘or’ in CLA

2018-09-14 Thread Henri Yandell
Thanks Michael. Should I read the text as a logical OR or an AND? ie) does EDK2 feel the current text is unchanged in effect from the Apache ICLA or that the text is intentionally changed in effect from the Apache ICLA so that both clauses apply on each contribution? Thanks, Hen On Fri, Sep 14

[edk2] Updating/adding video mode

2018-09-14 Thread prabin ca
Hi Team, I’m working with a platform having UHD (3840X2160as native resolution) display screen. I have dump the video modes using EFI_GRAPHICS_PROTOCOL. Following are the dump result Mode 0 : hRes = 3840 Vres=2160 Mode 1 : hRes = 640 Vres = 480 Mode 2 : hRes = 800 Vres = 600 Mode 3 : hRes = 10

Re: [edk2] Missing ‘or’ in CLA

2018-09-14 Thread Kinney, Michael D
Hi Hen, Thanks for the feedback. After review, we do not think this change is required. If there are other reasons to update the agreement in the future, we can include this update at that time. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On

Re: [edk2] Missing ‘or’ in CLA

2018-09-14 Thread Henri Yandell
Apologies for the nudge. I was wondering if anyone had had a chance to ponder this? Thanks, Hen On Mon, Sep 3, 2018 at 2:44 PM Henri Yandell wrote: > > > On Mon, Sep 3, 2018 at 4:08 AM Leif Lindholm > wrote: > >> On Fri, Aug 31, 2018 at 09:30:31PM +0200, Laszlo Ersek wrote: >> > On 08/31/18 0

Re: [edk2] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error

2018-09-14 Thread Laszlo Ersek
On 09/14/18 09:11, Jian J Wang wrote: >> v2 >> a. Refine the error message >> b. Use CpuDeadLoop to replace ASSERT(FALSE) for release build > > BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1165 > > HOB gEfiAcpiVariableGuid is a must have data for S3 resume if > PcdAcpiS3Enable is set t

[edk2] How do I access Prefetchable Memory region through EFI_PCI_IO_PROTOCOL

2018-09-14 Thread Kirkendall, Garrett
Hopefully someone can help me understand. I assume I should be able to access MMIO pointed to by a PCI devices Prefetchable Memory BAR. I would think I would use EFI_PCI_IO_PROTOCOL.Mem.Read or Write. This in turn will send the request up to EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL.Mem.Read or Write.

Re: [edk2] [staging/UEFIPayload]: Creating a new feature branch UEFIPayload in edk2-staging

2018-09-14 Thread Kinney, Michael D
Hi Benjamin, Once this work is complete would the CoreBoot*Pkgs be removed from edk2/master and the UefiPayloadPkg added? In order to remove the Readme.md conflict, I recommend cloning edk2 and edk2-statging into different directories and use PACKAGES_PATH for the build to see packages from both

[edk2] [PATCH v1] BaseTools/GenFds: remove function parameter

2018-09-14 Thread Jaben Carsey
Currently __GetAprioriSection has a parameter default to {}, which is incorrect. Since the parameter is updated in the function but not used and none of the callers of the function pass in a dictionary that is later used, just remove the parameter entirely. Cc: Yonghong Zhu Cc: Liming Gao Cc: Bo

[edk2] [staging/UEFIPayload]: Creating a new feature branch UEFIPayload in edk2-staging

2018-09-14 Thread You, Benjamin
Hi, A new feature branch "UEFIPayload" is being created in edk2-staging. UEFI Payload (UefiPayloadPkg) aims to be an upgrade to CorebootModulePkg and CorebootPayloadPkg UEFI Payload has some new features: * Supporting Slim Bootloader in addition to Coreboot * Source level configuration using .

[edk2] [Patch] BaseTool: Replace dict with OrderedDict.

2018-09-14 Thread BobCF
Replace dict with OrderedDict for PCD so that the pcd list has same order. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/GenFds/FdfParser.py | 7 +++-- .../Python/Workspace/BuildClassObject.py | 11 --- ...

Re: [edk2] [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-14 Thread Laszlo Ersek
I've got some comments on the code as well: On 09/14/18 07:13, Jian J Wang wrote: > BZ#1116: https://bugzilla.tianocore.org/show_bug.cgi?id=1116 > > Currently IA32_EFER.NXE is only set against PcdSetNxForStack. This > confuses developers because following two other PCDs also need NXE > to be set,

Re: [edk2] [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-14 Thread Laszlo Ersek
On 09/14/18 08:50, Wang, Jian J wrote: > Ard, > >> Why? Is it unreasonable to protect the stack but not other >> EfiBootServicesData regions? > > I think you got me wrong. It's reasonable to protect stack but not > other EfiBootServicesData regions. What I want to express in the > commit message is

[edk2] [Patch] Vlv2TbltDevicePkg: Switch to BDS of MdeModulePkg

2018-09-14 Thread Guo, Mang
Provide a MACRO to select which BDS to use. If BDS_MDE_SUPPORT is true, BDS of MdeModulePkg will be used. The default value of this MACRO is true. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang Cc: Michael D Kinney Cc: David Wei --- .../Include/Guid/PttPTPInst

[edk2] [PATCH] MdePkg: Add a inf path in MdePkg.dsc

2018-09-14 Thread shenglei
DxeRuntimeDebugLibSerialPort.inf is missing in MdePkg.dsc. So add the path into it. https://bugzilla.tianocore.org/show_bug.cgi?id=1177 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdePkg/MdePkg.dsc | 2 +- 1 file chang

Re: [edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Subramanian, Sriram
Reviewed-by: Sriram Subramanian -Original Message- From: Wang Fan [mailto:fan.w...@intel.com] Sent: Friday, September 14, 2018 1:54 PM To: edk2-devel@lists.01.org Cc: subraman...@mx0b-002e3701.pphosted.com; Subramanian, Sriram ; Ye Ting ; Fu Siyuan ; Wu Jiaxin Subject: [Patch v2] Netw

[edk2] [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wang Fan
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1152 v2: Sync the same logic to Ipv6 and update code comments. The PXE driver installs a SNP and open this SNP with attribute BY_DRIVER to avoid it being opened by MNP driver, this SNP is also expected not to be opened by other drivers with EXCL

Re: [edk2] [Patch] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wang, Fan
Thanks, Shiram, I missed that. Best Regards Fan -Original Message- From: Subramanian, Sriram [mailto:srira...@hpe.com] Sent: Friday, September 14, 2018 4:05 PM To: Wang, Fan ; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: RE: [edk2] [Patch] NetworkPkg: UefiPxe

Re: [edk2] [Patch] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Subramanian, Sriram
1. We need to update the comments as well: // // Open SNP on the child handle BY_DRIVER. It will prevent any additionally // layering to perform the experiment. // 2. PxeBcCreateIp6Children() will also need to follow the same logic, in my opinion. Thanks, Sriram. -Original M

Re: [edk2] [Patch] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Friday, September 14, 2018 3:39 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [edk2] [Patch] NetworkPkg: UefiPxeBcDxe:

[edk2] [Patch] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute when opening SNP protocol installed by PXE.

2018-09-14 Thread Wang Fan
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1152 The PXE driver installs a SNP and open this SNP with attribute BY_DRIVER to avoid it being opened by MNP driver, this SNP is also expected not to be opened by other drivers with EXCLUSIVE attribute. In some cases, other drivers may happen to

[edk2] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: move InitSmmS3Cr3() into else block

2018-09-14 Thread Jian J Wang
> v2: >Move InitSmmS3Cr3() into 'else' block because it needs to access >SmmS3ResumeState BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1165 InitSmmS3Cr3 () will update SmmS3ResumeState so moving the calling of it into else block to keep the logic consistency. Cc: Star Zeng Cc: Be

[edk2] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error

2018-09-14 Thread Jian J Wang
> v2 > a. Refine the error message > b. Use CpuDeadLoop to replace ASSERT(FALSE) for release build BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1165 HOB gEfiAcpiVariableGuid is a must have data for S3 resume if PcdAcpiS3Enable is set to TRUE. Current code in CpuS3.c doesn't embody this

[edk2] [PATCH V2 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error

2018-09-14 Thread Jian J Wang
> v2 > a. refine the error message to be more useful > b. improve the code logic BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1165 HOB gEfiAcpiVariableGuid is a must have data for S3 resume if PcdAcpiS3Enable is set to TRUE. Current code in CpuS3.c doesn't embody this strong binding be