Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2018-12-28 Thread Gao, Liming
Lin: Thanks for your verification. This issue has been fixed in the latest version of https://github.com/lgao4/edk2/tree/Python3. Could you try again? Thanks Liming >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: Friday, December 28, 2018 6:40 PM >To: Gao, Liming >C

Re: [edk2] [patch] MdeModulePkg/NonDiscoverable: Use compare operator for comparison

2018-12-28 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Bi, Dandan > Sent: Friday, December 28, 2018 4:54 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Wu, Hao A > Subject: [patch] MdeModulePkg/NonDiscoverable: Use compare operator for > comparison > > REF: https://bugzilla.tian

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2018-12-28 Thread Gary Lin
On Tue, Dec 25, 2018 at 07:50:43AM +, Gao, Liming wrote: > Hi, all > On Python3 migration https://bugzilla.tianocore.org/show_bug.cgi?id=55, we > update Edk2 BaseTools python source code with the compatible syntax to > support Python2 and Python3 both. Here is code > https://github.com/lga

Re: [edk2] edk2-devel@lists.01.org

2018-12-28 Thread wang xiaofeng
Just add more information, If I comment the OBJCOPY in of Static-Library-File in build_rule , the error will disapper, but I am not sure whether any side effort to remove objcopy? [Static-Library-File] *.lib $(MAKE_FILE) $(DEBUG_DIR)(+)$(MODULE_NAME)

[edk2] [patch] MdeModulePkg/NonDiscoverable: Use compare operator for comparison

2018-12-28 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1422 According to EDK II C Coding Standards Specification, Non-Boolean comparisons must use a compare operator. This patch is to update the code to follow EDKII coding style. Cc: Jian J Wang Cc: Hao Wu Contributed-under: TianoCore Contribution

[edk2] [patch] BaseTools/VfrCompile: report error for Integer overflow

2018-12-28 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1415 When an integer constant specified in the .vfr file is too large for the varstore field it is being used with, the VFR compiler reports an overflow warning like this: Test.vfr(693): WARNING: Overflow: Value 1024 is too large to stor