Re: [edk2] [Patch] BaseTools: report error for same Guid's Private definition conflict

2016-11-22 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Saturday, November 19, 2016 5:21 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: report error for

Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS

2016-11-23 Thread Gao, Liming
Ard: Which AArch64 platforms? I will investigate it further. Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, November 23, 2016 6:09 PM > To: Gao, Liming <liming@intel.com> > Cc: edk2-devel-01 <

Re: [edk2] [patch 0/4] MdeModulePkg: Don't support password without interactive flag

2016-11-23 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Thursday, November 17, 2016 10:24 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Dong, Eric <eric.d...@intel.com>; > Yao, Jie

Re: [edk2] [PATCH v2] MdeModulePkg/DriverSample: Remove the password related codes

2016-11-23 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, November 23, 2016 4:42 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Dong, Eric <eric.d...@intel.com>; > Yao, Jie

Re: [edk2] [Patch] BaseTools: Fix bug for decimal value of VPDPCD offset display in report

2016-11-24 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, November 24, 2016 11:23 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: Fix bug for decimal va

Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS

2016-11-27 Thread Gao, Liming
Ard: I root cause the issue, and provide the fix. Could you help integrate it? Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 24, 2016 4:04 PM > To: Gao, Liming <liming@intel.com> > Cc

Re: [edk2] [Patch] MdePkg Base.h: Add add comments on __ prefix in enum VERIFY_UINTXX_ENUM_SIZE

2016-11-16 Thread Gao, Liming
Got you. I will update comments and push this change. From: Kinney, Michael D Sent: Thursday, November 17, 2016 12:47 AM To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [Patch] MdePkg Base.h: Add

Re: [edk2] [Patch] MdePkg/BaseMemoryLib: Fix VS2015 build error

2016-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Kinney, Michael D Sent: Thursday, November 17, 2016 10:04 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Gao, Liming <liming@intel.com> Subject: [Patch] MdePkg/

Re: [edk2] [patch 0/4] MdeModulePkg: Use SHA256 algorithm for password encoding

2016-11-16 Thread Gao, Liming
@lists.01.org Cc: Gao, Liming <liming@intel.com>; Dong, Eric <eric.d...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Justen, Jordan L <jordan.l.jus...@i

Re: [edk2] [Patch] MdeModulePkg HiiDatabase: Remove extra memory initialization.

2016-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Dong, Eric > Sent: Tuesday, November 15, 2016 10:29 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Bi, Dandan <dandan...@intel.com> > Subject: [Pat

Re: [edk2] [PATCH V2 0/3] HobLib: Check FV alignment when building FV HOB

2016-11-15 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 16, 2016 10:18 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; > Gao, L

Re: [edk2] [PATCH] BaseTools/BuildEnv: Do not modify the env 'PACKAGES_PATH' in BuildEnv

2016-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Wu, Hao A > Sent: Wednesday, November 16, 2016 4:47 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Gao, Liming <liming@intel.com>; > Zhu, Yonghon

Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console

2016-11-17 Thread Gao, Liming
Lin: Please run . edksetup.sh --reconfig to reset your local configure files. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Friday, November 18, 2016 11:43 AM > To: Gao, Liming <li

Re: [edk2] EDK2 master build failure

2016-11-17 Thread Gao, Liming
In Misc.py, it import string class. But, in the same directory, there is source file String.py. Seemly, python interpreter wrongly imports String.py and cause this issue. This issue may happen on the case insensitive file system. We meet with such issue before. We set up virtual machine on

Re: [edk2] [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile

2016-11-17 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Friday, November 18, 2016 3:35 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch v2 0/3] MdePkg/BaseSynchronizationLi

Re: [edk2] [Patch] BaseTools/Scripts: Add BinToPcd utility

2016-11-13 Thread Gao, Liming
;|VOID*|20 gEfiNt32PkgTokenSpaceGuid.PcdWinNtGop|L"UGA Window 1!UGA Window 2"|VOID*|52 Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Friday, November 11, 2016 8:14 AM To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists

Re: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb

2016-11-15 Thread Gao, Liming
, 2016 12:25 AM To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming, The current patch would ignore .exe in BaseTools/Bin S

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile for mNumberToFinish

2016-11-15 Thread Gao, Liming
com>; Yao, Jiewen <jiewen@intel.com>; Tian, Feng <feng.t...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com> Subject: RE: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile for mNumberToFinish Laszlo, I agree to separate a

Re: [edk2] [PATCH 1/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro

2016-11-15 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeremy Linton Sent: Tuesday, November 15, 2016 5:10 AM To: edk2-devel@lists.01.org Cc: steve.cap...@arm.com; leif.lindh...@linaro.org; ry

Re: [edk2] [PATCH 29/33] SecurityPkg: Fix typos in comments

2016-11-13 Thread Gao, Liming
Lin: We don't plan to clean up all existing codes with EDKII DEBUG_ macros. We expect DEBUG_ macro will be applied with other change together. So, I propose to add this check in PatchCheck.py script. You only need to update your changed lines. Thanks Liming > -Original Message- >

Re: [edk2] [Patch v2] BaseTools/Scripts: Add BinToPcd utility

2016-11-13 Thread Gao, Liming
Mike: There is one minor issue in help message. -m is not only used with --type VPD. -m MAXSIZE, --max-size MAXSIZE Maximum size of the PCD. Only used with --type VPD. Other are good to me. Reviewed-by: Liming Gao <liming@intel.com> Thanks

Re: [edk2] [Patch] BaseTools: Fix a bug for tooldef class not include the newly Env

2016-10-31 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Friday, October 28, 2016 12:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: Fix a bug for tooldef cla

Re: [edk2] [Patch 0/3] BaseTools: Replace hardcoding VS path in tools_def.template

2016-10-31 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, October 28, 2016 12:44 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/3] BaseTools: Replace hardcoding V

Re: [edk2] [Patch] BaseTools: Fix the bug for OptionRom generation with different arch

2016-10-31 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zhu, Yonghong Sent: Wednesday, October 19, 2016 5:11 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: [Patch] BaseTools: Fix the bug for OptionRom generation with dif

Re: [edk2] [Patch] BaseTools: Fix a bug for ExpandMacros to support mixed case ENV var

2016-11-01 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Friday, October 28, 2016 12:43 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@

Re: [edk2] [Patch] QuarkSocPkg/Library: Remove extra UefiBaseType.h includes

2016-10-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Kinney > Sent: Thursday, October 27, 2016 11:15 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] Qua

Re: [edk2] [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib

2016-11-02 Thread Gao, Liming
0x Thanks Liming > -Original Message- > From: Song, BinX > Sent: Thursday, November 03, 2016 9:31 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [PATCH] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in > Bas

Re: [edk2] [PATCH V3] MdePkg/BaseLib: Move CHAR_NULL definition to Base.h in BaseLib

2016-11-02 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Song, BinX > Sent: Thursday, November 03, 2016 10:33 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [PATCH V3] MdePkg/BaseLib: Move CHAR_NULL def

Re: [edk2] [PATCH v3] MdePkg/BaseMemoryLib*: check for zero length in ZeroMem ()

2016-11-04 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Friday, November 04, 2016 5:05 PM > To: edk2-devel@lists.01.org; Kinney, Michael D > <micha

Re: [edk2] [PATCH v2] MdePkg/BaseMemoryLibOptDxe: check for zero length in ZeroMem ()

2016-11-03 Thread Gao, Liming
<michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com> > Cc: ler...@redhat.com; Carsey, Jaben <jaben.car...@intel.com>; Ard > Biesheuvel <ard.biesheu...@linaro.org> > Subject: [PATCH v2] MdePkg/BaseMemoryLibOptDxe: check for zero length > in ZeroMem ()

Re: [edk2] [PATCH 3/3] MdeModulePkg/DxeIplPeim: UINTN used wrongly for EFI_PHYSICAL_ADDRESS

2016-11-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Friday, November 04, 2016 10:19 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Gao, Liming <liming@intel.com>; > Kinney, M

Re: [edk2] [Patch] BaseTools: Add the support for character '<' and '>' in the map file

2016-11-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Friday, November 04, 2016 8:30 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: Add the support for char

Re: [edk2] [PATCH 0/4] Defer 3rd party images loading to after EndOfDxe

2016-11-03 Thread Gao, Liming
Ray: Seemly, PlatformBdsLib library instance should call EfiBootManagerDispatchDeferredImages(), right? Are there patches to update PlatformBdsLib library instance? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni >

Re: [edk2] [Patch] BaseTools: Fix the bug to support generate FFS by Align = Auto

2016-11-03 Thread Gao, Liming
o:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, November 03, 2016 9:58 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [edk2] [Patch] BaseTools: Fix the bug to support generate FFS by > Align = Auto >

Re: [edk2] [Patch] BaseTools: Fix the Windows GCC Build Failure with too long path

2016-11-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, November 03, 2016 6:32 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@

Re: [edk2] [PATCH 3/3] MdeModulePkg/DxeIplPeim: UINTN used wrongly for EFI_PHYSICAL_ADDRESS

2016-11-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Friday, November 04, 2016 10:19 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Gao, Liming <liming@intel.com>; > Kinney, M

Re: [edk2] [PATCH V5 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

2016-11-01 Thread Gao, Liming
vel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com> Subject: RE: [PATCH V5 06/12] SignedCapsulePkg/Capsu

Re: [edk2] [PATCH] MdeModulePkg/FrameBufferBltLib: Change module type to UEFI_DRIVER

2016-11-02 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Song, BinX Sent: Wednesday, November 2, 2016 10:12 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: [PATCH] MdeModulePkg/FrameBufferBltLib: Change module type to UEFI_DR

Re: [edk2] [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char check

2016-11-02 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Song, BinX Sent: Wednesday, November 2, 2016 10:09 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: [PATCH] EdkCompatibilityPkg/PrintLite: Fix ErrorPrint() wrong NULL char

Re: [edk2] [PATCH] MdePkg/BaseLib: Re-define CHAR_NULL in BaseLib

2016-11-02 Thread Gao, Liming
Bin: I suggest move CHAR_NULL definition from Protocol\SimpleTextIn.h to Base.h Thanks Liming -Original Message- From: Song, BinX Sent: Wednesday, November 2, 2016 4:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: [PATCH] MdePkg/BaseLib: Re-

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Gao, Liming
Tim: The first parameter in AsciiPrint() is the Format string. Per PrintLib.h definition, \n will be changed to \r\n in the format string. The following end of line(EOL) translations must be performed on the contents of the format string: - '\\r' is translated to '\\r' - '\\r\\n'

Re: [edk2] [[patch]] UefiCpuPkg/Cpuid: Remove wrong while-loop check after for-loop

2016-10-14 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Friday, October 14, 2016 3:04 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com&

Re: [edk2] [PATCH v3 1/5] MdePkg/GraphicsInfoHob: Add GraphicsDeviceInfo HOB GUID and structure

2016-10-10 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Monday, October 10, 2016 10:35 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [PATCH v3 1/5] MdePkg/GraphicsInfoHob: Add

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2016-10-16 Thread Gao, Liming
Bhupesh: In this patch, five class APIs are new added. They are MmioReadBe16(),MmioWriteBe16(),MmioClearSetBe16(),MmioSetBitsBe16(),MmioClearBitsBe16(). In fact, they can map to the existing MMIO APIs. Below is their mapping. And, I understand some hardware uses little-endian MMIO interfaces,

Re: [edk2] [Patch] BaseTools: Update sign tool to make MonotonicCount *after* Payload

2016-10-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Yao, Jiewen > Sent: Friday, October 14, 2016 9:11 PM > To: Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject:

Re: [edk2] [PATCH V2 39/50] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

2016-10-12 Thread Gao, Liming
tel.com>; Zeng, Star <star.z...@intel.com>; Gao, Liming <liming@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com> Subject: RE: [PATCH V2 39/50] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF. Yes. I will do that once BaseTool binary is updated. From: Kinney,

Re: [edk2] [PATCH] MdePkg/BaseLib: Remove the unnecessary '_' before library APIs in ASM/NASM

2016-10-17 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Wu, Hao A Sent: Monday, October 17, 2016 7:22 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel

Re: [edk2] [Patch] BaseTools: fix the bug to add PaletteSize info into AutoGen

2016-11-29 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, November 29, 2016 7:41 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: fix the bug to add

Re: [edk2] [PATCH] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-11 Thread Gao, Liming
Per coding style document, 5.1.1 Lines shall be 120 columns, or less. So, I suggest to add report line size for line with 120+ characters. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daniil Egranov > Sent: Friday, December 09, 2016

Re: [edk2] [PATCH 0/1] Use the Windows Kits directory in 32-bit ProgramFiles, since none exists in 64-bit one

2016-12-12 Thread Gao, Liming
Rebecca: Please use VS2015x86 tool chain tag when windows is 64bit. VS2015 tool chain tag is used for 32bit windows. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Rebecca Cran > Sent: Tuesday, December 13, 2016 10:33 AM

Re: [edk2] $ escape sequence at build_rule.txt

2016-12-13 Thread Gao, Liming
> To: af...@apple.com; Zhu, Yonghong <yonghong....@intel.com>; Gao, > Liming <liming@intel.com> > Cc: edk2-devel@lists.01.org <edk2-de...@ml01.01.org> > Subject: RE: [edk2] $ escape sequence at build_rule.txt > > Hi Andrew, > > in the meantime I

Re: [edk2] [PATCH v5] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-13 Thread Gao, Liming
016 10:15 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; leif.lindh...@linaro.org > Subject: [edk2] [PATCH v5] BaseTools/Scripts/PatchCheck.py: Extended > patch style check for c code > > Corrected code checking for multi-line and commented lines. Both

Re: [edk2] [PATCH 0/4] Fix GCC build warnings for BaseTools

2016-12-15 Thread Gao, Liming
Heyi: Thanks for your fix. The patch 1~3 are good to me. The patch 4 is not necessary. We can disable this warning like other C tools. I will provide the patch for it. For the remaining C tool issue, we will look it. ../support/set/set.c:557:2: warning: format ā€˜%dā€™ expects argument of type

Re: [edk2] [PATCH v6] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-15 Thread Gao, Liming
rce) :fprintf(f, "#define zzSET_SIZE %lu\n", NumWords(TokenNum-1)*sizeof(unsigned)); Thanks Liming > -Original Message- > From: Daniil Egranov [mailto:daniil.egra...@arm.com] > Sent: Friday, December 16, 2016 11:09 AM > To: edk2-devel@lists.01.org > Cc: l

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

2016-12-14 Thread Gao, Liming
o Ersek <ler...@redhat.com>; Bruce Cran <br...@cran.org.uk>; > edk2-devel (edk2-devel@lists.01.org) <edk2-de...@ml01.01.org> > Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Gao, > Liming <liming@intel.com> > Subject:

Re: [edk2] correct way to reserve memory from PrePi?

2016-12-14 Thread Gao, Liming
Michael: I understand your usage that BuildResourceDescriptorHob adds system memory range, BuildMemoryAllocationHob allocate the full memory range as reserved memory. Then, you expect they can be shown in EFI memory map. Right? BuildResourceDescriptorHob() with (start,size)

Re: [edk2] correct way to reserve memory from PrePi?

2016-12-14 Thread Gao, Liming
age- > From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] > Sent: Thursday, December 15, 2016 1:02 PM > To: Gao, Liming <liming@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; edk2-devel@lists.01.org > <edk2-de...@ml01.01.org>; Zeng, St

Re: [edk2] [Patch 1/2] MdeModulePkg SmmIpl: Fill Smram range for SMM driver when LMFA enable

2016-12-11 Thread Gao, Liming
Agree. Thanks! > -Original Message- > From: Zeng, Star > Sent: Friday, December 09, 2016 6:20 PM > To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com> > Subject:

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Gao, Liming
Thursday, January 12, 2017 9:51 AM >To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org >Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Justen, Jordan L ><jordan.l.jus...@intel.com>; Singh, Brijesh <brijesh.si...@amd.com>; Fan, >Jeff <jef

Re: [edk2] [PATCH v3 00/10] IoLib class library

2017-01-14 Thread Gao, Liming
Leo: Thanks for your update. I have no other comments. Reviewed-by: Liming Gao <liming@intel.com> Thanks Liming -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, January 14, 2017 4:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-10 Thread Gao, Liming
org] On Behalf Of Leo Duran Sent: Wednesday, January 11, 2017 7:56 AM To: edk2-devel@lists.01.org Cc: brijesh.si...@amd.com; Justen, Jordan L <jordan.l.jus...@intel.com>; Gao, Liming <liming@intel.com>; Leo Duran <leo.du...@amd.com>; Kinney, Michael D <michael.d.kin...@intel

Re: [edk2] [PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file

2017-01-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Maurice Ma >Sent: Tuesday, January 10, 2017 11:33 AM >To: edk2-devel@lists.01.org >Cc: Agyeman, Prince <prince.agye...

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-10 Thread Gao, Liming
Jeff: This patch moves source files from UefiCpuPkg to MdePkg. .asm and .nasm are not new added ones. So, I suggest to keep them. Thanks Liming -Original Message- From: Fan, Jeff Sent: Wednesday, January 11, 2017 9:45 AM To: Gao, Liming <liming@intel.com>; Leo Duran &

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-10 Thread Gao, Liming
nal Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Duran, Leo Sent: Wednesday, January 11, 2017 11:37 AM To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Justen, Jordan L <jordan.

Re: [edk2] [PATCH] MdeModulePkg DxeCorePerformanceLib: Only support linking with DxeCore

2017-01-12 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Thursday, January 12, 2017 4:29 PM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Gao, Liming <limin

Re: [edk2] FDF file syntax question?

2017-01-12 Thread Gao, Liming
Andrew: So, this requests not to set FV size same to FD region size when this FV is placed into FD region. I think one way to do it. In [FD] section, FILE statement is used to point to the generated XXX.Fv image. And, [FV] section includes this FV block size and base address, but no block

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-09 Thread Gao, Liming
>Sent: Monday, January 09, 2017 10:23 PM >To: Gao, Liming <liming@intel.com>; Justen, Jordan L ><jordan.l.jus...@intel.com>; 'Laszlo Ersek' <ler...@redhat.com>; edk2- >de...@lists.01.org >Cc: Singh, Brijesh <brijesh.si...@amd.com>; Fan, Jeff <jeff..

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Gao, Liming
puIo driver to base on IoLib to implement FifoIo APIs. Thanks Liming -Original Message- From: Duran, Leo [mailto:leo.du...@amd.com] Sent: Thursday, January 12, 2017 12:29 AM To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Gao, Liming
...@lists.01.org] On Behalf Of Duran, Leo Sent: Thursday, January 12, 2017 9:35 AM To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; Singh, Brijesh <brijesh.si..

Re: [edk2] [Patch] BaseTools: Support QuotedString for PREBUILD/POSTBUILD in DSC file

2016-12-01 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zhu, Yonghong Sent: Wednesday, November 30, 2016 4:24 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: [Patch] BaseTools: Support QuotedString for PREBUILD/POSTBUILD

Re: [edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

2016-12-01 Thread Gao, Liming
Hao: Place move UnicodeStrLen() and Unicode2AsciiString() implementation before main() function. If so, they are not required to be declared again. Other changes are good. Reviewed-by: Liming Gao <liming@intel.com> Thanks Liming -Original Message- From: Wu, Hao A

Re: [edk2] [Patch] BaseTools: Fix the bug to parse the new map file format

2016-12-01 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zhu, Yonghong Sent: Wednesday, November 30, 2016 4:23 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com> Subject: [Patch] BaseTools: Fix the bug to parse the new map file for

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-04 Thread Gao, Liming
, 2016 1:59 AM To: Anthony PERARD <anthony.per...@citrix.com> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Gao, Liming <liming@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

2016-11-30 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, December 01, 2016 1:20 AM To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> Cc: Wu, Hao A <hao.a...@intel.com>;

Re: [edk2] [Patch] MdeModulePkg PiSmmCore: Update comments in InitializeMemoryServices

2016-12-01 Thread Gao, Liming
Got it. I will keep comment "Need add Free memory at first, to let gSmmMemoryMap record data". -Original Message- From: Yao, Jiewen Sent: Thursday, December 01, 2016 3:41 PM To: Gao, Liming <liming@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@int

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

2016-12-01 Thread Gao, Liming
To: Anthony PERARD <anthony.per...@citrix.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: edk2-de...@ml01.01.org Subject: Re: [edk2]

Re: [edk2] [Patch] BaseTools: not report error for the optional items in the FmpTokens

2017-01-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, January 04, 2017 1:15 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: not report error for the op

Re: [edk2] [Patch] BaseTools: fix the bug for Mixed Pcd display in the report

2017-01-03 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Friday, December 30, 2016 3:48 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: fix the bug for Mixed Pcd displa

Re: [edk2] [Patch] BaseTools: Fix the bug for RAW file alignment value support

2016-12-29 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, December 27, 2016 6:06 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@

Re: [edk2] [PATCH] MdePkg/UefiFileHandleLib: Refine the check for valid Ascii character

2017-01-08 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Wu, Hao A >Sent: Friday, January 06, 2017 4:50 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A <hao.a...@intel.com>; Gao, Liming <liming@intel.com>; >Kinney, Michael D &

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-08 Thread Gao, Liming
md.com] >Sent: Sunday, January 08, 2017 1:17 AM >To: Justen, Jordan L <jordan.l.jus...@intel.com>; 'Laszlo Ersek' ><ler...@redhat.com>; Gao, Liming <liming@intel.com>; edk2- >de...@lists.01.org >Cc: Singh, Brijesh <brijesh.si...@amd.com>; Fan,

Re: [edk2] [Patch] MdePkg/Include: Add include file to FileHandleLib.h

2017-01-08 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Michael Kinney >Sent: Monday, January 09, 2017 12:48 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] MdePkg/I

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

2017-01-08 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Michael Kinney >Sent: Monday, January 09, 2017 1:00 PM >To: edk2-devel@lists.01.org >Cc: Tian, Feng <feng.t...@int

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-05 Thread Gao, Liming
leo.du...@amd.com] >Sent: Friday, January 06, 2017 5:49 AM >To: edk2-devel@lists.01.org >Cc: brijesh.si...@amd.com; ler...@redhat.com; Justen, Jordan L ><jordan.l.jus...@intel.com>; Fan, Jeff <jeff@intel.com>; Kinney, Michael >D <michael.d.kin...@intel.com>;

Re: [edk2] [Patch] BaseTools: Correct bin wrappers for GenDepex.py path

2016-12-18 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Monday, December 19, 2016 11:30 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Subject: [Patch] BaseTools: Correct bin

Re: [edk2] How to build commonlib of Basetools in x64 mode

2016-12-22 Thread Gao, Liming
...@apple.com] Sent: Friday, December 23, 2016 12:54 PM To: wang xiaofeng <winggundu...@163.com>; Gao, Liming <liming@intel.com> Cc: edk2-devel <edk2-devel@lists.01.org> Subject: Re: [edk2] How to build commonlib of Basetools in x64 mode On Dec 22, 2016, at 8:39 PM, Gao, Liming <

Re: [edk2] How to build commonlib of Basetools in x64 mode

2016-12-22 Thread Gao, Liming
Xiaofeng: BaseTools Windows Makefile (BaseTools\Source\C\Makefile) sets ARCH = IA32. It means BaseTools C tool passes IA32 arch only in Windows OS. I don't try building it with X64 arch. You can update ARCH=X64, and try building BaseTools with 64bit VS compiler. If you meet with warning or

Re: [edk2] FDF Spec question?

2016-12-22 Thread Gao, Liming
)/MyPackage/MyNewType/Binary/newform.bin } Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Andrew Fish > Sent: Thursday, December 22, 2016 9:38 AM > To: Gao, Liming <liming@intel.com> > Cc: edk2-devel

Re: [edk2] [PATCH v2 1/6] MdePkg/BaseLib: Refine (Ascii)StrnLenS functions logic

2016-12-21 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Wu, Hao A > Sent: Friday, December 16, 2016 11:38 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Yao, Jiewen <jiewen@intel.com>; > Gao, Liming <l

Re: [edk2] [PATCH] BaseTools/Pccts: Resolve GCC sting format mismatch build warning

2016-12-21 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Wu, Hao A > Sent: Thursday, December 22, 2016 9:32 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Gao, Liming <liming@intel.com>; > Zhu, Yonghon

Re: [edk2] FDF Spec question?

2016-12-21 Thread Gao, Liming
Fish Sent: Thursday, December 22, 2016 1:29 AM To: Gao, Liming <liming@intel.com> Cc: edk2-devel <edk2-devel@lists.01.org> Subject: Re: [edk2] FDF Spec question? > On Dec 21, 2016, at 6:27 AM, Gao, Liming <liming@intel.com> wrote: > > Andrew: > Encapsulati

Re: [edk2] [PATCH v7] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

2016-12-19 Thread Gao, Liming
lists.01.org > Cc: leif.lindh...@linaro.org; Gao, Liming <liming@intel.com>; Daniil > Egranov <daniil.egra...@arm.com> > Subject: [PATCH v7] BaseTools/Scripts/PatchCheck.py: Extended patch style > check for c code > > Changed output format to make it more com

Re: [edk2] [Patch] BaseTools: Fix build failure for DynamicEx Pcd used in the Library

2017-03-26 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, March 22, 2017 9:45 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [Patch] BaseTools: Fix build failure for Dyna

Re: [edk2] [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library

2017-03-26 Thread Gao, Liming
Behalf Of >Laszlo Ersek >Sent: Saturday, March 25, 2017 1:09 AM >To: Zeng, Star <star.z...@intel.com>; Ard Biesheuvel ><ard.biesheu...@linaro.org>; Kinney, Michael D ><michael.d.kin...@intel.com>; af...@apple.com >Cc: Tian, Feng <feng.t...@intel.com>; Gao, Lim

Re: [edk2] [RFC] GLOBAL_REMOVE_IF_UNREFERENCED, multiply defined symbols, and MSFT/GCC tool chains.

2017-03-26 Thread Gao, Liming
Felix: This changes the default MSFT build behavior. It will impact all platforms even if this platform has no requirement to pass GCC build. I suggest to update platform DSC to enable it in MSFT tool chain if this platform needs to support MSFT and GCC both. In Base.h: I agree to define

Re: [edk2] [PATCH V2] BaseTools: Update Brotli and BrotliCompress mode and format

2017-03-30 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: Song, BinX >Sent: Thursday, March 30, 2017 4:23 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming <liming@intel.com> >Subject: [PATCH V2] BaseTools: Update Brotli and BrotliC

Re: [edk2] [PATCH 0/4] MdeModulePkg/BaseTools: Add Brotli algorithm support

2017-03-29 Thread Gao, Liming
Michasel: Please delete cache Conf/tools_def.txt, and run edksetup again to apply new tools_def.txt. Thanks Liming >-Original Message- >From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] >Sent: Thursday, March 30, 2017 5:04 AM >To: Gao, Liming <liming@intel

Re: [edk2] [PATCH v3] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-03-29 Thread Gao, Liming
t;Cc: Leo Duran <leo.du...@amd.com>; Kinney, Michael D ><michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com>; Brijesh >Singh <brijesh.si...@amd.com> >Subject: [PATCH v3] MdePkg: BaseIoLibIntrinsic (IoLib class) library > >This patch adds an SEV-spec

Re: [edk2] [PATCH 0/4] MdeModulePkg/BaseTools: Add Brotli algorithm support

2017-03-29 Thread Gao, Liming
Michael: Thanks for point. I will create the patch to fix 2&3. For 1, I am not sure whether there is generic way to handle it. Thanks Liming >-Original Message- >From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] >Sent: Thursday, March 30, 2017 1:13 PM >To: Gao

Re: [edk2] [PATCH] MdeModulePkg/PeiCore: avoid EFI_IMAGE_MACHINE_TYPE_SUPPORTED to check arch

2017-03-29 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Monday, March 27, 2017 8:22 PM >To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.

<    3   4   5   6   7   8   9   10   11   12   >