Re: [edk2] [PATCH 1/3] ArmPlatformPkg: PL061: fix accessing GPIO DATA

On Tue, 2015-08-18 at 10:45 +0200, Ard Biesheuvel wrote: On 18 August 2015 at 10:39, Haojian Zhuang haojian.zhu...@linaro.org wrote: // All bits low except one bit high, restricted to 8 bits // (i.e. ensures zeros above 8bits) But '' is wrong at here. It'll only return 1 or 0

[edk2] [PATCH v3 0/3] support multiple PL061 gpio controllers

. * Support multiple PL061 gpio controllers in one platform. v2: * Append the patch to fix gpio pin mask macro. Haojian Zhuang (3): ArmPlatformPkg: PL061: fix accessing GPIO DATA EmbeddedPkg: enhance for multiple gpio controllers ArmPlatformPkg: PL061: support multiple controller

[edk2] [PATCH 3/3] ArmPlatformPkg: PL061: support multiple controller

Support multiple PL061 controllers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c| 107 ++--- .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3

[edk2] [PATCH 2/3] EmbeddedPkg: enhance for multiple gpio controllers

EmbeddedGpio only supports one gpio controller in one platform. Now create PLATFORM_GPIO_CONTROLLER to support multiple gpio controllers in one platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- EmbeddedPkg

[edk2] [PATCH v4 3/3] ArmPlatformPkg: PL061: support multiple controller

-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c| 137 +++-- .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 1 + ArmPlatformPkg/Include/Drivers/PL061Gpio.h | 47 --- 3 files changed, 125 insertions(+), 60

[edk2] [PATCH v4 2/3] EmbeddedPkg: enhance for multiple gpio controllers

EmbeddedGpio only supports one gpio controller in one platform. Now create PLATFORM_GPIO_CONTROLLER to support multiple gpio controllers in one platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- EmbeddedPkg

[edk2] [PATCH v4 0/3] support multiple PL061 gpio controllers

controllers in one platform. v2: * Append the patch to fix gpio pin mask macro. Haojian Zhuang (3): ArmPlatformPkg: PL061: fix accessing GPIO DATA EmbeddedPkg: enhance for multiple gpio controllers ArmPlatformPkg: PL061: support multiple controller ArmPlatformPkg/Drivers/PL061GpioDxe

[edk2] [PATCH] ArmPlatformPkg: Bds: delete BootNext when fail

of this message until overflow. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Bds/Bds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ArmPlatformPkg/Bds/Bds.c b/ArmPlatformPkg/Bds/Bds.c

[edk2] [PATCH v2 2/2] ArmPlatformPkg: PL061: fix accessing gpio value

to be read as 0, regardless of their value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPlatformPkg

Re: [edk2] [PATCH] ArmPlatformPkg: PL061: fix accessing gpio value

On Tue, 2015-08-11 at 09:42 +0200, Ard Biesheuvel wrote: On 11 August 2015 at 09:11, Haojian Zhuang haojian.zhu...@linaro.org wrote: The way of accessing PL061 GPIODATA register is wrong. The spec said in below. In order to write to GPIODATA, the corresponding bits in the mask

[edk2] [PATCH] ArmPlatformPkg: PL061: fix accessing gpio value

to be read as 0, regardless of their value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhu...@linaro.org --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPlatformPkg

Re: [edk2] Variable Storage Driver

Haojian Thanks for the sharing. May I know if you have validated variable set in UEFI runtime? I found it is marked as DXE driver instead of RUNTIME driver. But maybe I am wrong. Thank you Yao Jiewen -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org

Re: [edk2] Armv8 64bit: System error booting linux from the UEFI

On 11 November 2015 at 08:20, Vladimir Olovyannikov wrote: > Hello, > > I am not sure this is the right forum to ask this question, so I am sorry in > advance if this is an offtopic here (please point me to the proper one). > > I brought up UEFI on the device and am trying

[edk2] [PATCH 2/2] ArmPkg: Bds: tranverse handles for fv file

BdsConnectAndUpdateDevicePath() won't set right handle if device path is file path or memory mapped. Now try to tranverse all handles for FvFile in Fv. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPkg/Library/

[edk2] [PATCH 1/2] ArmPkg: Bds: check path first for supporting fs

in file system. Now check the device path first. If it's not file path in file system, return directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPkg/Library/BdsLib/BdsFilePath.c | 8 +--- 1 file changed, 5 inse

[edk2] [PATCH 0/2] Fix FvFile in ARM BDS

Fix to load Fv file from UEFI image. Haojian Zhuang (2): ArmPkg: Bds: check path first for supporting fs ArmPkg: Bds: tranverse handles for fv file ArmPkg/Library/BdsLib/BdsFilePath.c | 143 1 file changed, 80 insertions(+), 63 deletions(-) -- 1.9.1

Re: [edk2] [RFC 0/3] Rework the pl061 driver for better readability

在 02/10/2016 11:55 PM, Leif Lindholm 写道: Apologies to Haojian for not giving any feedback on his set of significant improvements to the pl061 GPIO controller driver. I found myself unable to review his modifications due to the complexity of the original driver, so I decided to refactor it ...

[edk2] [PATCH 9/9] MmcDxe: expand to support multiple blocks

Make use of DMA to transfer multiple blocks at one time. It could improve the performance on MMC/SD driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h| 6 + Embed

[edk2] [PATCH 7/9] MmcDxe: Fix uninitialized mediaid for SD

When SD card is used, mediaid is not initialized and used directly. So fix it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 ++- 1 file changed, 6 insertions

[edk2] [PATCH] EmbeddedPkg/AndroidFastboot: fix size with 64bit

Since there's percentage calcution, multiply on 32bit variable will cause overflow. So fix the variables as 64bit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhangfei Gao <zhangfei@linaro.org> Signed-off-by: Haojian Zhuang <haojian.zhu...@l

[edk2] [PATCH 2/2] EmbeddedPkg: FastbootUsb: add string descriptors

Support both manufacturer and product string descriptors. Otherwise, the manufacturer and product sub nodes won't be created in sysfs directory of linux host. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- .../D

[edk2] [PATCH 0/2] fix the index in usb string descriptor

Set the right value of Manufacturer, Product and SerialNumber in usb string descriptor. Haojian Zhuang (2): EmbeddedPkg: FastbootUsb: set serial number as 3 EmbeddedPkg: FastbootUsb: add string descriptors .../Drivers/AndroidFastbootTransportUsbDxe/FastbootTransportUsb.c | 6 +++--- 1

[edk2] [PATCH 1/2] EmbeddedPkg: FastbootUsb: set serial number as 3

Set serial number as 3. If the serial number is 0, fastboot won't load real serial number from descriptor at all. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- .../Drivers/AndroidFastbootTransport

[edk2] [PATCH] ArmVExpressFastBoot: Add support for sparse Images

Riku Voipio <riku.voi...@linaro.org> Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- .../ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 58 -- .../Include/Protocol/AndroidFastbootPlatform.h | 26 ++ 2 files changed, 81 insertions(+), 3 deletion

Re: [edk2] [PATCH 0/9] enhance mmc

On 2016/2/27 4:38, Leif Lindholm wrote: Hi Haojian, On Fri, Feb 26, 2016 at 05:27:47PM +0800, Haojian Zhuang wrote: * Wait OCR busy bit free according to eMMC spec. * Define ECSD structure. * Add interface to set IO bus width and speed. * Support to access multiple blocks

Re: [edk2] [PATCH 1/2] ArmPkg: Bds: check path first for supporting fs

On 01/15/2016 10:29 AM, Haojian Zhuang wrote: BdsFileSystemSupport() checks Handle first before validating device path of file. There's the potential issue at here. BdsConnectAndUpdateDevicePath() will skip to locate handle if it's file or memory mapped. Then BdsFileSystemSupport() tries

[edk2] [PATCH v5 2/2] ArmPlatformPkg: PL061: support multiple controller

-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c| 141 - .../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 1 + ArmPlatformPkg/Include/Drivers/PL061Gpio.h | 46 --- 3 files changed, 129 insertions(

[edk2] [PATCH v5 1/2] EmbeddedPkg: enhance for multiple gpio controllers

EmbeddedGpio only supports one gpio controller in one platform. Now create PLATFORM_GPIO_CONTROLLER to support multiple gpio controllers in one platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- Embed

[edk2] [PATCH v5 0/2] support multiple PL061 gpio controllers

structure in embedded gpio. * Support multiple PL061 gpio controllers in one platform. v2: * Append the patch to fix gpio pin mask macro. Haojian Zhuang (2): EmbeddedPkg: enhance for multiple gpio controllers ArmPlatformPkg: PL061: support multiple controller ArmPlatformPkg/Drivers

Re: [edk2] [PATCH v5 2/2] ArmPlatformPkg: PL061: support multiple controller

在 03/14/2016 09:19 PM, Leif Lindholm 写道: On Mon, Mar 14, 2016 at 01:30:37PM +0800, Haojian Zhuang wrote: Support multiple PL061 controllers. If platform gpio driver couldn't be found, PL061 gpio driver will continue to load PcdPL061GpioBase as the register base. It could be compatible

[edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. It's not formal code. And it needs to be updated later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h

[edk2] [PATCH v2 9/9] MmcDxe: expand to support multiple blocks

Make use of DMA to transfer multiple blocks at one time. It could improve the performance on MMC/SD driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h| 6 + Embed

[edk2] [PATCH v2 1/9] MmcDxe: wait OCR busy bit free

According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy bit is '0', CMD1 should be sent and OCR should be fetched again. And add a timeout counter on the repeated steps. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.

[edk2] [PATCH v2 4/9] MmcDxe: add interface to change io width and speed

By default, MMC is initialized with 1-bit mode and less than 400KHz bus clock. It causes MMC working inefficiently. Add the interface to change the bus width and speed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.

[edk2] [PATCH v2 6/9] MmcDxe: set io bus width before reading EXTCSD

Set io bus width on both MMC controller and EXTCSD. Otherwise, it may cause unmatched failure case. And support more timing mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- E

[edk2] [PATCH v2 5/9] MmcDxe: declare ECSD structure

Declare fields in ECSD structure. And drop the original 128 words arrary. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 157 ++- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 4 +- 2 files change

[edk2] [PATCH v2 3/9] MmcDxe: add SPEC_VERS field in CSD structure

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe

[edk2] [PATCH v2 2/9] MmcDxe: move ECSD into CardInfo structure

Since ECSD also describes the information of card, move it into structure CardInfo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 + EmbeddedPkg/Universal/

[edk2] [PATCH v2 7/9] MmcDxe: Fix uninitialized mediaid for SD

When SD card is used, mediaid is not initialized and used directly. So fix it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 ++- 1 file changed, 6 insertions

[edk2] [PATCH v2 0/9] enhance mmc

bus width and speed. * Support to access multiple blocks. Haojian Zhuang (9): MmcDxe: wait OCR busy bit free MmcDxe: move ECSD into CardInfo structure MmcDxe: add SPEC_VERS field in CSD structure MmcDxe: add interface to change io width and speed MmcDxe: declare ECSD structure MmcDxe

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

On 5 April 2016 at 02:54, Ard Biesheuvel wrote: > On 4 April 2016 at 19:17, Ryan Harkin wrote: >> Hi Haojian, >> >> I've had time to investigate where TC2 is hanging with your patches >> applied and narrowed it down to the single line of code

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

On 5 April 2016 at 11:25, Tian, Feng wrote: > Hi, HaoJian > > We newly added EDKII SD/MMC stack to EDKII repo. If the SD/MMC host > controller follows SD PCI host controller spec, the whole stack should work. > > But looks like PL180 doesn't follow the SD PCI host controller

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

On 5 April 2016 at 17:49, Ryan Harkin <ryan.har...@linaro.org> wrote: > On 5 April 2016 at 09:37, Ryan Harkin <ryan.har...@linaro.org> wrote: >> On 5 April 2016 at 03:57, Haojian Zhuang <haojian.zhu...@linaro.org> wrote: >>> On 5 April 2016 at 01:17, Ryan H

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

, You would have to have an override version as it doesn't follow SD/MMC specs. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Thursday, July 21, 2016 9:40 PM To: Ard Biesheuvel <ard.biesheu...@linaro.org>; C

Re: [edk2] Question on eMMC and SD driver

-Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday, July 21, 2016 12:04 PM To: Haojian Zhuang <haojian.zhu...@linaro.org> Cc: Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.org; Leif Lindholm <leif.lindh...@linaro.org>; Ard Biesh

Re: [edk2] Instance of library class [ArmMmuLib] is not found

On 2016/7/21 19:27, Ard Biesheuvel wrote: On 20 July 2016 at 07:44, Michael Zimmermann wrote: Hi, since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:

Re: [edk2] Instance of library class [ArmMmuLib] is not found

On 2016/7/21 19:27, Ard Biesheuvel wrote: On 20 July 2016 at 07:44, Michael Zimmermann wrote: Hi, since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file:

Re: [edk2] Question on eMMC and SD driver

C partition. So BlockVariableDxe is created to access variables on block devices. Thanks Feng -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Thursday, July 21, 2016 10:34 AM To: Tian, Feng <feng.t...@intel.com> Cc: Leif Lindholm <leif.lindh...@

[edk2] Question on eMMC and SD driver

Hi all, I have a few questions on eMMC/SD driver when I'm working on my driver. In my hikey platform, there's no PCI bus. So I create my own DwMmc driver to do the same thing as SdMmcPciHcDxe driver. There's one controller for eMMC and one controller for SD. 1. How to support both eMMC and

Re: [edk2] Question on eMMC and SD driver

在 07/21/2016 11:23 AM, Tian, Feng 写道: Hi, Haojian If there is no PCI bus, you could implement a fake one. Just like what we did at edk2\Omap35xxPkg\PciEmulation. Through this way, you can reuse SdMmcPciHc driver. Oh, your eMMC/SD IP is compatible SDHC. But Designware eMMC/SD IP isn't

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

On 2016/7/21 19:24, Ard Biesheuvel wrote: On 21 July 2016 at 13:17, Haojian Zhuang <haojian.zhu...@linaro.org> wrote: On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the desi

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

On 2016/7/21 9:52, Haojian Zhuang wrote: 在 07/21/2016 09:51 AM, Haojian Zhuang 写道: Hi Feng, I think the main difference is who to handle the CRC bits. In the designware emmc/sd controller, the whole 128-bit value is loaded into the four response registers. There's no any shift on the 128-bit

[edk2] [PATCH] EmmcBlockIo: fix to get CSD data

The CSD structure is a 128-bit structure. But EmmcGetCsd() only loads 120 bits with 8-bit offset. Now fix it. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[edk2] [PATCH 1/2] ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG

PL061_GPIO_DATA_REG offset is referenced in PL061EffectiveAddress () already. So remove the duplicated reference when invoke PL061GetPins () or PL061SetPins (). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPlatf

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function

On 13 February 2017 at 15:53, Haojian Zhuang <haojian.zhu...@linaro.org> wrote: > When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset) > as parameter, not offset. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojia

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG

On 13 February 2017 at 15:52, Haojian Zhuang <haojian.zhu...@linaro.org> wrote: > PL061_GPIO_DATA_REG offset is referenced in PL061EffectiveAddress () > already. So remove the duplicated reference when invoke PL061GetPins () > or PL061SetPins (). > > Contributed-under: T

[edk2] [PATCH v2 4/5] MdeModulePkg/UfsPassThruDxe: fix initialize OCS value to 0x0F

The OCS value should be initiliazed as 0x0F according to UFS spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Reviewed-by: Feng Tian <feng.t...@intel.com> --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci

[edk2] [PATCH v2 5/5] MdeModulePkg/UfsBlockIoPei: fix initialize OCS value to 0x0F

The OCS value should be initiliazed as 0x0F according to UFS spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeMod

[edk2] [PATCH v2 3/5] MdeModulePkg/UfsBlockIoPei: fix the bit in UFS_HC_UTRLDBR_OFFSET reg

When UPIU packet is sent, (BIT0 << Slot) should be set according to context. But BIT0 is used without Slot when UfsWaitMemSet () is invoked. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- MdeModulePkg/Bus/Ufs/U

[edk2] [PATCH v2 2/5] MdeModulePkg/UfsPassThruDxe: fix the bit in UFS_HC_UTRLDBR_OFFSET reg

When UPIU packet is sent, (BIT0 << Slot) should be set according to context. But BIT0 is used without Slot when UfsWaitMemSet () is invoked. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Reviewed-by: Feng

[edk2] [PATCH v2 0/5] fix UFS driver

v2: 1. Drop unnecessary patches. 2. Append fixes on UfsBlockIoPei driver. v1: 1. Fix issues in UFS driver. 2. Add PhyInit in UFS driver. 3. Add retry in ScsiDisk for UFS device. Haojian Zhuang (5): MdeModuelPkg/UfsPassThruDxe: fix to identify 32 bits address mode MdeModulePkg

[edk2] [PATCH v2 1/5] MdeModuelPkg/UfsPassThruDxe: fix to identify 32 bits address mode

When UFS_HC_CAP_64ADDR bit is set, it means 64-bit address, not 32-bit address. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Reviewed-by: Feng Tian <feng.t...@intel.com> --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsP

[edk2] [PATCH v3 05/10] MmcDxe: declare ECSD structure

Declare fields in ECSD structure. And drop the original 128 words arrary. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 157 ++- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 4 +- 2 files change

[edk2] [PATCH v3 04/10] MmcDxe: add interface to change io width and speed

By default, MMC is initialized with 1-bit mode and less than 400KHz bus clock. It causes MMC working inefficiently. Add the interface to change the bus width and speed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.

[edk2] [PATCH v3 01/10] MmcDxe: wait OCR busy bit free

According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy bit is '0', CMD1 should be sent and OCR should be fetched again. And add a timeout counter on the repeated steps. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.

[edk2] [PATCH v3 02/10] MmcDxe: move ECSD into CardInfo structure

Since ECSD also describes the information of card, move it into structure CardInfo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 + EmbeddedPkg/Universal/

[edk2] [PATCH v3 00/10] enhance mmc

spec. * Define ECSD structure. * Add interface to set IO bus width and speed. * Support to access multiple blocks. Haojian Zhuang (10): MmcDxe: wait OCR busy bit free MmcDxe: move ECSD into CardInfo structure MmcDxe: add SPEC_VERS field in CSD structure MmcDxe: add interface to chang

[edk2] [PATCH v3 03/10] MmcDxe: add SPEC_VERS field in CSD structure

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe

[edk2] [PATCH v3 06/10] MmcDxe: set io bus width before reading EXTCSD

Set io bus width on both MMC controller and EXTCSD. Otherwise, it may cause unmatched failure case. And support more timing mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- E

[edk2] [PATCH v3 09/10] MmcDxe: expand to support multiple blocks

Make use of DMA to transfer multiple blocks at one time. It could improve the performance on MMC/SD driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h| 6 + Embed

[edk2] [PATCH v3 10/10] PL180: update for indentifying SD

When CMD6 & ACMD51 are added into indentifying SD process, PL180 should also support CMD6 & ACMD51. Otherwise, it'll hang when system tries to read expected data. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 15

[edk2] [PATCH v3 07/10] MmcDxe: Fix uninitialized mediaid for SD

When SD card is used, mediaid is not initialized and used directly. So fix it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 ++- 1 file changed, 6 insertions

[edk2] [PATCH v3 08/10] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. It's not formal code. And it needs to be updated later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h

Re: [edk2] [PATCH] PL180: set variable length for CMD6 and ACMD51

On 8 November 2016 at 22:58, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Nov 08, 2016 at 12:37:12PM +, Ryan Harkin wrote: >> Hi Haojian, >> >> On 7 November 2016 at 15:49, Haojian Zhuang <haojian.zhu...@linaro.org> >> wrote: >> >

[edk2] [PATCH v4 10/11] PL180: update for indentifying SD

When CMD6 & ACMD51 are added into indentifying SD process, PL180 should also support CMD6 & ACMD51. Otherwise, it'll hang when system tries to read expected data. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 15

[edk2] [PATCH v4 08/11] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. It's not formal code. And it needs to be updated later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h

[edk2] [PATCH v4 01/11] MmcDxe: wait OCR busy bit free

According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy bit is '0', CMD1 should be sent and OCR should be fetched again. And add a timeout counter on the repeated steps. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.

[edk2] [PATCH v4 02/11] MmcDxe: move ECSD into CardInfo structure

Since ECSD also describes the information of card, move it into structure CardInfo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 + EmbeddedPkg/Universal/

[edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

Declare fields in ECSD structure. And drop the original 128 words arrary. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 157 ++- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 4 +- 2 files change

[edk2] [PATCH v4 03/11] MmcDxe: add SPEC_VERS field in CSD structure

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe

[edk2] [PATCH v4 04/11] MmcDxe: add interface to change io width and speed

By default, MMC is initialized with 1-bit mode and less than 400KHz bus clock. It causes MMC working inefficiently. Add the interface to change the bus width and speed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.

[edk2] [PATCH v4 06/11] MmcDxe: set io bus width before reading EXTCSD

Set io bus width on both MMC controller and EXTCSD. Otherwise, it may cause unmatched failure case. And support more timing mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- E

[edk2] [PATCH v4 07/11] MmcDxe: Fix uninitialized mediaid for SD

When SD card is used, mediaid is not initialized and used directly. So fix it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 ++- 1 file changed, 6 insertions

[edk2] [PATCH v4 11/11] PL180: set variable length for CMD6 and ACMD51

Since CMD6 & ACMD51 needs to read data size less than 512, proper variable length should be set. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 14 -- 1

Re: [edk2] [PATCH v4 00/11] enhance MMC

On 9 November 2016 at 01:32, Ryan Harkin <ryan.har...@linaro.org> wrote: > Hi Haojian, > > I've tested your v4 series. > > On 8 November 2016 at 15:21, Haojian Zhuang <haojian.zhu...@linaro.org> wrote: >> v4: >> * Fix PL180 hang in some cases. Since the

Re: [edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

On 9 November 2016 at 04:43, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Tue, Nov 08, 2016 at 11:21:10PM +0800, Haojian Zhuang wrote: >> Declare fields in ECSD structure. And drop the original 128 words >> arrary. > > Functionality-wise, I'm happy with this,

[edk2] [PATCH] PL180: set variable length for CMD6 and ACMD51

Since CMD6 & ACMD51 needs to read data size less than 512, proper variable length should be set. Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

[edk2] [PATCH v7 4/4] MmcDxe: expand to support multiple blocks

Make use of DMA to transfer multiple blocks at one time. It could improve the performance on MMC/SD driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- Embedde

[edk2] [PATCH v7 3/4] PL180: update for indentifying SD

When CMD6 & ACMD51 are added into indentifying SD process, PL180 should also support CMD6 & ACMD51. Otherwise, it'll hang when system tries to read expected data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> T

[edk2] [PATCH v7 2/4] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h |

[edk2] [PATCH v7 0/4] enhance MMC

to send ACMD51. v1: * Wait OCR busy bit free according to eMMC spec. * Define ECSD structure. * Add interface to set IO bus width and speed. * Support to access multiple blocks. Haojian Zhuang (4): MmcDxe: add interface to change io width and speed MmcDxe: set iospeed and bus wid

[edk2] [PATCH v7 1/4] MmcDxe: add interface to change io width and speed

mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h | 25 ++- EmbeddedPkg/Univer

[edk2] [PATCH v8 3/4] PL180: update for indentifying SD

When CMD6 & ACMD51 are added into indentifying SD process, PL180 should also support CMD6 & ACMD51. Otherwise, it'll hang when system tries to read expected data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Re

[edk2] [PATCH v8 1/4] MmcDxe: add interface in mmc host protocol

. And support more timing mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h | 31 +

[edk2] [PATCH v8 0/4] enhance MMC

us width and speed. * Support to access multiple blocks. Haojian Zhuang (4): MmcDxe: add interface in mmc host protocol MmcDxe: set iospeed and bus width in SD stack PL180: update for indentifying SD MmcDxe: expand to support multiple blocks ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c

[edk2] [PATCH v8 2/4] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h |

[edk2] [PATCH v8 4/4] MmcDxe: expand to support multiple blocks

Make use of DMA to transfer multiple blocks at one time. It could improve the performance on MMC/SD driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- Embedde

[edk2] [PATCH v6 1/4] MmcDxe: add interface to change io width and speed

mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h | 20 +++ EmbeddedPkg/Univer

[edk2] [PATCH v6 0/4] enhance MMC

OCR busy bit free according to eMMC spec. * Define ECSD structure. * Add interface to set IO bus width and speed. * Support to access multiple blocks. Haojian Zhuang (4): MmcDxe: add interface to change io width and speed MmcDxe: set iospeed and bus width in SD stack PL180

[edk2] [PATCH v6 2/4] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> Tested-by: Ryan Harkin <ryan.har...@linaro.org> --- EmbeddedPkg/Include/Protocol/MmcHost.h |

  1   2   3   4   >