ude\Register\.
>
> V3 changes includes:
> 1. Only change Patch 8 and 14 which changed MSR data structures.
> 2. Keep ReservedX not change if bit info not changed for this field.
series
Acked-by: Laszlo Ersek
Thanks!
Laszlo
___
edk2-devel mailing
On 09/21/18 20:15, poxyran wrote:
> Hello again,
>
> my question is: is it possible to create a SMM driver that
> installs/register a SMI handler (in order to call it from a usermode app
> in the OS) and test it in the UEFI Shell or do I need to setup up a
> dedicated machine with the SMM stack as
dge->MemAbove4G) || RESOURCE_VALID
> (Bridge->PMemAbove4G)) {
> return NULL;
>}
> }
>
Two superficial comments:
- edk2 prefers long parameter names, so I suggest replacing "R" in the
macro definition with "Resource"
- taking the paramete
ch is that, if any one of the first
three branches is taken, then the final checks will automatically pass.
That's because, on the first three branches, we select the base & the
limit *because* the access falls between them. Therefore, in the end,
when we check whether the access falls between base and end, they
miraculously happen to do so. :)
Reviewed-by: Laszlo Ersek
Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
e to be used
> // for checking
> //
> -if (Address + MultU64x32 (Count, Size) <= RootBridge->Mem.Limit + 1) {
> +if (Address + Length <= RootBridge->Mem.Limit + 1) {
>Base = RootBridge->Mem.Base;
>Limit = RootBridge->Mem.Limit;
> } else
> CpuSmmDebugEntryAbsAddr:
> callrax
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao
> Cc: Laszlo Ersek
> Cc: Eric Dong
> Cc: Jiewen Yao
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 42
>
2_EFER.NXE is only set against PcdSetNxForStack. This
>>> confuses developers because following two other PCDs also need NXE
>>> to be set, but actually not.
>>>
>>> PcdDxeNxMemoryProtectionPolicy
>>> PcdImageProtectionPolicy
>>>
>>&
On 09/21/18 10:44, Ni, Ruiyu wrote:
> On 9/21/2018 3:41 PM, Eric Dong wrote:
>> UINT32 User:1;
>> - UINT32 Reserved1:2;
>> + ///
>> + /// [Bit 4] PwrEvtEn.
>> + ///
>> + UINT32 PwrEvtEn:1;
>> + ///
>> + /// [Bit 5] FUPonPTW.
>> + ///
>> + UINT32 FUPonPTW:1;
>>
On 09/21/18 08:33, Wu, Jiaxin wrote:
> I agree we need document something to highlight that. Siyuan/Ting, if no
> objection, I will do that in separate patch instead of mixing with this new
> feature support.
That's a good idea (well, both: documenting the differences, and adding
the documentat
On 09/19/18 16:26, Samah Mansour wrote:
> Hello,
>
>
> Our product uses a Baytrail with Minnowboard Max bios firmware ( version
> 0.93). Every now and then we see SPI flash corruption due to power cuts
> while the unit is booting which causes the unit not to boot anymore. After
> investigation we
abilities.pdf
>
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Jiewen Yao
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Star Zeng
> Cc: Eric Dong
I'd like to test this series, but before I do that, I'll wait a bit
longer for
; https://software.intel.com/security-software-guidance/insights/host-firmware-speculative-execution-side-channel-mitigation
>
> Cc: Ard Biesheuvel
> Cc: Laszlo Ersek
> Cc: Jiewen Yao
> Cc: Michael D Kinney
> Cc: Liming Gao
> Contributed-under: TianoCore Contribution Agr
b. boot to shell on real intel platform with valid PCD setting combinations
> (IA32/X64)
> c. boot to fedora26, ubuntu18.04, windows 7 and windows 10 on OVMF emulated
> platform (X64)
>
> Cc: Star Zeng
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Ruiyu Ni
> Cc
On 09/20/18 07:54, Wu, Jiaxin wrote:
> Hi Laszlo,
>
> I agree there is no document to describe the detailed difference
> against the overlapped network drivers the between NetworkPkg and
> MdeModulePkg (except IPv4/IPv6 support ). We only declared that those
> drivers should not be used at the same
On 09/19/18 11:13, Wang, Jian J wrote:
> If no more new comments, I'll do following changes in v2, including review
> comments got so far:
>
> a. change ToEnableExecuteDisableFeature() to EnableNonExec()
> b. remove the ASSERT and DEBUG in current ToEnableExecuteDisableFeature()
> c. update dec/un
>
>> After the series:
>> - PXEv4: 48 seconds (~ 9728 KB/s)
>> - PXEv6: 60 seconds (~ 7782 KB/s)
>>
>> These measurements are very rough (I didn't run them multiple times
>> etc), but I think they are still quite good indicators.
>>
>
On 09/19/18 03:31, Wu, Jiaxin wrote:
>>> Subject: [Patch v2] NetworkPkg: UefiPxeBcDxe: Add EXCLUSIVE attribute
>> when opening SNP protocol installed by PXE.
>>>
>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1152
>>>
>>> v2: Sync the same logic to Ipv6 and update code comments.
>>>
>>> Th
ocal variable way, which was marked by static
>> code checker as an unsafe way.
>>
>> Cc: Dandan Bi
>> Cc: Hao A Wu
>> Cc: Eric Dong
>> Cc: Laszlo Ersek
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Jian J Wang
>&g
ways be created in advance.
>
> Cc: Dandan Bi
> Cc: Hao A Wu
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCpuPkg/CpuMpPei/CpuPaging.c | 3 +++
> 1 file changed, 3 insertio
ed by static
> code checker as an unsafe way.
>
> Cc: Dandan Bi
> Cc: Hao A Wu
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCpuPkg/CpuMpPei/CpuMpPei.h | 8
> UefiC
they are still quite good indicators.
For the testing, I used the UEFI boot options in UiApp, and not the
shell command, hence I have no feedback on patch #3.
For patches #1, #2, and #5:
Tested-by: Laszlo Ersek
However, as I pointed out elsewhere in the thread, I think:
- You might want
On 09/17/18 07:43, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886
>
> This patch is to define one new PCD for PXE driver to specify MTFTP
> windowsize so as
> to improve the PXE download performance. The default value is set to 4.
>
> Cc: Ye Ting
> Cc: Fu Siyuan
> C
On 09/14/18 10:50, Subramanian, Sriram wrote:
> Reviewed-by: Sriram Subramanian
>
> -Original Message-
> From: Wang Fan [mailto:fan.w...@intel.com]
> Sent: Friday, September 14, 2018 1:54 PM
> To: edk2-devel@lists.01.org
> Cc: subraman...@mx0b-002e3701.pphosted.com; Subramanian, Sriram
t is still
fact. If we keep those field names, but change the fields' meanings,
code will silently break. We should make the breakage explicit, by *not*
recycling names. Just delete the old names, and introduce brand new
ones.
To be clear, this refers to patches #8 and #14; I'm ready to ac
On 09/17/18 18:20, Duran, Leo wrote:
>
>> -Original Message-
>> From: Ni, Ruiyu
>> Sent: Thursday, September 13, 2018 11:44 PM
>> To: Duran, Leo ; Laszlo Ersek ;
>> edk2-devel@lists.01.org
>> Cc: Dong, Eric
>> Subject: Re: [edk2] [PATCH] U
would be a lot easier to code).
Thanks
Laszlo
>
>
> Thanks,
> Star
> -Original Message-----
> From: Wang, Jian J
> Sent: Monday, September 17, 2018 10:11 AM
> To: Laszlo Ersek ; edk2-devel@lists.01.org
> Cc: Zeng, Star ; Ard Biesheuvel
> ; Ni, Ruiyu ; Yao, Jiewen
Adding Ray, and a comment at the bottom:
On 09/14/18 20:24, Kirkendall, Garrett wrote:
> Hopefully someone can help me understand.
>
> I assume I should be able to access MMIO pointed to by a PCI devices
> Prefetchable Memory BAR. I would think I would use
> EFI_PCI_IO_PROTOCOL.Mem.Read or Wri
Hello Aurélien,
adding Thomas to the CC list, and commenting at the bottom:
On 09/15/18 18:36, Aurélien wrote:
> Hi,
>
> I don't know if it is the right place to report a bug, sorry if not.
>
> I'm a Promox user and the last version (5.2) has a package versionned
> 20180612-1 actually (
> https:
me if
> PcdAcpiS3Enable is set to TRUE. Current code in CpuS3.c doesn't
> embody this strong binding between them. An error message and
> CpuDeadLoop are added in this patch to warn platform developer
> about it.
>
> Cc: Star Zeng
> Cc: Benjamin You
> Cc: Er
otectionPolicy & (1 <
> PcdImageProtectionPolicy == 0 &&
> (PcdDxeNxMemoryProtectionPolicy & (1 <
> In other words, PcdSetNxForStack and PcdImageProtectionPolicy have
> priority over PcdDxeNxMemoryProtectionPolicy.
>
> Cc: Star Zeng
>
On 09/14/18 08:50, Wang, Jian J wrote:
> Ard,
>
>> Why? Is it unreasonable to protect the stack but not other
>> EfiBootServicesData regions?
>
> I think you got me wrong. It's reasonable to protect stack but not
> other EfiBootServicesData regions. What I want to express in the
> commit message is
On 09/13/18 14:27, Nikita Leshenko wrote:
>
>
>> On 11 Sep 2018, at 15:34, Laszlo Ersek wrote:
>>
>> "BasePciExpressLib" has the prefix "Base", meaning that it is supposed
>> to be usable in all types of firmware modules, even in SEC and PEIMs -
le by signature in different modules.
>
> This patch updates PiSmmCpuDxeSmm to use new
> EfiLocateFirstAcpiTable() and remove the duplicated code.
>
> Cc: Younas khan
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Eric Dong
&g
On 09/12/18 17:42, Gao, Liming wrote:
> Laszlo:
> Before commit e21e355e2ca7fefb15b4df7078f995d3fb9c2b89, jmp _SmiHandler is
> commented. And below code, ASM_PFX(CpuSmmDebugEntry) is moved into rax, then
> call it. But, this code doesn't work in XCODE5 tool chain. Like you say,
> XCODE5 doesn'
h like others to chime in too.)
Thanks
Laszlo
>
> I hope that helps explain what I'm after.
> Leo.
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Wednesday, September 12, 2018 4:55 AM
>> To: Duran, Leo ; edk2-devel@lists.01.org
>> Cc:
ution Agreement 1.1
> Signed-off-by: Liming Gao
> Cc: Laszlo Ersek
> Cc: Eric Dong
> Cc: Jiewen Yao
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 34
> +
> 1 file changed, 25 insertions(+), 9 deletions(-)
>
> diff --git a/Uef
nderstanding has been that it's not about enabling/disabling a CPU
feature, but about marking specific pages as non-executable. Under that
interpretation, it should be possible to mark pages used for stack
purposes as non-executable, and leave everything else executable, even
on x86.
Laszlo
>
easily.
>
> (3)How about log both of them? GUID value may be more friendly to log
> parser but
> a GUID name is more friendly to person.
>
> (4)Good idea. I’ll add it in v2.
Those work for me as well.
Thanks
Laszlo
> From: Laszlo Ersek [mailto:ler...@redhat.com]
&
h needs a separate BZ
> tracker?
Separate patch in the same series should be fine.
IMO the second patch can refer to the same BZ, or not even refer to any
BZ at all.
Thanks,
Laszlo
>
> Regards,
> Jian
>
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, Septembe
On 09/11/18 21:47, Duran, Leo wrote:
>
>
>> -Original Message-----
>> From: Laszlo Ersek
>> Sent: Tuesday, September 11, 2018 1:50 PM
>> To: Duran, Leo ; edk2-devel@lists.01.org
>> Cc: Eric Dong ; Ruiyu Ni
>> Subject: Re: [PATCH] UefiCpuPkg
On 09/11/18 17:41, Leo Duran wrote:
> The default behavior is to disable MTRRs prior to an MTRR change.
> However, on SMT platforms with shared CPU resources it may be desirable to
> skip the default behavior, and leave the current state of the Enable bit.
>
> Cc: Eric Dong
>
On 09/07/18 02:07, Robinson, Herbie wrote:
> This is a fix for a double cluster allocation when the disk is full. The
> double allocation happens because FatGrowEof calls FatAllocateCluster without
> immediately marking the each returned cluster as allocated. The fix is to
> move the FatSetFat
ace PcdSetNxForStack.
>
> Cc: Laszlo Ersek
> Cc: Star Zeng
> Cc: Jordan Justen
> Cc: Ard Biesheuvel
> Cc: Ruiyu Ni
> Cc: Jiewen Yao
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> OvmfPkg/PlatformPei/Platform.c |
On 09/04/18 15:43, Stephen Benjamin wrote:
> On Tue, Sep 4, 2018 at 7:02 AM Laszlo Ersek wrote:
>>
>> On 09/04/18 09:17, Jiaxin Wu wrote:
>>> This patch is to resolve the lock-up issue if the value of HTTP header
>>> is blank. The issue is recorded @
&
_PFX(gSmiHandlerIdtr)]
> learcx, [SmiHandlerIdtrAbsAddr]
> movqword [rcx - 8], rax
> -
> -learax, [_SmiHandler]
> -learcx, [_SmiHandlerAbsAddr]
> -movqword [rcx - 8], rax
> ret
>
Please remember to CC package maintainers / revi
Jian,
On 09/11/18 06:47, Jian J Wang wrote:
> BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1166
>
> Cc: Dandan Bi
> Cc: Hao A Wu
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCpuPkg/CpuMpPei/CpuPaging.c | 23 ---
>
An error message and
> ASSERT is added by this patch to warn platform developer about
> it.
>
> Cc: Star Zeng
> Cc: Benjamin You
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCp
Laszlo
>
>
> Thanks,
> Star
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, September 10, 2018 11:22 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; You, Benjamin ;
> Dong, Eric ; Laszlo Ersek
> Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm:
On 09/07/18 19:01, Liran Alon wrote:
>
>
>> On 7 Sep 2018, at 11:44, Laszlo Ersek wrote:
>>
>> (+Ard)
>>
>> On 09/06/18 21:08, Nikita Leshenko wrote:
>>> Hi,
>>>
>>> We ran into a bug in EDK2 relating to PCI-Express in PciBu
On 09/07/18 06:39, Ni, Ruiyu wrote:
> Reviewed-by: Ruiyu Ni
Commit 98257f982072.
Thanks
Laszlo
>> -Original Message-
>> From: edk2-devel On Behalf Of shenglei
>> Sent: Friday, September 7, 2018 9:52 AM
>> To: edk2-devel@lists.01.org
>> Cc: Carsey, Jaben ; Ni, Ruiyu
>> Subject: [edk2]
r (&IdtDescriptor);
>IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> -
> +
>Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
>ASSERT (Exception0StubHeader != NULL);
>CopyMem (
>
Reviewed-by: Laszlo Ersek
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
(+Ard)
On 09/06/18 21:08, Nikita Leshenko wrote:
> Hi,
>
> We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the
> flow
> of the bug:
>
> 1. PciBusDxe/PciEnumeratorSupport.c: Function BarExisted probes a BAR. It
> raises
>TPL to TPL_HIGH_LEVEL to avoid timer interrupts
yPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c
> | 27 +++
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c
> | 25 +++
> 4 files changed, 25 insertions(+), 101 deletions(-)
Reviewed-by: Laszlo Ersek
__
On 09/06/18 19:25, Ard Biesheuvel wrote:
> On 6 September 2018 at 18:47, Laszlo Ersek wrote:
>> For build-testing, I suggest
>>
>> build -p SecurityPkg/SecurityPkg.dsc ...
>>
>> It will build all SecurityPkg modules, without putting them in a flash
>> d
On 09/06/18 20:01, Carsey, Jaben wrote:
> We have a BZ to remove the compatibility package... I’d call updating it
> redundant and not worth your time.
Ah, very good point!
https://bugzilla.tianocore.org/show_bug.cgi?id=1103
Laszlo
___
edk2-devel mail
On 09/06/18 15:45, Ard Biesheuvel wrote:
> Now that Itanium support has been dropped, we can remove the various
> occurrences of the ELILO on Itanium PE/COFF header workaround.
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816
> Contributed-under: TianoCore Contribution Agreement 1.1
> S
On 09/06/18 15:45, Ard Biesheuvel wrote:
> Now that Itanium support has been dropped, we can remove the various
> occurrences of the ELILO on Itanium PE/COFF header workaround.
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816
> Contributed-under: TianoCore Contribution Agreement 1.1
>
OPTIONAL_HDR32_MAGIC)
> {
>//
>// Use PE32 offset
>//
> @@ -1721,7 +1681,6 @@ PeCoffLoaderRelocateImageForRuntime (
>CHAR8 *FixupData;
>UINTN Adjust;
>RETURN_STATUS Status;
> - UINT16 Magic;
>
>OldBase = (CHAR8 *)((UINTN)ImageBase);
>NewBase = (CHAR8 *)((UINTN)VirtImageBase);
> @@ -1750,9 +1709,7 @@ PeCoffLoaderRelocateImageForRuntime (
> return ;
>}
>
> - Magic = PeCoffLoaderGetPeHeaderMagicValue (Hdr);
> -
> - if (Magic == EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) {
> + if (Hdr.Pe32->OptionalHeader.Magic == EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) {
> //
> // Use PE32 offset
> //
>
Reviewed-by: Laszlo Ersek
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
nalHeader is
> EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC
> - // then override the returned value to
> EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC
> - //
> - if (Hdr.Pe32->FileHeader.Machine == IMAGE_FILE_MACHINE_IA64 &&
> Hdr.Pe32->OptionalHeader.Magic == EFI_IMAGE_NT_OPTIONAL_HDR32_M
he
error.)
Thanks
Laszlo
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
>> Biesheuvel
>> Sent: Thursday, September 6, 2018 8:31 PM
>> To: Laszlo Ersek
>> Cc: Carsey, Jaben ; Ni, Ruiyu ;
>>
On 09/06/18 12:28, Ard Biesheuvel wrote:
> On 9 August 2018 at 17:41, wrote:
>> The InvalidChars[] array is only used in function IsValidCommandName().
>> The array should be deleted also, I think.
>>
>
> Indeed, and for this reason this patch has now broken the build for
> clang. Please fix.
I
On 09/06/18 03:35, Zeng, Star wrote:
> Thanks for the quick following up. :)
>
> Reviewed-by: Star Zeng
Thanks! Commit b48ec0e8ab1c.
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Hi Eric,
On 09/05/18 09:57, Laszlo Ersek wrote:
> On 09/05/18 08:22, Eric Dong wrote:
>> Fix trailing white spaces and invalid line ending issue.
>>
>> Cc: Dandan Bi
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Eric Dong
>&g
On 09/06/18 08:10, prabin ca wrote:
> Hi Team,
>
> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a
> event handler. Event is created successfully and event handler is also called
> successfully, but I can capture the performance of this event handler with
> PerformanceP
On 09/06/18 04:34, Ni, Ruiyu wrote:
> On 9/6/2018 3:47 AM, Andrew Fish wrote:
>>
>> Laszlo,
>>
>> gEfiMemoryTypeInformationGuid is an edk2/MdeModulePkg concept used to
>> give the DXE Core hints on how to reduce fragmentation in the memory
>> map. Typically there is code in PEI that creates a HOB a
x27;t simple, extract it to a separate function.
Cc: Ruiyu Ni
Cc: Star Zeng
Suggested-by: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
Notes:
Repo: https://github.com/lersek/edk2.git
Branch: ehci_dbgport_in_use
MdeModulePkg/Bu
On 09/05/18 19:25, Leif Lindholm wrote:
> Hi all,
>
> (This is partly a summary of discussions that have been held on IRC
> and offline, with Alex Graf and Mike Kinney.)
>
> The UEFI Shell, as produced by the contents of ShellPkg, is needed for
> running the UEFI SCT. This has never been problemati
Hi Star,
On 09/05/18 11:55, Zeng, Star wrote:
> I agree to commit this patch first. Reviewed-by: Star Zeng
> to this patch.
>
> To further enhance with an abstracted function, how about like below?
>
> BOOLEAN
> EhcIsDebugPortInUse (
> IN CONST USB2_HC_DEV *Ehc,
> IN UINT8 *PortNum
On 09/05/18 12:55, Shi, Steven wrote:
>> Steven, can you confirm the patch fixes the issue you saw?
> Yes. The patch fixes my issue in
> https://bugzilla.tianocore.org/show_bug.cgi?id=1129 .
Thanks! I've added your Tested-by.
Pushed as commit c3d5d800d775.
I'll follow up with the EhcIsDebugPort
inconvenient. But, I agree
that given the current source code, that won't happen. I'll post another
patch for this.
Thanks!
Laszlo
>
> Thanks,
> Star
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, September 4, 2018 6:38 PM
;//
>// Allocate buffer for empty RegisterTable and PreSmmInitRegisterTable for
> all CPUs
> - //
> + //
>TableSize = 2 * NumberOfCpus * sizeof (CPU_REGISTER_TABLE);
>RegisterTable = AllocatePages (EFI_SIZE_TO_PAGES (TableSize));
>ASSERT (RegisterTable != NULL);
>
Reviewed-by: Laszlo Ersek
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 09/04/18 09:17, Jiaxin Wu wrote:
> This patch is to resolve the lock-up issue if the value of HTTP header
> is blank. The issue is recorded @
> https://bugzilla.tianocore.org/show_bug.cgi?id=1102.
>
> Cc: Stephen Benjamin
> Cc: Laszlo Ersek
> Cc: Ye Ting
> Cc:
bugPortInUse (Ehc, -1)
in EhcReset() and EhcDriverBindingStart(), and we can call
EhcIsDebugPortInUse (Ehc, PortNumber)
in EhcGetRootHubPortStatus().
What do you think?
... Anyway, I would like to append such a patch separately to the series
-- I'd like to keep the bugfix and the refac
nHandlerLib.inf | 4 +
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +-
> 8 files changed, 962 insertions(+), 18 deletions(-)
> create mode 100644 UefiCpuPkg/CpuMpPei/CpuPaging.c
>
Regression-tested-by: Laszlo Ersek
dification right
(that is, the condition is already correct); what it got wrong was the
negation of the condition, for EhcDriverBindingStart(). That's the only
thing we have to correct in this patch.
Thanks,
Laszlo
>
>
> Thanks,
> Star
> -Original Message-
> From: La
le by signature in different modules.
>
> This patch updates PiSmmCpuDxeSmm to use new
> EfiFindAcpiTableBySignature() and remove the duplicated code.
>
> Cc: Younas khan
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Eric Dong
&g
Mike,
On 08/31/18 01:58, Henri Yandell wrote:
> The CLA is missing an ‘or’ in section 3.
>
> See https://github.com/tianocore/edk2/pull/133/files for an example of the
> specific text.
could you please turn this report into a real patch (if the suggested
change is valid)? Technically it's easy e
3b2b5819
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek
---
Notes:
Repo: https://github.com/lersek/edk2.git
Branch: ehci_start_reset_1129
MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/
On 08/30/18 22:17, aaron.yo...@oracle.com wrote:
> We have encountered what we believe to be a regression in the
> OvmfPkg/VirtioNetDxe driver.
>
> This regression causes PXE boot to fail with the following ASSERT:
>
> ASSERT
> [VirtioNetDxe]/builddir/build/BUILD/ovmf-92d07e48907f/OvmfPkg/Vir
On 08/30/18 03:36, Gao, Liming wrote:
> EDK2 plans to retire EDK style packages. Below BZ requests to remove
> FatBinPkg, EdkShellPkg, EdkShellBinPkg and EdkCompatiblityPkg from edk2
> master. They can be replaced by Edk2 FatPkg, ShellBinPkg and ShellPkg.
> UnixPkg is an empty package. So, it is
16s boot time can be saved.
>
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> UefiCpuPkg/CpuDxe/CpuDxe.c | 2 +-
> UefiCpuPkg/CpuDxe/CpuPageTable.c | 4 ++--
> 2 files changed, 3 i
On 08/28/18 05:42, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
>
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
On 08/28/18 05:42, shenglei wrote:
> The PCD below is unused, so it has been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize
>
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On 08/28/18 05:42, shenglei wrote:
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
>
> Cc: Jaben Carsey
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Cont
ltOemTableId
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision
>
> Cc: Jiewen Yao
> Cc: Chao Zhang
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On 08/28/18 07:36, Star Zeng wrote:
> Add Jian J Wang and
> remove Eric Dong .
> Eric is focusing on UefiCpuPkg.
>
> Cc: Jian J Wang
> Cc: Eric Dong
> Cc: Michael D Kinney
> Cc: Laszlo Ersek
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Contributed-under: Tia
On 08/27/18 15:31, Zhu, Yonghong wrote:
> We have a bugzilla. https://bugzilla.tianocore.org/show_bug.cgi?id=55
> Current I am working on it. And planned to finish to migrate to Python 3
> before end of October.
Thank you!
Laszlo
___
edk2-devel mailing
On 08/27/18 13:53, heyi@linaro.org wrote:
> It is said that python3 is not compatible with python2.
Did you mean s/said/sad/? :)
> Can we use python3 to build edk2?
Gary and Mike wrote several BaseTools patches for python3 compatibility;
I'm unsure if we have a high-level tracker BZ for that
features until the next
stable tag, those URLs will get pretty tiresome to look at.
For the version that's currently visible in your clone:
Acked-by: Laszlo Ersek
Thanks!
Laszlo
> -Original Message-----
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, Augus
On 08/22/18 21:27, Joseph Edward Hemann wrote:
> Hello Laszlo,
> I have been trying to test measured boot using OVMF with swtpm and
> qemu, but I'm having issues.
>
> For EDK2 I'm using git commit 3a0c1bf64b5deaa4e227b31 (pulled Jul
> 31), building OVMF with
> build flags -DTPM2_ENABLE=TRUE -DSE
On 08/23/18 07:51, Haojian Zhuang wrote:
> Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
> the hotkey of boot option won't be registered correctly.
>
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore
On 08/23/18 08:40, Star Zeng wrote:
> Cc: Michael D Kinney
> Cc: Laszlo Ersek
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Dandan Bi
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng
> ---
> EDK-II-Release-Planning.md | 2 ++
>
On 08/22/18 18:34, Gao, Liming wrote:
> Reviewed-by: Liming Gao
Thanks!
> And, push at aa4e0df1f0c7ffdff07d7e382c9da89cbe207cdb
That's very kind of you! Thanks! :)
Laszlo
> Thanks
> Liming
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@
Hi Liming,
On 08/17/18 04:38, Laszlo Ersek wrote:
> In commit 81502cee20ac ("BaseTools/Source/C: take EXTRA_LDFLAGS from the
> caller", 2018-08-16), I missed that "VfrCompile/GNUmakefile" does not use
> BUILD_LFLAGS in the APPLICATION linking rule, unlike &
On 08/22/18 09:13, Wang, Jian J wrote:
> Hi Laszlo,
>
> Regards,
> Jian
>
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, August 21, 2018 10:59 PM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Dong, Eric
> Subject: Re: [edk2] [P
nsole so that
> the developer/QA can find that there's potential heap overflow or null
> pointer access occurred.
>
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
>
bit will be set in interrupted function context
> so that it can be triggered once the cpu control returns back to the
> instruction causing #PF and re-execute it.
>
> This is an necessary step to implement non-stop mode for Heap Guard
> and NULL Pointer Detection feature.
>
&
On 08/21/18 05:05, Jian J Wang wrote:
>> v2 changes:
>>fix GCC build error
>
> Background:
> Heap Guard and NULL Pointer Detection are very useful features to detect
> code flaw in EDK II. If an issue is detected, #PF exception will be
> triggered and the BIOS will enter into dead loop, which
On 08/21/18 03:35, shenglei wrote:
> The PCD below is unused, so it has been removed from inf.
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On 08/20/18 08:29, Li, Songpeng wrote:
> It worked on my end.
>
> Tested-by: Songpeng Li
Thank you!
Jiaxin, Siyuan, are you guys OK with this patch?
Thanks
Laszlo
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Friday, Aug
801 - 900 of 6352 matches
Mail list logo
