Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; F
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Tuesday, January 16, 2018 3:57 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan...@int
Series Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Wang, Fan
> Sent: Wednesday, January 10, 2018 11:16 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin...@intel.com>; Ye, Ting <ting...@intel.com>; Fu,
> Siyuan <
Hi Karunakar,
Please also report the issue on Bugzilla.
Thanks,
Jiaxin
From: Wu, Jiaxin
Sent: Saturday, January 20, 2018 2:37 PM
To: Karunakar P <karunak...@amiindia.co.in>; Ye, Ting <ting...@intel.com>; Fu,
Siyuan <siyuan...@intel.com>; 'edk2-devel@lists.01.org'
<ed
debug image hang when this API is called, this patch is to fix this issue.
Cc: Jiaxin Wu <jiaxin...@intel.com>
Cc: Fu Siyuan <siyuan...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wang Fan <fan.w...@intel.com>
Reviewed-by: Jiaxin Wu <jiaxin.
ailto:ler...@redhat.com]
> Sent: Thursday, January 25, 2018 12:13 AM
> To: Wu, Jiaxin <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ye,
> Ting <ting...@intel.com>; Long, Qin <qin.l...@intel.com>; Yao, Jiewen
> <jiewen@intel.com>; Hsiung, Har
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Wang, Fan
> Sent: Thursday, January 11, 2018 6:14 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Wu,
> Hao A <h
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Wang, Fan
> Sent: Thursday, January 11, 2018 6:20 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin...@intel.com>; Ye, Ting <ting...@intel.com>; Fu,
> Siyuan <
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, January 11, 2018 5:19 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Wang,
> Fan &l
vel@lists.01.org>
> Subject: Re: setting the TLS cipher list for HTTPS booting
>
> On 01/25/18 05:52, Wu, Jiaxin wrote:
> > Hi Laszlo,
> >
> > The HttpDxe driver needs to install the Driver Binding Protocol so as
> > to check if a specific controller is su
Leaving the variable up to the platform setting is good to me.
Mike,
If you have no comments, we will follow the variable solution.
Thanks,
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, February 5, 2018 6:47 PM
> To: Wu, Ji
Thanks the comment, I will refine the series patch.
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, February 9, 2018 1:23 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D
&g
Sure, I will update the wiki once the patch is committed.
Thanks
Jiaxin
> -Original Message-
> From: Li, Ruth
> Sent: Friday, February 9, 2018 3:08 PM
> To: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>;
> edk2-devel@lists.01.
Thanks Laszlo.
If no other comments, I will commit this patch by the end of today.
Best Regards!
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, February 13, 2018 3:56 AM
> To: Wu,
Hi Laszlo,
Can you help to report one Bugzilla for the new feature request? It's better to
describe the reason why we need support in Bugzilla.
Thanks,
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Sunday, February 11, 2018 11:15 AM
> To: edk2-devel@lists
rsek [mailto:ler...@redhat.com]
> Sent: Friday, February 9, 2018 6:12 PM
> To: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>;
> edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Zimmer, Vincent
> <vincent.zim...@intel.com>
Thanks Laszlo, I will integrate your comments into the new patch.
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, February 9, 2018 6:16 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
>
Thanks the comment, I will integrate it when I commit the patch.
> -Original Message-
> From: Ye, Ting
> Sent: Monday, February 12, 2018 11:06 AM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Laszlo Ersek <ler...@redhat.com>; Kinney,
Thanks to catch that.
Best Regards!
Jiaxin
> -Original Message-
> From: Gary Lin [mailto:g...@suse.com]
> Sent: Tuesday, December 26, 2017 9:56 AM
> To: Wu, Jiaxin <jiaxin...@intel.com>
> Cc: edk2-devel@lists.01.org; Ye, Ting <ting...@intel.com>; Wang, Fan
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
Please update the copyright before commit the patch.
Thanks,
Jiaxin
> -Original Message-
> From: Wang, Fan
> Sent: Tuesday, January 2, 2018 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.w...@intel.
Series Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu
> Siyuan
> Sent: Tuesday, January 2, 2018 1:28 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 0/5] Refi
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Wang, Fan
> Sent: Wednesday, January 3, 2018 10:32 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.w...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ye,
> Ting <
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Wang, Fan
> Sent: Wednesday, January 3, 2018 10:32 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.w...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ye,
> Ting <
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: Wang, Fan
> Sent: Wednesday, January 3, 2018 10:32 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.w...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Ye,
> Ting <
After talked with Siyuan, we agree to use the int 0-1 value instead of Boolean
type so as to keep the same coding style in TcpInput.c.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, December 27, 2017 11:03 AM
> To: Wu, Jiaxin <jiaxin...@intel.c
Thanks, Siyuan I will refine the commit log before apply the patch.
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, December 27, 2017 11:01 AM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.co
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Wednesday, December 27, 2017 11:23 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin...@
Hi Siva,
Thanks the report.
>From the code review, it does the problem for HTTP protocol to route the
>package over Internet.
But I'm confused with your patch that how can you get the RouterAddr since
there is no interface for HTTP protocol to get the RouterAddr?
> +
is quite simply even
than API did. What do you think?
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, August 1, 2018 10:06 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Laszlo Ersek
> Subject: RE: [Patch] NetworkPkg/HttpDxe: Stripp
Thanks Laszlo, I have refined the patch to v2 with your "Reviewed-by" tag.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, August 1, 2018 5:49 PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyu
01.org] On Behalf Of
> Sivaraman Nainar
> Sent: Saturday, August 4, 2018 5:46 PM
> To: Wu, Jiaxin ; Ye, Ting ; Laszlo
> Ersek ; edk2-devel@lists.01.org
> Subject: Re: [edk2] reg: HTTP Request Failure over Internet
>
> Hello Jiaxin,
>
> We have tried both the methods and b
Looks good to me.
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Li, Songpeng
> Sent: Monday, August 13, 2018 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH] NetworkPkg: Remove the redundant code and definition.
>
o:edk2-devel-boun...@lists.01.org] On Behalf Of
> Sivaraman Nainar
> Sent: Thursday, August 9, 2018 7:09 PM
> To: Wu, Jiaxin ; Ye, Ting ; Laszlo
> Ersek ; edk2-devel@lists.01.org
> Subject: Re: [edk2] reg: HTTP Request Failure over Internet
>
> Hello Jiaxin,
>
&
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: Li, Songpeng
> Sent: Monday, August 20, 2018 2:29 PM
> To: Laszlo Ersek ; edk2-devel-01 de...@lists.01.org>
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: RE: [PATCH 3/4] NetworkPkg/TlsAuthConfigDxe:
X, Mask: 255.255.255.255, NextHope: 0.0.0.0} }, if
so, looks the package will be sent to NextHope: 0.0.0.0?
>
> BestRegards
> Fu Siyuan
>
> > -Original Message-
> > From: Wu, Jiaxin
> > Sent: Tuesday, August 28, 2018 2:51 PM
> > To: Fu, Siyuan ; edk
0.0.0.0,NextHope: Gataway }
in instance route table, while it exists in default route table, the failure
will happen. So, we need update the code to handle such case.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, August 28, 2018 5:41 PM
> To: Wu, Jiaxi
28, 2018 9:53 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: [Patch 1/2] MdeModulePkg/Network: Add 32bit subnet mask
> support for IP4 PXE boot.
>
> This patch updates IP4 stack to support 32bit subnet mask in PXE boot
> process.
> When 32bit subn
Series Reviewed-by: Jiaxin Wu after dropping the patch
for TlsDxe.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Thursday, August 16, 2018 9:38 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/5]
Looks good with me.
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, July 19, 2018 4:51 AM
> To: edk2-devel-01
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 3/6] NetworkPkg/TlsAuth
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, August 28, 2018 9:53 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Ye, Ting ; Wu, Jiaxin
>
> Subject: [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit
> subnet mask
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, August 29, 2018 4:53 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: [PATCH v2] MdeModulePkg/Network: Add 32bit subnet mask
> support for IP4 PXE
Hi Laszlo,
> Jiaxin: I agree with the dynamic PCD solution for the CipherList
> setting, the PCD format can use as following one:
> gEfiNetworkPkgTokenSpaceGuid.PcdHttpsTlsCipherLists
> >>> |{0x0}|VOID*|0x000D
> If the platform wants to set the below CipherSuites (RFC
Hi Laszlo,
After the discussion with team member, we still prefer to use the PCD solution.
In HttpDxe driver, we don't want to locate/use a nonstandard protocol. We think
It's not a general solution for the UEFI driver.
Thanks,
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
Hi Laszlo,
More comments:
>
> Dynamic PCDs is just one of the solutions for the required settings, just
> like the
> platform protocol (HTTPS_CONFIG_PROTOCOL), provides the capability to
> support the global HTTPS configuration.
>
> Each solutions have its own advantages and disadvantages:
>
>
> Hello Jiaxin, Siyuan,
>
> it seems that the "preferred set of ciphers" can be controlled at the
> TLS session level.
Jiaxin: Yes, TLS CipherList can be configured by TLS protocol.
>
> With regard to HTTPS booting, "NetworkPkg/HttpDxe" makes several calls
> to
Hi Karunakar,
You should sent out the attached patches for the review:).
Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
Thanks,
Jiaxin
From: Karunakar P [mailto:karunak...@amiindia.co.in]
Sent: Wednesday, January 17, 2018 6:29 PM
To: Wu, Jiaxin <jiaxin...@intel.com>; Ye, Ting <ti
> >>
> >> Hello Jiaxin, Siyuan,
> >>
> >> it seems that the "preferred set of ciphers" can be controlled at the
> >> TLS session level.
> >
> >
> > Jiaxin: Yes, TLS CipherList can be configured by TLS protocol.
> >
> >
> >>
> >> With regard to HTTPS booting, "NetworkPkg/HttpDxe" makes several
>
Hi Laszlo,
In the commit log of patch 0001, "EFI_TLS_CA_CERTIFICATE_VARIABLE" should be
"EDKII_HTTP_TLS_CIPHER_LIST_VARIABLE".
Others looks good to me.
Series Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
Thanks,
Jiaxin
> -Original Message-
>
t; Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Gary Ching-Pang Lin
> <g...@suse.com>; Wu, Jiaxin <jiaxin...@intel.com>; Justen, Jordan L
> <jordan.l.jus...@intel.com>; Gao, Liming <liming@intel.com>; Kinney,
> Michael D <michael.d.kin...@intel.com>; Long
It's good to me with new coming series patches:).
Thanks,
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 11, 2018 4:06 AM
> To: Long, Qin <qin.l...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>;
> edk2-devel-
Series Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
Thanks,
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, March 23, 2018 12:39 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Wu, Jiaxin <jiaxin...@
Reviewed-by: Wu Jiaxin <jiaxin...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Monday, March 26, 2018 10:10 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan...@int
Hi Laszlo,
Insert my comments as below:
> The nested loops that parse the signature list in TlsConfigCertificate()
> currently ignore the contents of the following fields:
> - EFI_SIGNATURE_LIST.SignatureType,
> - EFI_SIGNATURE_DATA.SignatureOwner.
>
> I'd like the generator / extractor tool
, March 2, 2018 9:24 AM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.w...@intel.com>; Ye, Ting <ting...@intel.com>
> Subject: RE: [Patch] MdeModulePkg/Mtftp4Dxe: Restore the TPL before the
> poll function.
>
> Jiaxin
() {}:
while (Token->Status == EFI_NOT_READY) {
This->Poll (This);
}
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Thursday, March 1, 2018 7:03 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Wang, Fan <fan.w
Reviewed-by: Wu Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, June 27, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: [Patch] MdeModulePkg: Update IP4 driver to check for NULL
> pointer before using.
>
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Jin, Eric
> Sent: Friday, October 12, 2018 3:05 PM
> To: edk2-devel@lists.01.org
> Cc: Supreeth Venkatesh ; Wu, Jiaxin
>
> Subject: [edk2-test][Patch] uefi-sct\EMS:Add HTTP Test
>
> Contributed-under: Tiano
Thanks Ting, I will update the comments against the function.
> -Original Message-
> From: Ye, Ting
> Sent: Thursday, October 18, 2018 11:26 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: RE: [edk2] [Patch] NetworkPkg/IpSecDxe:
Looks good to me.
Series Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Monday, October 29, 2018 1:48 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting
Hi Jaben,
The patch already has been pushed after received your/Siyuan reviewed-by tag.
Thanks,
Jiaxin
> -Original Message-
> From: Carsey, Jaben
> Sent: Thursday, November 8, 2018 9:09 AM
> To: Fu, Siyuan ; Wu, Jiaxin ;
> edk2-devel@lists.01.org
> Cc: Ye, Ting
>
Thanks Star, I have committed the patch since it resolves the VS2012 build
error.
> -Original Message-
> From: Zeng, Star
> Sent: Friday, September 28, 2018 10:31 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Carsey,
> Jaben ; Zeng, S
Hi Laszlo,
>
> If that's the case, should we consider the three drivers under
> "MdeModulePkg/Universal/Network/" deprecated, and should we abandon
> them
> completely?
>
I think the answer is NO (At least for now). In my opinion, the drivers in
MdeModulePkg is also useful in some case,
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Carsey, Jaben ;
> Fu, Siyuan ; Shao, Ming
> Subject: Re: [edk2] [Patch 0/5] Support windowsize to benefit tftp/pxe
> download performance.
>
> On 09/19/18 04:20, Wu, Jiaxin wrote:
> >> On 09/17/18 0
Besides, I recommend to separate the patch for HttpDxe and HttpUtilitiesDxe.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, September 25, 2018 11:43 AM
> To: Li, Songpeng ; edk2-devel@lists.01.org
> Cc: Wu, Jiaxin
> Subject: RE: [PATCH] Ne
Thanks the correction, I will refine all the patches according your comments
before committing the patches.
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, September 25, 2018 6:31 PM
> To: Wu, Jiaxin ; edk2-devel@
>
> git-am complained about trailing whitespace:
>
>
> (4) and here.
>
> With those fixed:
>
> Reviewed-by: Laszlo Ersek
>
I will fix them. Thanks reminder. /Jiaxin
___
edk2-devel mailing list
edk2-devel@lists.01.org
> > MdeModulePke/Mtftp4Dxe: Support windowsize in read request
> operation.
> > NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation.
> > ShellPkg/TftpDynamicCommand: Add one option for tftp command to
> > specify windowsize.
> > NetworkPkg: Define one PCD for PXE to
> >> This is my idea to avoid the duplicated mail. I also include Ard and
> >> Laszlo to
> collect the feedback on how to handle the partial update in the patchset.
> >>
> >
> > Laszlo may disagree with me, but I think that it is not always
> > necessary to resend the entire series when only a
Good suggestion. Thanks Leif. Already resubmit as version 2.
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, January 18, 2019 9:19 PM
> To: Wu, Jiaxin
> Cc: edk2-devel@lists.01.org; Wang, Fan ; Ye, Ting
> ; Li, Ruth
Series Reviewed-by: Jiaxin Wu
Thanks,
jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Monday, January 14, 2019 5:25 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v1 0/2] Remove unused global variables
Hi Laszlo,
Thanks review the patch.
>
> (1) The linked list from BaseLib (LIST_ENTRY) always has at least one
> element (the head element), and the list is empty if the head element
> points back to itself. In other words, ForwardLink may never be NULL.
>
> So why is it necessary to check
Just confirmed with Liming, we don't need to seed the full series patches if
only one is updated.
Thanks,
jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 18, 2019 1:29 PM
> To: Wu, Hao A ; Wu, Jiaxin ;
> edk2-devel@lists.01.org
> Cc: Ye,
Thanks Siyuan, I will double check that.
> -Original Message-
> From: Fu, Siyuan
> Sent: Friday, January 18, 2019 10:00 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Hao A ; Gao,
> Liming
> Subject: RE: [PATCH v1 1/3] MdeModulePkg/Dhcp4Dxe:
Series Reviewed-by: Jiaxin Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Siyuan Fu
> Sent: Thursday, December 20, 2018 9:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wu, Jiaxin ;
> Zeng, Star ; Ni, Ru
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Vijayenthiran Subramaniam
> [mailto:vijayenthiran.subraman...@arm.com]
> Sent: Wednesday, November 21, 2018 11:36 PM
> To: edk2-devel@lists.01.org; Fu, Siyuan ; Wu, Jiaxin
>
> Cc: Vijayenthiran Subramaniam
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: Li, Songpeng
> Sent: Wednesday, January 9, 2019 4:42 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Wu, Jiaxin
> Subject: [PATCH v1] ShellPkg/TftpDynamicCommand: Change file wri
Looks good to me.
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: Ashish Singhal [mailto:ashishsin...@nvidia.com]
> Sent: Friday, January 11, 2019 3:27 AM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin ;
> Ashish Singhal
> Subjec
Reviewed-by: Wu Jiaxin
> -Original Message-
> From: Li, Songpeng
> Sent: Thursday, January 10, 2019 10:54 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray ;
> Wu, Jiaxin
> Subject: [PATCH v2] ShellPkg/TftpDynamicCommand: Change file writing
>
Already pushed. SHA-1: 22b35e8bd1f9aea7bbab3a26e8ab4df339454463
Thanks,
Jiaxin
> -Original Message-
> From: Ashish Singhal [mailto:ashishsin...@nvidia.com]
> Sent: Monday, January 14, 2019 12:58 PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Fu, Siyuan
> S
Reviewed-by: Wu Jiaxin
Thanks,
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> Sent: Friday, September 14, 2018 3:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [edk2] [Patch] Net
or PXE driver to specify MTFTP
> windowsize so as
> > to improve the PXE download performance. The default value is set to 4.
> >
> > Cc: Ye Ting
> > Cc: Fu Siyuan
> > Cc: Shao Ming
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed
Thanks Siyuan, I will rename the PCD name for better understanding.
> -Original Message-
> From: Fu, Siyuan
> Sent: Wednesday, September 19, 2018 8:38 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Shao, Ming
> Subject: RE: [Patch 4/5] MdeModulePk
> On 09/17/18 07:43, Jiaxin Wu wrote:
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886
> >
> > The series patches are to support the TFTP windowsize option described in
> RFC 7440.
> > TFTP shell command and UEFI PXE driver will use the feature to benefit the
> download
> > performance.
r, and thus cause a system crash.
> > This patch adds EXCLUSIVE attribute when opening SNP in PXE driver, and
> > will reject all OpenProtocol requests by EXCLUSIVE.
> >
> > Cc: Subramanian, Sriram
> > Cc: Ye Ting
> > Cc: Fu Siyuan
> > Cc: Wu Jiaxin
> &g
Correct one of my comments.
The new version patch should *NOT* include the reviewed-by tag from previous
version.
Thanks,
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wu, Jiaxin
> Sent: Wednesday, September 19,
Reviewed-by: Wu Jiaxin
> -Original Message-
> From: Wang, Fan
> Sent: Friday, March 1, 2019 9:57 AM
> To: Fu, Siyuan ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wu, Jiaxin
> Subject: RE: [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM
>
> Thanks, Si
Thanks Laszlo, I will update the subject to include the CVE number when commit
the patch.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, February 26, 2019 7:17 PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wang, F
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, February 12, 2019 9:05 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Michael Turner ; Ye, Ting
>
> Subject: RE: [PATCH v2] NetworkPkg/Ip6Dxe: Clean the invalid IPv6
> configuration during driver start.
>
Agree, thanks the comment. I will update the patch.
> -Original Message-
> From: Ye, Ting
> Sent: Monday, February 11, 2019 11:09 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Michael Turner ; Fu, Siyuan
>
> Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: C
Looks it's enough to add the warning debug message. I have sent the version 2
patch to do that.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, February 12, 2019 8:28 AM
> To: Wu, Jiaxin
> Cc: edk2-devel@lists.01.org; Mike Turner ;
> Ye, T
Hi Tom,
One thing I want to highlight is that our design of network stack is not only
for the PXE/HTTP boot trigged in BootManager, but also to make sure it's
workable once there is any MNP instance configured by upper drivers
(ARP/IPv4/IPv6).
Take ARP/IP as an example, once ARP/IP are
-satging process.
Thanks,
Jiaxin
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, January 21, 2019 2:19 AM
> To: edk2-devel@lists.01.org
> Cc: Leif Lindholm ; Rothman, Michael A
> ; Kinney, Michael D
> ; Li, Ruth ; Ye, Ting
> ; Fu, Siyuan ; Wang, Fan
> ; Wu,
401 - 492 of 492 matches
Mail list logo