, Jian J ; Ni, Ruiyu ;
edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: Re: [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable
On 08/08/18 09:04, Wang, Jian J wrote:
> Hi Ruiyu,
>
> In function description comments, the @retval doesn't match the changes in
> this patch
Agree, thanks very much. :)
Star
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, August 8, 2018 9:02 AM
To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
D
Subject: RE: [PATCH 0/2] Fix ESRT out of date
Series Reviewed-by: Michael D Kinney
The commit message in
Cc Jian.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Monday, August 6, 2018 5:57 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [PATCH] IntelFrameworkModulePkg/Csm: Set CSM memory executable
-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: [edk2] [PATCH] MdeModulePkg: Remove redundant library classes and GUIDs
Some redundant library classes and GUIDs have been removed in inf, .c and .h
files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1044
https://bugzilla.tianocore.org
.org
Cc: Ni, Ruiyu ; Zeng, Star ; Dong,
Eric ; Kinney, Michael D
Subject: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move display of test key usage
into BDS module
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 04/21] FmpDevicePkg: Add
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 02/21] FmpDevicePkg: Add
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 01/21] FmpDevicePkg: Add
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 03/21] FmpDevicePkg: Add
below before calling FmpDeviceGetLowestSupportedVersion().
DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Monday, July 30, 2018 1:36 PM
To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
D
Subject
Update the title to include "[staging/FmpDevicePkg-master]".
Thanks,
Star
-Original Message-----
From: Zeng, Star
Sent: Monday, July 30, 2018 10:50 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Kinney, Michael D
Subject: [PATCH] FmpDevicePkg FmpDxe:
Agree. :)
Will send a V2 patch soon.
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Saturday, July 28, 2018 2:01 PM
To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
D
Cc: Zeng, Star
Subject: RE: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak
in FreePciDevice
On 7/3/2018 11:32 PM, Thomas Palmer wrote:
> When cleaning the PciIoDevice, also free the BusNumberRange
>
> Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Star Zeng and pushed the patch at
b5bd3ed64898db1088a9468446a0d2d0dc7185e8 with changing the title a little to "
MdeModulePkg FvSimpleFileSystemDxe: Fix memory leak in Read function ".
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
x27;s suggestion.
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Tuesday, July 24, 2018 2:39 PM
To: marvin.haeu...@outlook.com; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Zeng, Star
; Dong, Eric ; Ni, Ruiyu
; ler...@redhat.com; Steele, Kelly
; Justen, Jordan L ;
ard.bi
Reviewed-by: Star Zeng to this patch series.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu
Sent: Friday, July 20, 2018 1:26 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH 0/6] Check untested memory and
That is fine, then I am ok with the patch, Reviewed-by: Star Zeng
.
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, July 19, 2018 9:21 PM
To: Zeng, Star ; edk2-devel-01
Cc: Dong, Eric ; Wu, Jiaxin ; Ni,
Ruiyu ; Fu, Siyuan
Subject: Re
Oh, you are right. The flag mDescriptorPopulated means populated or not, but
not populating needed or not.
Will send new patch soon.
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Friday, July 20, 2018 3:02 PM
To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
D
2-devel-01
Cc: Dong, Eric ; Wu, Jiaxin ; Ni,
Ruiyu ; Fu, Siyuan ; Zeng, Star
Subject: [PATCH 2/6] MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath()
with UefiLib API
Replace the OpenFileByDevicePath() function with EfiOpenFileByDevicePath() from
UefiLib, correcting the following issues:
-
-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin
H?user
Sent: Friday, July 13, 2018 9:26 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] Inquiry regarding early DxeIplPeim loading.
Hey Star,
Thank you very much for your reply
edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin
H?user
Sent: Friday, July 13, 2018 7:19 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: [edk2] Inquiry regarding early DxeIplPeim loading.
Good day developers,
While checking out which edk2 modules request bein
Reviewed-by: Star Zeng
And pushed patch at 9090c8b533013078c6df773e128070c76d917830.
Thanks,
Star
-Original Message-
From: Bi, Dandan
Sent: Friday, July 6, 2018 4:11 PM
To: Thomas Palmer ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [edk2] [PATCH 1/1] MdeModulePkg
Pushed at 4d76bbcce62e3b972cd226e5f0e43d21db48a3f7.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Friday, July 6, 2018 3:30 PM
To: Thomas Palmer ; edk2-devel@lists.01.org
Cc: Dong, Eric ; gar...@hpe.com; joseph.shiffl...@hpe.com;
Zeng, Star
Subject: RE: [PATCH 1/1
g
Cc: Dong, Eric ; Zeng, Star ; Ni,
Ruiyu ; gar...@hpe.com; joseph.shiffl...@hpe.com; Thomas
Palmer
Subject: [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in
FreePciDevice
When cleaning the PciIoDevice, also free the BusNumberRange
Contributed-under: TianoCore Contribution Agreement 1
Reviewed-by: Star Zeng
-Original Message-
From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
Sent: Wednesday, July 4, 2018 12:41 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star ;
gar...@hpe.com; joseph.shiffl...@hpe.com; Thomas Palmer
Subject: [PATCH 1/1] MdeModulePkg
Pushed at f88290964fe528ffeb67ff108e8174fc2ce52741.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Wednesday, July 4, 2018 10:00 PM
To: Brijesh Singh ; edk2-devel@lists.01.org
Cc: Tom Lendacky ; Dong, Eric ;
Justen, Jordan L ; Laszlo Ersek ;
Zeng, Star
Subject: RE: [PATCH v2 1
: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [Patch] MdeModulePkg/S3SmmInitDone.h: Fix copyright coding
style error.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
MdeModulePkg/Include/Guid/S3SmmInitDone.h | 2 +-
1 file changed
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Brijesh Singh [mailto:brijesh.si...@amd.com]
Sent: Wednesday, July 4, 2018 10:02 AM
To: edk2-devel@lists.01.org
Cc: Tom Lendacky ; Brijesh Singh
; Dong, Eric ; Justen, Jordan L
; Zeng, Star ; Laszlo Ersek
Subject: [PATCH
; Dong, Eric ; Justen, Jordan L
; Zeng, Star ; Laszlo Ersek
Subject: [PATCH 1/2] MdeModulePkg/Variable: Check EFI_MEMORY_RUNTIME attribute
before setting it
Set the EFI_MEMORY_RUNTIME attribute in FtwNotificationEvent() only if the
attribute is not already present. This will ensure
Ok. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 3, 2018 10:17 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney, Michael D
Subject: Re: [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check
PixelHeight/PixelWidth against 0
On 7/3/2018 10
So, you mean caller knows ((PixelHeight == 0) || (PixelWidth == 0)), and caller
knows TranslateGopBltToBmp will return RETURN_UNSUPPORTED for that?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 3, 2018 10:03 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney
Good idea, I agree.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Tuesday, July 3, 2018 9:05 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zeng, Star
Subject: RE: [edk2] [PATCH] MdeModulePkg SataControllerDxe: Use compare logic
in if condition
Maybe:
if ((Data32
== 0) || (PixelWidth == 0)) { " ???
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 25, 2018 3:37 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Kinney, Michael D
Subject: [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth
against 0
The patc
: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Zeng, Star
Subject: [edk2] [PATCH 1/2] MdeModulePkg/BmpSupportLib: Correct debug message
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Michael D Kinney
Cc: Star Zeng
---
MdeModulePkg/Library
Reviewed-by: Star Zeng
How about doing same update in ResetSystemPei in an updated patch or a
separated patch?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 3/3] MdeModulePkg
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 2/3] MdeModulePkg/[Pei|Dxe]ResetSystemLib: Add PPI/Protocol
dependency
Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 1/3] MdeModulePkg/ResetUtilityLib: Add pack(1) for reset data
structure
RESET_UTILITY_GUID_SPECIFIC_RESET_DATA structure should be
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Thursday, June 28, 2018 9:42 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Anbazhagan Baraneedharan
; Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg/Sd: Fix type when adding model name string
REF:https
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Thursday, June 28, 2018 9:41 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Shi, Steven ; Dong,
Eric
Subject: RE: [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL ptr check in
BindingStart
Correction:
Should be V1
FvbRuntimeDxe + FvbSmm.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, June 28, 2018 9:14 PM
To: Zeng, Star ; Brijesh Singh ;
edk2-devel@lists.01.org
Cc: Tom Lendacky ; Dong, Eric ;
Justen, Jordan L
Subject: Re
2018 1:50 AM
To: Laszlo Ersek ; edk2-devel@lists.01.org
Cc: Tom Lendacky ; brijesh.si...@amd.com; Dong, Eric
; Zeng, Star ; Justen, Jordan L
Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable
access when SEV is enabled
On 06/27/2018 11:59 AM, Laszlo Ersek wrote:
> O
Behalf Of Laszlo
Ersek
Sent: Wednesday, June 27, 2018 8:54 PM
To: Brijesh Singh ; edk2-devel@lists.01.org
Cc: Tom Lendacky ; Dong, Eric ;
Zeng, Star ; Justen, Jordan L
Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable
access when SEV is enabled
On 06/26/18 21:46
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, June 25, 2018 9:08 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [patch] MdeModulePkg/CapsuleRuntimeDxe: Fix ECC issue
Add guard macro for new added header file.
Cc: Star Zeng
Contributed-under
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu
Sent: Friday, June 22, 2018 10:39 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Ni, Ruiyu ; Yao, Jiewen
; Dong, Eric ; Zeng, Star
Subject: [edk2] [PATCH v2 2/4
I think the code needs
1. Remove the check to S3 boot mode.
2. Use DEBUG_BLKIO in block read function.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express
devices
Cc
Please fix typo 'DevicePathLenth' to 'DevicePathLength'.
With that, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Y
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Tuesday, June 19, 2018 3:39 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
; Zeng, Star
Subject: [edk2] [patch] SignedCapsulePkg
Pushed at 24fee0528c32b240720547afdd737ca928b34e60.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sami
Mujawar
Sent: Wednesday, June 20, 2018 4:23 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; nd ; Stephanie Hughes
If you agree, you do not need resend new patch.
I will help update it simply and push the patch.
Thanks,
Star
-Original Message-
From: Sami Mujawar [mailto:sami.muja...@arm.com]
Sent: Tuesday, June 19, 2018 7:58 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Ni,
Ruiyu
Reviewed-by: Star Zeng
-Original Message-
From: Gao, Liming
Sent: Monday, June 18, 2018 10:58 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Zeng, Star
Subject: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to
match code logic
BdsEntry marks the read-only variables
Hi Sami,
My feedback are inline.
On 2018/6/15 21:51, Sami Mujawar wrote:
Hi Zeng,
Please find my response marked [SAMI] below.
Regards,
Sami Mujawar
-Original Message-
From: Zeng, Star
Sent: 15 June 2018 10:42 AM
To: Sami Mujawar ; edk2-devel@lists.01.org
Cc: ruiyu...@intel.com
Hi Sami,
I will have feedback in the V1 patch thread based on your response there.
Thanks,
Star
-Original Message-
From: Sami Mujawar [mailto:sami.muja...@arm.com]
Sent: Friday, June 15, 2018 10:14 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Ni,
Ruiyu ; ard.biesheu
;
ard.biesheu...@linaro.org; leif.lindh...@linaro.org; nd ; Zeng,
Star
Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem
space
Hi Laszlo, Star.
Looking at the e-mail thread, I think I also made the mistake of getting Star's
name inverted.
I'm sorry, especially as in th
: Saturday, June 16, 2018 12:13 AM
To: Evan Lloyd
Cc: Ni, Ruiyu ; nd ; Stephanie Hughes-Fitt
; Dong, Eric ; Ard
Biesheuvel ; edk2-devel@lists.01.org; Zeng, Star
Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem
space
On Fri, Jun 15, 2018 at 03:26:54PM +, Evan Lloyd
Generally, the patch is good to me.
Some comments below.
On 2018/6/14 19:38, Sami Mujawar wrote:
The SATA controller driver crashes while accessing the
PCI memory, as the PCI memory space is not enabled.
The code "accessing the PCI memory" you mentioned here is
the AhciReadReg in the following
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Wednesday, June 13, 2018 4:54 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [PATCH] MdeModulePkg/IncompPciDeviceSupport: Use correct
Agree.
I think cleanup in C code can be done in next step. :)
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, June 13, 2018 8:40 PM
To: Chen, Chen A
Cc: edk2-devel@lists.01.org; Kinney, Michael D ;
Dong, Eric ; Zeng, Star
Reviewed-by: Star Zeng
-Original Message-
From: Wang, Jian J
Sent: Wednesday, June 13, 2018 1:35 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Yao,
Jiewen ; Ni, Ruiyu
Subject: [PATCH v2 2/2] MdeModulePkg/Core: remove SMM check for Heap Guard
feature detection
CpuDxe
Reviewed-by: Star Zeng
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, June 13, 2018 4:09 PM
To: edk2-devel@lists.01.org
Cc: leif.lindh...@linaro.org; Zeng, Star ; Yao, Jiewen
; Kinney, Michael D ; Ard
Biesheuvel
Subject: [PATCH v4 2/4
linaro.org]
Sent: Wednesday, June 13, 2018 4:09 PM
To: edk2-devel@lists.01.org
Cc: leif.lindh...@linaro.org; Zeng, Star ; Yao, Jiewen
; Kinney, Michael D ; Ard
Biesheuvel
Subject: [PATCH v4 1/4] MdeModulePkg/CapsuleRuntimeDxe: clean the capsule
payload to DRAM
When capsule updates are staged for
-devel@lists.01.org;
leif.lindh...@linaro.org; Zeng, Star
Subject: RE: [edk2] [PATCH v2 2/5] MdeModulePkg/DxeCapsuleLibFmp: permit
ProcessCapsules () to be called once
The difference between 1st call and 2nd call is that: The system will reset
even there are capsules not dispatched in 2nd call
"to DEBUG_INFO" should be "DEBUG_BLKIO".
With that updated, Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Tuesday, June 12, 2018 11:37 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Ard Biesheuvel ;
Zeng, Star ; Dong, Eric
Subject: [PATCH 2/2
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Tuesday, June 12, 2018 11:37 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Ard Biesheuvel ;
Zeng, Star ; Dong, Eric
Subject: [PATCH 1/2] MdeModulePkg/NvmExpressDxe: Adjust R/W DEBUG prints to
BLKIO level
REF:https
Sorry, fix typo.
DXE > (SMM communcation) > InSmm = TRUE > SMM driver dispatcher/SMM handler >
InSmm = FALSE > (exit SMM communication) > DXE
-Original Message-
From: Zeng, Star
Sent: Tuesday, June 12, 2018 11:35 AM
To: Laszlo Ersek ; Wang, Jian J ;
edk2-devel@l
Share some information here according to my knowledge.
The EFI_SMM_BASE2_PROTOCOL.InSmm definition in PI spec is really very
confusion. The naming for it are not consistent.
The interface name: In*Smm*
The typedef name of InSmm: EFI_*SMM_INSIDE_OUT*2
The second parameter name of InSmm: In*Smram*
, Hao A
Cc: Zeng, Star ; edk2-devel@lists.01.org; Laszlo Ersek
Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to
DEBUG_BLKIO
On 11 June 2018 at 10:38, Wu, Hao A wrote:
> Hi Ard,
>
> After a quick check on the behavior of other storage device drivers,
> it seem
Thanks.
Just pushed patch at a05a8a5aa17da4bc7144706a9931d68beec1a61f.
Star
-Original Message-
From: Duran, Leo [mailto:leo.du...@amd.com]
Sent: Sunday, June 10, 2018 7:30 AM
To: Zeng, Star ; Dong, Eric
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] MdeModulePkg/Library
edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Friday, June 8, 2018 2:07 PM
To: Zeng, Star
Cc: Kinney, Michael D ; edk2-devel@lists.01.org;
Yao, Jiewen ; leif.lindh...@linaro.org
Subject: Re: [edk2] [PATCH 1/5] MdeModulePkg/CapsulePei: clean Dcache before
2018 1:23 AM
To: Ard Biesheuvel ; edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to
DEBUG_BLKIO
On 06/07/18 11:10, Ard Biesheuvel wrote:
> Lower the priority of the DEBUG print in EmmcReadWrite(), which is
> emitted for each re
,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, June 7, 2018 7:08 PM
To: edk2-devel@lists.01.org
Cc: leif.lindh...@linaro.org; Kinney, Michael D ;
Yao, Jiewen ; Zeng, Star ; Ard
Biesheuvel
Subject: [PATCH 2/5] MdeModulePkg
...@linaro.org; Kinney, Michael D ;
Yao, Jiewen ; Zeng, Star ; Ard
Biesheuvel
Subject: [PATCH 1/5] MdeModulePkg/CapsulePei: clean Dcache before consuming
capsule data
When capsule updates are staged for processing after a warm reboot, they are
copied into memory with the MMU and caches enabled. When
Sent: Thursday, June 7, 2018 6:14 PM
To: Zeng, Star
Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Leif Lindholm
; Yao, Jiewen ; Gao, Liming
; Kinney, Michael D
Subject: Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache before
consuming capsule data
On 7 June 2018 at 12:12, Zeng, Star
platform may not report memory resource
HOB before capsule coalescing, then MemoryResource == NULL and the code thinks
it is valid.
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, June 7, 2018 5:52 PM
To: Zeng, Star
Cc: Ni, Ruiyu ; edk2
sage-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, June 7, 2018 2:00 PM
To: Zeng, Star
Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Gao, Liming
; Yao, Jiewen ; Leif Lindholm
; Kinney, Michael D
Subject: Re: [edk2] [PATCH] MdeModuleP
, June 7, 2018 12:50 PM
To: Zeng, Star
Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Leif Lindholm
; Yao, Jiewen ; Gao, Liming
; Kinney, Michael D
Subject: Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache before
consuming capsule data
On 7 June 2018 at 03:37, Zeng, Star wrote:
> Hi
Cc: Ni, Ruiyu ; Ard Biesheuvel ;
Gao, Liming ; Yao, Jiewen ; Leif
Lindholm ; Kinney, Michael D
; Zeng, Star
Subject: Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: clean Dcache before
consuming capsule data
On 6 June 2018 at 11:52, Ard Biesheuvel wrote:
> When capsule updates are staged
I am ok with that, you can propose patch.
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, June 5, 2018 8:15 PM
To: Pipat/メタワニットポン ピパット
Cc: edk2-devel@lists.01.org; Ni, Ruiyu ; Dong, Eric
; Zeng, Star
Subject: Re: [edk2
added into the commit message
for further easy maintenance.
-Original Message-
From: Duran, Leo [mailto:leo.du...@amd.com]
Sent: Wednesday, June 6, 2018 9:05 AM
To: Zeng, Star ; Dong, Eric
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] MdeModulePkg/Library
6, 2018 5:21 AM
To: Zeng, Star ; Dong, Eric
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure
FIFO Polled Mode
Any updates on this patch?
Do you require to know my "default value of IER"?
Thanks,
Leo.
-Original Message
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Tuesday, June 5, 2018 4:36 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [patch] MdeModulePkg/DisplayUpdateProgressLib: Fix ECC issues
Make the comment align with Edk2 coding style.
Cc: Star Zeng
, Ruiyu
Sent: Tuesday, June 5, 2018 1:40 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Chiu, Chasel
Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS
per policy
I see your point.
I prefer to use AhciPuisEnable().
The function name describe the purpose.
The function
Yes, that is why I was saying to use AhciSetFeaturePuis as the function name.
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, June 5, 2018 11:41 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Chiu, Chasel
Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable
Reviewed-by: Star Zeng
How about using function name AhciSetFeaturePuis instead of AhciPuisEnable as
the function is not just to enable Puis?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 4, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Chiu, Chasel
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, June 5, 2018 11:09 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Subject: RE: [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition
Yes. That's intentional.
DeviceSleep and Agreesive Device Slee
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Monday, June 4, 2018 2:10 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 0/3] Fix bugs in core ResetSystem software stack
v2:
Fix the comments in 2/
Ray,
I could not find code to compare DeviceSleepEnable/AggressiveDeviceSleepEnable
with value 0, is that expected?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 4, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH v2 2/4] MdeModulePkg: Add
With update, Reviewed-by: Star Zeng .
-Original Message-
From: Gao, Liming
Sent: Monday, June 4, 2018 2:39 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info
for BootLogo protocol
Good catch. I will
Liming,
Should " If it is installed " be " If it is not installed " in the commit
message?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Tuesday, May 29, 2018 1:54 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Su
value than 0/1?
Could that information be also stated?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Friday, June 1, 2018 1:39 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition
The patch adds AtaAtapiPolicy
Reviewed-by: Star Zeng
Pushed at 38c977c148e92e2af17c5d346d9b4b2e7a18680a.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Friday, June 1, 2018 10:00 PM
To: Marcin Wojtas ; Zeng, Star ; Dong,
Eric
Cc: Tian
: Friday, June 1, 2018 3:22 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Gao, Liming
Subject: [PATCH 1/3] MdeModulePkg/DxeResetSystemLib: Avoid depending on
UefiRuntimeLib
Current DxeResetSystemLib depends on UefiRuntimeLib because it calls
EfiResetSystem() API exposed by UefiRuntimeLib.
Due to the
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
D Kinney
Sent: Wednesday, May 30, 2018 12:18 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
; Dong, Eric ; Zeng, Star
Subject: [edk2] [Patch v3
.
Please also get Jiewen's RB for the patch.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, May 31, 2018 5:02 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Zeng, Star ;
leif.lindh...@linaro.org
; Zeng, Star ; Ard
Biesheuvel ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Zeng, Star
Subject: RE: [edk2] [PATCH v3 3/5] MdePkg/DxeServicesLib: introduce
AllocatePeiAccessiblePages routine
Jiewen,
I see what you mean. It is not the submitting of capsules you are referring
to. It is the
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Monday, May 28, 2018 10:40 PM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel
Subject: [edk2] [PATCH v3 5/5] MdeModulePkg/FirmwarePerformanceDataTableDxe:
I think " be accessible by PEI after a warm reboot " should be " be accessible
by PEI after resuming from S3 ".
You can update it when pushing without need to send a new patch if other has no
comment to the code part.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-b
from DXE.
Thanks,
Star
From: Abhishek Singh [mailto:a...@cs.unc.edu]
Sent: Tuesday, May 29, 2018 2:02 AM
To: Marvin Häuser
Cc: edk2-devel@lists.01.org; Laszlo Ersek ; af...@apple.com;
Ni, Ruiyu ; Dong, Eric ; Zeng, Star
Subject: Re: [edk2] smm lock query
Thank you everyone for your inputs and
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Monday, May 28, 2018 10:40 PM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel
Subject: [edk2] [PATCH v3 4/5] MdeModulePkg/DxeCorePerformanceLib: use
Allo
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Monday, May 28, 2018 3:31 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/3] Use comparison logic to check UINTN parameter in
GetBestLanguage API
Li
301 - 400 of 1395 matches
Mail list logo
