Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Heyi Guo [mailto:heyi@linaro.org]
Sent: Thursday, March 29, 2018 4:20 PM
To: edk2-devel@lists.01.org
Cc: Heyi Guo ; Yi Li ; Renhao
Liang ; Zeng, Star ; Dong, Eric
; Kinney, Michael D ; Gao,
Liming ; Wang, Jian J ; Ni
Pushed at 5b91bf82c67b586b9588cbe4bbffa1588f6b5926.
Thanks,
Star
-Original Message-
From: Heyi Guo [mailto:heyi@linaro.org]
Sent: Thursday, March 29, 2018 4:20 PM
To: edk2-devel@lists.01.org
Cc: Heyi Guo ; Yi Li ; Renhao
Liang ; Zeng, Star ; Dong, Eric
; Kinney, Michael D ; Gao
, 2018 5:43 AM
To: Zeng, Star ; Heyi Guo ;
edk2-devel@lists.01.org; Kinney, Michael D
Cc: Yi Li ; Renhao Liang ;
Dong, Eric ; Gao, Liming ; Wang,
Jian J ; Ni, Ruiyu
Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion
Star,
This commit breaks Vlv2TbltDevicePkg.
On this
ent.
Seemingly, we also need introduce MemoryAttribute protocol for DXE?
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Tuesday, April 3, 2018 8:59 AM
To: Kinney, Michael D ; Heyi Guo
; edk2-devel@lists.01.org
Cc: Yi Li ; Renhao Liang ;
Dong, Eric ; Gao, Liming ; Wang,
Jian J ; Ni, Ru
GCD service. :)
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Tuesday, April 3, 2018 10:26 AM
To: Wang, Jian J ; Zeng, Star ;
Kinney, Michael D ; Heyi Guo ;
edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Yi Li ; Gao,
Liming ; Dong, Eric ; Renhao Liang
Subject: RE: [PATCH 1/1
-Original Message-
From: Yao, Jiewen
Sent: Tuesday, April 3, 2018 10:34 AM
To: Zeng, Star ; Wang, Jian J ;
Kinney, Michael D ; Heyi Guo ;
edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Yi Li ; Gao,
Liming ; Dong, Eric ; Renhao Liang
Subject: RE: [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute
Sure, I can do that.
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, April 4, 2018 5:45 AM
To: Yao, Jiewen ; Zeng, Star ; Wang,
Jian J ; Heyi Guo ;
edk2-devel@lists.01.org; Kinney, Michael D
Cc: Ni, Ruiyu ; Yi Li ; Gao,
Liming ; Dong, Eric ; Renhao Liang
Agree (also for patch 2/2).
Thanks for the feedback.
I will update them before pushing
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 3, 2018 7:37 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: Re: [edk2] [PATCH 1/2
Good news.
Thanks,
Star
From: Rob Taglang [mailto:r...@taglang.io]
Sent: Wednesday, April 4, 2018 12:49 AM
To: Laszlo Ersek
Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Ming Huang
; Zeng, Star
Subject: Re: [edk2] OVMF UsbBulkTransfer returns EFI_OUT_OF_RESOURCES
Hello,
Thanks for you help, I got
Thanks all.
Push the patch at 0c9f2cb10b7ddec56a3440e77219fd3ab1725e5c. :)
Star
-Original Message-
From: Kinney, Michael D
Sent: Thursday, April 5, 2018 4:28 AM
To: Yao, Jiewen ; Zeng, Star ;
edk2-devel@lists.01.org; Kinney, Michael D
Cc: Ni, Ruiyu ; Yi Li ; Dong, Eric
; Renhao Liang
Curious about which tool to generate the FMP_PAYLOAD_HEADER?
BaseTools needs to be updated?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Thursday, April 5, 2018 8:29 AM
To: Yao, Jiewen ; edk2-devel@lists.01
Since PcdFmpDeviceBuildTimeLowestSupportedVersion is defined to support only
FixedAtBuild and PatchableInModule, it is definitely for build time.
Do we really need "BuildTime" keyword in the PCD name
PcdFmpDeviceBuildTimeLowestSupportedVersion?
Thanks,
Star
-Original Message-
From: edk2
@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Yao,
Jiewen ; Ni, Ruiyu ; Kinney, Michael
D
Subject: [PATCH] MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM
This patch fixes an issue introduced by commit
5b91bf82c67b586b9588cbe4bbffa1588f6b5926
This issue will only happen if
, Michael D ; Sean Brogan
; Zeng, Star ; Dong, Eric
Subject: [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=801
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share
Has no need to set paging capability as the code is going to clear paging
attribute.
With that refined, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Wang, Jian J
Sent: Thursday, April 12, 2018 12:58 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Yao
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J
Wang
Sent: Wednesday, April 11, 2018 4:39 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH 0/2] add sanity check for SetMemoryAttributes
Heap Guard feature needs
If the cases can be listed completely, then it will be better to also add them
in the comments for the two GUIDs, then consumer can easily know them.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi,
Dandan
Sent: Thursday, April 1
t; in
Start() will not happen.
Could more detailed information in the commit log or code comments?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Friday, April 13, 2018 12:14 PM
To: edk2-devel@lists.01.org
Cc: Zeng
Thanks Laszlo.
If the commit log is updated to reference the BZ link or even add more detailed
information.
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, April 13, 2018 5:00 PM
To: Zeng, Star ; Ni, Ruiyu ;
edk2
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, April 19, 2018 6:42 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH] Nt32Pkg/NtGopInput: ReadKeyStrokeEx always return key state
Today's implementation only return key state when
I also had another comment to the protocol at
https://lists.01.org/pipermail/edk2-devel/2018-April/023720.html before.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Friday, April 20, 2018 12:23 PM
To: Kinney, Michael D ; edk2-devel@lists.01.org
Cc: Sean Brogan ; Zeng, Star
I had a minor comment at
https://lists.01.org/pipermail/edk2-devel/2018-April/023570.html to
PcdFmpDeviceBuildTimeLowestSupportedVersion before.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
Jiewen
Sent: Friday, April 20, 20
Mike,
Thanks for the clarification.
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Saturday, April 21, 2018 7:12 AM
To: Zeng, Star ; Yao, Jiewen ;
edk2-devel@lists.01.org; Kinney, Michael D
Cc: Sean Brogan ; Dong, Eric ;
Wei, David ; Guo, Mang
Mike,
Thanks for the clarification.
Star
-Original Message-
From: Kinney, Michael D
Sent: Saturday, April 21, 2018 7:06 AM
To: Zeng, Star ; Yao, Jiewen ;
edk2-devel@lists.01.org; Kinney, Michael D
Subject: RE: [RFC v2 0/4] Add FmpDevicePkg
Star,
Thanks for the feedback. I think
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, April 20, 2018 10:56 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric ; Zeng,
Star
Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix
enough space.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Monday, April 23, 2018 4:49 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: RE: [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table
Thanks for the update.
Would you please share what unit
I also built VS2015/GCC49 (tool chain in my local), and checked ecc result.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Monday, April 23, 2018 4:55 PM
To: Yao, Jiewen ; edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Zeng, Star
Subject: RE: [PATCH] IntelSiliconPkg
That is fine. :)
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Tuesday, April 24, 2018 2:48 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric
Subject: Re: [edk2] [PATCH] MdeModulePkg
Michael D
; Zeng, Star
Subject: [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path
Today's implementation does an exact device path match to check
whether the device path of a console is in ConIn/ConOut/ErrOut.
But that doesn't work for the USB keyboard.
Because when a pl
: Wednesday, April 25, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Zhang, Chao B
Subject: [PATCH] MdeModulePkg/Bds: Validate the device path stored in Boot
The patch adds additional check to the device path when loading the
Boot/Driver variable data.
If the device path is invalid
, April 26, 2018 11:15 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: RE: [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table
Thanks.
Maybe we should also do more test on different FIT table (correct format, or
wrong format), to check the robustness of the code
yu Ni
Sent: Wednesday, April 25, 2018 3:06 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [PATCH] IntelFrameworkModule/LegacyBios: Use reserved memory
for legacy data
Certain Legacy USB implementation needs to access legacy data (BDA,
etc.) from SMM environment. While currently it
01.org
Cc: Zeng, Star ; Chiu, Chasel
Subject: [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when
polling
RootBridgeIo.PollMem()/PollIo() originally don't count the IO/MMIO access
overhead when delaying.
The patch changes the implementation to count the access overhead so that
Reviewed-by: Star Zeng if it is updated. :)
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, May 2, 2018 2:37 PM
To: Zeng, Star ; 'edk2-devel@lists.01.org'
Cc: Chiu, Chasel
Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Count the (mm)io overhead when
pol
Another minor comment below.
There are three lines added with no code, I guess they are added accidently. It
is better to remove them.
+
+
+
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Wednesday, May 2, 2018 2:39 PM
To: Ni, Ruiyu ; 'edk2-devel@lists.01.org'
esday, May 2, 2018 3:52 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Kinney, Michael D
; Zeng, Star
Subject: [edk2] [PATCH v2] MdeModulePkg/ConPlatform: Support short-form USB
device path
Today's implementation does an exact device path match to check whether the
device path of a console i
The GcdAllocateType are EfiGcdAllocateMaxAddress*, the MaxAddress comes from
input BaseAddress parameter.
The original code logic is correct according to PI spec.
PI Spec:
If GcdAllocateType is EfiGcdAllocateMaxAddressSearchBottomUp, then the GCD
memory space map is searched from the lowest addr
Glad to know you found the way. :)
Thanks,
Star
-Original Message-
From: Roman Bacik [mailto:roman.ba...@broadcom.com]
Sent: Friday, May 4, 2018 12:12 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Vladimir Olovyannikov
Subject: RE: [edk2] [PATCH v2] MdeModulePkg/Core
It is about USB short form device path handling? Check
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c#L1368?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
Fish
Sent: Friday, May 4,
Häuser [mailto:marvin.haeu...@outlook.com]
Sent: Saturday, May 5, 2018 10:26 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Ni,
Ruiyu
Subject: [PATCH] MdeModulePkg/AcpiPlatformDxe: Unload after execution.
AcpiPlatformDxe solely performs one-time tasks and does not expose any services
: Ni, Ruiyu ; Dong, Eric ; Zeng,
Star
Subject: [edk2] [PATCH v2] MdeModulePkg/AcpiPlatformDxe: Unload after execution.
AcpiPlatformDxe solely performs one-time tasks and does not expose any services
or create any events. Hence it can safely be unloaded after the Entry Point
execution by
M
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric ; Zeng,
Star
Subject: [edk2] [PATCH 1/2] MdeModulePkg: Add PlatformAcpiLib LibraryClass.
PlatformAcpiLib can be consumed by the generic ACPI Platform driver
to allow platform specific updates to the ACPI tables loaded from the
configured Firmw
com]
Sent: Friday, May 11, 2018 12:18 PM
To: edk2-devel@lists.01.org
Cc: ler...@redhat.com; Zeng, Star ; cinnamon shia
; Ansen Huang
Subject: [PATCH 1/2] MdeModulePkg Variable: Failed to set a variable if the
remaining size is equal to the variable data size.
Fix the issue that failed to update or
TED Fvb is a NULL for Non-Volatile variable update.
Thanks,
Star
-Original Message-
From: cinnamon shia [mailto:cinnamon.s...@hpe.com]
Sent: Friday, May 11, 2018 12:18 PM
To: edk2-devel@lists.01.org
Cc: ler...@redhat.com; Zeng, Star ; cinnamon shia
; Ansen Huang
Subject: [PATC
11, 2018 4:43 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: ler...@redhat.com; Huang, Ansen
Subject: RE: [PATCH 2/2] MdeModulePkg Variable: Correct the returned EFI_STATUS
in the UpdateVariableStore().
Hi Star,
Thanks for your comments.
About returning EFI_NOT_FOUND for the case (Fvb == NULL
cinnamon
shia
Sent: Friday, May 11, 2018 11:21 PM
To: edk2-devel@lists.01.org
Cc: ler...@redhat.com; Zeng, Star ; Ansen Huang
Subject: [edk2] [PATCH v2 1/2] MdeModulePkg Variable: Fix a corner case issue
about setting a variable
Fix the issue that failed to update or add a UEFI variable if the
Cc Ray.
Thanks,
Star
From: Marvin H?user [mailto:marvin.haeu...@outlook.com]
Sent: Tuesday, May 15, 2018 3:00 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: Proposition of a BmEnumerateBootOptions() hook.
Hey Star, Eric and everyone else,
I have seen that some platforms
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Wednesday, May 16, 2018 9:35 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [Patch] MdeModulePkg PeiCore: FvCount to be checked for the registered
for shadow PEIM
The PEIM in all cached FV image
Was HighPrecisionEventTimerTable.h just created for ACPI related, but not for
HPET register related?
We also see AlertStandardFormatTable.h, DmaRemappingReportingTable.h, etc. They
are all ACPI related.
What is the criteria about including ACPI related, and including
register/command/message re
Got it. Good information.
Thanks,
Star
-Original Message-
From: Marvin H?user [mailto:marvin.haeu...@outlook.com]
Sent: Thursday, May 17, 2018 7:45 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Kinney, Michael D
; Gao, Liming ; Yao, Jiewen
Subject: RE: [PATCH] MdePkg/Hpet: Add Event
_ERROR (Status)) {
return EFI_OUT_OF_RESOURCES;
}
}
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, May 22, 2018 4:52 PM
To: Bi, Dandan ; Laszlo Ersek ; Andrew
Fish ; Kinney, Michael D
Cc: Leif Lindholm ; edk2-devel@lists.
It comes to an old question: how to know PEI is 32bit/64bit? But not DXE is
32bit/64bit.
Thanks,
Star
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, May 22, 2018 5:03 PM
To: Zeng, Star
Cc: Bi, Dandan ; Laszlo Ersek ; Andrew
Fish ; Kinney
), SMM, etc), but the new
interface is just needed in DXE (Uefi/DxeCore) instances, how about adding it
in UefiLib?
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, May 22, 2018 6:00 PM
To: Zeng, Star ; Ard Biesheuvel
Cc: Bi, Dandan ; Andrew
On 2018/5/22 22:08, Ard Biesheuvel wrote:
Add a routine to UefiLib that abstracts the allocation of memory that
should be accessible by PEI after a warm reboot. We will use it to
Glad to see this patch series.
It is the case "PEI for S3", but not "PEI after a warm reboot".
Thanks,
Star
rep
On 2018/5/23 3:11, Laszlo Ersek wrote:
On 05/22/18 19:47, Ard Biesheuvel wrote:
OK, to summarize:
- move the implementation of EfiAllocatePeiAccessiblePages() to
DxeServicesLib (and perhaps rename it to something more appropriate
for its new home)
- only restrict the X64 version to below 4 GB i
Reviewed-by: Star Zeng to MdeModulePkg changes.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Friday, May 18, 2018 5:32 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch v2 0/5] Remove X86 ASM and S files
For
Ray,
Two points need be noticed.
1. BaseLib.inf forgets to include RngLib.
2. This patch will include RngLib dependency to BaseLib, that may break many
platforms that do not declare RngLib in their platform dsc.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...
3, 2018 11:30 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH] MdeModulePkg/PciBus: Use actual max bus # for subordinary bus #
Current code assumes the max bus(0xFF) is under this P2P bridge and temporarily
set it as subordinate bus.
It may cause silicon hangs during PCI enumerati
Kinney,
Michael D ; Zeng, Star
Subject: RE: [edk2] [PATCH v2 4/5] MdeModulePkg/DxeCorePerformanceLib: use
AllocatePeiAccessiblePages
Hi Ard,
Thank you very much for helping fix this issue.
And for ZeroMem(), it should be added back.
Because after the memory is allocated, the optional padding (from t
PCAT_RTC_DATA_REGISTERPcdGet8 (PcdRtcTargetRegister))
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Friday, May 25, 2018 4:46 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH] PcAtChipsetPkg/PcRtc: Add two new PCD for RTC Index/Target
registers
In certain HW implementation, the
Reviewed-by: Star Zeng after fixing typo ' custoimize '
to ' customize '.
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Friday, May 25, 2018 2:16 PM
To: edk2-devel@lists.01.org
Cc: Sean Brogan ; Zeng, Star ;
Dong, Eric
Subject: [Patch v3 1/
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Friday, May 25, 2018 2:16 PM
To: edk2-devel@lists.01.org
Cc: Sean Brogan ; Zeng, Star ;
Dong, Eric
Subject: [Patch v3 2/3] MdeModulePkg: Add DisplayUpdateProgressLib instances
https
, 2018 3:08 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure
FIFO Polled Mode
Put the UART in FIFO Polled Mode by clearing IER after setting FCR.
Also, add comments to show DLAB state for registers 0 and 1
Reviewed-by: Star Zeng star.z...@intel.com
发件人: edk2-devel [edk2-devel-boun...@lists.01.org] 代表 Ruiyu Ni
[ruiyu...@intel.com]
发送时间: 2018年5月25日 4:02
收件人: edk2-devel@lists.01.org
主题: [edk2] [PATCH 0/2] MdeModulePkg/PciBus: Do not enable MemWriteAndInvalidate
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Monday, May 28, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [PATCH v2] PcAtChipsetPkg/PcRtc: Add two new PCD for RTC
Index/Target
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Monday, May 28, 2018 3:31 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/3] Use comparison logic to check UINTN parameter in
GetBestLanguage API
Li
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Monday, May 28, 2018 10:40 PM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel
Subject: [edk2] [PATCH v3 4/5] MdeModulePkg/DxeCorePerformanceLib: use
Allo
from DXE.
Thanks,
Star
From: Abhishek Singh [mailto:a...@cs.unc.edu]
Sent: Tuesday, May 29, 2018 2:02 AM
To: Marvin Häuser
Cc: edk2-devel@lists.01.org; Laszlo Ersek ; af...@apple.com;
Ni, Ruiyu ; Dong, Eric ; Zeng, Star
Subject: Re: [edk2] smm lock query
Thank you everyone for your inputs and
I think " be accessible by PEI after a warm reboot " should be " be accessible
by PEI after resuming from S3 ".
You can update it when pushing without need to send a new patch if other has no
comment to the code part.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-b
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Monday, May 28, 2018 10:40 PM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel
Subject: [edk2] [PATCH v3 5/5] MdeModulePkg/FirmwarePerformanceDataTableDxe:
; Zeng, Star ; Ard
Biesheuvel ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Zeng, Star
Subject: RE: [edk2] [PATCH v3 3/5] MdePkg/DxeServicesLib: introduce
AllocatePeiAccessiblePages routine
Jiewen,
I see what you mean. It is not the submitting of capsules you are referring
to. It is the
01.org] On Behalf Of Udit
Kumar
Sent: Tuesday, June 6, 2017 7:11 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: Re: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of
useless Status check
Hi Star
> -Original Message-
> From: edk2-devel [mailto
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, June 19, 2017 9:21 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zeng, Star ; Ni,
Ruiyu
Subject: [patch 1/8] MdePkg/SimpleTextInEx: Update comments according to UEFI
2.7 spec
Cc: Liming Gao
Cc: Star Zeng
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, June 19, 2017 9:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Ni, Ruiyu ; Fan, Jeff
Subject: [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx
Update comments in SimpleTextInEx
Dandan,
The change also needs to be in Ps2KeyboardDxe in MdeModulePkg, right?
Please double confirm that.
Thanks,
Star
-Original Message-
From: Bi, Dandan
Sent: Monday, June 19, 2017 9:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Ni, Ruiyu
Subject: [patch 3/8] MdeModulePkg
lists.01.org
Cc: Gao, Liming ; Zeng, Star
Subject: [patch 5/8] MdePkg: Update comments in EFI_MEMORY_DESCRIPTOR according
to UEFI2.7
Cc: Liming Gao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Include/Uefi/UefiSpec.h | 21 +
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, June 19, 2017 9:22 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zeng, Star
Subject: [patch 7/8] MdePkg: Clean ACPI 2.0 characters in UEFI spec
Cc: Liming Gao
Cc: Star Zeng
Contributed-under: TianoCore
Dandan,
Seemingly, there are some missing changes in RootBridgeIoConfiguration(),
please double confirm that.
Thanks,
Star
-Original Message-
From: Bi, Dandan
Sent: Monday, June 19, 2017 9:22 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [patch 8/8] MdeModulePkg: Clean ACPI
Reviewed-by: Star Zeng to this patch series.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Monday, June 19, 2017 12:46 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 0/8] Update function comments according to UEFI2.7
s
Just found below comments in MdePkg.dec, should it be removed also?
##
## In UEFI 2.6 spec,this guid value is duplicate with
## EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to
## avoid the duplicate guid issue. So its value is not consistent with
## UEFI spec definiti
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Monday, June 19, 2017 12:39 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Kinney,
Michael D ; Gao, Liming
Subject: [PATCH] MdePkg: Add EFI UFS Device Config Protocol definitions
Cc: Star Zeng
Cc: Michael D
Should the code
+// Return NULL Interface if Unsupported Protocol
+*Interface = NULL;
be
+if (Attributes != EFI_OPEN_PROTOCOL_TEST_PROTOCOL) {
+ // Return NULL Interface if Unsupported Protocol
+ *Interface = NULL;
+}
to cover the case Attributes = EFI_OPEN_PROTOCOL_TE
EFI_OPEN_PROTOCOL_TEST_PROTOCOL.”
Thanks,
Star
From: Amit Kumar [mailto:amit...@samsung.com]
Sent: Thursday, June 22, 2017 8:54 PM
To: edk2-devel@lists.01.org; Gao, Liming ; Zeng, Star
; Kinney, Michael D
Cc: Tian, Feng
Subject: RE: RE: [edk2] [PATCH V3] MdeModulePkg/DxeCore: Fixed Interface
returned by
branch "xxx 2".
if (((VariableName[MaxLen - 1] != 0))) {
DEBUG ((DEBUG_INFO, "xxx 1\n"));
} else {
DEBUG ((DEBUG_INFO, "xxx 2\n"));
}
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Friday, June 23, 2017 4:20 PM
To: Zeng, Star ; edk2-deve
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Amit
Kumar
Sent: Friday, June 23, 2017 6:10 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng ; Gao, Liming ;
Kinney, Michael D ; Zeng, Star
Subject: [edk2] [PATCH V4
Patch has been pushed at 45cfcd8dccf84b8abbc1d6f587fedb5d2037ec79. :)
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Monday, June 26, 2017 9:20 AM
To: Amit Kumar ; edk2-devel@lists.01.org
Cc: Tian, Feng ; Gao, Liming ;
Kinney, Michael D ; Zeng, Star
Subject: RE: [edk2] [PATCH
AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: RE: [PATCH V2 3/3] DuetPkg FsVariable: Update GetNextVariableName to
follow UEFI 2.7
Star,
I don't recommend to add the additional check for performance consideration.
Because we have no idea what the input VariableName buffer i
to indicate the
ending of searching.
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 26, 2017 1:37 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: RE: [PATCH V2 3/3] DuetPkg FsVariable: Update GetNextVariableName to
follow UEFI 2.7
I understand
sults."
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 26, 2017 1:47 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: RE: [PATCH V2 3/3] DuetPkg FsVariable: Update GetNextVariableName to
follow UEFI 2.7
Can you add more comments here to de
to return EFI_NOT_FOUND, it was our code's
implementation choice.
Do you mean which piece of comments to be put in code? :)
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 26, 2017 2:18 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: RE: [PATCH
AM
To: Amit Kumar ; edk2-devel@lists.01.org
Cc: Tian, Feng ; Gao, Liming ;
Kinney, Michael D ; Zeng, Star
; Gabriel L. Somlo (GMail) ; Fan, Jeff
Subject: Re: [edk2] [PATCH V4] MdeModulePkg/DxeCore: Fixed Interface returned
by CoreOpenProtocol
On 06/23/17 12:09, Amit Kumar wrote:
> Change si
I have reverted this patch at fd220166c435479a81dfe8519c92abec9acf7d82 first.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Tuesday, June 27, 2017 8:53 AM
To: Laszlo Ersek ; Amit Kumar ;
edk2-devel@lists.01.org
Cc: Tian, Feng ; Gao, Liming ;
Kinney, Michael D ; Gabriel L
Liming is taking leave today, and Reviewed-by: Star Zeng .
And we have no concern to pull this to UDK2017 branch.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Tuesday, June 27, 2017 12:57 AM
To: edk2-devel@list
(it's my fault that I did not catch the failure when reviewing patch), the
patch is so risky.
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, June 27, 2017 5:45 PM
To: Zeng, Star ; Amit Kumar ;
edk2-devel@lists.01.org
Cc: Tian, Feng
I also prefer to document it in UEFI spec personally.
And we are also having more discussion about it internally, nice to share more
after that. :)
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, June 27, 2017 9:23 PM
To: Zeng, Star ; Amit
ssage-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, June 28, 2017 2:05 AM
To: edk2-devel@lists.01.org; Zeng, Star ; Dong, Eric
Cc: Tian, Feng ; leif.lindh...@linaro.org; Ard Biesheuvel
Subject: [PATCH] MdeModulePkg/AtaAtapiPassThru: relax PHY detect timeout
The SATA
The updated comments "Wait at least 10 ms" seems not correct.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Wednesday, June 28, 2017 4:23 PM
To: edk2-devel@lists.01.org; Zeng, Star
Cc: Tian, Feng ;
conditions
that must be checked before this function can return EFI_SUCCESS.
Of course, the code still needs to be updated and the revised patch based on
this V4 patch is attached.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Tuesday, June 27, 2017 9:31 PM
To: Laszlo Ersek
sday, June 28, 2017 4:58 PM
To: Tian, Feng
Cc: leif.lindh...@linaro.org; edk2-devel@lists.01.org; Dong, Eric
; Zeng, Star
Subject: Re: [edk2] [PATCH v2] MdeModulePkg/AtaAtapiPassThru: relax PHY detect
timeout
On 28 June 2017 at 08:49, Tian, Feng wrote:
> Ard & Star,
>
> I agree thi
-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, June 28, 2017 5:58 PM
To: Zeng, Star
Cc: Tian, Feng ; leif.lindh...@linaro.org;
edk2-devel@lists.01.org; Dong, Eric
Subject: Re: [edk2] [PATCH v2] MdeModulePkg/AtaAtapiPassThru: relax PHY detect
timeout
> On 28
401 - 500 of 1395 matches
Mail list logo
