Re: [edk2] [PATCH v1 3/4] BaseTools: Remove un-needed list comprehension

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 12, 2018 7:08 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v1 2/4] BaseTools: replace 'UINT8', 'UINT16', 'UINT32', 'UINT64', 'VOID*' with shared constants.

Hi Jaben, In GenFdsGlobalVariable.py file, it should use DataType.TAB_VOID because current the import statement in this file is " import Common.DataType as DataType". Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, April 12, 2018 7:08 A

Re: [edk2] [PATCH v1 2/2] BaseTools: refactor and remove un-needed use of .keys() on dictionaries

() +self.SkuIdSet = SkuIds Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 13, 2018 8:02 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject: [PATCH v1 2/2] BaseTools: refacto

Re: [edk2] [PATCH v1 1/2] BaseTools: fix None comparisons

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Friday, April 13, 2018 8:02 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v1 0/9] BaseTools: refactoring

Reviewed this series patch. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Saturday, April 14, 2018 4:51 AM To: edk2-devel@lists.01.org S

Re: [edk2] [PATCH v1] BaseTools: remove an unused file

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, April 14, 2018 1:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com>

Re: [edk2] [PATCH v1] BaseTools: delete an unused file

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, April 14, 2018 12:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com>

Re: [edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 11, 2018 7:17 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH

Re: [edk2] [PATCH v1 2/3] BaseTools: use predefined constants instead of local strings

l build pass because in those files it also have " from Common.DataType import *". So you will send out a V2 or update this import statement when push the patch? Other patch are fine to me. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, Ap

Re: [edk2] [PATCH 1/1] BaseTools: Fix one or more multiply defined symbols found issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, April 13, 2018 1:21 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> S

Re: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, April 10, 2018 9:10 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> S

Re: [edk2] [PATCH 3/3] BaseTools: fix --genfds-multi-thread generate makefile issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, April 10, 2018 9:13 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> S

Re: [edk2] [PATCH 2/3] BaseTools: argument genfds-multi-thread create GenSec command issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, April 10, 2018 9:11 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> S

Re: [edk2] [PATCH v1 3/3] BaseTools: use existing contrants to replace raw strings in python code.

Hi Jaben, Seems only replaced 'UEFI_APPLICATION', what about others, eg ' DXE_SMM_DRIVER' ? Do you have plan to update it ? Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, April 10, 2018 10:20 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <lim

Re: [edk2] OVMF build fail because of missing Dictionary.py

Hi Fan, The build failure issue was fixed, please help to check it. thanks. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Tuesday, April 10, 2018 2:02 PM To: 'Chen, Farrah' <farrah.c...@intel.com>; edk2-devel@lists.01.org Cc: Hu, Robert <robert...@

Re: [edk2] [PATCH v1 1/2] BaseTools: copy a dictionary from InfClassObject to BuildReport

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, April 04, 2018 11:02 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH] BaseTools: Remove EdkIIWorkspaceBuild.py from source code

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Wednesday, April 04, 2018 1:53 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] OVMF build fail because of missing Dictionary.py

Thanks. I will fix it soon. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen, Farrah Sent: Tuesday, April 10, 2018 1:55 PM To: edk2-devel@lists.01.org Cc: Hu, Robert <robert...@intel.com>; Guo, Xuelian &l

Re: [edk2] [PATCH] BaseTools: Parse PCD GUID name in FILE statement issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, April 09, 2018 11:31 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, April 06, 2018 7:14 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1

Re: [edk2] [PATCH v1 0/3] BaseTools: refactor and cleanup

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Thursday, April 05, 2018 4:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH

Re: [edk2] [PATCH v1 2/2] BaseTools: Remove unneeded files

remove this file ? Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, April 04, 2018 11:02 PM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject: [PATCH v1 2/2] BaseTools: Remove un

Re: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

The patches are good to me. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 04, 2018 6:34 AM To: edk2-devel@lists.01.org S

Re: [edk2] [PATCH v1 00/10] BaseTools: refactor code

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, April 04, 2018 5:03 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1

Re: [edk2] [PATCH v1 0/4] BaseTools: remove un-needed code

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, March 30, 2018 8:19 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH

Re: [edk2] [PATCH v1 0/3] BaseTools: reduce RegExp compile times...

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, March 30, 2018 5:38 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH

Re: [edk2] [Patch] edk2-VfrSpecification: update version to 1.92

Add the 1.92 version info in Revision History. Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, April 3, 2018 4:28 PM To: Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; S

Re: [edk2] [PATCH v1 0/4] BaseTools: eliminate some redundant code.

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Thursday, March 29, 2018 8:02 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH

Re: [edk2] [Patch] BaseTools: compare GUID value should not case-sensitive

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, March 28, 2018 2:26 PM To: edk2-devel@lists.01.org Cc: Wang, BinX A <

Re: [edk2] [PATCH v1 4/4] BaseTools: dont use enumerate when un-needed

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, March 28, 2018 7:43 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH v1 3/4] BaseTools: move regular expression compile out of function call.

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, March 28, 2018 7:43 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH v1 2/4] BaseTools: expression can use single in instead of 3 API calls.

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, March 28, 2018 7:43 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Su

Re: [edk2] [PATCH v2 5/9] BaseTools: Regular Expressions refactor out the hex char for later reuse

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, March 24, 2018 1:49 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> Subj

Re: [edk2] [PATCH v2 6/9] BaseTools: Add new RegExp for future use

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, March 29, 2018 12:05 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&

Re: [edk2] [PATCH v2 1/9] BaseTools: FdfParser and FdfParserLite share reg exp

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, March 29, 2018 12:05 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> Su

Re: [edk2] [PATCH v1 1/9] BaseTools: FdfParser and FdfParserLite share reg exp

statement "g4HexChar = re.compile(r'{}{4}'.format(_HexChar))" Others are good to me. thanks. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Saturday, March 17, 2018 7:28 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.co

Re: [edk2] [PATCH v1 1/1] BaseTools: refactor repeated RegExp when no special searching is needed.

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, March 27, 2018 8:33 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subj

Re: [edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

he feature request for flexible Pcd value format. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, March 28, 2018 7:43 AM To: edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong <yonghong@intel.com> Subject: [PATCH v1

Re: [edk2] [Patch V2] BaseTools/BinToPcd: Add support for multiple binary input files

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Thursday, March 22, 2018 6:54 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Sean Brogan <sean.bro...@micr

Re: [edk2] [PATCH v2] BaseTools: Update Rsa2048Sha256Sign to use openssl standard options

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, March 27, 2018 1:48 PM To: edk2-devel@lists.01.org Cc: Liao, Jui-pengX <jui-pengx.l...@intel.com>; Kinney, Michael D <michael.d.kin...@

Re: [edk2] [PATCH] BaseTools/ECC: Add a new exception support

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, March 21, 2018 4:23 PM To: edk2-devel@lists.01.org Cc: Chen, Hesheng <

Re: [edk2] [Patch] BaseTools: Add the missing package include directory in PcdValueInit Makefile

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, March 22, 2018 11:22 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C <bob.c.f...@intel.com>; Zhu, Yonghong <yonghong@intel.com&g

Re: [edk2] [Patch] DecSpecification: Add structure PCD definition syntax

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:43 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Kinney, Michael D <michael.d.kin...@int

Re: [edk2] [Patch 2/3] DscSpecification: Add DefaultStores section to describe the default setting

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:42 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Zhu, Yonghong <yonghong@int

Re: [edk2] [Patch 1/3] DSCSpecification: Add syntax to support SKU ID inherit from another SKU ID

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:42 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Zhu, Yonghong <yonghong@int

Re: [edk2] [Patch] BuildSpecification: Clarify structure PCD field value assignment precedence

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:43 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Zhu, Yonghong <yonghong@int

Re: [edk2] [Patch 3/3] DscSpecification: Add structure PCD field value assignment syntax

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, March 16, 2018 12:42 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Zhu, Yonghong <yonghong@int

Re: [edk2] [PATCH v1 0/5] BaseTools: improve reuse and remove dead code

Reviewed-by: Yonghong Zhu <yonghong@intel.com> I will push this series patch. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, March 16, 2018 5:39 AM To: edk2-devel@lists.01.org S

Re: [edk2] [PATCH v1 0/2] BaseTools: AutoGen code style compliance

Reviewed-by: Yonghong Zhu <yonghong@intel.com> I will push this patch. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Thursday, March 15, 2018 8:20 AM To: edk2-devel@lists.01.org Subject:

Re: [edk2] [PATCH v1 0/5] BaseTools - some simple cleanups for BaseTools

Reviewd this series patch. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, March 14, 2018 7:12 AM To: edk2-devel@lists.01.org S

Re: [edk2] [PATCH v1 1/1] BaseTools: UPT: remove unused variable and inaccessible code.

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Monday, March 12, 2018 10:25 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> Subj

Re: [edk2] [PATCH v1 1/1] BaseTools: GlobalData remove unused variable

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, March 08, 2018 8:45 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> Subj

Re: [edk2] [PATCH] BaseTools: Fix parse OFFSET_OF get wrong offset

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, March 9, 2018 4:46 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com> Subject:

Re: [edk2] [PATCH] BaseTools: Dsc/Fdf conditional statement parse issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, March 01, 2018 8:42 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: report error if flag in LABEL() invalid

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, March 01, 2018 4:22 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: GlobalData.gConfDirectory is None when run GenFds

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, March 01, 2018 10:23 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Fix eval parse string issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, March 01, 2018 10:16 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [Patch] BaseTools: Align WIN_CERTIFICATE_UEFI_GUID definition to MdePkg one.

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, February 28, 2018 4:36 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [PATCH V2]BaseTools: Fix flexible PCD single quote and double quote bugs

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, February 27, 2018 4:43 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com>

Re: [edk2] [PATCH] BaseTools: Fix report not used --pcd value incorrectly

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, February 27, 2018 3:38 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [Patch] BaseTools: Resolve BaseTools C tool build failure

Please help to update copyright year when push the patch. thanks. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, February 27, 2018 4

Re: [edk2] [Patch] BaseTools: Add more error message when PcdValue is wrong

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, February 26, 2018 3:15 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTool

Re: [edk2] [Patch] BaseTools: Update GenFw to correct DebugEntry Offset when convert XIP image

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, February 26, 2018 1:52 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [Patch] BaseTools: Add the missing basic definition in C BaseType.h

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 08, 2018 9:14 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [Patch] BaseTools GenFv: Update error message to describe PE image alignment

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 08, 2018 3:30 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [PATCH] BaseTools/Expression: Use 2nd passes on PCD values

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Saturday, February 24, 2018 10:14 AM To: edk2-devel@lists.01.org Cc: Kinney, Mic

Re: [edk2] [PATCH] BaseTools: Update ValueExpressionEx for flexible PCD

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, February 23, 2018 7:48 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Fix VOID* type bug

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, February 09, 2018 12:31 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Update Expression.py for string comparison and MACRO replace issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, February 08, 2018 10:46 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <

Re: [edk2] [Patch V2] Build spec: Add description about auto detect thread number

Yes. Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Wednesday, February 07, 2018 10:24 AM To: Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Shaw, Kevin W <kevin.w.s...@intel.c

Re: [edk2] [PATCH] BaseTools: Fix COMPRESS alignment incorrect issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, February 06, 2018 3:26 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Fix build argument --pcd for flexible format bugs

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Monday, February 05, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Fix flexible PCD DEVICE_PATH parse issue

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, February 06, 2018 10:20 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Report error GUID format if incorrectly

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Monday, February 05, 2018 11:43 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 31, 2018 8:00 PM To: edk2-devel@lists.01.org Subject: [edk2] [Pat

Re: [edk2] [PATCH] BaseTools: StructurePcd array Value support flexible format

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, February 02, 2018 2:49 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Update Expression.py for VOID* support L'a' and 'a'

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, YunhuaX Sent: Friday, February 02, 2018 9:49 PM To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@

Re: [edk2] [PATCH] BaseTools: Fix GCC build PcdValueCommon.c bug

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, February 02, 2018 10:34 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 31, 2018 5:04 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [Patch] BaseTools: Enhance parse performance by optimize ValueExpressionEx

w Pcd format. Best Regards, Zhu Yonghong -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Saturday, January 27, 2018 3:21 AM To: Zhu, Yonghong <yonghong@intel.com> Cc: edk2-devel@lists.01.org; Feng, YunhuaX <yunhuax.f...@intel.com>; Gao, Lim

Re: [edk2] [PATCH 00/15] BaseTools: One step toward python3

Hi Gary, Thanks for your patches. I am still in evaluating these changes and do some verification for it. I still need some more days to give you comment. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, January 19, 2018 12:43

Re: [edk2] [PATCH] BaseTools: Fix indentation

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, January 17, 2018 12:06 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <limin

Re: [edk2] [Patch] BaseTools: CommonLib Fix Crash to write the last byte

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, January 25, 2018 9:42 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [Patch] BaseTools: Fixed some small issues 1. The structure pcd default value should use the default value under sku. 2. Incorrect VpdOffset value for those un-used in module Vpd 3. Add a c

Hi Bob, Please use PatchCheck.py script to check the patch, current it will report following error. The commit message format is not valid: * First line of commit message (subject line) is too long. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel

Re: [edk2] [PATCH] BaseTools: Optimizing DscDefaultValue process in BuildReport

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Saturday, January 20, 2018 2:23 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] BaseTools: Fix increment build bug

Reviewed-by: Yonghong Zhu <yonghong@intel.com> I will add more info into when push this patch. eg: BaseTools: Fix GenFds increment build bug that missing cover command option's change Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Friday, January 19

Re: [edk2] [Patch 1/7] BaseTools: Disable -Wno-unused-const-variable in XCODE5 RELEASE target

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Wednesday, January 10, 2018 11:24 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Andrew Fish <af...@apple.com> S

Re: [edk2] [PATCH 1/2] BaseTools: Enable MAX_CONCURRENT_THREAD_NUMBER = 0 feature

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, January 09, 2018 6:38 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Zhu, Yonghong <yonghong@intel.co

Re: [edk2] [PATCH 0/5] BaseTools/Common & DevicePath: Code refinements

Please help to update copyright year when push it. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Wu, Hao A Sent: Monday, January 08, 2018 1:31 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Ni,

Re: [edk2] [PATCH] BaseTools: Enable MAX_CONCURRENT_THREAD_NUMBER = 0 feature

Hi Yunhua, Please separate this patch into two. And remember to update copyright year. Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, January 09, 2018 10:14 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Zhu, Yo

Re: [edk2] [PATCH] BaseTools: Correct Target Path in CodaTargetList replace Path

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, January 09, 2018 9:56 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Zhu, Yonghong <yonghong@intel.co

Re: [edk2] [PATCH] BaseTools/DevicePath: fix GCC build error in print_mem(), and clean it up

I pushed this fix first since it blocked some GCC tool chain. SHA-1: 9a6b445bc2e6e2db6f67ab3cc425d5831aa1b7c8 Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Wednesday, January 3, 2018 9:27 AM To: Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <e

Re: [edk2] [Patch] BaseTools CommonLib: Fix printf %llx issue on UINT64

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, January 3, 2018 8:34 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Bas

Re: [edk2] [PATCH] BaseTools/DevicePath: fix GCC build error in print_mem(), and clean it up

Thanks. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, January 03, 2018 1:17 AM To: edk2-devel-01 <edk2-devel@lists.01.org> Cc: Gao, Liming <liming....@

Re: [edk2] [Patch] BaseTools: Update Python Makefile to include the new added python files

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 11:14 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com>; Feng, Bob C <bob.c.f...@intel.com&g

Re: [edk2] [Patch] BaseTools: Update SkuId checker to make sure it be valid UINT64 value

Please remove the " Signed-off-by" info in Cc. Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, December 26, 2017 3:59 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@in

Re: [edk2] [Patch] BaseTools: Update BrotliCompress script to handle the different input format

Reviewed-by: Yonghong Zhu <yonghong@intel.com> Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Friday, December 8, 2017 12:39 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong@intel.com> Subject: [Patch] BaseTools: Update BrotliCom

Re: [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file

Hi Leif, I just sent out V2 patch. thanks. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Thursday, December 07, 2017 10:42 PM To: 'Leif Lindholm' <leif.lindh...@linaro.org> Cc: edk2-devel@lists.01.org; Feng, YunhuaX <yunhuax.f...@intel.com>;

Re: [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file

Hi Leif, May I know how this binary driver is described in DSC file and FDF file, and the [Rule.Common.DXE_DRIVER.BINARY] section ? I tried to add this driver into OvmfPkg, but failed to reproduce this failure. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Leif Lindholm

Re: [edk2] [Patch 4/4 V3] BaseTools: Update Makefile to support FFS file generation

Hi Leif, Please help to check whether this patch " [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file" can fix it. thanks a lot. Best Regards, Zhu Yonghong -Original Message----- From: Zhu, Yonghong Sent: Thursday, December 07, 2017 9:00 AM To: Leif Lindholm &

<    1   2   3   4   5   >