On 02/28/18 09:19, Ard Biesheuvel wrote:
> On 28 February 2018 at 08:15, Michael Zimmermann
> wrote:
>>> I agree. Did you run into any issues due to this?
>> Surprisingly no. I was just trying to understand the fastboot implementation
>> before I use it on my platform
>>
Well since the fastboot implementation already is an application (and not a
driver) all we need to do is to use WaitEvent instead of a notify callback.
Once that's fixed I'd add ASSERTs on the current tpl to the relevant API
functions so you know immediately when you try to violate the spec.
On
On 28 February 2018 at 08:15, Michael Zimmermann
wrote:
>> I agree. Did you run into any issues due to this?
> Surprisingly no. I was just trying to understand the fastboot implementation
> before I use it on my platform
> and was surprised that this works at all. I can
> I agree. Did you run into any issues due to this?
Surprisingly no. I was just trying to understand the fastboot
implementation before I use it on my platform
and was surprised that this works at all. I can imagine that's because this
is supposed to load linux's efistub which probably doesn't do
On 28 February 2018 at 07:56, Michael Zimmermann
wrote:
> I feel like both of you misunderstood my intention.
> As I said in my initial mail, I'm not arguing the spec - I know that
> StartImage must be called from TPL_APPLICATION.
>
> I'm just discussing a bug inside
I feel like both of you misunderstood my intention.
As I said in my initial mail, I'm not arguing the spec - I know that
StartImage must be called from TPL_APPLICATION.
I'm just discussing a bug inside EmbeddedPkg/Application/AndroidFastboot -
because they actually do call StartImage from
Violating the spec is undefined behavior. If it works that is bad luck, or good
luck depending on your point of view.
Sent from my iPhone
> On Feb 27, 2018, at 11:33 PM, Michael Zimmermann
> wrote:
>
> Are you sure?
>
> If you look at this file:
>
Are you sure?
If you look at this file:
https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c
The DataReady Event is a TPL_CALLBACK event.
>From there the call chain goes as follows:
AcceptCmd -> HandleBoot -> BootAndroidBootImg ->
>From looking at the code it seems to me that StartImage is called from
TPL_CALLBACK.
According to the Spec StartImage can only be called from https://lists.01.org/mailman/listinfo/edk2-devel
9 matches
Mail list logo