On 07/19/15 00:55, Scott Duplichan wrote:
> The most severe restriction (in my opinion) is this:
>
> * The entire first line should be less than ~70 characters.
>
> The header "CorebootPayloadPkg: " takes 21 characters, leaving only
> 49 characters for summarizing the purpose of the patch.
Ye
Jordan Justen [mailto:jordan.l.jus...@intel.com] wrote:
]Sent: Saturday, July 18, 2015 01:41 AM
]To: Scott Duplichan ; edk2-devel@lists.01.org
]Cc: 'Ni, Ruiyu' ; 'Maurice Ma' ;
'Yingke D Liu' ]; 'Prince Agyeman'
; 'Laszlo Ersek'
]Subject: Re: [PATCH]: CorebootPayloadPkg: Remove data alignment r
data alignment
restriction to support GCC49
]
]On 18 July 2015 at 06:23, Scott Duplichan wrote:
]> Gcc 4.9 produces data alignments of up to 64 bytes. Previous gcc
]> versions align data at up to 32 bytes. With GCC49, this difference
]> causes CorebootPayloadPkg to hang after PeCoffLoader
Jordan Justen [mailto:jordan.l.jus...@intel.com] wrote:
]Sent: Saturday, July 18, 2015 12:52 AM
]To: Scott Duplichan ; edk2-de...@ml01.01.org
]Cc: 'Ni, Ruiyu' ; 'Maurice Ma' ;
'Yingke D Liu' ]; 'Prince Agyeman'
; 'Laszlo Ersek'
]Subject: Re: [PATCH]: CorebootPayloadPkg: Remove data alignment re
On 18 July 2015 at 06:23, Scott Duplichan wrote:
> Gcc 4.9 produces data alignments of up to 64 bytes. Previous gcc
> versions align data at up to 32 bytes. With GCC49, this difference
> causes CorebootPayloadPkg to hang after PeCoffLoaderLoadImage() sets
> ImageError to IMAGE_ERROR_INVALID_SECTIO
Another question. Why did you send this to ml01.01.org rather than
lists.01.org? It seems that either works, but as far as I can see the
list page indicates that the domain is lists.01.org. (I'm just
wondering if we need to change some web page that lists the other
domain...)
Thanks,
-Jordan
On
On 2015-07-17 21:23:16, Scott Duplichan wrote:
> Gcc 4.9 produces data alignments of up to 64 bytes. Previous gcc
> versions align data at up to 32 bytes. With GCC49, this difference
> causes CorebootPayloadPkg to hang after PeCoffLoaderLoadImage() sets
> ImageError to IMAGE_ERROR_INVALID_SECTION_A
Gcc 4.9 produces data alignments of up to 64 bytes. Previous gcc
versions align data at up to 32 bytes. With GCC49, this difference
causes CorebootPayloadPkg to hang after PeCoffLoaderLoadImage() sets
ImageError to IMAGE_ERROR_INVALID_SECTION_ALIGNMENT and returns an
error. This change removes the
8 matches
Mail list logo
