Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-28 Thread Ard Biesheuvel
On 27 May 2017 at 09:05, Gao, Liming wrote: > Ard: > I just run BaseTools\Scripts\PatchCheck.py to check the latest patches. It > reports one issue in this patch. Could you fix it? > Pushed as f4d3ba87bb8f -- Ard. > The commit message format passed all checks. > Code

Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-27 Thread Gao, Liming
Ard: I just run BaseTools\Scripts\PatchCheck.py to check the latest patches. It reports one issue in this patch. Could you fix it? The commit message format passed all checks. Code format is not valid: * Line ending ('\n') is not CRLF File: BaseTools/Scripts/GccBase.lds Line:

Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-24 Thread Ard Biesheuvel
On 21 May 2017 at 21:05, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks. Pushed as 00b00cc57bfe0fca54c904d4dd44a263e243c88b >>-Original Message- >>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>Sent: Friday, May 19, 2017

Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Friday, May 19, 2017 6:48 PM >To: edk2-devel@lists.01.org >Cc: leif.lindh...@linaro.org; Zhu, Yonghong ; Gao, >Liming

Re: [edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-19 Thread Leif Lindholm
On Fri, May 19, 2017 at 11:47:40AM +0100, Ard Biesheuvel wrote: > Some builds of GCC/binutils will default to using the GNU flavor of > the symbol hash table, and will emit it into a section called .gnu.hash > rather than .hash. We have no use for its contents, and GenFw ignores > it anyway, so it

[edk2] [PATCH] BaseTools/Scripts: discard .gnu.hash section in GCC builds

2017-05-19 Thread Ard Biesheuvel
Some builds of GCC/binutils will default to using the GNU flavor of the symbol hash table, and will emit it into a section called .gnu.hash rather than .hash. We have no use for its contents, and GenFw ignores it anyway, so it shouldn't really matter what we do with it. However, due to a