Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

Hi Star, On 09/05/18 11:55, Zeng, Star wrote: > I agree to commit this patch first. Reviewed-by: Star Zeng > to this patch. > > To further enhance with an abstracted function, how about like below? > > BOOLEAN > EhcIsDebugPortInUse ( > IN CONST USB2_HC_DEV *Ehc, > IN UINT8

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

On 09/05/18 12:55, Shi, Steven wrote: >> Steven, can you confirm the patch fixes the issue you saw? > Yes. The patch fixes my issue in > https://bugzilla.tianocore.org/show_bug.cgi?id=1129 . Thanks! I've added your Tested-by. Pushed as commit c3d5d800d775. I'll follow up with the

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

> Steven, can you confirm the patch fixes the issue you saw? Yes. The patch fixes my issue in https://bugzilla.tianocore.org/show_bug.cgi?id=1129 . Thanks Steven Shi ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

On 09/05/18 11:55, Zeng, Star wrote: > I agree to commit this patch first. Reviewed-by: Star Zeng > to this patch. Thanks! Steven, can you confirm the patch fixes the issue you saw? > To further enhance with an abstracted function, how about like below? > > BOOLEAN > EhcIsDebugPortInUse ( >

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

I agree to commit this patch first. Reviewed-by: Star Zeng to this patch. To further enhance with an abstracted function, how about like below? BOOLEAN EhcIsDebugPortInUse ( IN CONST USB2_HC_DEV *Ehc, IN UINT8 *PortNumber OPTIONAL ) Thanks, Star -Original Message- From:

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

On 09/04/18 03:27, Zeng, Star wrote: > Oh, yes. Got the point, the patch is correct indeed. :) > Thanks for the explanation. > > Maybe, an abstracted function will make the logic more clear, like > EhcIsDebugPortInUse(). > What do you think? Haha, I thought of almost exactly the same name (just

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

Oh, yes. Got the point, the patch is correct indeed. :) Thanks for the explanation. Maybe, an abstracted function will make the logic more clear, like EhcIsDebugPortInUse(). What do you think? Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday,

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

Hi Star, On 09/03/18 10:35, Zeng, Star wrote: > Good finding. > > There is another place at > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c#L150 > which has similar logic, please update it also. I audited all the "DebugPortNum" checks that were added by commit

Re: [edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

Good finding. There is another place at https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c#L150 which has similar logic, please update it also. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, August 31, 2018

[edk2] [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

Commit 09943f5ecc0f ("MdeModulePkg: Skip to manage usb debug port in EDKII EHCI driver if it's used by usb debug port driver", 2012-04-28) made the host controller reset in EhcDriverBindingStart() conditional. The intent was to avoid the reset when - one of the USB ports on the host controller was