Re: [edk2] [PATCH] NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp()

2016-01-06 Thread Laszlo Ersek
On 01/06/16 01:58, Fu, Siyuan wrote: > The patch is good to me. > > Reviewed-by: Fu Siyuan Thanks for the reviews; I committed the patch to SVN as r19609. Thanks Laszlo > > > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent:

Re: [edk2] [PATCH] NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp()

2016-01-05 Thread Fu, Siyuan
The patch is good to me. Reviewed-by: Fu Siyuan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, January 6, 2016 4:30 AM To: edk2-de...@ml01.01.org Cc: Subramanian Sriram ; El-Haj-Mahmoud Samer

Re: [edk2] [PATCH] NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp()

2016-01-05 Thread Wu, Jiaxin
Hi Laszlo, The patch is good to me. Reviewed-by: Jiaxin Wu Do you need my help to commit this one or by yourself? Thanks. Jiaxin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, January 6, 2016 4:30 AM To: edk2-de...@ml01.01.org

[edk2] [PATCH] NetworkPkg: DnsDxe: fix return type of DnsFillinQNameForQueryIp()

2016-01-05 Thread Laszlo Ersek
Change the return type of DnsFillinQNameForQueryIp() from (UINT8*) to (CHAR*). This brings the function in sync with both its internal variables and all of its call sites, fixing the following gcc build breakage: > NetworkPkg/DnsDxe/DnsImpl.c: In function 'DnsFillinQNameForQueryIp': >