Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

2017-02-26 Thread Fan, Jeff
Yes. Some platform sets memory allocation HOB. It makes sense. So, I remove ASSERT() from the code. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, February 24, 2017 5:44 PM To: Fan, Jeff; edk2-de...@ml01.01.org Cc: Zeng, Star; Tian, Feng; Kinney, Michael

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

2017-02-24 Thread Laszlo Ersek
On 02/24/17 07:12, Jeff Fan wrote: > Platform PEI may add LOCAL APIC memory mapped space into > EFI_HOB_MEMORY_ALLOCATION. Or platform may allocate this range before. > > So, we skip AllocateMemorySpace()'s return status checking. Instead, we add > one > DEBUG message for possible trace. > >

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

2017-02-23 Thread Zeng, Star
eng <feng.t...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Zeng, Star <star.z...@intel.com> Subject: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error Platform PEI may add LOCAL APIC memory mapped space into EFI_HOB_MEMORY_ALLOCATION. Or platform may a

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

2017-02-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, February 24, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Zeng, Star ; Tian, Feng ; Kinney, Michael D

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

2017-02-23 Thread Jeff Fan
Platform PEI may add LOCAL APIC memory mapped space into EFI_HOB_MEMORY_ALLOCATION. Or platform may allocate this range before. So, we skip AllocateMemorySpace()'s return status checking. Instead, we add one DEBUG message for possible trace. https://bugzilla.tianocore.org/show_bug.cgi?id=390