Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-18 Thread Ard Biesheuvel
On 18 December 2015 at 10:45, Zeng, Star wrote: > On 2015/12/17 23:47, Ard Biesheuvel wrote: >> >> On 17 December 2015 at 15:10, Zeng, Star wrote: >>> >>> On 2015/12/17 18:01, Ard Biesheuvel wrote: C99 does not define left-shifting

[edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-17 Thread Ard Biesheuvel
C99 does not define left-shifting negative values, so make all [positive] preprocessor constants unsigned explicitly, so they do not become negative values after bitwise negation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-17 Thread Zeng, Star
On 2015/12/17 18:01, Ard Biesheuvel wrote: C99 does not define left-shifting negative values, so make all [positive] preprocessor constants unsigned explicitly, so they do not become negative values after bitwise negation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-17 Thread Ard Biesheuvel
On 17 December 2015 at 15:10, Zeng, Star wrote: > On 2015/12/17 18:01, Ard Biesheuvel wrote: >> >> C99 does not define left-shifting negative values, so make all >> [positive] preprocessor constants unsigned explicitly, so they >> do not become negative values after bitwise