Re: [edk2] [PATCH V2 3/8] OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib

2016-04-06 Thread Zeng, Star
The comments below are fair enough, accepted. Thanks, Star On 2016/4/7 0:24, Laszlo Ersek wrote: On 04/06/16 14:40, Star Zeng wrote: Currently, the LockBox protocol is installed in entrypoint of OVMF AcpiS3SaveDxe, that is strange. (6) please remove the phrase that is strange It is not

Re: [edk2] [PATCH V2 3/8] OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib

2016-04-06 Thread Laszlo Ersek
On 04/06/16 14:40, Star Zeng wrote: > Currently, the LockBox protocol is installed in entrypoint of > OVMF AcpiS3SaveDxe, that is strange. (6) please remove the phrase that is strange It is not strange; the commit message for the change justified it. (In other words, what the patch does is