SerialPortLib.c that do nothing.
I've been missing the above GetControl() context all this time.
At this point my opinion is as follows:
- Your patch "[edk2] [PATCH V3 10/12] OvmfPkg XenConsoleSerialPortLib:
Implement Get(Set)Control/SetAttributes" is correct, and my R-b stands.
- You
oint my opinion is as follows:
- Your patch "[edk2] [PATCH V3 10/12] OvmfPkg XenConsoleSerialPortLib:
Implement Get(Set)Control/SetAttributes" is correct, and my R-b stands.
- Your patch "[edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in
MdeModulePkg instead of EmbeddedPkg&quo
t;> Returning "unsupported" and *not* setting Control to zero is unsafe at
>> the moment (although it would be self-consistent for the GetControl()
>> function itself). The problem is that Control would be indeterminate at
>> the time of the check, meaning the E
the implementation of SerialPortRead() and SerialPortPoll() in
> EarlyFdtPL011SerialPortLib.c that do nothing.
I've been missing the above GetControl() context all this time.
At this point my opinion is as follows:
- Your patch "[edk2] [PATCH V3 10/12] OvmfPkg XenConsoleSer
Star,
On 11/23/15 02:44, Star Zeng wrote:
> Beyond just changing the directly related lines in the FDF and DSC files,
> we have to adapt the EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib
> instances as well, in the same patch. This is because the EmbeddedPkg
> driver expects the
More comments below.
On 2015/11/24 9:01, Zeng, Star wrote:
Laszlo,
Explain more below.
On 2015/11/23 22:01, Laszlo Ersek wrote:
Star,
On 11/23/15 02:44, Star Zeng wrote:
Beyond just changing the directly related lines in the FDF and DSC
files,
we have to adapt the
Beyond just changing the directly related lines in the FDF and DSC files,
we have to adapt the EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib
instances as well, in the same patch. This is because the EmbeddedPkg
driver expects the SerialPortSetAttributes(),
SerialPortSetControl() and
7 matches
Mail list logo
