Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 17:47, Laszlo Ersek wrote: > On 02/27/18 18:33, Ard Biesheuvel wrote: >> On 27 February 2018 at 16:10, Ard Biesheuvel >> wrote: >>> On 27 February 2018 at 16:09, Laszlo Ersek wrote: On 02/27/18 15:21,

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 18:33, Ard Biesheuvel wrote: > On 27 February 2018 at 16:10, Ard Biesheuvel > wrote: >> On 27 February 2018 at 16:09, Laszlo Ersek wrote: >>> On 02/27/18 15:21, Ard Biesheuvel wrote: On 27 February 2018 at 10:43, Laszlo Ersek

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 16:10, Ard Biesheuvel wrote: > On 27 February 2018 at 16:09, Laszlo Ersek wrote: >> On 02/27/18 15:21, Ard Biesheuvel wrote: >>> On 27 February 2018 at 10:43, Laszlo Ersek wrote: On 02/27/18 10:23, Ard

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 16:09, Laszlo Ersek wrote: > On 02/27/18 15:21, Ard Biesheuvel wrote: >> On 27 February 2018 at 10:43, Laszlo Ersek wrote: >>> On 02/27/18 10:23, Ard Biesheuvel wrote: On 27 February 2018 at 01:50, Guo Heyi

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 15:21, Ard Biesheuvel wrote: > On 27 February 2018 at 10:43, Laszlo Ersek wrote: >> On 02/27/18 10:23, Ard Biesheuvel wrote: >>> On 27 February 2018 at 01:50, Guo Heyi wrote: Hi Ard, Sorry for the late of seeing this patch. I

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 12:30, Guo Heyi wrote: > On Tue, Feb 27, 2018 at 11:43:35AM +0100, Laszlo Ersek wrote: >> On 02/27/18 10:23, Ard Biesheuvel wrote: >>> On 27 February 2018 at 01:50, Guo Heyi wrote: Hi Ard, Sorry for the late of seeing this patch. I have one

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 10:43, Laszlo Ersek wrote: > On 02/27/18 10:23, Ard Biesheuvel wrote: >> On 27 February 2018 at 01:50, Guo Heyi wrote: >>> Hi Ard, >>> >>> Sorry for the late of seeing this patch. I have one question: why don't we >>> implement a

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On Tue, Feb 27, 2018 at 11:43:35AM +0100, Laszlo Ersek wrote: > On 02/27/18 10:23, Ard Biesheuvel wrote: > > On 27 February 2018 at 01:50, Guo Heyi wrote: > >> Hi Ard, > >> > >> Sorry for the late of seeing this patch. I have one question: why don't we > >> implement a

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 10:39, Leif Lindholm wrote: > On Sat, Feb 24, 2018 at 02:25:14PM +, Ard Biesheuvel wrote: >> Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more >> debug message") broke the DEBUG build for all platforms that rely on >> MMIO

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 10:23, Ard Biesheuvel wrote: > On 27 February 2018 at 01:50, Guo Heyi wrote: >> Hi Ard, >> >> Sorry for the late of seeing this patch. I have one question: why don't we >> implement a runtime serial port lib, which will switch UART base address in >> virtual

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On Sat, Feb 24, 2018 at 02:25:14PM +, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more > debug message") broke the DEBUG build for all platforms that rely on > MMIO mapped UART devices, since it introduces a DEBUG() print that > may trigger at runtime,

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 01:50, Guo Heyi wrote: > Hi Ard, > > Sorry for the late of seeing this patch. I have one question: why don't we > implement a runtime serial port lib, which will switch UART base address in > virtual address map change? I think this will be useful when

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

Hi Ard, Sorry for the late of seeing this patch. I have one question: why don't we implement a runtime serial port lib, which will switch UART base address in virtual address map change? I think this will be useful when we want to debug runtime driver in OS stage. And if we have a runtime version

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/24/18 15:25, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more > debug message") broke the DEBUG build for all platforms that rely on > MMIO mapped UART devices, since it introduces a DEBUG() print that > may trigger at runtime, at which such UART

[edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message") broke the DEBUG build for all platforms that rely on MMIO mapped UART devices, since it introduces a DEBUG() print that may trigger at runtime, at which such UART devices are usually not mapped, resulting in an OS