Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

2017-12-28 Thread Wang, Jian J
...@intel.com> > Subject: RE: [edk2] [PATCH v2 0/2] Fix error in PrintLib > > Jian, > > This change breaks GCC5 builds. > > /home/mdkinney/tianocore/edk2/MdeModulePkg/Library/DxePrintLibPrint2Pro > tocol/PrintLib.c: In function 'InternalPrintLibSPrintMarker': &

Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

2017-12-28 Thread Kinney, Michael D
~ Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Jian J Wang > Sent: Wednesday, December 27, 2017 6:38 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/2] Fix error in PrintLib > >

Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

2017-12-27 Thread Zeng, Star
Reviewed-by: Star Zeng <star.z...@intel.com> Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Thursday, December 28, 2017 10:38 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 0/2] Fix error in Pr

Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

2017-12-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Thursday, December 28, 2017 10:38 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/

[edk2] [PATCH v2 0/2] Fix error in PrintLib

2017-12-27 Thread Jian J Wang
> v2: >a. Correct incorrect description in commit log >b. Fix another similar issue in the same function >c. Fix similar issues in MdeModulePkg/DxePrintLibPrint2Protocol Due to a potential hole in the stop condition of the loop, the two continuous access to ArgumentString (index,