Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 4:19 PM Laszlo Ersek wrote: > > On 10/02/18 14:10, Marc-André Lureau wrote: > > Hi > > > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > >> > >> On 10/02/18 13:37, Marc-André Lureau wrote: > >>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > >> >

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 14:10, Marc-André Lureau wrote: > Hi > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: >> >> On 10/02/18 13:37, Marc-André Lureau wrote: >>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: >> Please fix your git settings for your local edk2 clone. Your patch

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > > On 10/02/18 13:37, Marc-André Lureau wrote: > > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > >> Please fix your git settings for your local edk2 clone. Your patch > >> contains context lines with LF (not CRLF) line endings, and

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 13:55, Laszlo Ersek wrote: > On 10/02/18 13:37, Marc-André Lureau wrote: >> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > >>> Please fix your git settings for your local edk2 clone. Your patch >>> contains context lines with LF (not CRLF) line endings, and that's not >>>

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 13:37, Marc-André Lureau wrote: > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: >> Please fix your git settings for your local edk2 clone. Your patch >> contains context lines with LF (not CRLF) line endings, and that's not >> correct for edk2. > > Shouldn't it be catched by:

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
Anthony, Julien, Gary, On 10/02/18 13:16, Laszlo Ersek wrote: > On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: [...] > The rest looks good, thanks. I'll regression-test the patch (with SMP > and UP guests) once you post v3. can one of you guys please regression-test v3 as well, in a Xen

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Marc-André Lureau
Hi On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > Hi Marc-André, > > On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This is for conformance with the TCG "Platform Reset Attack Mitigation > > Specification". Because clearing the CPU caches at

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally, for simplicity's

Re: [edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread Laszlo Ersek
Hi Marc-André, On 10/02/18 10:36, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is for conformance with the TCG "Platform Reset Attack Mitigation > Specification". Because clearing the CPU caches at boot doesn't impact > performance significantly, do it unconditionally,

[edk2] [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches

2018-10-02 Thread marcandre . lureau
From: Marc-André Lureau This is for conformance with the TCG "Platform Reset Attack Mitigation Specification". Because clearing the CPU caches at boot doesn't impact performance significantly, do it unconditionally, for simplicity's sake. Flush the cache on all logical processors, thanks to