Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-24 Thread Wang, Jian J
Ersek [mailto:ler...@redhat.com] > Sent: Friday, September 21, 2018 6:14 PM > To: Zeng, Star ; Wang, Jian J ; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen > Subject: Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX > related PCDs > > On 09

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-21 Thread Laszlo Ersek
On 09/21/18 10:42, Zeng, Star wrote: > Another minor suggestion is to move IsExecuteDisableBitAvailable() to > VirtualMemory.c, then there will be no need to declare it in > VirtualMemeory.h. I'm fine with both ideas (name change as you see fit, and code movement). Thanks Laszlo > > > Thanks,

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-21 Thread Zeng, Star
Another minor suggestion is to move IsExecuteDisableBitAvailable() to VirtualMemory.c, then there will be no need to declare it in VirtualMemeory.h. Thanks, Star On 2018/9/21 14:00, Zeng, Star wrote: Jian and Laszlo, There is also a superficial comment at below. On 2018/9/20 14:02, Jian J

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-21 Thread Zeng, Star
Jian and Laszlo, There is also a superficial comment at below. On 2018/9/20 14:02, Jian J Wang wrote: v2 changes: a. remove macros no longer needed b. remove DEBUG and ASSERT in ToEnableExecuteDisableFeature() c. change ToEnableExecuteDisableFeature to EnableNonExec BZ#1116:

[edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-20 Thread Jian J Wang
> v2 changes: >a. remove macros no longer needed >b. remove DEBUG and ASSERT in ToEnableExecuteDisableFeature() >c. change ToEnableExecuteDisableFeature to EnableNonExec BZ#1116: https://bugzilla.tianocore.org/show_bug.cgi?id=1116 Currently IA32_EFER.NXE is only set against