Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-27 Thread Zeng, Star
Cc: Tian, Feng <feng.t...@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org>; af...@apple.com; Gao, Liming > <liming@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; ler...@redhat.com; Zeng, Star > <star.z...@intel.com> >

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-27 Thread Ard Biesheuvel
lt;ard.biesheu...@linaro.org>; af...@apple.com; Gao, Liming > <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; > ler...@redhat.com; Zeng, Star <star.z...@intel.com> > Subject: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-27 Thread Ard Biesheuvel
On 27 February 2017 at 06:50, Zeng, Star wrote: > CoreAllocatePoolPages() could not be updated simply by adding > CoreAcquireMemoryLock() and CoreReleaseMemoryLock(), it is also used by > AllocateMemoryMapEntry() with the lock locked. > Indeed. But I am wondering now if

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-26 Thread Zeng, Star
CoreAllocatePoolPages() could not be updated simply by adding CoreAcquireMemoryLock() and CoreReleaseMemoryLock(), it is also used by AllocateMemoryMapEntry() with the lock locked. Thanks, Star -Original Message- From: Gao, Liming Sent: Monday, February 27, 2017 2:43 PM To: Ard

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-26 Thread Gao, Liming
Ard: I agree to separate lock for pool allocations. I suggest you update CoreAllocatePoolPages() and CoreFreePoolPages() implementation by adding CoreAcquireMemoryLock() and CoreReleaseMemoryLock(). If so, you don't need to introduce new CoreAllocatePoolPagesI () and CoreFreePoolPagesI ().

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-26 Thread Zeng, Star
eng, Star <star.z...@intel.com> Subject: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations In preparation of adding memory permission attribute management to the pool allocator, split off the locking of the pool metadata into a separate lock. This is an im

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-26 Thread Ard Biesheuvel
On 26 February 2017 at 18:30, Ard Biesheuvel wrote: > In preparation of adding memory permission attribute management to > the pool allocator, split off the locking of the pool metadata into > a separate lock. This is an improvement in itself, given that pool >

[edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

2017-02-26 Thread Ard Biesheuvel
In preparation of adding memory permission attribute management to the pool allocator, split off the locking of the pool metadata into a separate lock. This is an improvement in itself, given that pool allocation can only interfere with the page allocation bookkeeping if pool pages are allocated