Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Seemingly, the Memory Attributes Table should be consumed for memory protection. UEFI spec: "The Memory Attributes Table is currently used to describe memory protections that may be applied to the EFI Runtime code and data by an operating system or hypervisor." Someone (Jiewen?) familiar with

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

I second. Since this patch breaks existing OS, I agree that we should rollback the memory map change. It means we can use original memory map, by filtering all page attributes. I also suggest we add detail comment on why we do that. GCD map is OK, which has both attribute and capability. And GCD

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

On 15 November 2017 at 15:48, Laszlo Ersek wrote: > Hi Jian, > > On 11/15/17 10:27, Wang, Jian J wrote: >> I tried this workaround and there're no failure in booting Fedora 26 and >> Windows >> server 2016 now. If no objection, I'll merge it into new version of this >> patch.

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

with before >>> 14dde9e903bb9a719ebb8f3381da72b19509bc36 [MdeModulePkg/Core: Fix >> out- >>> of-sync issue in GCD]. >>> >>> Thanks, >>> Star >>> -Original Message----- >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beh

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

r 14, 2017 10:36 PM > > To: Laszlo Ersek <ler...@redhat.com> > > Cc: Matt Fleming <m...@codeblueprint.co.uk>; edk2-devel@lists.01.org; Yao, > > Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com>; Ard > > Biesheuvel <ard.biesheu...

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

ntel.com>; Dong, Eric <eric.d...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map Hi Laszlo, I did some investigation works on this issue. I think I found the root cause and te

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Laszlo, I did some investigation works on this issue. I think I found the root cause and tend to believe this is a Fedora kernel issue. Here're proves: memmap output patterns in which Fedora 26 failed to boot: 1) BS_DataAE20-AE20EFFF 000F 0002600F

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

This is really a surprise. Anyway, thanks for validating so many OSs. I guess we have to turn to your suggestion before, which is adding capability to affected memory block only, not all memory space. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday,

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Jian, I'm CC'ing Ard and Matt, and commenting at the bottom. On 11/10/17 02:02, Jian J Wang wrote: >> v5: >>Coding style clean-up > >> v4: >> a. Remove DoUpdate and check attributes mismatch all the time to avoid >>a logic hole >> b. Add warning message if failed to update capability

[edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

> v5: >Coding style clean-up > v4: > a. Remove DoUpdate and check attributes mismatch all the time to avoid >a logic hole > b. Add warning message if failed to update capability > c. Add local variable to hold new attributes to make code cleaner > v3: > a. Add comment to explain more on