Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-04-02 Thread Feng, Bob C
BZ for remove additional copy action. https://bugzilla.tianocore.org/show_bug.cgi?id=1673 -Original Message- From: Gao, Liming Sent: Friday, March 29, 2019 10:09 PM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function Yes.

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Gao, Liming
Yes. Please submit one BZ for it. > -Original Message- > From: Feng, Bob C > Sent: Friday, March 29, 2019 8:40 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: RE: [Patch] BaseTools: Fixed issue in MultiThread Genfds function > > That will impact the original GenFds since the co

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Feng, Bob C
That will impact the original GenFds since the command is generate by reusing the GenFds functions. What about enter a new BZ to do that change? Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, March 29, 2019 8:33 PM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Gao, Liming
Bob: Could you update the rule to depend on EFI image from DEBUG_DIR? I would like to remove the additional copy from DEBUG dir to OUTPUT dir and save the disk and performance. $(FFS_OUTPUT_DIR)\$(MODULE_GUID)SEC2.1.1.1.pe32 : $(DEBUG_DIR)\LogoDxe.efi GenSec -s EFI_SECTION_PE32 -o $(

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Feng, Bob C
That's to fix the issue that make will fail if enable multiple thread genfds. For example, If enable Multiple thread Genfds, there will be GenSec command in the Makefile like below. $(FFS_OUTPUT_DIR)\$(MODULE_GUID)SEC2.1.1.1.pe32 : $(OUTPUT_DIR)\LogoDxe.efi GenSec -s EFI_SECTION_PE32 -o

Re: [edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Gao, Liming
Bob: Could you list the more information on why update build_rule.txt? > -Original Message- > From: Feng, Bob C > Sent: Friday, March 29, 2019 7:07 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Fixed issue in MultiThread Genfds function >

[edk2] [Patch] BaseTools: Fixed issue in MultiThread Genfds function

2019-03-29 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1450 In the Multiple thread Genfds feature, build tool generates GenSec, GenFFS command in Makefile. The Non-Hii Driver does not generate .offset file for uni string offset, but the build tool has not knowledge about this in autogen phase. So in this