Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-10 Thread Laszlo Ersek
o:ler...@redhat.com] > Sent: Thursday, December 10, 2015 7:04 PM > To: Ni, Ruiyu ; Kinney, Michael D > ; Paolo Bonzini ; Zeng, Star > ; Scott Duplichan > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang > issue >

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-10 Thread Ni, Ruiyu
ted to new machine types. Thanks Laszlo > > > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 10, 2015 9:33 AM > To: Ni, Ruiyu ; Laszlo Ersek ; Kinney, > Michael D > Cc: Paolo Bonzini ; Scott Duplichan ; > edk2-devel@lists.01.org

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-10 Thread Laszlo Ersek
aszlo > > > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 10, 2015 9:33 AM > To: Ni, Ruiyu ; Laszlo Ersek ; Kinney, > Michael D > Cc: Paolo Bonzini ; Scott Duplichan ; > edk2-devel@lists.01.org ; Zeng, Star > > Subject: RE: [edk

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-10 Thread Zeng, Star
10, 2015 9:36 AM To: Kinney, Michael D; Laszlo Ersek Cc: Paolo Bonzini; Scott Duplichan; edk2-devel@lists.01.org; Zeng, Star Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue Yes. Regards, Ray -Original Message- From: Kinney, Michael D Sent: Thursday

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
eng, Star > Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang > issue > > Mike, > The UEFI Spec doesn't require implementation to call > InstallConfigurationTable() every time the ACPI table is updated through > EFI_ACPI_PROTOCOL.InstallAcpiTable()

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
gt; > > the memory allocation services, of course). > > > > > > I think that the PCD is more robust, and in case a platform's ACPI > > > driver is *not* updated to consider it, then the situation is still no > > > worse than with Ray's curre

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
ecember 10, 2015 3:49 AM To: Ni, Ruiyu ; Laszlo Ersek ; Kinney, Michael D Cc: Paolo Bonzini ; Scott Duplichan ; edk2-devel@lists.01.org ; Zeng, Star Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue Ray, The UEFI Specification 2.5 p. 136 - CreateEventEx() require

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 9, 2015 10:48 AM > To: Laszlo Ersek > Cc: Kinney, Michael D ; Paolo Bonzini > ; Scott Duplichan ; > edk2-devel@lists.01.org ; Zeng, Star > > Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a U

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
--- >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >>> Sent: Wednesday, December 9, 2015 9:40 AM >>> To: Laszlo Ersek ; Kinney, Michael D >>> ; Ni, Ruiyu ; Scott >>> Duplichan >>> Cc: 'edk2-devel@lists.01.org' ; Zeng, Star >>

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Laszlo Ersek
atch. Thanks Laszlo > > Mike > > >> -Original Message- >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Sent: Wednesday, December 9, 2015 9:40 AM >> To: Laszlo Ersek ; Kinney, Michael D >> ; Ni, Ruiyu ; Scott >> Duplichan >>

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 18:55, Kinney, Michael D wrote: > 1) RTC driver use info from FADT in SetTime() when FADT is available. > Add event notification to RTC driver to capture FADT info before > ExitBootServices(). > 2) Use PCD in RTC driver and in ACPI FADT table. > > Advantage of (1) is that it is com

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
devel@lists.01.org' ; Zeng, Star > > Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang > issue > > > > On 09/12/2015 18:37, Laszlo Ersek wrote: > > - A DXE driver that runs before *both* the ACPI platform DXE driver, and > > this ru

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 18:37, Laszlo Ersek wrote: > - A DXE driver that runs before *both* the ACPI platform DXE driver, and > this runtime DXE driver -- to be ordered by any means necessary --, *or* > a PEIM, sets a dynamic PCD that keys off *both* the ACPI platform DXE > driver and this runtime DXE driv

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Laszlo Ersek
ntimeDxe so that it match the FADT generated by QEMU. Thanks Laszlo > > Paolo > >> Mike >> >>> -Original Message- >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >>> Paolo Bonzini >>> Sent: Wednesday, Decemb

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 18:11, Kinney, Michael D wrote: > Paolo, > > I agree SetTime() is not called in very many places. But since the > SetTime() service is added to Runtime Services Table when the RTC > driver runs, the logic in SetTime() must be implemented to handle > case where SetTime() is called

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
nal Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, December 9, 2015 8:42 AM > To: Kinney, Michael D ; Ni, Ruiyu > ; Scott Duplichan > Cc: 'edk2-devel@lists.01.org' ; Zeng, Star > > Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc:

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Paolo Bonzini
i >> Sent: Wednesday, December 9, 2015 3:50 AM >> To: Ni, Ruiyu ; Scott Duplichan >> Cc: 'edk2-devel@lists.01.org' ; Zeng, Star >> >> Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang >> issue >> >> >&g

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Kinney, Michael D
ay, December 9, 2015 3:50 AM > To: Ni, Ruiyu ; Scott Duplichan > Cc: 'edk2-devel@lists.01.org' ; Zeng, Star > > Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang > issue > > > > On 09/12/2015 12:16, Ni, Ruiyu wrote: > > Scott,

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Scott Duplichan
Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: ]Sent: Wednesday, December 09, 2015 05:16 AM ]To: Scott Duplichan ]Cc: 'Paolo Bonzini' ; 'edk2-devel@lists.01.org' ; Zeng, Star ] ]Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue ]Scott, ]I debugg

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 12:16, Ni, Ruiyu wrote: > Scott, I debugged the issue further and had the below findings: > According to the ACPI spec 6.0 5.2.9 Fixed ACPI Description Table > (FADT), the FADT.Century can be set to 0 indicating the RTC doesn't > support to store century value. But the Win7 boot lo

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-12-09 Thread Ni, Ruiyu
cAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: ]Sent: Friday, November 20, 2015 01:37 AM ]To: Scott Duplichan ]Cc: Paolo Bonzini ; edk2-devel@lists.01.org ; Zeng, Star ] ]Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-20 Thread Scott Duplichan
Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: ]Sent: Friday, November 20, 2015 01:37 AM ]To: Scott Duplichan ]Cc: Paolo Bonzini ; edk2-devel@lists.01.org ; Zeng, Star ] ]Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue ] ]Scott, ]The UEFI Windows 7 is fresh

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-19 Thread Ni, Ruiyu
PM > ]To: Paolo Bonzini ; Zeng, Star ; > edk2-devel@lists.01.org > ]Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang > issue > ] > ]If we strictly follow the spec, it's only needed to save the century value > ]in CMOS when FADT.CenturyOffset is not

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-19 Thread Scott Duplichan
Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: ]Sent: Thursday, November 19, 2015 06:37 PM ]To: Paolo Bonzini ; Zeng, Star ; edk2-devel@lists.01.org ]Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue ] ]If we strictly follow the spec, it's only needed to sav

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-19 Thread Ni, Ruiyu
rg Subject: Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue On 18/11/2015 06:08, Zeng, Star wrote: > > @@ -508,6 +509,7 @@ PcRtcSetTime ( > RtcWrite (RTC_ADDRESS_DAY_OF_THE_MONTH, RtcTime.Day); > RtcWrite (RTC_ADDRESS_MONTH, RtcTime.Month); > R

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-19 Thread Paolo Bonzini
On 18/11/2015 06:08, Zeng, Star wrote: > > @@ -508,6 +509,7 @@ PcRtcSetTime ( > RtcWrite (RTC_ADDRESS_DAY_OF_THE_MONTH, RtcTime.Day); > RtcWrite (RTC_ADDRESS_MONTH, RtcTime.Month); > RtcWrite (RTC_ADDRESS_YEAR, (UINT8) RtcTime.Year); > + RtcWrite (RTC_ADDRESS_CENTURY, Century); Sho

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-17 Thread Zeng, Star
On 2015/11/17 16:48, Ruiyu Ni wrote: The patch updates the Century value in CMOS location 50 (32h) to avoid UEFI Win7 hang during booting. (Though Win8 is good.) Per the ACPI spec the Century storage in CMOS is optional, but the fact is even we set the FADT.CenturyOffset to 0 indicating the platf

[edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-17 Thread Ruiyu Ni
The patch updates the Century value in CMOS location 50 (32h) to avoid UEFI Win7 hang during booting. (Though Win8 is good.) Per the ACPI spec the Century storage in CMOS is optional, but the fact is even we set the FADT.CenturyOffset to 0 indicating the platform doesn't store century value in CMOS