Re: [edk2] [patch] NetworkPkg: Fix assert issue in iSCSI driver

2016-08-01 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Monday, August 1, 2016 4:38 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [patch]

Re: [edk2] [patch] NetworkPkg: Fix assert issue in iSCSI driver

2016-08-01 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Monday, August 01, 2016 4:38 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin Subject: [patch] NetworkPkg: Fix assert

[edk2] [patch] NetworkPkg: Fix assert issue in iSCSI driver

2016-08-01 Thread Zhang Lubo
The bug is caused by using already freed memory. If there is already an attempt and execute 'reconnect -r' command, all the AttemptConfig structure will be freed, but the mCallbackInfo->Current is not configured as null and this pointer will be used again in IScsiFormExtractConfig.

Re: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

2016-07-10 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Friday, July 8, 2016 3:51 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [patch] NetworkPkg:

Re: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

2016-07-08 Thread Ye, Ting
om>; Wu, Jiaxin <jiaxin...@intel.com> Subject: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver. The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS, since MacString now is a pointer, the value sizeof(MacString)/sizeof (MacString[0]) is not correct her

Re: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

2016-07-08 Thread Zeng, Star
om>; Wu, Jiaxin <jiaxin...@intel.com> Subject: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver. The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS, since MacString now is a pointer, the value sizeof(MacString)/sizeof (MacString[0]) is not correct her

Re: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

2016-07-08 Thread Wu, Jiaxin
Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Friday, July 8, 2016 3:51 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin >

[edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI driver.

2016-07-08 Thread Zhang Lubo
The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS, since MacString now is a pointer, the value sizeof(MacString)/sizeof (MacString[0]) is not correct here as the third parameter. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin