Re: [edk2] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

2014-12-01 Thread Olivier Martin
I have not see anything controversial and I do not disagree with Feng's comments. These patches (this one and the one on 2014-11-26) look good to me. Reviewed-By: Olivier Martin olivier.mar...@arm.com -Original Message- From: Pawell, Randy [mailto:randy.paw...@hp.com] Sent: 25

Re: [edk2] NetworkPkg: Source fixes and cleanup for ARMGCC compile

2014-12-01 Thread Olivier Martin
I would also suggest to add CompilerIntrinsicsLib.inf to LibraryClasses.AARCH64: [LibraryClasses.ARM, LibraryClasses.AARCH64] # # It is not possible to prevent ARM compiler calls to generic intrinsic functions. # This library provides the instrinsic functions generated by a given compiler.

Re: [edk2] [PATCH] BaseTools: Fix ARM build failure with gcc 4.6

2014-12-01 Thread Olivier Martin
Reviewed-By: Olivier Martin olivier.mar...@arm.com I can see this patch has not been merged. Dennis, are you happy to do it? -Original Message- From: Liu, Yingke D [mailto:yingke.d@intel.com] Sent: 24 November 2014 01:56 To: Scott Duplichan; edk2-devel@lists.sourceforge.net

Re: [edk2] ASSERT with TARGET=DEBUG

2014-12-01 Thread Olivier Martin
A reason why you do not see this ASSERT when TARGET=RELEASE is because ASSERT is probably disabled for RELEASE build. Check you DSC file to see if gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask has a different value for DEBUG/RELEASE. Example: # DEBUG_ASSERT_ENABLED 0x01 #

[edk2] PEI driver help

2014-12-01 Thread Joe Thomas
Folks, I'm trying to convert/port one of our DXE drivers to PEI (for Recovery support) but I'm having trouble finding useful information on generating a PEIM module that can be integrated into a BIOS. Does anyone have any good pointers/info that might help point the way? Thanks. Background:

Re: [edk2] [PATCH] MdeModulePkg : Add a new DxeServicesLib GetSectionFromAnyFvEx() function

2014-12-01 Thread El-Haj-Mahmoud, Samer
One possible usage is to be able to load an application from a FV. * Need to search for the EFI application in all FVs using GetSectionFromAnyFvEx() * Once found, the file is loaded from FV to memory (in Buffer and Size outputs of GetSectionFromAnyFvEx() * We then

Re: [edk2] [PATCH v2] NetworkPkg: Source fixes and cleanup for ARMGCC compile

2014-12-01 Thread Pawell, Randy
Please re-review the attached NetworkPkg patch. Feedback from both of my open reviews has been incorporated. Thanks, Randy Pawell ___ NetworkPkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages to

Re: [edk2] [PATCH v3] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

2014-12-01 Thread Pawell, Randy
Please re-review the attached MdeModulePkg patch. Feedback from both of my open reviews has been incorporated. Thanks, Randy Pawell ___ MdeModulePkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages

Re: [edk2] PEI driver help

2014-12-01 Thread Andrew Fish
On Dec 1, 2014, at 8:48 AM, Joe Thomas joe.tho...@dothill.com wrote: Folks, I’m trying to convert/port one of our DXE drivers to PEI (for Recovery support) but I’m having trouble finding useful information on generating a PEIM module that can be integrated into a BIOS. Does anyone

Re: [edk2] [PATCH v3] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

2014-12-01 Thread Tian, Feng
Hi, Randy, In your patch, you are using: + (C) Copyright 2014 Hewlett-Packard Development Company, L.P.BR But in previous MdePkg/MdeModulePkg check-ins, the format was: + Copyright (c) 2014, Hewlett-Packard Development Company, L.P.BR I am not sure if it's a problem. Please double confirm

Re: [edk2] [PATCH] BaseTools: Fix ARM build failure with gcc 4.6

2014-12-01 Thread Liu, Yingke D
Sure, I will commit the change. Dennis -Original Message- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Tuesday, December 02, 2014 1:07 AM To: edk2-devel@lists.sourceforge.net; Scott Duplichan Subject: Re: [edk2] [PATCH] BaseTools: Fix ARM build failure with gcc 4.6

Re: [edk2] [PATCH v2] NetworkPkg: Source fixes and cleanup for ARMGCC compile

2014-12-01 Thread Fu, Siyuan
Pawell I will follow our process to review and check in it, thanks. Best Regards Siyuan -Original Message- From: Pawell, Randy [mailto:randy.paw...@hp.com] Sent: Tuesday, December 02, 2014 3:48 AM To: Olivier Martin; edk2-devel@lists.sourceforge.net; Fu, Siyuan Subject: RE:

Re: [edk2] [PATCH] MdeModulePkg : Add a new DxeServicesLib GetSectionFromAnyFvEx() function

2014-12-01 Thread Tian, Feng
Hi, Samer If it's such usage case, why you don't use the below logic? Status = GetSectionFromAnyFv ( AppGuid, EFI_SECTION_PE32, 0, AppImageBase, AppImageSize ); Status = gBS-LoadImage ( TRUE,