Hi Cecil,
We found a regression after your patch is committed, the attached patch fix the
problem.
Contributed-Under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yingke Liu yingke.d@intel.com
Thanks,
Dennis
From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hp.com]
Sent: Wednesday,
Now, BaseTools is part of EDK2 source tree. Should BaseTools use
ProcessorBind.h from MdePkg?
Today, we have two sets of ProcessorBind.h files; one in
BaseTools/Source/C/Include and one in MdePkg/Include.
--
Download BIRT
Andrew –
Thanks!
At this point, I’m not sure of anything… not the least of which is the
DebugLib.
Continuing to experiment, I did find that if I compile the PEI driver for IA32
(as opposed to X64), then at least it doesn’t brick the BIOS. Doesn’t mean that
my code is running since I’m not
We cannot duplicate them in the shell's DEC. someone else might actually make
a dependency on that and that would be bad.
What would you say to doing it like NT32 GUIDs and have them defined right in
the C file so only that one place can use them?
-Jaben
From: Tim Lewis
Thanks. The revised copyright format is correct per our legal department.
Previously other source changes may have been contributed using older copyright
formats.
-Randy
-Original Message-
From: Tian, Feng [mailto:feng.t...@intel.com]
Sent: Monday, December 01, 2014 4:36 PM
To:
That seems OK
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, December 02, 2014 12:53 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol
We cannot duplicate them in the shell's DEC. someone else might actually make
On 02/12/2014 13:42, Olivier Martin wrote:
Now, BaseTools is part of EDK2 source tree. Should BaseTools use
ProcessorBind.h from MdePkg?
Note that it's possible that BaseTools is compiled for a different
architecture than MdePkg. Unifying the files can be useful, but perhaps
the BaseTools
If you go forward on this, make sure that it is easy to turn off or disable.
For systems that implement LPAR, you want different groups of CPUs to have
different MTRR settings.
Daryl McDaniel
It is the mark of an educated mind to be able to entertain a thought without
accepting it.
- Aristotle
I've been trying the newly added feature of support for X64 builds of Nt32.
One small problem is that build -a X64 run in a X64 Visual Studio command
prompt doesn't succeed in starting the X64 build of Nt32.
The error reported is as follows
Processing meta-data ... donebuild... : error C0DE:
Richard,
Thanks for reporting this problem. I think we will fix it soon.
Thanks,
Dennis
From: Richard Mahn [mailto:rmah...@yahoo.com]
Sent: Wednesday, December 03, 2014 7:43 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] build run not properly handling x64 builds of Nt32
I've been
Hi Jaben,
Could you help review the patch? Serial console will lost connection after
reconnect -r. When running reconnect -r Shell 2.0 do connect -r after
disconnect -r, this operation may not correctly connect all the possible
console devices. So we need to connect all the consoles before
Hi Jaben,
Could you help review the patch? This patch adds 'ASSERT' to check the pointer
returned from HiiGetString to avoid pointer dereferenced.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin shumin@intel.commailto:shumin@intel.com
Thanks
Shumin
Ok, looks good to me.
Reviewed-by: Feng Tian feng.t...@intel.com
-Original Message-
From: Pawell, Randy [mailto:randy.paw...@hp.com]
Sent: Wednesday, December 03, 2014 03:06
To: Tian, Feng; Olivier Martin; edk2-devel@lists.sourceforge.net
Subject: RE: [edk2][PATCH v3] MdeModulePkg:
On Dec 2, 2014, at 6:56 PM, Qiu, Shumin shumin@intel.com wrote:
Hi Jaben,
Could you help review the patch? This patch adds ‘ASSERT’ to check the
pointer returned from HiiGetString to avoid pointer dereferenced.
Why are we adding ASSERT to check pointers. It is likely turned off in
Dennis:
The patch is good. Reviewed-by: Liming Gao liming@intel.com
Thanks
Liming
From: Liu, Yingke D [mailto:yingke.d@intel.com]
Sent: Tuesday, December 2, 2014 4:07 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] BaseTool : Fix '/' handling in UNI files
Hi Cecil,
15 matches
Mail list logo