Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-12-02 Thread El-Haj-Mahmoud, Samer
That seems OK From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Tuesday, December 02, 2014 12:53 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol We cannot duplicate them in the shell's DEC. someone else might actually

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-12-02 Thread Carsey, Jaben
im.le...@insyde.com] Sent: Tuesday, November 25, 2014 4:33 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol Jaben - Consider an ARM source delivery. Do we really a package full of Intel-isms delivered? They never use those protocols and l

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-26 Thread El-Haj-Mahmoud, Samer
the GUID definitions in the ShellPkg.dec Thanks, --Samer From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Tuesday, November 25, 2014 6:33 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol Jaben - Consider an ARM source delivery. Do

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-25 Thread Tim Lewis
-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol Jaben, Samer - Do we really want to make the shell dependent on the IntelFrameworkModulePkg? Tim From: Carsey, Jaben [mailto:jaben.car...@intel.com

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-25 Thread Carsey, Jaben
@lists.sourceforge.net Subject: Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol Jaben, Samer - Do we really want to make the shell dependent on the IntelFrameworkModulePkg? Tim From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Tuesday, November 25, 2014 2:42 PM To: edk2-devel

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-25 Thread Tim Lewis
er 25, 2014 2:08 PM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol Jaben, Can you please review this and submit it? Update Shell DH command to display gEfiAdapterInformationProtocolGuid a

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-25 Thread Carsey, Jaben
edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol Jaben, Can you please review this and submit it? Update Shell DH command to display gEfiAdapterInformationProtocolGuid and decode information blocks defined in the UEFI 2.4 specification. Also added

Re: [edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-25 Thread Bruce Cran
On 11/25/2014 3:08 PM, El-Haj-Mahmoud, Samer wrote: > *Also added GUIDs for gEfiIsaIoProtocolGuid and gEfiIsaAcpiProtocolGuid > protocols.* While you're changing UefiHandleParsingLib, could you add gEfiShellDynamicCommandProtocolGuid please? Both master and UDK2014.SP1 branches are affected, a

[edk2] [PATCH] ShellPkg: Update DH for AdapterInfoProtocol

2014-11-25 Thread El-Haj-Mahmoud, Samer
Jaben, Can you please review this and submit it? Update Shell DH command to display gEfiAdapterInformationProtocolGuid and decode information blocks defined in the UEFI 2.4 specification. Also added GUIDs for gEfiIsaIoProtocolGuid and gEfiIsaAcpiProtocolGuid protocols. Contributed-under: Ti